@ckeditor/ckeditor5-engine 43.0.0 → 43.1.0-alpha.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ckeditor/ckeditor5-engine",
-  "version": "43.0.0",
+  "version": "43.1.0-alpha.0",
   "description": "The editing engine of CKEditor 5 – the best browser-based rich text editor.",
   "keywords": [
     "wysiwyg",
@@ -24,7 +24,7 @@
   "type": "module",
   "main": "src/index.js",
   "dependencies": {
-    "@ckeditor/ckeditor5-utils": "43.0.0",
+    "@ckeditor/ckeditor5-utils": "43.1.0-alpha.0",
     "lodash-es": "4.17.21"
   },
   "author": "CKSource (http://cksource.com/)",

package/src/model/differ.js

@@ -1248,7 +1248,18 @@ function _generateDiffInstructionsFromChanges(oldChildrenLength, changes) {
             oldChildrenHandled += change.howMany;
         }
         else {
-            diff.push(...'a'.repeat(change.howMany).split(''));
+            // Total maximum amount of arguments that can be passed to `Array.prototype.push` may be limited so we need to
+            // add them manually one by one to avoid this limit. However loop might be a bit slower than `push` method on
+            // smaller changesets so we need to decide which method to use based on the size of the change.
+            // See: https://github.com/ckeditor/ckeditor5/issues/16819
+            if (change.howMany > 1500) {
+                for (let i = 0; i < change.howMany; i++) {
+                    diff.push('a');
+                }
+            }
+            else {
+                diff.push(...'a'.repeat(change.howMany).split(''));
+            }
             // The last handled offset is at the position after the changed range.
             offset = change.offset + change.howMany;
             // We changed `howMany` old nodes, update `oldChildrenHandled`.

package/src/view/view.js

@@ -189,7 +189,12 @@ export default class View extends /* #__PURE__ */ ObservableMixin() {
                 this._writer.addClass(value.split(' '), viewRoot);
             }
             else {
-                this._writer.setAttribute(name, value, viewRoot);
+                // There is a chance that some attributes have already been set on the view root before attaching
+                // the DOM root and should be preserved. This is a similar case to the "class" attribute except
+                // this time there is no workaround using a some low-level API.
+                if (!viewRoot.hasAttribute(name)) {
+                    this._writer.setAttribute(name, value, viewRoot);
+                }
             }
         }
         this._initialDomRootAttributes.set(domRoot, initialDomRootAttributes);