@ckeditor/ckeditor5-engine 41.4.2 → 42.0.0-alpha.1

package/src/view/domconverter.d.ts

@@ -544,6 +544,15 @@ export default class DomConverter {
      * @returns `true` if given `node` ends with space, `false` otherwise.
      */
     private _nodeEndsWithSpace;
+    /**
+     * Checks whether given text contains preformatted white space. This is the case if
+     * * any of node ancestors has a name which is in `preElements` array, or
+     * * the closest ancestor that has the `white-space` CSS property sets it to a value that preserves spaces
+     *
+     * @param node Node to check
+     * @returns `true` if given node contains preformatted white space, `false` otherwise.
+     */
+    private _isPreFormatted;
     /**
      * Helper function. For given {@link module:engine/view/text~Text view text node}, it finds previous or next sibling
      * that is contained in the same container element. If there is no such sibling, `null` is returned.

package/src/view/domconverter.js

@@ -1123,7 +1123,7 @@ export default class DomConverter {
             }
             let data;
             let nodeEndsWithSpace = false;
-            if (_hasViewParentOfType(node, this.preElements)) {
+            if (this._isPreFormatted(node)) {
                 data = getDataWithoutFiller(node.data);
             }
             else {
@@ -1207,9 +1207,8 @@ export default class DomConverter {
      */
     _processDataFromViewText(node) {
         let data = node.data;
-        // If any of node ancestors has a name which is in `preElements` array, then currently processed
-        // view text node is (will be) in preformatted element. We should not change whitespaces then.
-        if (node.getAncestors().some(parent => this.preElements.includes(parent.name))) {
+        // If the currently processed view text node is preformatted, we should not change whitespaces.
+        if (this._isPreFormatted(node)) {
             return data;
         }
         // 1. Replace the first space with a nbsp if the previous node ends with a space or there is no previous node
@@ -1247,12 +1246,35 @@ export default class DomConverter {
      * @returns `true` if given `node` ends with space, `false` otherwise.
      */
     _nodeEndsWithSpace(node) {
-        if (node.getAncestors().some(parent => this.preElements.includes(parent.name))) {
+        if (this._isPreFormatted(node)) {
             return false;
         }
         const data = this._processDataFromViewText(node);
         return data.charAt(data.length - 1) == ' ';
     }
+    /**
+     * Checks whether given text contains preformatted white space. This is the case if
+     * * any of node ancestors has a name which is in `preElements` array, or
+     * * the closest ancestor that has the `white-space` CSS property sets it to a value that preserves spaces
+     *
+     * @param node Node to check
+     * @returns `true` if given node contains preformatted white space, `false` otherwise.
+     */
+    _isPreFormatted(node) {
+        if (_hasViewParentOfType(node, this.preElements)) {
+            return true;
+        }
+        for (const ancestor of node.getAncestors({ parentFirst: true })) {
+            if (!ancestor.is('element') || !ancestor.hasStyle('white-space') || ancestor.getStyle('white-space') === 'inherit') {
+                continue;
+            }
+            // If the node contains the `white-space` property with a value that does not preserve spaces, it will take
+            // precedence over any white-space settings its ancestors contain, so no further parent checking needs to
+            // be done.
+            return ['pre', 'pre-wrap', 'break-spaces'].includes(ancestor.getStyle('white-space'));
+        }
+        return false;
+    }
     /**
      * Helper function. For given {@link module:engine/view/text~Text view text node}, it finds previous or next sibling
      * that is contained in the same container element. If there is no such sibling, `null` is returned.

package/src/view/editableelement.d.ts

@@ -19,7 +19,7 @@ declare const EditableElement_base: import("@ckeditor/ckeditor5-utils").Mixed<ty
  * The constructor of this class shouldn't be used directly. To create new `EditableElement` use the
  * {@link module:engine/view/downcastwriter~DowncastWriter#createEditableElement `downcastWriter#createEditableElement()`} method.
  */
-export default class EditableElement extends EditableElement_base {
+export default class EditableElement extends /* #__PURE__ */ EditableElement_base {
     /**
      * Whether the editable is in read-write or read-only mode.
      *

package/src/view/editableelement.js

@@ -16,7 +16,7 @@ import { ObservableMixin } from '@ckeditor/ckeditor5-utils';
  * The constructor of this class shouldn't be used directly. To create new `EditableElement` use the
  * {@link module:engine/view/downcastwriter~DowncastWriter#createEditableElement `downcastWriter#createEditableElement()`} method.
  */
-export default class EditableElement extends ObservableMixin(ContainerElement) {
+export default class EditableElement extends /* #__PURE__ */ ObservableMixin(ContainerElement) {
     /**
      * Creates an editable element.
      *

package/src/view/node.d.ts

@@ -17,7 +17,7 @@ declare const Node_base: import("@ckeditor/ckeditor5-utils").Mixed<typeof TypeCh
  * Use the {@link module:engine/view/downcastwriter~DowncastWriter} or {@link module:engine/view/upcastwriter~UpcastWriter}
  * to create new instances of view nodes.
  */
-export default abstract class Node extends Node_base {
+export default abstract class Node extends /* #__PURE__ */ Node_base {
     /**
      * The document instance to which this node belongs.
      */

package/src/view/node.js

@@ -15,7 +15,7 @@ import { clone } from 'lodash-es';
  * Use the {@link module:engine/view/downcastwriter~DowncastWriter} or {@link module:engine/view/upcastwriter~UpcastWriter}
  * to create new instances of view nodes.
  */
-export default class Node extends EmitterMixin(TypeCheckable) {
+export default class Node extends /* #__PURE__ */ EmitterMixin(TypeCheckable) {
     /**
      * Creates a tree view node.
      *

package/src/view/observer/observer.d.ts

@@ -14,7 +14,7 @@ declare const Observer_base: {
  * Observers can also add features to the view, for instance by updating its status or marking elements
  * which need a refresh on DOM events.
  */
-export default abstract class Observer extends Observer_base {
+export default abstract class Observer extends /* #__PURE__ */ Observer_base {
     /**
      * An instance of the view controller.
      */

package/src/view/observer/observer.js

@@ -12,7 +12,7 @@ import { DomEmitterMixin } from '@ckeditor/ckeditor5-utils';
  * Observers can also add features to the view, for instance by updating its status or marking elements
  * which need a refresh on DOM events.
  */
-export default class Observer extends DomEmitterMixin() {
+export default class Observer extends /* #__PURE__ */ DomEmitterMixin() {
     /**
      * Creates an instance of the observer.
      */

package/src/view/renderer.d.ts

@@ -26,7 +26,7 @@ declare const Renderer_base: {
  * Renderer uses {@link module:engine/view/domconverter~DomConverter} to transform view nodes and positions
  * to and from the DOM.
  */
-export default class Renderer extends Renderer_base {
+export default class Renderer extends /* #__PURE__ */ Renderer_base {
     /**
      * Set of DOM Documents instances.
      */

package/src/view/renderer.js

@@ -23,7 +23,7 @@ import '../../theme/renderer.css';
  * Renderer uses {@link module:engine/view/domconverter~DomConverter} to transform view nodes and positions
  * to and from the DOM.
  */
-export default class Renderer extends ObservableMixin() {
+export default class Renderer extends /* #__PURE__ */ ObservableMixin() {
     /**
      * Creates a renderer instance.
      *

package/src/view/selection.d.ts

@@ -26,7 +26,7 @@ declare const Selection_base: import("@ckeditor/ckeditor5-utils").Mixed<typeof T
  * A selection can consist of {@link module:engine/view/range~Range ranges} that can be set by using
  * the {@link module:engine/view/selection~Selection#setTo `Selection#setTo()`} method.
  */
-export default class Selection extends Selection_base {
+export default class Selection extends /* #__PURE__ */ Selection_base {
     /**
      * Stores all ranges that are selected.
      */

package/src/view/selection.js

@@ -23,7 +23,7 @@ import { CKEditorError, EmitterMixin, count, isIterable } from '@ckeditor/ckedit
  * A selection can consist of {@link module:engine/view/range~Range ranges} that can be set by using
  * the {@link module:engine/view/selection~Selection#setTo `Selection#setTo()`} method.
  */
-export default class Selection extends EmitterMixin(TypeCheckable) {
+export default class Selection extends /* #__PURE__ */ EmitterMixin(TypeCheckable) {
     /**
      * Creates new selection instance.
      *

package/src/view/view.d.ts

@@ -64,7 +64,7 @@ declare const View_base: {
  * If you do not need full a DOM - view management, and only want to transform a tree of view elements to a tree of DOM
  * elements you do not need this controller. You can use the {@link module:engine/view/domconverter~DomConverter DomConverter} instead.
  */
-export default class View extends View_base {
+export default class View extends /* #__PURE__ */ View_base {
     /**
      * Instance of the {@link module:engine/view/document~Document} associated with this view controller.
      */

package/src/view/view.js

@@ -57,7 +57,7 @@ import { cloneDeep } from 'lodash-es';
  * If you do not need full a DOM - view management, and only want to transform a tree of view elements to a tree of DOM
  * elements you do not need this controller. You can use the {@link module:engine/view/domconverter~DomConverter DomConverter} instead.
  */
-export default class View extends ObservableMixin() {
+export default class View extends /* #__PURE__ */ ObservableMixin() {
     /**
      * @param stylesProcessor The styles processor instance.
      */