@ckeditor/ckeditor5-dev-release-tools 44.0.0-alpha.5 → 44.1.0

package/lib/tasks/publishpackages.js

@@ -4,44 +4,50 @@
  */
 
 import upath from 'upath';
-import { glob } from 'glob';
+import fs from 'fs-extra';
 import assertNpmAuthorization from '../utils/assertnpmauthorization.js';
 import assertPackages from '../utils/assertpackages.js';
 import assertNpmTag from '../utils/assertnpmtag.js';
 import assertFilesToPublish from '../utils/assertfilestopublish.js';
 import executeInParallel from '../utils/executeinparallel.js';
 import publishPackageOnNpmCallback from '../utils/publishpackageonnpmcallback.js';
+import checkVersionAvailability from '../utils/checkversionavailability.js';
+import findPathsToPackages from '../utils/findpathstopackages.js';
 
 /**
  * The purpose of the script is to validate the packages prepared for the release and then release them on npm.
  *
  * The validation contains the following steps in each package:
  * - User must be logged to npm on the specified account.
- * - The package directory mmust contain `package.json` file.
+ * - The package directory must contain `package.json` file.
  * - All other files expected to be released must exist in the package directory.
  * - The npm tag must match the tag calculated from the package version.
  *
  * When the validation for each package passes, packages are published on npm. Optional callback is called for confirmation whether to
  * continue.
  *
- * @param {Object} options
- * @param {String} options.packagesDirectory Relative path to a location of packages to release.
- * @param {String} options.npmOwner The account name on npm, which should be used to publish the packages.
- * @param {ListrTaskObject} options.listrTask An instance of `ListrTask`.
+ * If a package has already been published, the script does not try to publish it again. Instead, it treats the package as published.
+ * Whenever a communication between the script and npm fails, it tries to re-publish a package (up to three attempts).
+ *
+ * @param {object} options
+ * @param {string} options.packagesDirectory Relative path to a location of packages to release.
+ * @param {string} options.npmOwner The account name on npm, which should be used to publish the packages.
+ * @param {ListrTaskObject} [options.listrTask] An instance of `ListrTask`.
  * @param {AbortSignal|null} [options.signal=null] Signal to abort the asynchronous process.
- * @param {String} [options.npmTag='staging'] The npm distribution tag.
- * @param {Object.<String, Array.<String>>|null} [options.optionalEntries=null] Specifies which entries from the `files` field in the
+ * @param {string} [options.npmTag='staging'] The npm distribution tag.
+ * @param {Object.<string, Array.<string>>|null} [options.optionalEntries=null] Specifies which entries from the `files` field in the
  * `package.json` are optional. The key is a package name, and its value is an array of optional entries from the `files` field, for which
  * it is allowed not to match any file. The `options.optionalEntries` object may also contain the `default` key, which is used for all
  * packages that do not have own definition.
- * @param {String} [options.confirmationCallback=null] An callback whose response decides to continue the publishing packages. Synchronous
- * and asynchronous callbacks are supported.
- * @param {Boolean} [options.requireEntryPoint=false] Whether to verify if packages to publish define an entry point. In other words,
+ * @param {function|null} [options.confirmationCallback=null] An callback whose response decides to continue the publishing packages.
+ * Synchronous and asynchronous callbacks are supported.
+ * @param {boolean} [options.requireEntryPoint=false] Whether to verify if packages to publish define an entry point. In other words,
  * whether their `package.json` define the `main` field.
- * @param {Array.<String>} [options.optionalEntryPointPackages=[]] If the entry point validator is enabled (`requireEntryPoint=true`),
+ * @param {Array.<string>} [options.optionalEntryPointPackages=[]] If the entry point validator is enabled (`requireEntryPoint=true`),
  * this array contains a list of packages that will not be checked. In other words, they do not have to define the entry point.
- * @param {String} [options.cwd=process.cwd()] Current working directory from which all paths will be resolved.
- * @param {Number} [options.concurrency=4] Number of CPUs that will execute the task.
+ * @param {string} [options.cwd=process.cwd()] Current working directory from which all paths will be resolved.
+ * @param {number} [options.concurrency=4] Number of CPUs that will execute the task.
+ * @param {number} [options.attempts=3] Number of attempts. After reaching 0, it won't be publishing packages again.
  * @returns {Promise}
  */
 export default async function publishPackages( options ) {
@@ -56,15 +62,14 @@ export default async function publishPackages( options ) {
 		requireEntryPoint = false,
 		optionalEntryPointPackages = [],
 		cwd = process.cwd(),
-		concurrency = 4
+		concurrency = 4,
+		attempts = 3
 	} = options;
 
+	const remainingAttempts = attempts - 1;
 	await assertNpmAuthorization( npmOwner );
 
-	const packagePaths = await glob( '*/', {
-		cwd: upath.join( cwd, packagesDirectory ),
-		absolute: true
-	} );
+	const packagePaths = await findPathsToPackages( cwd, packagesDirectory );
 
 	await assertPackages( packagePaths, { requireEntryPoint, optionalEntryPointPackages } );
 	await assertFilesToPublish( packagePaths, optionalEntries );
@@ -72,17 +77,69 @@ export default async function publishPackages( options ) {
 
 	const shouldPublishPackages = confirmationCallback ? await confirmationCallback() : true;
 
-	if ( shouldPublishPackages ) {
-		await executeInParallel( {
-			cwd,
-			packagesDirectory,
-			listrTask,
-			taskToExecute: publishPackageOnNpmCallback,
-			taskOptions: {
-				npmTag
-			},
-			signal,
-			concurrency
-		} );
+	if ( !shouldPublishPackages ) {
+		return Promise.resolve();
 	}
+
+	await removeAlreadyPublishedPackages( packagePaths );
+
+	await executeInParallel( {
+		cwd,
+		packagesDirectory,
+		listrTask,
+		taskToExecute: publishPackageOnNpmCallback,
+		taskOptions: {
+			npmTag
+		},
+		signal,
+		concurrency
+	} );
+
+	const packagePathsAfterPublishing = await findPathsToPackages( cwd, packagesDirectory );
+
+	// All packages have been published. No need for re-executing.
+	if ( !packagePathsAfterPublishing.length ) {
+		return Promise.resolve();
+	}
+
+	// No more attempts. Abort.
+	if ( remainingAttempts <= 0 ) {
+		throw new Error( 'Some packages could not be published.' );
+	}
+
+	// Let's give an npm a moment for taking a breath...
+	await wait( 1000 );
+
+	// ...and try again.
+	return publishPackages( {
+		packagesDirectory,
+		npmOwner,
+		listrTask,
+		signal,
+		npmTag,
+		optionalEntries,
+		requireEntryPoint,
+		optionalEntryPointPackages,
+		cwd,
+		concurrency,
+		confirmationCallback: null, // Do not ask again if already here.
+		attempts: remainingAttempts
+	} );
+}
+
+async function removeAlreadyPublishedPackages( packagePaths ) {
+	for ( const absolutePackagePath of packagePaths ) {
+		const pkgJson = await fs.readJson( upath.join( absolutePackagePath, 'package.json' ) );
+		const isAvailable = await checkVersionAvailability( pkgJson.version, pkgJson.name );
+
+		if ( !isAvailable ) {
+			await fs.remove( absolutePackagePath );
+		}
+	}
+}
+
+function wait( time ) {
+	return new Promise( resolve => {
+		setTimeout( resolve, time );
+	} );
 }

package/lib/tasks/push.js

@@ -9,10 +9,10 @@ import shellEscape from 'shell-escape';
 /**
  * Push the local changes to a remote server.
  *
- * @param {Object} options
- * @param {String} options.releaseBranch A name of the branch that should be used for releasing packages.
- * @param {String} options.version Name of tag connected with the release.
- * @param {String} [options.cwd] Root of the repository to prepare. `process.cwd()` by default.
+ * @param {object} options
+ * @param {string} options.releaseBranch A name of the branch that should be used for releasing packages.
+ * @param {string} options.version Name of tag connected with the release.
+ * @param {string} [options.cwd] Root of the repository to prepare. `process.cwd()` by default.
  * @returns {Promise}
  */
 export default async function push( options ) {

package/lib/tasks/reassignnpmtags.js

@@ -19,10 +19,10 @@ const execPromise = util.promisify( exec );
  * Used to switch the tags from `staging` to `latest` for specified array of packages.
  * Each operation will be retried up to 3 times in case of failure.
  *
- * @param {Object} options
- * @param {String} options.npmOwner User that is authorized to release packages.
- * @param {String} options.version Specifies the version of packages to reassign the tags for.
- * @param {Array.<String>} options.packages Array of packages' names to reassign tags for.
+ * @param {object} options
+ * @param {string} options.npmOwner User that is authorized to release packages.
+ * @param {string} options.version Specifies the version of packages to reassign the tags for.
+ * @param {Array.<string>} options.packages Array of packages' names to reassign tags for.
  * @returns {Promise}
  */
 export default async function reassignNpmTags( { npmOwner, version, packages } ) {
@@ -79,16 +79,16 @@ export default async function reassignNpmTags( { npmOwner, version, packages } )
 }
 
 /**
- * @param {String} message
- * @returns {String}
+ * @param {string} message
+ * @returns {string}
  */
 function trimErrorMessage( message ) {
 	return message.replace( /npm ERR!.*\n/g, '' ).trim();
 }
 
 /**
- * @param {Function} callback
- * @param {Number} times
+ * @param {function} callback
+ * @param {number} times
  * @returns {RetryCallback}
  */
 function retry( callback, times = 3 ) {

package/lib/tasks/updatedependencies.js

@@ -4,8 +4,10 @@
  */
 
 import fs from 'fs-extra';
-import { glob } from 'glob';
 import upath from 'upath';
+import findPathsToPackages from '../utils/findpathstopackages.js';
+
+const { normalizeTrim } = upath;
 
 /**
  * The purpose of this script is to update all eligible dependencies to a version specified in the `options.version`. The following packages
@@ -17,16 +19,16 @@ import upath from 'upath';
  * The eligible dependencies are distinguished by the return value from the `options.shouldUpdateVersionCallback` function. Only if this
  * callback returns a truthy value for a given dependency, its version will be updated.
  *
- * @param {Object} options
- * @param {String} options.version Target version or a range version to which all eligible dependencies will be updated.
+ * @param {object} options
+ * @param {string} options.version Target version or a range version to which all eligible dependencies will be updated.
  * Examples: `1.0.0`, `^1.0.0`, etc.
  * @param {UpdateVersionCallback} options.shouldUpdateVersionCallback Callback function that decides whether to update a version
  * for a dependency. It receives a package name as an argument and should return a boolean value.
  * @param {UpdateDependenciesPackagesDirectoryFilter|null} [options.packagesDirectoryFilter=null] An optional callback allowing
  * filtering out directories/packages that should not be touched by the task.
- * @param {String} [options.packagesDirectory] Relative path to a location of packages to update their dependencies. If not specified,
+ * @param {string} [options.packagesDirectory] Relative path to a location of packages to update their dependencies. If not specified,
  * only the root package is checked.
- * @param {String} [options.cwd=process.cwd()] Current working directory from which all paths will be resolved.
+ * @param {string} [options.cwd=process.cwd()] Current working directory from which all paths will be resolved.
  * @returns {Promise}
  */
 export default async function updateDependencies( options ) {
@@ -38,15 +40,15 @@ export default async function updateDependencies( options ) {
 		cwd = process.cwd()
 	} = options;
 
-	const globPatterns = [ 'package.json' ];
-
-	if ( packagesDirectory ) {
-		const packagesDirectoryPattern = upath.join( packagesDirectory, '*', 'package.json' );
-
-		globPatterns.push( packagesDirectoryPattern );
-	}
-
-	const pkgJsonPaths = await getPackageJsonPaths( cwd, globPatterns, packagesDirectoryFilter );
+	const pkgJsonPaths = await findPathsToPackages(
+		cwd,
+		packagesDirectory ? normalizeTrim( packagesDirectory ) : null,
+		{
+			includePackageJson: true,
+			includeCwd: true,
+			packagesDirectoryFilter
+		}
+	);
 
 	for ( const pkgJsonPath of pkgJsonPaths ) {
 		const pkgJson = await fs.readJson( pkgJsonPath );
@@ -62,9 +64,9 @@ export default async function updateDependencies( options ) {
 /**
  * Updates the version for each eligible dependency.
  *
- * @param {String} version
- * @param {Function} callback
- * @param {Object} [dependencies]
+ * @param {string} version
+ * @param {function} callback
+ * @param {object} [dependencies]
  */
 function updateVersion( version, callback, dependencies ) {
 	if ( !dependencies ) {
@@ -78,40 +80,18 @@ function updateVersion( version, callback, dependencies ) {
 	}
 }
 
-/**
- * @param {String} cwd
- * @param {Array.<String>} globPatterns
- * @param {UpdateDependenciesPackagesDirectoryFilter|null} packagesDirectoryFilter
- * @returns {Promise.<Array.<String>>}
- */
-async function getPackageJsonPaths( cwd, globPatterns, packagesDirectoryFilter ) {
-	const globOptions = {
-		cwd,
-		nodir: true,
-		absolute: true
-	};
-
-	const pkgJsonPaths = await glob( globPatterns, globOptions );
-
-	if ( !packagesDirectoryFilter ) {
-		return pkgJsonPaths;
-	}
-
-	return pkgJsonPaths.filter( packagesDirectoryFilter );
-}
-
 /**
  * @callback UpdateVersionCallback
  *
- * @param {String} packageName A package name.
+ * @param {string} packageName A package name.
  *
- * @returns {Boolean} Whether to update (`true`) or ignore (`false`) bumping the package version.
+ * @returns {boolean} Whether to update (`true`) or ignore (`false`) bumping the package version.
  */
 
 /**
  * @callback UpdateDependenciesPackagesDirectoryFilter
  *
- * @param {String} packageJsonPath An absolute path to a `package.json` file.
+ * @param {string} packageJsonPath An absolute path to a `package.json` file.
  *
- * @returns {Boolean} Whether to include (`true`) or skip (`false`) processing the given directory/package.
+ * @returns {boolean} Whether to include (`true`) or skip (`false`) processing the given directory/package.
  */

package/lib/tasks/updateversions.js

@@ -5,11 +5,10 @@
 
 import upath from 'upath';
 import fs from 'fs-extra';
-import { glob } from 'glob';
 import semver from 'semver';
-import checkVersionAvailability from '../utils/checkversionavailability.js';
+import findPathsToPackages from '../utils/findpathstopackages.js';
 
-const { normalizeTrim, toUnix, dirname, join } = upath;
+const { normalizeTrim } = upath;
 
 /**
  * The purpose of the script is to update the version of a root package found in the current working
@@ -22,13 +21,13 @@ const { normalizeTrim, toUnix, dirname, join } = upath;
  *   Exception: passing a version starting with the `0.0.0-nightly` string. It is used for publishing
  *   a nightly release.
  *
- * @param {Object} options
- * @param {String} options.version Version to store in a `package.json` file under the `version` key.
+ * @param {object} options
+ * @param {string} options.version Version to store in a `package.json` file under the `version` key.
  * @param {UpdateVersionsPackagesDirectoryFilter|null} [options.packagesDirectoryFilter=null] An optional callback allowing filtering out
  * directories/packages that should not be touched by the task.
- * @param {String} [options.packagesDirectory] Relative path to a location of packages to update. If not specified,
+ * @param {string} [options.packagesDirectory] Relative path to a location of packages to update. If not specified,
  * only the root package is checked.
- * @param {String} [options.cwd=process.cwd()] Current working directory from which all paths will be resolved.
+ * @param {string} [options.cwd=process.cwd()] Current working directory from which all paths will be resolved.
  * @returns {Promise}
  */
 export default async function updateVersions( options ) {
@@ -38,24 +37,18 @@ export default async function updateVersions( options ) {
 		packagesDirectoryFilter = null,
 		cwd = process.cwd()
 	} = options;
-	const normalizedCwd = toUnix( cwd );
-	const normalizedPackagesDir = packagesDirectory ? normalizeTrim( packagesDirectory ) : null;
 
-	const globPatterns = getGlobPatterns( normalizedPackagesDir );
-	const pkgJsonPaths = await getPackageJsonPaths( cwd, globPatterns, packagesDirectoryFilter );
-
-	const randomPackagePath = getRandomPackagePath( pkgJsonPaths, normalizedPackagesDir );
-
-	const { version: rootPackageVersion } = await readPackageJson( normalizedCwd );
-	const { name: randomPackageName } = await readPackageJson( randomPackagePath );
-
-	checkIfVersionIsValid( version, rootPackageVersion );
+	const pkgJsonPaths = await findPathsToPackages(
+		cwd,
+		packagesDirectory ? normalizeTrim( packagesDirectory ) : null,
+		{
+			includePackageJson: true,
+			includeCwd: true,
+			packagesDirectoryFilter
+		}
+	);
 
-	const isVersionAvailable = await checkVersionAvailability( version, randomPackageName );
-
-	if ( !isVersionAvailable ) {
-		throw new Error( `The "${ randomPackageName }@${ version }" already exists in the npm registry.` );
-	}
+	checkIfVersionIsValid( version );
 
 	for ( const pkgJsonPath of pkgJsonPaths ) {
 		const pkgJson = await fs.readJson( pkgJsonPath );
@@ -66,85 +59,18 @@ export default async function updateVersions( options ) {
 }
 
 /**
- * @param {String} cwd
- * @param {Array.<String>} globPatterns
- * @param {UpdateVersionsPackagesDirectoryFilter|null} packagesDirectoryFilter
- * @returns {Promise.<Array.<String>>}
- */
-async function getPackageJsonPaths( cwd, globPatterns, packagesDirectoryFilter ) {
-	const pkgJsonPaths = await glob( globPatterns, {
-		cwd,
-		absolute: true,
-		nodir: true
-	} );
-
-	if ( !packagesDirectoryFilter ) {
-		return pkgJsonPaths;
-	}
-
-	return pkgJsonPaths.filter( packagesDirectoryFilter );
-}
-
-/**
- * @param {String} packagesDirectory
- * @returns {Promise.<Object>}
+ * @param {string} version
  */
-function readPackageJson( packagesDirectory ) {
-	const packageJsonPath = join( packagesDirectory, 'package.json' );
-
-	return fs.readJson( packageJsonPath );
-}
-
-/**
- * @param {String|null} packagesDirectory
- * @returns {Array.<String>}
- */
-function getGlobPatterns( packagesDirectory ) {
-	const patterns = [ 'package.json' ];
-
-	if ( packagesDirectory ) {
-		patterns.push( packagesDirectory + '/*/package.json' );
-	}
-
-	return patterns;
-}
-
-/**
- * @param {Array.<String>} pkgJsonPaths
- * @param {String|null} packagesDirectory
- * @returns {Object}
- */
-function getRandomPackagePath( pkgJsonPaths, packagesDirectory ) {
-	const randomPkgJsonPaths = packagesDirectory ?
-		pkgJsonPaths.filter( packagePath => packagePath.includes( packagesDirectory ) ) :
-		pkgJsonPaths;
-	const randomPkgJsonPath = randomPkgJsonPaths[ Math.floor( Math.random() * randomPkgJsonPaths.length ) ];
-
-	return dirname( randomPkgJsonPath );
-}
-
-/**
- * Checks if the specified version is greater than the current one.
- *
- * A nightly version is always considered as valid.
- *
- * @param {String} newVersion
- * @param {String} currentVersion
- */
-function checkIfVersionIsValid( newVersion, currentVersion ) {
-	if ( newVersion.startsWith( '0.0.0-nightly' ) ) {
-		return;
-	}
-
-	if ( !semver.gt( newVersion, currentVersion ) ) {
-		throw new Error( `Provided version ${ newVersion } must be greater than ${ currentVersion } or match pattern 0.0.0-nightly.` );
+function checkIfVersionIsValid( version ) {
+	if ( !semver.valid( version ) ) {
+		throw new Error( `Provided version ${ version } must follow the "Semantic Versioning" standard.` );
 	}
 }
 
 /**
  * @callback UpdateVersionsPackagesDirectoryFilter
  *
- * @param {String} packageJsonPath An absolute path to a `package.json` file.
+ * @param {string} packageJsonPath An absolute path to a `package.json` file.
  *
- * @returns {Boolean} Whether to include (`true`) or skip (`false`) processing the given directory/package.
+ * @returns {boolean} Whether to include (`true`) or skip (`false`) processing the given directory/package.
  */

package/lib/tasks/verifypackagespublishedcorrectly.js

@@ -12,13 +12,23 @@ import checkVersionAvailability from '../utils/checkversionavailability.js';
  * Npm sometimes throws incorrect error 409 while publishing, while the package uploads correctly.
  * The purpose of the script is to validate if packages that threw 409 are uploaded correctly to npm.
  *
- * @param {Object} options
- * @param {String} options.packagesDirectory Relative path to a location of packages to release.
- * @param {String} options.version Version of the current release.
- * @param {Function} options.onSuccess Callback fired when function is successful.
+ * @param {object} options
+ * @param {string} options.packagesDirectory Relative path to a location of packages to release.
+ * @param {string} options.version Version of the current release.
+ * @param {function} options.onSuccess Callback fired when function is successful.
  * @returns {Promise}
  */
 export default async function verifyPackagesPublishedCorrectly( options ) {
+	process.emitWarning(
+		'The `verifyPackagesPublishedCorrectly()` function is deprecated and will be removed in the upcoming release (v45). ' +
+		'Its responsibility has been merged with `publishPackages()`.',
+		{
+			type: 'DeprecationWarning',
+			code: 'DEP0001',
+			detail: 'https://github.com/ckeditor/ckeditor5-dev/blob/master/DEPRECATIONS.md#dep0001-verifypackagespublishedcorrectly'
+		}
+	);
+
 	const { packagesDirectory, version, onSuccess } = options;
 	const packagesToVerify = await glob( upath.join( packagesDirectory, '*' ), { absolute: true } );
 	const errors = [];
@@ -32,16 +42,12 @@ export default async function verifyPackagesPublishedCorrectly( options ) {
 	for ( const packageToVerify of packagesToVerify ) {
 		const packageJson = await fs.readJson( upath.join( packageToVerify, 'package.json' ) );
 
-		try {
-			const packageWasUploadedCorrectly = !await checkVersionAvailability( version, packageJson.name );
+		const isPackageVersionAvailable = await checkVersionAvailability( version, packageJson.name );
 
-			if ( packageWasUploadedCorrectly ) {
-				await fs.remove( packageToVerify );
-			} else {
-				errors.push( packageJson.name );
-			}
-		} catch {
+		if ( isPackageVersionAvailable ) {
 			errors.push( packageJson.name );
+		} else {
+			await fs.remove( packageToVerify );
 		}
 	}
 

package/lib/utils/assertfilestopublish.js

@@ -10,8 +10,8 @@ import { glob } from 'glob';
 /**
  * Checks if all files expected to be released actually exist in the package directory. Verification takes place for all packages.
  *
- * @param {String} packagePaths
- * @param {Object.<String, Array.<String>>|null} optionalEntries
+ * @param {string} packagePaths
+ * @param {Object.<string, Array.<string>>|null} optionalEntries
  * @returns {Promise}
  */
 export default async function assertFilesToPublish( packagePaths, optionalEntries = null ) {
@@ -62,10 +62,10 @@ export default async function assertFilesToPublish( packagePaths, optionalEntrie
 /**
  * Filters out the optional entries from the `files` field and returns only the required ones.
  *
- * @param {Array.<String>} entries
- * @param {String} packageName
- * @param {Object.<String, Array.<String>>|null} optionalEntries
- * @returns {Array.<String>}
+ * @param {Array.<string>} entries
+ * @param {string} packageName
+ * @param {Object.<string, Array.<string>>|null} optionalEntries
+ * @returns {Array.<string>}
  */
 function getRequiredEntries( entries, packageName, optionalEntries ) {
 	if ( !optionalEntries ) {

package/lib/utils/assertnpmauthorization.js

@@ -8,7 +8,7 @@ import { tools } from '@ckeditor/ckeditor5-dev-utils';
 /**
  * Checks whether a user is logged to npm as the provided account name.
  *
- * @param {String} npmOwner Expected npm account name that should be logged into npm.
+ * @param {string} npmOwner Expected npm account name that should be logged into npm.
  * @returns {Promise}
  */
 export default async function assertNpmAuthorization( npmOwner ) {

package/lib/utils/assertnpmtag.js

@@ -5,13 +5,18 @@
 
 import fs from 'fs-extra';
 import upath from 'upath';
-import semver from 'semver';
+import getNpmTagFromVersion from './getnpmtagfromversion.js';
+
+const ALLOWED_NPM_LATEST_TAGS = [
+	'staging',
+	'next'
+];
 
 /**
  * Checks if the npm tag matches the tag calculated from the package version. Verification takes place for all packages.
  *
- * @param {Array.<String>} packagePaths
- * @param {String} npmTag
+ * @param {Array.<string>} packagePaths
+ * @param {string} npmTag
  * @returns {Promise}
  */
 export default async function assertNpmTag( packagePaths, npmTag ) {
@@ -20,13 +25,13 @@ export default async function assertNpmTag( packagePaths, npmTag ) {
 	for ( const packagePath of packagePaths ) {
 		const packageJsonPath = upath.join( packagePath, 'package.json' );
 		const packageJson = await fs.readJson( packageJsonPath );
-		const versionTag = getVersionTag( packageJson.version );
+		const versionTag = getNpmTagFromVersion( packageJson.version );
 
 		if ( versionTag === npmTag ) {
 			continue;
 		}
 
-		if ( versionTag === 'latest' && npmTag === 'staging' ) {
+		if ( versionTag === 'latest' && ALLOWED_NPM_LATEST_TAGS.includes( npmTag ) ) {
 			continue;
 		}
 
@@ -37,22 +42,3 @@ export default async function assertNpmTag( packagePaths, npmTag ) {
 		throw new Error( errors.join( '\n' ) );
 	}
 }
-
-/**
- * Returns the version tag for the package.
- *
- * For the official release, returns the "latest" tag. For a non-official release (pre-release), returns the version tag extracted from
- * the package version.
- *
- * @param {String} version
- * @returns {String}
- */
-function getVersionTag( version ) {
-	const [ versionTag ] = semver.prerelease( version ) || [ 'latest' ];
-
-	if ( versionTag.startsWith( 'nightly' ) ) {
-		return 'nightly';
-	}
-
-	return versionTag;
-}

package/lib/utils/assertpackages.js

@@ -9,11 +9,11 @@ import upath from 'upath';
 /**
  * Checks if all packages in the provided directories contain the `package.json` file.
  *
- * @param {Array.<String>} packagePaths
- * @param {Object} options
- * @param {Boolean} options.requireEntryPoint Whether to verify if packages to publish define an entry point. In other words,
+ * @param {Array.<string>} packagePaths
+ * @param {object} options
+ * @param {boolean} options.requireEntryPoint Whether to verify if packages to publish define an entry point. In other words,
  * whether their `package.json` define the `main` field.
- * @param {Array.<String>} options.optionalEntryPointPackages If the entry point validator is enabled (`requireEntryPoint=true`),
+ * @param {Array.<string>} options.optionalEntryPointPackages If the entry point validator is enabled (`requireEntryPoint=true`),
  * this array contains a list of packages that will not be checked. In other words, they do not have to define the entry point.
  * @returns {Promise}
  */