@ckeditor/ckeditor5-dev-release-tools 39.1.0 → 39.2.0

package/lib/tasks/publishpackages.js

@@ -38,6 +38,10 @@ const publishPackageOnNpmCallback = require( '../utils/publishpackageonnpmcallba
  * packages that do not have own definition.
  * @param {String} [options.confirmationCallback=null] An callback whose response decides to continue the publishing packages. Synchronous
  * and asynchronous callbacks are supported.
+ * @param {Boolean} [options.requireEntryPoint=false] Whether to verify if packages to publish define an entry point. In other words,
+ * whether their `package.json` define the `main` field.
+ * @param {Array.<String>} [options.optionalEntryPointPackages=[]] If the entry point validator is enabled (`requireEntryPoint=true`),
+ * this array contains a list of packages that will not be checked. In other words, they do not have to define the entry point.
  * @param {String} [options.cwd=process.cwd()] Current working directory from which all paths will be resolved.
  * @param {Number} [options.concurrency=4] Number of CPUs that will execute the task.
  * @returns {Promise}
@@ -51,6 +55,8 @@ module.exports = async function publishPackages( options ) {
 		npmTag = 'staging',
 		optionalEntries = null,
 		confirmationCallback = null,
+		requireEntryPoint = false,
+		optionalEntryPointPackages = [],
 		cwd = process.cwd(),
 		concurrency = 4
 	} = options;
@@ -62,7 +68,7 @@ module.exports = async function publishPackages( options ) {
 		absolute: true
 	} );
 
-	await assertPackages( packagePaths );
+	await assertPackages( packagePaths, { requireEntryPoint, optionalEntryPointPackages } );
 	await assertFilesToPublish( packagePaths, optionalEntries );
 	await assertNpmTag( packagePaths, npmTag );
 

package/lib/utils/assertpackages.js

@@ -12,20 +12,38 @@ const upath = require( 'upath' );
  * Checks if all packages in the provided directories contain the `package.json` file.
  *
  * @param {Array.<String>} packagePaths
+ * @param {Object} options
+ * @param {Boolean} options.requireEntryPoint Whether to verify if packages to publish define an entry point. In other words,
+ * whether their `package.json` define the `main` field.
+ * @param {Array.<String>} options.optionalEntryPointPackages If the entry point validator is enabled (`requireEntryPoint=true`),
+ * this array contains a list of packages that will not be checked. In other words, they do not have to define the entry point.
  * @returns {Promise}
  */
-module.exports = async function assertPackages( packagePaths ) {
+module.exports = async function assertPackages( packagePaths, options ) {
 	const errors = [];
+	const { requireEntryPoint, optionalEntryPointPackages } = options;
 
 	for ( const packagePath of packagePaths ) {
 		const packageName = upath.basename( packagePath );
 		const packageJsonPath = upath.join( packagePath, 'package.json' );
 
 		if ( await fs.pathExists( packageJsonPath ) ) {
-			continue;
-		}
+			if ( !requireEntryPoint ) {
+				continue;
+			}
+
+			const { name: packageName, main: entryPoint } = await fs.readJson( packageJsonPath );
 
-		errors.push( `The "package.json" file is missing in the "${ packageName }" package.` );
+			if ( optionalEntryPointPackages.includes( packageName ) ) {
+				continue;
+			}
+
+			if ( !entryPoint ) {
+				errors.push( `The "${ packageName }" package misses the entry point ("main") definition in its "package.json".` );
+			}
+		} else {
+			errors.push( `The "package.json" file is missing in the "${ packageName }" package.` );
+		}
 	}
 
 	if ( errors.length ) {

package/lib/utils/transformcommitutils.js

@@ -79,7 +79,7 @@ const transformCommitUtils = {
 	 * @returns {String}
 	 */
 	linkToGithubIssue( comment ) {
-		return comment.replace( /(\/?[\w-]+\/[\w-]+)?#([\d]+)/ig, ( matchedText, maybeRepository, issueId ) => {
+		return comment.replace( /(\/?[\w-]+\/[\w-]+)?#([\d]+)(?=$|[\s,.)\]])/igm, ( matchedText, maybeRepository, issueId ) => {
 			if ( maybeRepository ) {
 				if ( maybeRepository.startsWith( '/' ) ) {
 					return matchedText;

package/package.json

@@ -1,11 +1,11 @@
 {
   "name": "@ckeditor/ckeditor5-dev-release-tools",
-  "version": "39.1.0",
+  "version": "39.2.0",
   "description": "Tools used for releasing CKEditor 5 and related packages.",
   "keywords": [],
   "main": "lib/index.js",
   "dependencies": {
-    "@ckeditor/ckeditor5-dev-utils": "^39.1.0",
+    "@ckeditor/ckeditor5-dev-utils": "^39.2.0",
     "@octokit/rest": "^19.0.0",
     "chalk": "^4.0.0",
     "cli-table": "^0.3.1",