@ckeditor/ckeditor5-dev-release-tools 38.3.0 → 38.4.0

package/lib/tasks/reassignnpmtags.js

@@ -12,10 +12,13 @@
 const chalk = require( 'chalk' );
 const columns = require( 'cli-columns' );
 const { tools } = require( '@ckeditor/ckeditor5-dev-utils' );
+const util = require( 'util' );
+const exec = util.promisify( require( 'child_process' ).exec );
 const assertNpmAuthorization = require( '../utils/assertnpmauthorization' );
 
 /**
  * Used to switch the tags from `staging` to `latest` for specified array of packages.
+ * Each operation will be retried up to 3 times in case of failure.
  *
  * @param {Object} options
  * @param {String} options.npmOwner User that is authorized to release packages.
@@ -33,30 +36,29 @@ module.exports = async function reassignNpmTags( { npmOwner, version, packages }
 	const counter = tools.createSpinner( 'Reassigning npm tags...', { total: packages.length } );
 	counter.start();
 
-	for ( const packageName of packages ) {
-		const latestVersion = await exec( `npm show ${ packageName }@latest version` )
-			.then( version => version.trim() )
-			.catch( error => {
-				errors.push( trimErrorMessage( error.message ) );
-			} );
-
-		if ( latestVersion === version ) {
-			packagesSkipped.push( packageName );
-
-			continue;
-		}
-
-		await exec( `npm dist-tag add ${ packageName }@${ version } latest` )
-			.then( () => {
-				packagesUpdated.push( packageName );
+	const updateTagPromises = packages.map( async packageName => {
+		const updateLatestTagRetryable = retry( () => exec( `npm dist-tag add ${ packageName }@${ version } latest` ) );
+		await updateLatestTagRetryable()
+			.then( response => {
+				if ( response.stdout ) {
+					packagesUpdated.push( packageName );
+				} else if ( response.stderr ) {
+					throw new Error( response.stderr );
+				}
 			} )
 			.catch( error => {
-				errors.push( trimErrorMessage( error.message ) );
+				if ( error.message.includes( 'is already set to version' ) ) {
+					packagesSkipped.push( packageName );
+				} else {
+					errors.push( trimErrorMessage( error.message ) );
+				}
 			} )
 			.finally( () => {
 				counter.increase();
 			} );
-	}
+	} );
+
+	await Promise.allSettled( updateTagPromises );
 
 	counter.finish();
 
@@ -85,9 +87,24 @@ function trimErrorMessage( message ) {
 }
 
 /**
- * @param {String} command
- * @returns {Promise.<String>}
+ * @param {Function} callback
+ * @param {Number} times
+ * @returns {RetryCallback}
  */
-async function exec( command ) {
-	return tools.shExec( command, { verbosity: 'silent', async: true } );
+function retry( callback, times = 3 ) {
+	return ( ...args ) => Promise.resolve()
+		.then( () => callback( ...args ) )
+		.catch( err => {
+			if ( times > 0 ) {
+				return retry( callback, times - 1 )( ...args );
+			}
+
+			throw err;
+		} );
 }
+
+/**
+ * @callback RetryCallback
+ * @param {...*} args
+ * @returns {Promise}
+ */

package/lib/utils/executeinparallel.js

@@ -28,7 +28,7 @@ const WORKER_SCRIPT = upath.join( __dirname, 'parallelworker.js' );
  * @param {String} options.packagesDirectory Relative path to a location of packages to execute a task.
  * @param {Function} options.taskToExecute A callback that is executed on all found packages.
  * It receives an absolute path to a package as an argument. It can be synchronous or may return a promise.
- * @param {ListrTaskObject} options.listrTask An instance of `ListrTask`.
+ * @param {ListrTaskObject} [options.listrTask={}] An instance of `ListrTask`.
  * @param {AbortSignal|null} [options.signal=null] Signal to abort the asynchronous process. If not set, default AbortController is created.
  * @param {Object} [options.taskOptions=null] Optional data required by the task.
  * @param {Function} [options.packagesDirectoryFilter=null] A function that is executed for each found package directory to filter out those
@@ -42,7 +42,7 @@ module.exports = async function executeInParallel( options ) {
 	const {
 		packagesDirectory,
 		taskToExecute,
-		listrTask,
+		listrTask = {},
 		signal = null,
 		taskOptions = null,
 		packagesDirectoryFilter = null,

package/package.json

@@ -1,11 +1,11 @@
 {
   "name": "@ckeditor/ckeditor5-dev-release-tools",
-  "version": "38.3.0",
+  "version": "38.4.0",
   "description": "Tools used for releasing CKEditor 5 and related packages.",
   "keywords": [],
   "main": "lib/index.js",
   "dependencies": {
-    "@ckeditor/ckeditor5-dev-utils": "^38.3.0",
+    "@ckeditor/ckeditor5-dev-utils": "^38.4.0",
     "@octokit/rest": "^19.0.0",
     "chalk": "^4.0.0",
     "cli-table": "^0.3.1",