@ckeditor/ckeditor5-core 35.3.2 → 35.4.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ckeditor/ckeditor5-core",
-  "version": "35.3.2",
+  "version": "35.4.0",
   "description": "The core architecture of CKEditor 5 – the best browser-based rich text editor.",
   "keywords": [
     "wysiwyg",
@@ -23,25 +23,25 @@
   ],
   "main": "src/index.js",
   "dependencies": {
-    "@ckeditor/ckeditor5-engine": "^35.3.2",
-    "@ckeditor/ckeditor5-ui": "^35.3.2",
-    "@ckeditor/ckeditor5-utils": "^35.3.2",
+    "@ckeditor/ckeditor5-engine": "^35.4.0",
+    "@ckeditor/ckeditor5-ui": "^35.4.0",
+    "@ckeditor/ckeditor5-utils": "^35.4.0",
     "lodash-es": "^4.17.15"
   },
   "devDependencies": {
-    "@ckeditor/ckeditor5-autoformat": "^35.3.2",
-    "@ckeditor/ckeditor5-basic-styles": "^35.3.2",
-    "@ckeditor/ckeditor5-block-quote": "^35.3.2",
-    "@ckeditor/ckeditor5-editor-classic": "^35.3.2",
-    "@ckeditor/ckeditor5-essentials": "^35.3.2",
-    "@ckeditor/ckeditor5-heading": "^35.3.2",
-    "@ckeditor/ckeditor5-image": "^35.3.2",
-    "@ckeditor/ckeditor5-indent": "^35.3.2",
-    "@ckeditor/ckeditor5-link": "^35.3.2",
-    "@ckeditor/ckeditor5-list": "^35.3.2",
-    "@ckeditor/ckeditor5-media-embed": "^35.3.2",
-    "@ckeditor/ckeditor5-paragraph": "^35.3.2",
-    "@ckeditor/ckeditor5-table": "^35.3.2",
+    "@ckeditor/ckeditor5-autoformat": "^35.4.0",
+    "@ckeditor/ckeditor5-basic-styles": "^35.4.0",
+    "@ckeditor/ckeditor5-block-quote": "^35.4.0",
+    "@ckeditor/ckeditor5-editor-classic": "^35.4.0",
+    "@ckeditor/ckeditor5-essentials": "^35.4.0",
+    "@ckeditor/ckeditor5-heading": "^35.4.0",
+    "@ckeditor/ckeditor5-image": "^35.4.0",
+    "@ckeditor/ckeditor5-indent": "^35.4.0",
+    "@ckeditor/ckeditor5-link": "^35.4.0",
+    "@ckeditor/ckeditor5-list": "^35.4.0",
+    "@ckeditor/ckeditor5-media-embed": "^35.4.0",
+    "@ckeditor/ckeditor5-paragraph": "^35.4.0",
+    "@ckeditor/ckeditor5-table": "^35.4.0",
     "typescript": "^4.8.4",
     "webpack": "^5.58.1",
     "webpack-cli": "^4.9.0"

package/src/command.js

@@ -2,27 +2,30 @@
  * @license Copyright (c) 2003-2022, CKSource Holding sp. z o.o. All rights reserved.
  * For licensing, see LICENSE.md or https://ckeditor.com/legal/ckeditor-oss-license
  */
-import { Observable } from '@ckeditor/ckeditor5-utils/src/observablemixin';
 /**
- * The base class for CKEditor commands.
+ * @module core/command
+ */
+import { ObservableMixin } from '@ckeditor/ckeditor5-utils';
+/**
+ * Base class for the CKEditor commands.
  *
- * Commands are the main way to manipulate editor contents and state. They are mostly used by UI elements (or by other
- * commands) to make changes in the model. Commands are available in every part of code that has access to
+ * Commands are the main way to manipulate the editor contents and state. They are mostly used by UI elements (or by other
+ * commands) to make changes in the model. Commands are available in every part of the code that has access to
  * the {@link module:core/editor/editor~Editor editor} instance.
  *
  * Instances of registered commands can be retrieved from {@link module:core/editor/editor~Editor#commands `editor.commands`}.
  * The easiest way to execute a command is through {@link module:core/editor/editor~Editor#execute `editor.execute()`}.
  *
- * By default, commands are disabled when the editor is in {@link module:core/editor/editor~Editor#isReadOnly read-only} mode
+ * By default, commands are disabled when the editor is in the {@link module:core/editor/editor~Editor#isReadOnly read-only} mode
  * but commands with the {@link module:core/command~Command#affectsData `affectsData`} flag set to `false` will not be disabled.
  *
  * @mixes module:utils/observablemixin~ObservableMixin
  */
-export default class Command extends Observable {
+export default class Command extends ObservableMixin() {
     /**
      * Creates a new `Command` instance.
      *
-     * @param {module:core/editor/editor~Editor} editor Editor on which this command will be used.
+     * @param {module:core/editor/editor~Editor} editor The editor on which this command will be used.
      */
     constructor(editor) {
         super();
@@ -34,14 +37,14 @@ export default class Command extends Observable {
          */
         this.editor = editor;
         /**
-         * The value of the command. A concrete command class should define what it represents for it.
+         * The value of the command. A given command class should define what it represents for it.
          *
          * For example, the `'bold'` command's value indicates whether the selection starts in a bolded text.
-         * And the value of the `'link'` command may be an object with links details.
+         * And the value of the `'link'` command may be an object with link details.
          *
          * It is possible for a command to have no value (e.g. for stateless actions such as `'uploadImage'`).
          *
-         * A concrete command class should control this value by overriding the {@link #refresh `refresh()`} method.
+         * A given command class should control this value by overriding the {@link #refresh `refresh()`} method.
          *
          * @observable
          * @readonly
@@ -52,9 +55,9 @@ export default class Command extends Observable {
          * Flag indicating whether a command is enabled or disabled.
          * A disabled command will do nothing when executed.
          *
-         * A concrete command class should control this value by overriding the {@link #refresh `refresh()`} method.
+         * A given command class should control this value by overriding the {@link #refresh `refresh()`} method.
          *
-         * It is possible to disable a command from "outside". For instance, in your integration you may want to disable
+         * It is possible to disable a command "from outside". For instance, in your integration you may want to disable
          * a certain set of commands for the time being. To do that, you can use the fact that `isEnabled` is observable
          * and it fires the `set:isEnabled` event every time anyone tries to modify its value:
          *
@@ -149,7 +152,7 @@ export default class Command extends Observable {
      * Disables the command.
      *
      * Command may be disabled by multiple features or algorithms (at once). When disabling a command, unique id should be passed
-     * (e.g. feature name). The same identifier should be used when {@link #clearForceDisabled enabling back} the command.
+     * (e.g. the feature name). The same identifier should be used when {@link #clearForceDisabled enabling back} the command.
      * The command becomes enabled only after all features {@link #clearForceDisabled enabled it back}.
      *
      * Disabling and enabling a command:

package/src/commandcollection.js

@@ -5,7 +5,7 @@
 /**
  * @module core/commandcollection
  */
-import CKEditorError from '@ckeditor/ckeditor5-utils/src/ckeditorerror';
+import { CKEditorError } from '@ckeditor/ckeditor5-utils';
 /**
  * Collection of commands. Its instance is available in {@link module:core/editor/editor~Editor#commands `editor.commands`}.
  */

package/src/context.js

@@ -5,17 +5,14 @@
 /**
  * @module core/context
  */
-import Config from '@ckeditor/ckeditor5-utils/src/config';
-import Collection from '@ckeditor/ckeditor5-utils/src/collection';
+import { Config, Collection, CKEditorError, Locale } from '@ckeditor/ckeditor5-utils';
 import PluginCollection from './plugincollection';
-import Locale from '@ckeditor/ckeditor5-utils/src/locale';
-import CKEditorError from '@ckeditor/ckeditor5-utils/src/ckeditorerror';
 /**
  * Provides a common, higher-level environment for solutions that use multiple {@link module:core/editor/editor~Editor editors}
  * or plugins that work outside the editor. Use it instead of {@link module:core/editor/editor~Editor.create `Editor.create()`}
  * in advanced application integrations.
  *
- * All configuration options passed to a context will be used as default options for editor instances initialized in that context.
+ * All configuration options passed to a context will be used as default options for the editor instances initialized in that context.
  *
  * {@link module:core/contextplugin~ContextPlugin Context plugins} passed to a context instance will be shared among all
  * editor instances initialized in this context. These will be the same plugin instances for all the editors.
@@ -33,7 +30,7 @@ import CKEditorError from '@ckeditor/ckeditor5-utils/src/ckeditorerror';
  * enable and configure them using the context.
  *
  * If you are using only a single editor on each page, use {@link module:core/editor/editor~Editor.create `Editor.create()`} instead.
- * In such case, a context instance will be created by the editor instance in a transparent way.
+ * In such a case, a context instance will be created by the editor instance in a transparent way.
  *
  * See {@link module:core/context~Context.create `Context.create()`} for usage examples.
  */

package/src/contextplugin.js

@@ -5,7 +5,7 @@
 /**
  * @module core/contextplugin
  */
-import { Observable } from '@ckeditor/ckeditor5-utils/src/observablemixin';
+import { ObservableMixin } from '@ckeditor/ckeditor5-utils';
 /**
  * The base class for {@link module:core/context~Context} plugin classes.
  *
@@ -23,7 +23,7 @@ import { Observable } from '@ckeditor/ckeditor5-utils/src/observablemixin';
  * @implements module:core/plugin~PluginInterface
  * @mixes module:utils/observablemixin~ObservableMixin
  */
-export default class ContextPlugin extends Observable {
+export default class ContextPlugin extends ObservableMixin() {
     /**
      * Creates a new plugin instance.
      *

package/src/editingkeystrokehandler.js

@@ -5,7 +5,7 @@
 /**
  * @module core/editingkeystrokehandler
  */
-import KeystrokeHandler from '@ckeditor/ckeditor5-utils/src/keystrokehandler';
+import { KeystrokeHandler } from '@ckeditor/ckeditor5-utils';
 /**
  * A keystroke handler for editor editing. Its instance is available
  * in {@link module:core/editor/editor~Editor#keystrokes} so plugins

package/src/editor/editor.js

@@ -5,18 +5,12 @@
 /**
  * @module core/editor/editor
  */
+import { Config, CKEditorError, ObservableMixin } from '@ckeditor/ckeditor5-utils';
+import { Conversion, DataController, EditingController, Model, StylesProcessor } from '@ckeditor/ckeditor5-engine';
 import Context from '../context';
-import Config from '@ckeditor/ckeditor5-utils/src/config';
-import EditingController from '@ckeditor/ckeditor5-engine/src/controller/editingcontroller';
 import PluginCollection from '../plugincollection';
 import CommandCollection from '../commandcollection';
-import DataController from '@ckeditor/ckeditor5-engine/src/controller/datacontroller';
-import Conversion from '@ckeditor/ckeditor5-engine/src/conversion/conversion';
-import Model from '@ckeditor/ckeditor5-engine/src/model/model';
 import EditingKeystrokeHandler from '../editingkeystrokehandler';
-import { Observable } from '@ckeditor/ckeditor5-utils/src/observablemixin';
-import CKEditorError from '@ckeditor/ckeditor5-utils/src/ckeditorerror';
-import { StylesProcessor } from '@ckeditor/ckeditor5-engine/src/view/stylesmap';
 /**
  * The class representing a basic, generic editor.
  *
@@ -38,7 +32,7 @@ import { StylesProcessor } from '@ckeditor/ckeditor5-engine/src/view/stylesmap';
  * @abstract
  * @mixes module:utils/observablemixin~ObservableMixin
  */
-export default class Editor extends Observable {
+export default class Editor extends ObservableMixin() {
     /**
      * Creates a new instance of the editor class.
      *

package/src/editor/editorui.js

@@ -2,17 +2,17 @@
  * @license Copyright (c) 2003-2022, CKSource Holding sp. z o.o. All rights reserved.
  * For licensing, see LICENSE.md or https://ckeditor.com/legal/ckeditor-oss-license
  */
+// TODO: can't import it from `@ckeditor/ckeditor5-ui` because of indirect circular dependency
+// between `@ckeditor/ckeditor5-{ui,core}/src/index.ts`.
 import ComponentFactory from '@ckeditor/ckeditor5-ui/src/componentfactory';
-import FocusTracker from '@ckeditor/ckeditor5-utils/src/focustracker';
 import TooltipManager from '@ckeditor/ckeditor5-ui/src/tooltipmanager';
-import { Observable } from '@ckeditor/ckeditor5-utils/src/observablemixin';
-import isVisible from '@ckeditor/ckeditor5-utils/src/dom/isvisible';
+import { ObservableMixin, isVisible, FocusTracker } from '@ckeditor/ckeditor5-utils';
 /**
  * A class providing the minimal interface that is required to successfully bootstrap any editor UI.
  *
  * @mixes module:utils/emittermixin~EmitterMixin
  */
-export default class EditorUI extends Observable {
+export default class EditorUI extends ObservableMixin() {
     /**
      * Creates an instance of the editor UI class.
      *

package/src/editor/utils/attachtoform.js

@@ -3,7 +3,7 @@
  * For licensing, see LICENSE.md or https://ckeditor.com/legal/ckeditor-oss-license
  */
 import { isFunction } from 'lodash-es';
-import CKEditorError from '@ckeditor/ckeditor5-utils/src/ckeditorerror';
+import { CKEditorError } from '@ckeditor/ckeditor5-utils';
 /**
  * @module core/editor/utils/attachtoform
  */

package/src/editor/utils/elementapimixin.js

@@ -3,8 +3,7 @@
  * For licensing, see LICENSE.md or https://ckeditor.com/legal/ckeditor-oss-license
  */
 /* eslint-disable @typescript-eslint/explicit-module-boundary-types */
-import CKEditorError from '@ckeditor/ckeditor5-utils/src/ckeditorerror';
-import setDataInElement from '@ckeditor/ckeditor5-utils/src/dom/setdatainelement';
+import { CKEditorError, setDataInElement } from '@ckeditor/ckeditor5-utils';
 /**
  * @module core/editor/utils/elementapimixin
  */

package/src/editor/utils/securesourceelement.js

@@ -2,7 +2,7 @@
  * @license Copyright (c) 2003-2022, CKSource Holding sp. z o.o. All rights reserved.
  * For licensing, see LICENSE.md or https://ckeditor.com/legal/ckeditor-oss-license
  */
-import CKEditorError from '@ckeditor/ckeditor5-utils/src/ckeditorerror';
+import { CKEditorError } from '@ckeditor/ckeditor5-utils';
 /**
  * @module core/editor/utils/securesourceelement
  */

package/src/multicommand.js

@@ -3,7 +3,7 @@
  * For licensing, see LICENSE.md or https://ckeditor.com/legal/ckeditor-oss-license
  */
 import Command from './command';
-import insertToPriorityArray from '@ckeditor/ckeditor5-utils/src/inserttopriorityarray';
+import { insertToPriorityArray } from '@ckeditor/ckeditor5-utils';
 /**
  * @module core/multicommand
  */
@@ -12,7 +12,7 @@ import insertToPriorityArray from '@ckeditor/ckeditor5-utils/src/inserttopriorit
  *
  * This command is used to proxy multiple commands. The multi-command is enabled when
  * at least one of its registered child commands is enabled.
- * When executing a multi-command the first enabled command with highest priority will be executed.
+ * When executing a multi-command, the first enabled command with highest priority will be executed.
  *
  *		const multiCommand = new MultiCommand( editor );
  *
@@ -69,7 +69,7 @@ export default class MultiCommand extends Command {
      */
     registerChildCommand(command, options = {}) {
         insertToPriorityArray(this._childCommandsDefinitions, { command, priority: options.priority || 'normal' });
-        // Change multi command enabled state when one of registered commands changes state.
+        // Change multi-command enabled state when one of registered commands changes state.
         command.on('change:isEnabled', () => this._checkEnabled());
         this._checkEnabled();
     }

package/src/pendingactions.js

@@ -6,9 +6,7 @@
  * @module core/pendingactions
  */
 import ContextPlugin from './contextplugin';
-import { Observable } from '@ckeditor/ckeditor5-utils/src/observablemixin';
-import Collection from '@ckeditor/ckeditor5-utils/src/collection';
-import CKEditorError from '@ckeditor/ckeditor5-utils/src/ckeditorerror';
+import { CKEditorError, Collection, ObservableMixin } from '@ckeditor/ckeditor5-utils';
 /**
  * The list of pending editor actions.
  *
@@ -95,7 +93,7 @@ export default class PendingActions extends ContextPlugin {
              */
             throw new CKEditorError('pendingactions-add-invalid-message', this);
         }
-        const action = new Observable();
+        const action = new (ObservableMixin())();
         action.set('message', message);
         this._actions.add(action);
         this.hasAny = true;
@@ -111,7 +109,7 @@ export default class PendingActions extends ContextPlugin {
         this.hasAny = !!this._actions.length;
     }
     /**
-     * Returns the first action from the list or null when list is empty
+     * Returns the first action from the list or null if the list is empty
      *
      * returns {Object|null} The pending action object.
      */

package/src/plugin.js

@@ -6,14 +6,14 @@
 /**
  * @module core/plugin
  */
-import { Observable } from '@ckeditor/ckeditor5-utils/src/observablemixin';
+import { ObservableMixin } from '@ckeditor/ckeditor5-utils';
 /**
  * The base class for CKEditor plugin classes.
  *
  * @implements module:core/plugin~PluginInterface
  * @mixes module:utils/observablemixin~ObservableMixin
  */
-export default class Plugin extends Observable {
+export default class Plugin extends ObservableMixin() {
     /**
      * @inheritDoc
      */

package/src/plugincollection.js

@@ -5,14 +5,13 @@
 /**
  * @module core/plugincollection
  */
-import CKEditorError from '@ckeditor/ckeditor5-utils/src/ckeditorerror';
-import { Emitter } from '@ckeditor/ckeditor5-utils/src/emittermixin';
+import { CKEditorError, EmitterMixin } from '@ckeditor/ckeditor5-utils';
 /**
  * Manages a list of CKEditor plugins, including loading, resolving dependencies and initialization.
  *
  * @mixes module:utils/emittermixin~EmitterMixin
  */
-export default class PluginCollection extends Emitter {
+export default class PluginCollection extends EmitterMixin() {
     /**
      * Creates an instance of the plugin collection class.
      * Allows loading and initializing plugins and their dependencies.