@ckeditor/ckeditor5-core 34.0.0 → 35.0.0

package/src/editor/utils/elementapimixin.js

@@ -3,6 +3,8 @@
  * For licensing, see LICENSE.md or https://ckeditor.com/legal/ckeditor-oss-license
  */
 
+/* globals HTMLTextAreaElement */
+
 import CKEditorError from '@ckeditor/ckeditor5-utils/src/ckeditorerror';
 import setDataInElement from '@ckeditor/ckeditor5-utils/src/dom/setdatainelement';
 
@@ -20,7 +22,7 @@ const ElementApiMixin = {
 	/**
 	 * @inheritDoc
 	 */
-	updateSourceElement() {
+	updateSourceElement( data = this.data.get() ) {
 		if ( !this.sourceElement ) {
 			/**
 			 * Cannot update the source element of a detached editor.
@@ -36,7 +38,20 @@ const ElementApiMixin = {
 			);
 		}
 
-		setDataInElement( this.sourceElement, this.data.get() );
+		const shouldUpdateSourceElement = this.config.get( 'updateSourceElementOnDestroy' );
+		const isSourceElementTextArea = this.sourceElement instanceof HTMLTextAreaElement;
+
+		// The data returned by the editor might be unsafe, so we want to prevent rendering
+		// unsafe content inside the source element different than <textarea>, which is considered
+		// secure. This behaviour could be changed by setting the `updateSourceElementOnDestroy`
+		// configuration option to `true`.
+		if ( !shouldUpdateSourceElement && !isSourceElementTextArea ) {
+			setDataInElement( this.sourceElement, '' );
+
+			return;
+		}
+
+		setDataInElement( this.sourceElement, data );
 	}
 };
 
@@ -62,4 +77,6 @@ export default ElementApiMixin;
  * Updates the {@link #sourceElement editor source element}'s content with the data.
  *
  * @method #updateSourceElement
+ * @param {String} data The data that should be used to update the source element.
+ * By default, it is taken directly from the existing editor instance.
  */

package/src/plugincollection.js

@@ -344,7 +344,7 @@ export default class PluginCollection {
 			 * This is usually done in CKEditor 5 builds by setting the {@link module:core/editor/editor~Editor.builtinPlugins}
 			 * property.
 			 *
-			 * **If you see this warning when using one of the {@glink installation/advanced/alternative-setups/predefined-builds
+			 * **If you see this warning when using one of the {@glink installation/getting-started/predefined-builds
 			 * CKEditor 5 Builds}**,
 			 * it means that you try to enable a plugin which was not included in that build. This may be due to a typo
 			 * in the plugin name or simply because that plugin is not a part of this build. In the latter scenario,