@ckeditor/ckeditor5-clipboard 47.1.0 → 47.2.0-alpha.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ckeditor/ckeditor5-clipboard",
-  "version": "47.1.0",
+  "version": "47.2.0-alpha.1",
   "description": "Clipboard integration feature for CKEditor 5.",
   "keywords": [
     "ckeditor",
@@ -13,11 +13,11 @@
   "type": "module",
   "main": "src/index.js",
   "dependencies": {
-    "@ckeditor/ckeditor5-core": "47.1.0",
-    "@ckeditor/ckeditor5-engine": "47.1.0",
-    "@ckeditor/ckeditor5-ui": "47.1.0",
-    "@ckeditor/ckeditor5-utils": "47.1.0",
-    "@ckeditor/ckeditor5-widget": "47.1.0",
+    "@ckeditor/ckeditor5-core": "47.2.0-alpha.1",
+    "@ckeditor/ckeditor5-engine": "47.2.0-alpha.1",
+    "@ckeditor/ckeditor5-ui": "47.2.0-alpha.1",
+    "@ckeditor/ckeditor5-utils": "47.2.0-alpha.1",
+    "@ckeditor/ckeditor5-widget": "47.2.0-alpha.1",
     "es-toolkit": "1.39.5"
   },
   "author": "CKSource (http://cksource.com/)",

package/src/dragdrop.js

@@ -218,7 +218,8 @@ export class DragDrop extends Plugin {
                 return;
             }
             this._draggingUid = uid();
-            data.dataTransfer.effectAllowed = this.isEnabled ? 'copyMove' : 'copy';
+            const canEditAtDraggedRange = this.isEnabled && editor.model.canEditAt(this._draggedRange);
+            data.dataTransfer.effectAllowed = canEditAtDraggedRange ? 'copyMove' : 'copy';
             data.dataTransfer.setData('application/ckeditor5-dragging-uid', this._draggingUid);
             const draggedSelection = model.createSelection(this._draggedRange.toRange());
             const clipboardPipeline = this.editor.plugins.get('ClipboardPipeline');
@@ -227,7 +228,7 @@ export class DragDrop extends Plugin {
             const { clientX } = domEvent;
             this._updatePreview({ dataTransfer, domTarget, clientX });
             data.stopPropagation();
-            if (!this.isEnabled) {
+            if (!canEditAtDraggedRange) {
                 this._draggedRange.detach();
                 this._draggedRange = null;
                 this._draggingUid = '';
@@ -263,7 +264,12 @@ export class DragDrop extends Plugin {
                 return;
             }
             const { clientX, clientY } = data.domEvent;
-            dragDropTarget.updateDropMarker(data.target, data.targetRanges, clientX, clientY, this._blockMode, this._draggedRange);
+            const targetRange = dragDropTarget.updateDropMarker(data.target, data.targetRanges, clientX, clientY, this._blockMode, this._draggedRange);
+            // Do not allow dropping if there is no valid target range (e.g., dropping on non-editable place).
+            if (!targetRange) {
+                data.dataTransfer.dropEffect = 'none';
+                return;
+            }
             // If this is content being dragged from another editor, moving out of current editor instance
             // is not possible until 'dragend' event case will be fixed.
             if (!this._draggedRange) {

package/src/dragdroptarget.d.ts

@@ -58,9 +58,10 @@ export declare class DragDropTarget extends Plugin {
     /**
      * Finds the drop target range and updates the drop marker.
      *
+     * @return The updated drop target range or null if no valid range was found.
      * @internal
      */
-    updateDropMarker(targetViewElement: ViewElement, targetViewRanges: Array<ViewRange> | null, clientX: number, clientY: number, blockMode: boolean, draggedRange: ModelLiveRange | null): void;
+    updateDropMarker(targetViewElement: ViewElement, targetViewRanges: Array<ViewRange> | null, clientX: number, clientY: number, blockMode: boolean, draggedRange: ModelLiveRange | null): ModelRange | null;
     /**
      * Finds the final drop target range.
      *

package/src/dragdroptarget.js

@@ -79,6 +79,7 @@ export class DragDropTarget extends Plugin {
     /**
      * Finds the drop target range and updates the drop marker.
      *
+     * @return The updated drop target range or null if no valid range was found.
      * @internal
      */
     updateDropMarker(targetViewElement, targetViewRanges, clientX, clientY, blockMode, draggedRange) {
@@ -86,13 +87,20 @@ export class DragDropTarget extends Plugin {
         const targetRange = findDropTargetRange(this.editor, targetViewElement, targetViewRanges, clientX, clientY, blockMode, draggedRange);
         /* istanbul ignore next -- @preserve */
         if (!targetRange) {
-            return;
+            return null;
         }
         if (draggedRange && draggedRange.containsRange(targetRange)) {
             // Target range is inside the dragged range.
-            return this.removeDropMarker();
+            this.removeDropMarker();
+            return null;
+        }
+        if (targetRange && !this.editor.model.canEditAt(targetRange)) {
+            // Do not show drop marker if target place is not editable.
+            this.removeDropMarker();
+            return null;
         }
         this._updateDropMarkerThrottled(targetRange);
+        return targetRange;
     }
     /**
      * Finds the final drop target range.
@@ -270,7 +278,7 @@ function findDropTargetRange(editor, targetViewElement, targetViewRanges, client
                     const targetModelPosition = mapper.toModelPosition(targetViewPosition);
                     const canDropOnPosition = !draggedRange || Array
                         .from(draggedRange.getItems({ shallow: true }))
-                        .every(item => model.schema.checkChild(targetModelPosition, item));
+                        .some(item => model.schema.checkChild(targetModelPosition, item));
                     if (canDropOnPosition) {
                         if (model.schema.checkChild(targetModelPosition, '$text')) {
                             return model.createRange(targetModelPosition);