@ckeditor/ckeditor5-clipboard 47.1.0 → 47.2.0-alpha.0

package/README.md

@@ -2,7 +2,7 @@ CKEditor 5 clipboard feature
 ========================================
 
 [![npm version](https://badge.fury.io/js/%40ckeditor%2Fckeditor5-clipboard.svg)](https://www.npmjs.com/package/@ckeditor/ckeditor5-clipboard)
-[![Coverage Status](https://coveralls.io/repos/github/ckeditor/ckeditor5/badge.svg?branch=master)](https://coveralls.io/github/ckeditor/ckeditor5?branch=master)
+[![codecov](https://codecov.io/gh/ckeditor/ckeditor5/branch/master/graph/badge.svg)](https://codecov.io/gh/ckeditor/ckeditor5)
 [![CircleCI](https://circleci.com/gh/ckeditor/ckeditor5.svg?style=shield)](https://app.circleci.com/pipelines/github/ckeditor/ckeditor5?branch=master)
 
 This package implements the clipboard (copy, cut, paste) support for CKEditor 5.

package/dist/index.js

@@ -1092,18 +1092,26 @@ const toPx = /* #__PURE__ */ toUnit('px');
     /**
 	 * Finds the drop target range and updates the drop marker.
 	 *
+	 * @return The updated drop target range or null if no valid range was found.
 	 * @internal
 	 */ updateDropMarker(targetViewElement, targetViewRanges, clientX, clientY, blockMode, draggedRange) {
         this.removeDropMarkerDelayed.cancel();
         const targetRange = findDropTargetRange(this.editor, targetViewElement, targetViewRanges, clientX, clientY, blockMode, draggedRange);
         /* istanbul ignore next -- @preserve */ if (!targetRange) {
-            return;
+            return null;
         }
         if (draggedRange && draggedRange.containsRange(targetRange)) {
             // Target range is inside the dragged range.
-            return this.removeDropMarker();
+            this.removeDropMarker();
+            return null;
+        }
+        if (targetRange && !this.editor.model.canEditAt(targetRange)) {
+            // Do not show drop marker if target place is not editable.
+            this.removeDropMarker();
+            return null;
         }
         this._updateDropMarkerThrottled(targetRange);
+        return targetRange;
     }
     /**
 	 * Finds the final drop target range.
@@ -1275,7 +1283,7 @@ const toPx = /* #__PURE__ */ toUnit('px');
                     const targetModelPosition = mapper.toModelPosition(targetViewPosition);
                     const canDropOnPosition = !draggedRange || Array.from(draggedRange.getItems({
                         shallow: true
-                    })).every((item)=>model.schema.checkChild(targetModelPosition, item));
+                    })).some((item)=>model.schema.checkChild(targetModelPosition, item));
                     if (canDropOnPosition) {
                         if (model.schema.checkChild(targetModelPosition, '$text')) {
                             return model.createRange(targetModelPosition);
@@ -1675,7 +1683,8 @@ const toPx = /* #__PURE__ */ toUnit('px');
                 return;
             }
             this._draggingUid = uid();
-            data.dataTransfer.effectAllowed = this.isEnabled ? 'copyMove' : 'copy';
+            const canEditAtDraggedRange = this.isEnabled && editor.model.canEditAt(this._draggedRange);
+            data.dataTransfer.effectAllowed = canEditAtDraggedRange ? 'copyMove' : 'copy';
             data.dataTransfer.setData('application/ckeditor5-dragging-uid', this._draggingUid);
             const draggedSelection = model.createSelection(this._draggedRange.toRange());
             const clipboardPipeline = this.editor.plugins.get('ClipboardPipeline');
@@ -1688,7 +1697,7 @@ const toPx = /* #__PURE__ */ toUnit('px');
                 clientX
             });
             data.stopPropagation();
-            if (!this.isEnabled) {
+            if (!canEditAtDraggedRange) {
                 this._draggedRange.detach();
                 this._draggedRange = null;
                 this._draggingUid = '';
@@ -1730,7 +1739,12 @@ const toPx = /* #__PURE__ */ toUnit('px');
                 return;
             }
             const { clientX, clientY } = data.domEvent;
-            dragDropTarget.updateDropMarker(data.target, data.targetRanges, clientX, clientY, this._blockMode, this._draggedRange);
+            const targetRange = dragDropTarget.updateDropMarker(data.target, data.targetRanges, clientX, clientY, this._blockMode, this._draggedRange);
+            // Do not allow dropping if there is no valid target range (e.g., dropping on non-editable place).
+            if (!targetRange) {
+                data.dataTransfer.dropEffect = 'none';
+                return;
+            }
             // If this is content being dragged from another editor, moving out of current editor instance
             // is not possible until 'dragend' event case will be fixed.
             if (!this._draggedRange) {