@circuitwall/jarela 1.4.0 → 1.4.1

package/components/setup/PinKeypad.tsx

@@ -0,0 +1,238 @@
+"use client";
+
+import { useCallback, useEffect, useRef, useState } from "react";
+import { Logo } from "@/components/ui/Logo";
+
+// Shared 6-digit PIN keypad used by both the decrypt splash (master key
+// locked at boot) and the screen-lock overlay (idle timer fired). The
+// only differences between the two states are (a) the endpoint hit
+// (b) the copy on screen and (c) what happens after success. Everything
+// else — keypad layout, dot strip, rate-limit handling, keyboard
+// support, error mapping — is identical, so the two were collapsed into
+// one component to avoid drift.
+
+const PIN_LENGTH = 6;
+
+export type PinKeypadMode = "decrypt" | "unlock";
+
+interface PinKeypadProps {
+  mode: PinKeypadMode;
+  onSuccess: () => void;
+}
+
+interface ModeConfig {
+  endpoint: string;
+  title: string;
+  subtitle: string;
+  busyLabel: string;
+}
+
+const MODES: Record<PinKeypadMode, ModeConfig> = {
+  decrypt: {
+    endpoint: "/api/v1/security/unlock",
+    title: "Decrypt Jarela",
+    subtitle: "Enter your 6-digit PIN to decrypt your data.",
+    busyLabel: "Decrypting\u2026",
+  },
+  unlock: {
+    endpoint: "/api/v1/security/verify-pin",
+    title: "Welcome back",
+    subtitle: "Enter your 6-digit PIN to unlock.",
+    busyLabel: "Unlocking\u2026",
+  },
+};
+
+export function PinKeypad({ mode, onSuccess }: PinKeypadProps) {
+  const cfg = MODES[mode];
+  const [digits, setDigits] = useState("");
+  const [error, setError] = useState<string | null>(null);
+  const [submitting, setSubmitting] = useState(false);
+  const [retryAfterSec, setRetryAfterSec] = useState(0);
+  // Hard guard against parallel submits. setState updaters can run more
+  // than once (dev StrictMode, concurrent rendering), so if `submit`
+  // were called from inside `setDigits` we'd POST twice and the second
+  // request would race the first into `unlockMasterKey()` after state
+  // already flipped to unlocked — the route would 500.
+  const submittingRef = useRef(false);
+
+  const submit = useCallback(
+    async (pin: string) => {
+      if (submittingRef.current) return;
+      submittingRef.current = true;
+      setSubmitting(true);
+      setError(null);
+      try {
+        const res = await fetch(cfg.endpoint, {
+          method: "POST",
+          headers: { "content-type": "application/json" },
+          body: JSON.stringify({ pin }),
+        });
+        if (res.ok) {
+          onSuccess();
+          return;
+        }
+        const body = (await res.json().catch(() => ({}))) as {
+          error?: string;
+          retry_after_ms?: number;
+        };
+        // Goal-state convergence: both endpoints can return 409 when the
+        // server already reached the target state (decrypt → master key
+        // already unlocked; unlock → screen not locked). Treat as success
+        // rather than surfacing a confusing error.
+        if (res.status === 409 && (body.error === "not-locked" || body.error === "no-pin")) {
+          onSuccess();
+          return;
+        }
+        if (res.status === 429 && typeof body.retry_after_ms === "number") {
+          setRetryAfterSec(Math.ceil(body.retry_after_ms / 1000));
+          setError("Too many attempts. Try again later.");
+        } else if (res.status === 401) {
+          setError("Wrong PIN. Try again.");
+        } else if (res.status === 400) {
+          setError("Invalid PIN format.");
+        } else {
+          setError(body.error ?? `Error (${res.status})`);
+        }
+        setDigits("");
+      } catch (err) {
+        setError(err instanceof Error ? err.message : String(err));
+        setDigits("");
+      } finally {
+        submittingRef.current = false;
+        setSubmitting(false);
+      }
+    },
+    [cfg.endpoint, onSuccess],
+  );
+
+  const append = useCallback(
+    (d: string) => {
+      if (submitting || retryAfterSec > 0) return;
+      setError(null);
+      setDigits((cur) => (cur.length >= PIN_LENGTH ? cur : cur + d));
+    },
+    [submitting, retryAfterSec],
+  );
+
+  // Auto-submit once the buffer hits 6 digits.
+  useEffect(() => {
+    if (digits.length === PIN_LENGTH && !submittingRef.current) {
+      void submit(digits);
+    }
+  }, [digits, submit]);
+
+  const backspace = useCallback(() => {
+    if (submitting) return;
+    setError(null);
+    setDigits((cur) => cur.slice(0, -1));
+  }, [submitting]);
+
+  useEffect(() => {
+    function onKey(e: KeyboardEvent) {
+      if (/^[0-9]$/.test(e.key)) {
+        e.preventDefault();
+        append(e.key);
+      } else if (e.key === "Backspace") {
+        e.preventDefault();
+        backspace();
+      }
+    }
+    window.addEventListener("keydown", onKey);
+    return () => window.removeEventListener("keydown", onKey);
+  }, [append, backspace]);
+
+  useEffect(() => {
+    if (retryAfterSec <= 0) return;
+    const t = setInterval(() => {
+      setRetryAfterSec((s) => (s > 0 ? s - 1 : 0));
+    }, 1000);
+    return () => clearInterval(t);
+  }, [retryAfterSec]);
+
+  return (
+    <div
+      className="fixed inset-0 z-[1000] flex flex-col items-center justify-center gap-6 bg-surface text-fg animate-in fade-in duration-200"
+      style={{
+        paddingTop: "env(safe-area-inset-top)",
+        paddingBottom: "env(safe-area-inset-bottom)",
+      }}
+      data-pin-mode={mode}
+    >
+      <Logo className="h-16 w-auto" />
+      <div className="w-full max-w-xs p-6">
+        <h1 className="mb-1 text-center text-lg font-semibold text-fg">{cfg.title}</h1>
+        <p className="mb-6 text-center text-xs text-fg-faint">{cfg.subtitle}</p>
+
+        <div className="mb-6 flex justify-center gap-3" aria-label="PIN entry progress">
+          {Array.from({ length: PIN_LENGTH }).map((_, i) => (
+            <span
+              key={i}
+              className={`h-3 w-3 rounded-full transition-colors ${
+                i < digits.length ? (error ? "bg-red-500" : "bg-fg") : "bg-surface-3"
+              }`}
+            />
+          ))}
+        </div>
+
+        <div className="grid grid-cols-3 gap-2">
+          {["1", "2", "3", "4", "5", "6", "7", "8", "9"].map((d) => (
+            <PinKey
+              key={d}
+              digit={d}
+              onPress={() => append(d)}
+              disabled={submitting || retryAfterSec > 0}
+            />
+          ))}
+          <div />
+          <PinKey
+            digit="0"
+            onPress={() => append("0")}
+            disabled={submitting || retryAfterSec > 0}
+          />
+          <PinKey
+            digit="\u2190"
+            onPress={backspace}
+            disabled={submitting || digits.length === 0}
+            ariaLabel="Backspace"
+          />
+        </div>
+
+        <p
+          className={`mt-4 min-h-[1.5rem] text-center text-xs ${
+            error ? "text-red-400" : "text-fg-faint"
+          }`}
+          role="status"
+          aria-live="polite"
+        >
+          {retryAfterSec > 0
+            ? `Try again in ${retryAfterSec}s`
+            : error ?? (submitting ? cfg.busyLabel : "\u00A0")}
+        </p>
+      </div>
+    </div>
+  );
+}
+
+function PinKey({
+  digit,
+  onPress,
+  disabled,
+  ariaLabel,
+}: {
+  digit: string;
+  onPress: () => void;
+  disabled: boolean;
+  ariaLabel?: string;
+}) {
+  return (
+    <button
+      type="button"
+      onClick={onPress}
+      disabled={disabled}
+      aria-label={ariaLabel ?? digit}
+      className="h-14 rounded-xl bg-surface-3 text-xl font-medium text-fg transition-colors hover:bg-surface-3/70 active:bg-surface-3/50 disabled:cursor-not-allowed disabled:opacity-50"
+    >
+      {digit}
+    </button>
+  );
+}

package/components/setup/ScreenLock.tsx

@@ -1,179 +1,14 @@
 "use client";
 
-import { useCallback, useEffect, useRef, useState } from "react";
-import { Logo } from "@/components/ui/Logo";
+import { PinKeypad } from "./PinKeypad";
 
-// Screen-lock overlay (presence check). Shown when the server reports
-// `screen_locked: true` after an idle timeout. Distinct from
-// UnlockScreen — this does NOT touch the in-memory master key, just
-// verifies the human at the keyboard knows the PIN. Background work
-// (agents, scheduler, bridges) keeps running underneath.
-
-const PIN_LENGTH = 6;
+// Screen-lock overlay (presence check). Mounted by AppShell when the
+// idle timer fires or the server returns 423 `screen-locked`. Does
+// NOT touch the in-memory master key — background work (agents,
+// scheduler, bridges) keeps running underneath. The /verify-pin
+// endpoint just confirms the human at the keyboard and clears the
+// idle flag.
 
 export function ScreenLock({ onUnlock }: { onUnlock: () => void }) {
-  const [digits, setDigits] = useState("");
-  const [error, setError] = useState<string | null>(null);
-  const [submitting, setSubmitting] = useState(false);
-  const [retryAfterSec, setRetryAfterSec] = useState(0);
-  const submittingRef = useRef(false);
-
-  const submit = useCallback(async (pin: string) => {
-    if (submittingRef.current) return;
-    submittingRef.current = true;
-    setSubmitting(true);
-    setError(null);
-    try {
-      const res = await fetch("/api/v1/security/verify-pin", {
-        method: "POST",
-        headers: { "content-type": "application/json" },
-        body: JSON.stringify({ pin }),
-      });
-      if (res.ok) {
-        onUnlock();
-        return;
-      }
-      const body = (await res.json().catch(() => ({}))) as {
-        error?: string;
-        retry_after_ms?: number;
-      };
-      if (res.status === 429 && typeof body.retry_after_ms === "number") {
-        setRetryAfterSec(Math.ceil(body.retry_after_ms / 1000));
-        setError("Too many attempts. Try again later.");
-      } else if (res.status === 401) {
-        setError("Wrong PIN. Try again.");
-      } else if (res.status === 400) {
-        setError("Invalid PIN format.");
-      } else {
-        setError(body.error ?? `Error (${res.status})`);
-      }
-      setDigits("");
-    } catch (err) {
-      setError(err instanceof Error ? err.message : String(err));
-      setDigits("");
-    } finally {
-      submittingRef.current = false;
-      setSubmitting(false);
-    }
-  }, [onUnlock]);
-
-  const append = useCallback((d: string) => {
-    if (submitting || retryAfterSec > 0) return;
-    setError(null);
-    setDigits((cur) => (cur.length >= PIN_LENGTH ? cur : cur + d));
-  }, [submitting, retryAfterSec]);
-
-  useEffect(() => {
-    if (digits.length === PIN_LENGTH && !submittingRef.current) {
-      void submit(digits);
-    }
-  }, [digits, submit]);
-
-  const backspace = useCallback(() => {
-    if (submitting) return;
-    setError(null);
-    setDigits((cur) => cur.slice(0, -1));
-  }, [submitting]);
-
-  useEffect(() => {
-    function onKey(e: KeyboardEvent) {
-      if (/^[0-9]$/.test(e.key)) {
-        e.preventDefault();
-        append(e.key);
-      } else if (e.key === "Backspace") {
-        e.preventDefault();
-        backspace();
-      }
-    }
-    window.addEventListener("keydown", onKey);
-    return () => window.removeEventListener("keydown", onKey);
-  }, [append, backspace]);
-
-  useEffect(() => {
-    if (retryAfterSec <= 0) return;
-    const t = setInterval(() => {
-      setRetryAfterSec((s) => (s > 0 ? s - 1 : 0));
-    }, 1000);
-    return () => clearInterval(t);
-  }, [retryAfterSec]);
-
-  return (
-    <div
-      className="fixed inset-0 z-[1000] flex flex-col items-center justify-center gap-6 bg-surface text-fg"
-      style={{
-        paddingTop: "env(safe-area-inset-top)",
-        paddingBottom: "env(safe-area-inset-bottom)",
-      }}
-    >
-      <Logo className="h-16 w-auto" />
-      <div className="w-full max-w-xs p-6">
-        <h1 className="mb-1 text-center text-lg font-semibold text-fg">
-          Locked
-        </h1>
-        <p className="mb-6 text-center text-xs text-fg-faint">
-          Enter your 6-digit PIN to resume.
-        </p>
-
-        <div className="mb-6 flex justify-center gap-3" aria-label="PIN entry progress">
-          {Array.from({ length: PIN_LENGTH }).map((_, i) => (
-            <span
-              key={i}
-              className={`h-3 w-3 rounded-full transition-colors ${
-                i < digits.length
-                  ? error
-                    ? "bg-red-500"
-                    : "bg-fg"
-                  : "bg-surface-3"
-              }`}
-            />
-          ))}
-        </div>
-
-        <div className="grid grid-cols-3 gap-2">
-          {["1", "2", "3", "4", "5", "6", "7", "8", "9"].map((d) => (
-            <PinKey key={d} digit={d} onPress={() => append(d)} disabled={submitting || retryAfterSec > 0} />
-          ))}
-          <div />
-          <PinKey digit="0" onPress={() => append("0")} disabled={submitting || retryAfterSec > 0} />
-          <PinKey digit="←" onPress={backspace} disabled={submitting || digits.length === 0} ariaLabel="Backspace" />
-        </div>
-
-        <p
-          className={`mt-4 min-h-[1.5rem] text-center text-xs ${
-            error ? "text-red-400" : "text-fg-faint"
-          }`}
-          role="status"
-          aria-live="polite"
-        >
-          {retryAfterSec > 0
-            ? `Try again in ${retryAfterSec}s`
-            : error ?? (submitting ? "Verifying…" : "\u00A0")}
-        </p>
-      </div>
-    </div>
-  );
-}
-
-function PinKey({
-  digit,
-  onPress,
-  disabled,
-  ariaLabel,
-}: {
-  digit: string;
-  onPress: () => void;
-  disabled: boolean;
-  ariaLabel?: string;
-}) {
-  return (
-    <button
-      type="button"
-      onClick={onPress}
-      disabled={disabled}
-      aria-label={ariaLabel ?? digit}
-      className="h-14 rounded-xl bg-surface-3 text-xl font-medium text-fg transition-colors hover:bg-surface-3/70 active:bg-surface-3/50 disabled:cursor-not-allowed disabled:opacity-50"
-    >
-      {digit}
-    </button>
-  );
+  return <PinKeypad mode="unlock" onSuccess={onUnlock} />;
 }

package/components/setup/UnlockScreen.tsx

@@ -1,197 +1,30 @@
 "use client";
 
-import { useCallback, useEffect, useRef, useState } from "react";
-import { Logo } from "@/components/ui/Logo";
-
-// PIN unlock splash for ADR-0063 PIN-wrapped keyfiles. Rendered by the
-// root route when the server detects the master key is locked. Submits
-// the 6-digit PIN to /api/v1/security/unlock; on success, reloads so
-// the server re-renders into the normal authenticated tree.
-
-const PIN_LENGTH = 6;
-
-export function UnlockScreen() {
-  const [digits, setDigits] = useState("");
-  const [error, setError] = useState<string | null>(null);
-  const [submitting, setSubmitting] = useState(false);
-  const [retryAfterSec, setRetryAfterSec] = useState(0);
-  const containerRef = useRef<HTMLDivElement>(null);
-  // Hard guard against parallel submits. setState updaters can run more
-  // than once (dev StrictMode, concurrent rendering), so if `submit`
-  // were called from inside `setDigits` we'd POST twice and the second
-  // request would race the first into `unlockMasterKey()` after state
-  // already flipped to unlocked - the route would 500.
-  const submittingRef = useRef(false);
-
-  const submit = useCallback(async (pin: string) => {
-    if (submittingRef.current) return;
-    submittingRef.current = true;
-    setSubmitting(true);
-    setError(null);
-    try {
-      const res = await fetch("/api/v1/security/unlock", {
-        method: "POST",
-        headers: { "content-type": "application/json" },
-        body: JSON.stringify({ pin }),
-      });
-      if (res.ok) {
-        window.location.reload();
-        return;
-      }
-      const body = (await res.json().catch(() => ({}))) as {
-        error?: string;
-        retry_after_ms?: number;
-      };
-      if (res.status === 409 && body.error === "not-locked") {
-        // Master key was already unlocked (host typed the PIN, or
-        // another tab beat us to it). The goal state is reached —
-        // reload into the app shell.
-        window.location.reload();
-        return;
-      }
-      if (res.status === 429 && typeof body.retry_after_ms === "number") {
-        setRetryAfterSec(Math.ceil(body.retry_after_ms / 1000));
-        setError("Too many attempts. Try again later.");
-      } else if (res.status === 401) {
-        setError("Wrong PIN. Try again.");
-      } else if (res.status === 400) {
-        setError("Invalid PIN format.");
-      } else {
-        setError(body.error ?? `Error (${res.status})`);
-      }
-      setDigits("");
-    } catch (err) {
-      setError(err instanceof Error ? err.message : String(err));
-      setDigits("");
-    } finally {
-      submittingRef.current = false;
-      setSubmitting(false);
-    }
-  }, []);
-
-  const append = useCallback((d: string) => {
-    if (submitting || retryAfterSec > 0) return;
-    setError(null);
-    setDigits((cur) => (cur.length >= PIN_LENGTH ? cur : cur + d));
-  }, [submitting, retryAfterSec]);
-
-  // Auto-submit once the buffer hits 6 digits. Effect runs once per
-  // state transition (not per updater invocation), so we POST exactly
-  // one time even under StrictMode double-render.
-  useEffect(() => {
-    if (digits.length === PIN_LENGTH && !submittingRef.current) {
-      void submit(digits);
-    }
-  }, [digits, submit]);
-
-  const backspace = useCallback(() => {
-    if (submitting) return;
-    setError(null);
-    setDigits((cur) => cur.slice(0, -1));
-  }, [submitting]);
-
-  // Physical keyboard support.
-  useEffect(() => {
-    function onKey(e: KeyboardEvent) {
-      if (/^[0-9]$/.test(e.key)) {
-        e.preventDefault();
-        append(e.key);
-      } else if (e.key === "Backspace") {
-        e.preventDefault();
-        backspace();
-      }
-    }
-    window.addEventListener("keydown", onKey);
-    return () => window.removeEventListener("keydown", onKey);
-  }, [append, backspace]);
-
-  // Tick down the rate-limit countdown.
-  useEffect(() => {
-    if (retryAfterSec <= 0) return;
-    const t = setInterval(() => {
-      setRetryAfterSec((s) => (s > 0 ? s - 1 : 0));
-    }, 1000);
-    return () => clearInterval(t);
-  }, [retryAfterSec]);
-
-  return (
-    <div
-      ref={containerRef}
-      className="fixed inset-0 z-[1000] flex flex-col items-center justify-center gap-6 bg-surface text-fg"
-      style={{
-        paddingTop: "env(safe-area-inset-top)",
-        paddingBottom: "env(safe-area-inset-bottom)",
-      }}
-    >
-      <Logo className="h-16 w-auto" />
-      <div className="w-full max-w-xs p-6">
-        <h1 className="mb-1 text-center text-lg font-semibold text-fg">
-          Unlock Jarela
-        </h1>
-        <p className="mb-6 text-center text-xs text-fg-faint">
-          Enter your 6-digit PIN to decrypt your data.
-        </p>
-
-        <div className="mb-6 flex justify-center gap-3" aria-label="PIN entry progress">
-          {Array.from({ length: PIN_LENGTH }).map((_, i) => (
-            <span
-              key={i}
-              className={`h-3 w-3 rounded-full transition-colors ${
-                i < digits.length
-                  ? error
-                    ? "bg-red-500"
-                    : "bg-fg"
-                  : "bg-surface-3"
-              }`}
-            />
-          ))}
-        </div>
-
-        <div className="grid grid-cols-3 gap-2">
-          {["1", "2", "3", "4", "5", "6", "7", "8", "9"].map((d) => (
-            <PinKey key={d} digit={d} onPress={() => append(d)} disabled={submitting || retryAfterSec > 0} />
-          ))}
-          <div />
-          <PinKey digit="0" onPress={() => append("0")} disabled={submitting || retryAfterSec > 0} />
-          <PinKey digit="←" onPress={backspace} disabled={submitting || digits.length === 0} ariaLabel="Backspace" />
-        </div>
-
-        <p
-          className={`mt-4 min-h-[1.5rem] text-center text-xs ${
-            error ? "text-red-400" : "text-fg-faint"
-          }`}
-          role="status"
-          aria-live="polite"
-        >
-          {retryAfterSec > 0
-            ? `Try again in ${retryAfterSec}s`
-            : error ?? (submitting ? "Unlocking…" : "\u00A0")}
-        </p>
-      </div>
-    </div>
-  );
+import { useRouter } from "next/navigation";
+import { useCallback } from "react";
+import { PinKeypad } from "./PinKeypad";
+
+// Decrypt splash for ADR-0063 PIN-wrapped keyfiles. Two mount sites:
+//
+//   - app/page.tsx — when the server detects the master key is locked
+//     at boot. No `onUnlock` prop, so we fall back to router.refresh()
+//     to re-run the server component without a hard reload; this gives
+//     a far smoother decrypt → AppShell handoff than location.reload().
+//
+//   - AppShell — when the master key gets re-locked mid-session and the
+//     API client dispatches `jarela:master-key-locked`. The shell wants
+//     to hide the overlay and drop the user on the agent picker without
+//     re-running the SSR boundary, so it passes `onUnlock`.
+
+interface Props {
+  onUnlock?: () => void;
 }
 
-function PinKey({
-  digit,
-  onPress,
-  disabled,
-  ariaLabel,
-}: {
-  digit: string;
-  onPress: () => void;
-  disabled: boolean;
-  ariaLabel?: string;
-}) {
-  return (
-    <button
-      type="button"
-      onClick={onPress}
-      disabled={disabled}
-      aria-label={ariaLabel ?? digit}
-      className="h-14 rounded-xl bg-surface-3 text-xl font-medium text-fg transition-colors hover:bg-surface-3/70 active:bg-surface-3/50 disabled:cursor-not-allowed disabled:opacity-50"
-    >
-      {digit}
-    </button>
-  );
+export function UnlockScreen({ onUnlock }: Props = {}) {
+  const router = useRouter();
+  const onSuccess = useCallback(() => {
+    if (onUnlock) onUnlock();
+    else router.refresh();
+  }, [onUnlock, router]);
+  return <PinKeypad mode="decrypt" onSuccess={onSuccess} />;
 }

package/lib/documents/remote/github.ts

@@ -216,10 +216,23 @@ async function runGithubPullsIndexer(source: DocumentSourceRow): Promise<GithubI
       if (Number.isFinite(sinceMs) && Number.isFinite(updatedMs) && updatedMs <= sinceMs) break outer;
 
       try {
-        const [comments, reviews] = await Promise.all([
+        // allSettled so a failed comments fetch doesn't also discard
+        // the reviews (and vice versa); we still index what we have and
+        // count the partial as an error.
+        const [commentsRes, reviewsRes] = await Promise.allSettled([
           listIssueComments(auth, cfg.owner, cfg.repo, pr.number),
           listReviews(auth, cfg.owner, cfg.repo, pr.number),
         ]);
+        const comments = commentsRes.status === "fulfilled" ? commentsRes.value : [];
+        const reviews = reviewsRes.status === "fulfilled" ? reviewsRes.value : [];
+        if (commentsRes.status === "rejected") {
+          stats.errors++;
+          console.warn(`[github-indexer] pr#${pr.number} comments failed:`, commentsRes.reason);
+        }
+        if (reviewsRes.status === "rejected") {
+          stats.errors++;
+          console.warn(`[github-indexer] pr#${pr.number} reviews failed:`, reviewsRes.reason);
+        }
         const text = flattenPull(pr, comments, reviews);
         const res = await upsertRemoteDocument(source.id, {
           path: `github-pull://${cfg.owner}/${cfg.repo}/${pr.number}`,
@@ -229,8 +242,9 @@ async function runGithubPullsIndexer(source: DocumentSourceRow): Promise<GithubI
         });
         applyUpsert(stats, res);
         if (updated && (!highWater || updated > highWater)) highWater = updated;
-      } catch {
+      } catch (err) {
         stats.errors++;
+        console.warn(`[github-indexer] pr#${pr.number} upsert failed:`, err);
       }
     }
     if (pulls.length < PR_PAGE_LIMIT) break;