@chrrxs/robloxstudio-mcp 2.16.0 → 2.16.1

package/studio-plugin/MCPPlugin.rbxmx

@@ -10,6 +10,7 @@ local State = TS.import(script, script, "modules", "State")
 local UI = TS.import(script, script, "modules", "UI")
 local Communication = TS.import(script, script, "modules", "Communication")
 local ClientBroker = TS.import(script, script, "modules", "ClientBroker")
+local ServerUrlSettings = TS.import(script, script, "modules", "ServerUrlSettings")
 local _EvalBridges = TS.import(script, script, "modules", "EvalBridges")
 local cleanupLegacyEditBridges = _EvalBridges.cleanupLegacyEditBridges
 local ensureRuntimeBridgeInstalled = _EvalBridges.ensureRuntimeBridgeInstalled
@@ -28,6 +29,7 @@ RuntimeLogBuffer.install()
 -- edit DM (write the flag) and the play-server DM (read+act on the flag) can
 -- access plugin:SetSetting/GetSetting.
 StopPlayMonitor.init(plugin)
+ServerUrlSettings.init(plugin)
 UI.init(plugin)
 local elements = UI.getElements()
 local ICON_DISCONNECTED = "rbxassetid://75876056391496"
@@ -76,7 +78,7 @@ task.delay(2, function()
 	else
 		local result = ensureRuntimeBridgeInstalled()
 		if not result.installed then
-			warn(`[MCPPlugin] Runtime eval bridge install failed: {result.error}`)
+			warn(`[robloxstudio-mcp] Runtime eval bridge install failed: {result.error}`)
 		end
 	end
 	if role == "edit" or role == "server" then
@@ -84,10 +86,29 @@ task.delay(2, function()
 			local idx = State.getActiveTabIndex()
 			local conn = State.getConnection(idx)
 			if conn and not conn.isActive then
+				if role == "server" then
+					local _condition = ServerUrlSettings.readServerUrl()
+					if _condition == nil then
+						_condition = ClientBroker.DEFAULT_MCP_URL
+					end
+					local inheritedServerUrl = _condition
+					conn.serverUrl = inheritedServerUrl
+					elements.urlInput.Text = inheritedServerUrl
+					local portStr = string.match(conn.serverUrl, ":(%d+)$")
+					if portStr ~= 0 and portStr == portStr and portStr ~= "" and portStr then
+						local _condition_1 = tonumber(portStr)
+						if _condition_1 == nil then
+							_condition_1 = conn.port
+						end
+						conn.port = _condition_1
+					end
+					ClientBroker.setServerUrl(inheritedServerUrl)
+				end
 				-- Defensive default: in invisible play-DM UIs, the input field
 				-- may not be populated by the time we activate.
 				if conn.serverUrl == nil or conn.serverUrl == "" then
-					conn.serverUrl = ClientBroker.MCP_URL
+					conn.serverUrl = ClientBroker.DEFAULT_MCP_URL
+					elements.urlInput.Text = conn.serverUrl
 				end
 				Communication.activatePlugin(idx)
 			end
@@ -96,8 +117,8 @@ task.delay(2, function()
 	if role == "server" then
 		ClientBroker.setupServerBroker()
 		-- The play-server DM is the only one where StudioTestService:EndTest is
-		-- legal, so the stop-play monitor lives here. Reads MCP_STOP_PLAY_SIGNAL
-		-- at 1Hz and calls EndTest when the edit DM sets it.
+		-- legal, so the stop-play monitor lives here. It consumes tokenized
+		-- stop requests from plugin settings and acknowledges EndTest results.
 		StopPlayMonitor.startMonitor()
 	elseif role == "client" then
 		ClientBroker.setupClientBroker()
@@ -128,6 +149,7 @@ local InputHandlers = TS.import(script, script.Parent, "handlers", "InputHandler
 local EvalRuntimeHandlers = TS.import(script, script.Parent, "handlers", "EvalRuntimeHandlers")
 local LuauExec = TS.import(script, script.Parent, "LuauExec")
 local State = TS.import(script, script.Parent, "State")
+local HttpDiagnostics = TS.import(script, script.Parent, "HttpDiagnostics")
 local StudioTestService = game:GetService("StudioTestService")
 -- Mirror of Communication.computeInstanceId() — duplicated here because the
 -- client broker runs in the play-server DM where it can't easily import from
@@ -180,7 +202,8 @@ end
 -- intercept /api/stop-playtest and call StudioTestService:EndTest. That hack
 -- is gone: stop now uses StopPlayMonitor with plugin:SetSetting cross-DM
 -- signaling, which works regardless of MCP server state.)
-local MCP_URL = "http://localhost:58741"
+local DEFAULT_MCP_URL = "http://localhost:58741"
+local mcpUrl = DEFAULT_MCP_URL
 local BROKER_NAME = "__MCPClientBroker"
 local BROKER_OWNER_ATTRIBUTE = "__MCPBrokerOwner"
 -- Endpoints the server-peer broker is allowed to forward to the client peer.
@@ -241,7 +264,7 @@ end
 function postJson(endpoint, body)
 	return pcall(function()
 		return HttpService:RequestAsync({
-			Url = `{MCP_URL}{endpoint}`,
+			Url = `{mcpUrl}{endpoint}`,
 			Method = "POST",
 			Headers = {
 				["Content-Type"] = "application/json",
@@ -250,6 +273,17 @@ function postJson(endpoint, body)
 		})
 	end)
 end
+local function formatPostJsonFailure(endpoint, ok, res)
+	return HttpDiagnostics.formatRequestFailure(`{mcpUrl}{endpoint}`, ok, res)
+end
+local function setServerUrl(serverUrl)
+	if serverUrl ~= nil and serverUrl ~= "" then
+		mcpUrl = serverUrl
+	end
+end
+local function getServerUrl()
+	return mcpUrl
+end
 local function handleExecuteLuau(data)
 	local code = data and (data.code)
 	if type(code) == "string" == false or code == "" then
@@ -396,6 +430,7 @@ local function setupClientBroker()
 	end
 end
 local proxyByPlayer = {}
+local proxyRegisterFailuresByPlayer = {}
 local serverBrokerStarted = false
 local function pollProxy(proxyId, player, rf)
 	while true do
@@ -409,7 +444,7 @@ local function pollProxy(proxyId, player, rf)
 		end
 		local ok, res = pcall(function()
 			return HttpService:RequestAsync({
-				Url = `{MCP_URL}/poll?pluginSessionId={proxyId}`,
+				Url = `{mcpUrl}/poll?pluginSessionId={proxyId}`,
 				Method = "GET",
 				Headers = {
 					["Content-Type"] = "application/json",
@@ -488,7 +523,9 @@ local function registerProxy(player, rf)
 		pluginVariant = State.PLUGIN_VARIANT,
 	})
 	if not ok or not res or not res.Success then
-		warn(`[robloxstudio-mcp] proxy register failed for {player.Name}`)
+		local _player_1 = player
+		proxyRegisterFailuresByPlayer[_player_1] = true
+		warn(`[robloxstudio-mcp] proxy register failed for {player.Name}: {formatPostJsonFailure("/ready", ok, res)}`)
 		return nil
 	end
 	local body = HttpService:JSONDecode(res.Body)
@@ -503,11 +540,17 @@ local function registerProxy(player, rf)
 		role = assigned,
 	}
 	proxyByPlayer[_player_1] = _arg1
+	local _player_2 = player
+	if proxyRegisterFailuresByPlayer[_player_2] ~= nil then
+		local _player_3 = player
+		proxyRegisterFailuresByPlayer[_player_3] = nil
+		print(`[robloxstudio-mcp] proxy registered for {player.Name} as {assigned} via {mcpUrl}`)
+	end
 	task.spawn(pollProxy, proxyId, player, rf)
 end
 -- (Removed: startEditProxyLoop. The play-server DM no longer registers an
 -- "edit-proxy" peer with the MCP server. stop_playtest now uses a cross-DM
--- plugin:SetSetting flag consumed by StopPlayMonitor in the play-server DM,
+-- plugin:SetSetting request consumed by StopPlayMonitor in the play-server DM,
 -- which doesn't depend on MCP server state or peer registration at all.)
 local function setupServerBroker()
 	if serverBrokerStarted then
@@ -537,6 +580,8 @@ local function setupServerBroker()
 		if entry then
 			local _p_1 = p
 			proxyByPlayer[_p_1] = nil
+			local _p_2 = p
+			proxyRegisterFailuresByPlayer[_p_2] = nil
 			postJson("/disconnect", {
 				pluginSessionId = entry.pluginSessionId,
 			})
@@ -552,7 +597,10 @@ local function setupServerBroker()
 	end)
 end
 return {
-	MCP_URL = MCP_URL,
+	MCP_URL = DEFAULT_MCP_URL,
+	DEFAULT_MCP_URL = DEFAULT_MCP_URL,
+	getServerUrl = getServerUrl,
+	setServerUrl = setServerUrl,
 	forkRole = forkRole,
 	setupClientBroker = setupClientBroker,
 	setupServerBroker = setupServerBroker,
@@ -588,6 +636,8 @@ local SerializationHandlers = TS.import(script, script.Parent, "handlers", "Seri
 local MemoryHandlers = TS.import(script, script.Parent, "handlers", "MemoryHandlers")
 local SceneAnalysisHandlers = TS.import(script, script.Parent, "handlers", "SceneAnalysisHandlers")
 local EvalRuntimeHandlers = TS.import(script, script.Parent, "handlers", "EvalRuntimeHandlers")
+local ServerUrlSettings = TS.import(script, script.Parent, "ServerUrlSettings")
+local HttpDiagnostics = TS.import(script, script.Parent, "HttpDiagnostics")
 -- Per-plugin-load random GUID. Used as the /poll URL param so the server
 -- can tell our polls apart from any other plugin's polls. Not user-facing —
 -- MCP tools and the LLM operate on instanceId (the place identifier).
@@ -617,6 +667,7 @@ local assignedRole
 local duplicateInstanceRole = false
 local hasVersionMismatch = false
 local lastVersionMismatchWarningKey
+local readyFailureLogKeys = {}
 -- Cache the published place name from MarketplaceService:GetProductInfo so
 -- /ready can carry a friendly identifier (e.g. "Natural Disasters") distinct
 -- from game.Name (the DataModel name, often "Place1" in edit). We only fetch
@@ -824,31 +875,49 @@ function sendReady(conn)
 				}),
 			})
 		end)
+		local readyUrl = `{conn.serverUrl}/ready`
+		local readyRole = detectRole()
+		local readyLogKey = `{conn.serverUrl}|{instanceId}|{readyRole}`
 		if not readyOk then
+			readyFailureLogKeys[readyLogKey] = true
+			warn(`[robloxstudio-mcp] /ready failed for {instanceId}/{readyRole}: {HttpDiagnostics.formatRequestFailure(readyUrl, readyOk, readyResult)}`)
 			return nil
 		end
-		-- 409 = duplicate_instance_role. Surface in UI and stop polling.
-		if readyResult.StatusCode == 409 then
-			duplicateInstanceRole = true
-			conn.isActive = false
-			local ui = UI.getElements()
-			if State.getActiveTabIndex() == 0 then
-				ui.statusLabel.Text = "Duplicate instance"
-				ui.statusLabel.TextColor3 = Color3.fromRGB(239, 68, 68)
-				ui.detailStatusLabel.Text = "Another Studio is already connected as this place + role"
-				ui.detailStatusLabel.TextColor3 = Color3.fromRGB(239, 68, 68)
-			end
-			warn(`[MCPPlugin] Another Studio is already connected as ({instanceId}, {detectRole()}). Close the other Studio window or this one.`)
+		if not readyResult.Success then
+			local reason = HttpDiagnostics.formatRequestFailure(readyUrl, true, readyResult)
+			readyFailureLogKeys[readyLogKey] = true
+			-- 409 = duplicate_instance_role. Surface in UI and stop polling.
+			if readyResult.StatusCode == 409 then
+				duplicateInstanceRole = true
+				conn.isActive = false
+				local ui = UI.getElements()
+				if State.getActiveTabIndex() == 0 then
+					ui.statusLabel.Text = "Duplicate instance"
+					ui.statusLabel.TextColor3 = Color3.fromRGB(239, 68, 68)
+					ui.detailStatusLabel.Text = reason
+					ui.detailStatusLabel.TextColor3 = Color3.fromRGB(239, 68, 68)
+				end
+				warn(`[robloxstudio-mcp] /ready rejected for {instanceId}/{readyRole}: {reason}`)
+				return nil
+			end
+			warn(`[robloxstudio-mcp] /ready rejected for {instanceId}/{readyRole}: {reason}`)
 			return nil
 		end
-		if readyResult.Success then
-			local parseOk, readyData = pcall(function()
-				return HttpService:JSONDecode(readyResult.Body)
-			end)
-			local _value = parseOk and readyData.assignedRole
-			if _value ~= "" and _value then
-				assignedRole = readyData.assignedRole
-			end
+		local parseOk, readyData = pcall(function()
+			return HttpService:JSONDecode(readyResult.Body)
+		end)
+		local _value = parseOk and readyData.assignedRole
+		if _value ~= "" and _value then
+			assignedRole = readyData.assignedRole
+		end
+		local _condition = assignedRole
+		if _condition == nil then
+			_condition = detectRole()
+		end
+		local connectedRole = _condition
+		if readyFailureLogKeys[readyLogKey] ~= nil then
+			readyFailureLogKeys[readyLogKey] = nil
+			print(`[robloxstudio-mcp] /ready connected for {instanceId}/{connectedRole} via {conn.serverUrl}`)
 		end
 	end)
 end
@@ -894,7 +963,7 @@ local function pollForRequests(connIndex)
 			local warningKey = `{State.CURRENT_VERSION}:{serverVersion}`
 			if lastVersionMismatchWarningKey ~= warningKey then
 				lastVersionMismatchWarningKey = warningKey
-				warn(`[MCPPlugin] Version mismatch: Studio plugin v{State.CURRENT_VERSION} / MCP v{serverVersion}. Run npx -y @chrrxs/robloxstudio-mcp@latest --auto-install-plugin and restart Studio.`)
+				warn(`[robloxstudio-mcp] Version mismatch: Studio plugin v{State.CURRENT_VERSION} / MCP v{serverVersion}. Run npx -y @chrrxs/robloxstudio-mcp@latest --auto-install-plugin and restart Studio.`)
 			end
 			UI.showBanner("version-mismatch", `Plugin v{State.CURRENT_VERSION} / MCP v{serverVersion} mismatch`)
 		elseif hasVersionMismatch then
@@ -1062,6 +1131,7 @@ local function activatePlugin(connIndex)
 		UI.updateTabLabel(idx)
 		UI.updateUIState()
 	end
+	ServerUrlSettings.rememberServerUrl(conn.serverUrl)
 	UI.updateTabDot(idx)
 	if not conn.heartbeatConnection then
 		conn.heartbeatConnection = RunService.Heartbeat:Connect(function()
@@ -1292,9 +1362,9 @@ local function computeBridgeStamp()
 	for i = 1, #combined do
 		h = (h * 33 + (string.byte(combined, i))) % 2147483647
 	end
-	-- "2.16.0" is replaced with the package version at package time
+	-- "2.16.1" is replaced with the package version at package time
 	-- (scripts/build-plugin.mjs injectVersion), so a release bump also restamps.
-	return `{tostring(h)}-2.16.0`
+	return `{tostring(h)}-2.16.1`
 end
 local BRIDGE_STAMP = computeBridgeStamp()
 local function setSource(scriptInst, source)
@@ -6674,7 +6744,7 @@ local function startPlaytest(requestData)
 		return injectStopListener()
 	end)
 	if not injected then
-		warn(`[MCP] Failed to inject stop listener: {injErr}`)
+		warn(`[robloxstudio-mcp] Failed to inject stop listener: {injErr}`)
 	end
 	task.spawn(function()
 		local ok, result = pcall(function()
@@ -6702,17 +6772,17 @@ local function startPlaytest(requestData)
 	return response
 end
 local function stopPlaytest(_requestData)
-	-- Signal the play-server DM's StopPlayMonitor via plugin:SetSetting (a
-	-- cross-DM persistent store). The monitor polls at 1Hz, sees the flag,
-	-- calls StudioTestService:EndTest, then resets the flag. We wait up to
-	-- 2.5s for the reset to confirm a play DM actually consumed the request,
-	-- which avoids returning success when nothing is running.
-	if not StopPlayMonitor.requestStop() then
+	-- Signal the play-server DM's StopPlayMonitor via plugin:SetSetting.
+	-- The monitor acknowledges with the matching request id only after its
+	-- StudioTestService:EndTest call returns from pcall.
+	local stopRequest = StopPlayMonitor.requestStop()
+	if not stopRequest.ok or stopRequest.requestId == nil then
 		return {
 			error = "Plugin not ready. Try again in a moment.",
 		}
 	end
-	if not StopPlayMonitor.waitForConsumption() then
+	local consumption = StopPlayMonitor.waitForConsumption(stopRequest.requestId)
+	if not consumption.ok then
 		-- Two distinct failure modes collapse here, distinguished by whether
 		-- THIS edit DM has a playtest tracked:
 		--
@@ -6724,19 +6794,28 @@ local function stopPlaytest(_requestData)
 		--   from the caller's perspective — playtest may actually have ended).
 		--   Tell the caller it's a timing issue and they can retry.
 		--
-		-- Either way clean up the pending flag so a future playtest's monitor
+		-- Either way clean up the pending request so a future playtest's monitor
 		-- doesn't fire EndTest on startup against a stale signal.
-		StopPlayMonitor.clearPending()
+		StopPlayMonitor.clearPending(stopRequest.requestId)
 		if testRunning then
 			return {
-				error = "Playtest stop signal sent but consumption confirmation timed out. " .. "The playtest may have ended anyway; check get_connected_instances.",
+				error = "Playtest stop signal failed or was not acknowledged. " .. "The playtest may have ended anyway; check get_connected_instances.",
+				detail = consumption.error,
+			}
+		end
+		if consumption.consumed then
+			return {
+				error = "Playtest stop request reached the play server, but EndTest failed.",
+				detail = consumption.error,
 			}
 		end
 		return {
 			error = "No active playtest to stop.",
+			detail = consumption.error,
 		}
 	end
-	-- Flag was consumed (EndTest called). ExecutePlayModeAsync in our
+	StopPlayMonitor.clearPending(stopRequest.requestId)
+	-- Request was consumed (EndTest called). ExecutePlayModeAsync in our
 	-- startPlaytest task.spawn is still unwinding though — testRunning stays
 	-- true until that yield completes and the post-block runs. Wait so
 	-- back-to-back stop -> start sequences don't race against the prior
@@ -7040,6 +7119,87 @@ return {
         </Item>
       </Item>
       <Item class="ModuleScript" referent="21">
+        <Properties>
+          <string name="Name">HttpDiagnostics</string>
+          <string name="Source"><![CDATA[-- Compiled with roblox-ts v3.0.0
+local TS = require(script.Parent.Parent.include.RuntimeLib)
+local HttpService = TS.import(script, script.Parent.Parent, "node_modules", "@rbxts", "services").HttpService
+local function encodeForLog(value)
+	local ok, encoded = pcall(function()
+		return HttpService:JSONEncode(value)
+	end)
+	return if ok then encoded else tostring(value)
+end
+local function formatBody(body)
+	if body == "" then
+		return ""
+	end
+	local ok, decoded = pcall(function()
+		return HttpService:JSONDecode(body)
+	end)
+	if ok and type(decoded) == "table" then
+		local data = decoded
+		local parts = {}
+		local _error = data.error
+		local _condition = type(_error) == "string"
+		if _condition then
+			_condition = data.error ~= ""
+		end
+		if _condition then
+			local _arg0 = `error={data.error}`
+			table.insert(parts, _arg0)
+		end
+		local _message = data.message
+		local _condition_1 = type(_message) == "string"
+		if _condition_1 then
+			_condition_1 = data.message ~= ""
+		end
+		if _condition_1 then
+			local _arg0 = `message={data.message}`
+			table.insert(parts, _arg0)
+		end
+		if data.missingFields ~= nil then
+			local _arg0 = `missingFields={encodeForLog(data.missingFields)}`
+			table.insert(parts, _arg0)
+		end
+		if data.request ~= nil then
+			local _arg0 = `request={encodeForLog(data.request)}`
+			table.insert(parts, _arg0)
+		end
+		if data.existing ~= nil then
+			local _arg0 = `existing={encodeForLog(data.existing)}`
+			table.insert(parts, _arg0)
+		end
+		if data.details ~= nil then
+			local _arg0 = `details={encodeForLog(data.details)}`
+			table.insert(parts, _arg0)
+		end
+		if #parts > 0 then
+			return table.concat(parts, " ")
+		end
+	end
+	return `body={body}`
+end
+local function formatRequestFailure(url, ok, res)
+	if not ok then
+		return `RequestAsync threw for {url}: {tostring(res)}`
+	end
+	if res == nil then
+		return `RequestAsync returned no response for {url}`
+	end
+	local response = res
+	local statusMessage = if response.StatusMessage ~= "" then ` {response.StatusMessage}` else ""
+	local body = formatBody(response.Body)
+	local suffix = if body ~= "" then `: {body}` else ""
+	return `HTTP {response.StatusCode}{statusMessage} from {url}{suffix}`
+end
+return {
+	formatRequestFailure = formatRequestFailure,
+}
+]]></string>
+        </Properties>
+      </Item>
+      <Item class="ModuleScript" referent="22">
         <Properties>
           <string name="Name">LuauExec</string>
           <string name="Source"><![CDATA[-- Compiled with roblox-ts v3.0.0
@@ -7473,7 +7633,7 @@ return {
 ]]></string>
         </Properties>
       </Item>
-      <Item class="ModuleScript" referent="22">
+      <Item class="ModuleScript" referent="23">
         <Properties>
           <string name="Name">Recording</string>
           <string name="Source"><![CDATA[-- Compiled with roblox-ts v3.0.0
@@ -7503,7 +7663,7 @@ return {
 ]]></string>
         </Properties>
       </Item>
-      <Item class="ModuleScript" referent="23">
+      <Item class="ModuleScript" referent="24">
         <Properties>
           <string name="Name">RenderMonitor</string>
           <string name="Source"><![CDATA[-- Compiled with roblox-ts v3.0.0
@@ -7571,7 +7731,7 @@ return {
 ]]></string>
         </Properties>
       </Item>
-      <Item class="ModuleScript" referent="24">
+      <Item class="ModuleScript" referent="25">
         <Properties>
           <string name="Name">RuntimeLogBuffer</string>
           <string name="Source"><![CDATA[-- Compiled with roblox-ts v3.0.0
@@ -7752,11 +7912,71 @@ return {
 ]]></string>
         </Properties>
       </Item>
-      <Item class="ModuleScript" referent="25">
+      <Item class="ModuleScript" referent="26">
+        <Properties>
+          <string name="Name">ServerUrlSettings</string>
+          <string name="Source"><![CDATA[-- Compiled with roblox-ts v3.0.0
+local TS = require(script.Parent.Parent.include.RuntimeLib)
+local _services = TS.import(script, script.Parent.Parent, "node_modules", "@rbxts", "services")
+local HttpService = _services.HttpService
+local ServerStorage = _services.ServerStorage
+local SETTING_KEY_PREFIX = "MCP_SERVER_URL_"
+local pluginRef
+local function init(p)
+	pluginRef = p
+end
+local function computeInstanceId()
+	if game.PlaceId ~= 0 then
+		return `place:{tostring(game.PlaceId)}`
+	end
+	local existing = ServerStorage:GetAttribute("__MCPPlaceId")
+	if type(existing) == "string" and existing ~= "" then
+		return `anon:{existing}`
+	end
+	local fresh = HttpService:GenerateGUID(false)
+	pcall(function()
+		return ServerStorage:SetAttribute("__MCPPlaceId", fresh)
+	end)
+	return `anon:{fresh}`
+end
+local function settingKey(instanceId)
+	return SETTING_KEY_PREFIX .. instanceId
+end
+local function rememberServerUrl(serverUrl)
+	if not pluginRef or serverUrl == "" then
+		return nil
+	end
+	local key = settingKey(computeInstanceId())
+	pcall(function()
+		return pluginRef:SetSetting(key, serverUrl)
+	end)
+end
+local function readServerUrl()
+	if not pluginRef then
+		return nil
+	end
+	local key = settingKey(computeInstanceId())
+	local ok, value = pcall(function()
+		return pluginRef:GetSetting(key)
+	end)
+	if ok and type(value) == "string" and value ~= "" then
+		return value
+	end
+	return nil
+end
+return {
+	init = init,
+	rememberServerUrl = rememberServerUrl,
+	readServerUrl = readServerUrl,
+}
+]]></string>
+        </Properties>
+      </Item>
+      <Item class="ModuleScript" referent="27">
         <Properties>
           <string name="Name">State</string>
           <string name="Source"><![CDATA[-- Compiled with roblox-ts v3.0.0
-local CURRENT_VERSION = "2.16.0"
+local CURRENT_VERSION = "2.16.1"
 local PLUGIN_VARIANT = "main"
 local MAX_CONNECTIONS = 5
 local BASE_PORT = 58741
@@ -7850,7 +8070,7 @@ return {
 ]]></string>
         </Properties>
       </Item>
-      <Item class="ModuleScript" referent="26">
+      <Item class="ModuleScript" referent="28">
         <Properties>
           <string name="Name">StopPlayMonitor</string>
           <string name="Source"><![CDATA[-- Compiled with roblox-ts v3.0.0
@@ -7862,16 +8082,16 @@ local TS = require(script.Parent.Parent.include.RuntimeLib)
 -- `plugin:SetSetting` / `plugin:GetSetting` is a per-plugin persistent store
 -- shared across every DataModel the plugin runs in (edit DMs, play-server
 -- DMs, play-client DMs). For each connected place we use a dedicated key
--- "MCP_STOP_PLAY_<instanceId>" as a single-bit mailbox:
+-- "MCP_STOP_PLAY_<instanceId>" as a tiny request/result mailbox:
 --
---   * The edit DM's stopPlaytest handler writes `true` into its own key
+--   * The edit DM's handler writes a tokenized stop request into its own key
 --     (computed from its placeId / ServerStorage anon UUID).
 --   * Each play-server DM's monitor loop polls the key matching its own
---     instanceId at 0.1Hz; on `true` it clears the key and calls
---     StudioTestService:EndTest. Play-server DMs for other places never
---     touch this key.
---   * The edit DM waits up to ~8s for its key to be cleared, confirming a
---     matching play-server actually consumed the request.
+--     instanceId at 1Hz. On a fresh token, it calls StudioTestService:EndTest
+--     and writes a matching result token. Play-server DMs for other places
+--     never touch this key.
+--   * The edit DM waits up to ~8s for its result token, confirming a matching
+--     play-server actually consumed the request.
 --
 -- Earlier versions used a single shared boolean flag, which let any
 -- play-server DM in the same Studio process consume any place's stop
@@ -7879,20 +8099,24 @@ local TS = require(script.Parent.Parent.include.RuntimeLib)
 -- below is the fix.
 local _services = TS.import(script, script.Parent.Parent, "node_modules", "@rbxts", "services")
 local HttpService = _services.HttpService
+local RunService = _services.RunService
 local ServerStorage = _services.ServerStorage
 local StudioTestService = game:GetService("StudioTestService")
 local SETTING_KEY_PREFIX = "MCP_STOP_PLAY_"
--- Monitor checks the key at this cadence. 0.1s keeps worst-case detection
--- lag tight so the consumption-confirmation window doesn't have to absorb
--- polling jitter on top of EndTest's teardown time.
-local POLL_INTERVAL_SEC = 0.1
+-- Keep this conservative. plugin:GetSetting is backed by Studio's plugin
+-- settings store, and this monitor runs during every play session, including
+-- manually-started Play. The official reference implementation polls at 1s.
+local POLL_INTERVAL_SEC = 1
 -- Total time we wait for the matching play-server DM to consume the
 -- signal. Must cover: monitor detection (<= POLL_INTERVAL_SEC) +
 -- StudioTestService:EndTest teardown (several seconds on heavier places).
--- 8s is comfortable; the tighter poll above keeps real cases well under.
+-- 8s is intentionally shorter than the MCP request timeout but long enough
+-- for the 1s monitor cadence plus ordinary Studio teardown latency.
 local WAIT_FOR_CONSUMPTION_TIMEOUT_SEC = 8.0
 local WAIT_POLL_SEC = 0.1
+local REQUEST_TTL_SEC = 12.0
 local pluginRef
+local endTestIssued = false
 local function init(p)
 	pluginRef = p
 end
@@ -7918,32 +8142,125 @@ end
 local function settingKey(instanceId)
 	return SETTING_KEY_PREFIX .. instanceId
 end
+local function readSetting(key)
+	if not pluginRef then
+		return nil
+	end
+	local ok, value = pcall(function()
+		return pluginRef:GetSetting(key)
+	end)
+	return if ok then value else nil
+end
+local function writeSetting(key, value)
+	if not pluginRef then
+		return false
+	end
+	local ok = pcall(function()
+		return pluginRef:SetSetting(key, value)
+	end)
+	return ok
+end
+local function decodePayload(value)
+	local decoded = value
+	local _value = value
+	if type(_value) == "string" then
+		local ok, result = pcall(function()
+			return HttpService:JSONDecode(value)
+		end)
+		if not ok then
+			return nil
+		end
+		decoded = result
+	end
+	local _decoded = decoded
+	if not (type(_decoded) == "table") then
+		return nil
+	end
+	local payload = decoded
+	local _kind = payload.kind
+	local _condition = not (type(_kind) == "string")
+	if not _condition then
+		local _id = payload.id
+		_condition = not (type(_id) == "string")
+	end
+	if _condition then
+		return nil
+	end
+	return payload
+end
+local function writePayload(key, payload)
+	local encodedOk, encoded = pcall(function()
+		return HttpService:JSONEncode(payload)
+	end)
+	if not encodedOk or not (type(encoded) == "string") then
+		return false
+	end
+	return writeSetting(key, encoded)
+end
+local function writeResult(key, request, ok, errText)
+	writePayload(key, {
+		kind = "result",
+		id = request.id,
+		requestedAt = request.requestedAt,
+		consumedAt = tick(),
+		ok = ok,
+		error = errText,
+	})
+end
+local function handleStopRequest(key, request)
+	local _condition = request.kind ~= "request"
+	if not _condition then
+		local _id = request.id
+		_condition = not (type(_id) == "string")
+	end
+	if _condition then
+		return nil
+	end
+	local _requestedAt = request.requestedAt
+	if not (type(_requestedAt) == "number") then
+		writeSetting(key, false)
+		return nil
+	end
+	local age = tick() - request.requestedAt
+	if age < -5 or age > REQUEST_TTL_SEC then
+		writeSetting(key, false)
+		return nil
+	end
+	if endTestIssued then
+		writeResult(key, request, true)
+		return nil
+	end
+	if not RunService:IsRunning() or not RunService:IsServer() then
+		writeResult(key, request, false, "StopPlayMonitor is not running in the server DataModel.")
+		return nil
+	end
+	endTestIssued = true
+	local endOk, endErr = pcall(function()
+		return StudioTestService:EndTest("stopped_by_mcp")
+	end)
+	writeResult(key, request, endOk, if endOk then nil else tostring(endErr))
+	if not endOk then
+		endTestIssued = false
+	end
+end
 local function startMonitor()
 	if not pluginRef then
-		warn("[MCP] StopPlayMonitor.startMonitor called before init; skipping")
+		warn("[robloxstudio-mcp] StopPlayMonitor.startMonitor called before init; skipping")
 		return nil
 	end
 	local myKey = settingKey(computeInstanceId())
-	-- Clear any stale value left from a prior session. If a real stop
-	-- request is in-flight when this runs, the requesting edit DM will
-	-- write again within its consumption-confirmation window.
-	pcall(function()
-		return pluginRef:SetSetting(myKey, false)
-	end)
 	task.spawn(function()
 		while true do
-			local okGet, val = pcall(function()
-				return pluginRef:GetSetting(myKey)
-			end)
-			if okGet and val == true then
-				-- Consume the flag first so requestStop's
-				-- waitForConsumption returns success, then end the test.
-				pcall(function()
-					return pluginRef:SetSetting(myKey, false)
-				end)
-				pcall(function()
-					return StudioTestService:EndTest("stopped_by_mcp")
-				end)
+			local value = readSetting(myKey)
+			if value == true then
+				-- Legacy boolean requests are ambiguous and may be stale from
+				-- a prior crashed session. New stop requests use token payloads.
+				writeSetting(myKey, false)
+			else
+				local payload = decodePayload(value)
+				if payload then
+					handleStopRequest(myKey, payload)
+				end
 			end
 			task.wait(POLL_INTERVAL_SEC)
 		end
@@ -7951,39 +8268,61 @@ local function startMonitor()
 end
 local function requestStop()
 	if not pluginRef then
-		return false
+		return {
+			ok = false,
+		}
 	end
 	local myKey = settingKey(computeInstanceId())
-	local ok = pcall(function()
-		return pluginRef:SetSetting(myKey, true)
-	end)
-	return ok
+	local requestId = HttpService:GenerateGUID(false)
+	local ok = writePayload(myKey, {
+		kind = "request",
+		id = requestId,
+		requestedAt = tick(),
+	})
+	return {
+		ok = ok,
+		requestId = if ok then requestId else nil,
+	}
 end
-local function waitForConsumption()
+local function waitForConsumption(requestId)
 	if not pluginRef then
-		return false
+		return {
+			ok = false,
+			consumed = false,
+			error = "Plugin reference is not initialized.",
+		}
 	end
 	local myKey = settingKey(computeInstanceId())
 	local start = tick()
 	while tick() - start < WAIT_FOR_CONSUMPTION_TIMEOUT_SEC do
-		local okGet, val = pcall(function()
-			return pluginRef:GetSetting(myKey)
-		end)
-		if okGet and val ~= true then
-			return true
+		local payload = decodePayload(readSetting(myKey))
+		if payload and payload.kind == "result" and payload.id == requestId then
+			return {
+				ok = payload.ok == true,
+				consumed = true,
+				error = payload.error,
+			}
 		end
 		task.wait(WAIT_POLL_SEC)
 	end
-	return false
+	return {
+		ok = false,
+		consumed = false,
+		error = "Timed out waiting for the play-server DataModel to acknowledge stop_playtest.",
+	}
 end
-local function clearPending()
+local function clearPending(requestId)
 	if not pluginRef then
 		return nil
 	end
 	local myKey = settingKey(computeInstanceId())
-	pcall(function()
-		return pluginRef:SetSetting(myKey, false)
-	end)
+	if requestId ~= nil then
+		local payload = decodePayload(readSetting(myKey))
+		if payload and payload.id ~= requestId then
+			return nil
+		end
+	end
+	writeSetting(myKey, false)
 end
 return {
 	init = init,
@@ -7995,7 +8334,7 @@ return {
 ]]></string>
         </Properties>
       </Item>
-      <Item class="ModuleScript" referent="27">
+      <Item class="ModuleScript" referent="29">
         <Properties>
           <string name="Name">UI</string>
           <string name="Source"><![CDATA[-- Compiled with roblox-ts v3.0.0
@@ -8766,7 +9105,7 @@ return {
 ]]></string>
         </Properties>
       </Item>
-      <Item class="ModuleScript" referent="28">
+      <Item class="ModuleScript" referent="30">
         <Properties>
           <string name="Name">Utils</string>
           <string name="Source"><![CDATA[-- Compiled with roblox-ts v3.0.0
@@ -9296,11 +9635,11 @@ return {
         </Properties>
       </Item>
     </Item>
-    <Item class="Folder" referent="32">
+    <Item class="Folder" referent="34">
       <Properties>
         <string name="Name">include</string>
       </Properties>
-      <Item class="ModuleScript" referent="29">
+      <Item class="ModuleScript" referent="31">
         <Properties>
           <string name="Name">Promise</string>
           <string name="Source"><![CDATA[--[[
@@ -11374,7 +11713,7 @@ return Promise
 ]]></string>
         </Properties>
       </Item>
-      <Item class="ModuleScript" referent="30">
+      <Item class="ModuleScript" referent="32">
         <Properties>
           <string name="Name">RuntimeLib</string>
           <string name="Source"><![CDATA[local Promise = require(script.Parent.Promise)
@@ -11641,15 +11980,15 @@ return TS
         </Properties>
       </Item>
     </Item>
-    <Item class="Folder" referent="33">
+    <Item class="Folder" referent="35">
       <Properties>
         <string name="Name">node_modules</string>
       </Properties>
-      <Item class="Folder" referent="34">
+      <Item class="Folder" referent="36">
         <Properties>
           <string name="Name">@rbxts</string>
         </Properties>
-      <Item class="ModuleScript" referent="31">
+      <Item class="ModuleScript" referent="33">
         <Properties>
           <string name="Name">services</string>
           <string name="Source"><![CDATA[return setmetatable({}, {