@chrrxs/robloxstudio-mcp-inspector 2.8.0 → 2.8.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@chrrxs/robloxstudio-mcp-inspector",
-  "version": "2.8.0",
+  "version": "2.8.1",
   "description": "Read-only MCP Server for Roblox Studio (fork of boshyxd/robloxstudio-mcp-inspector with per-peer execute_luau fixes baked in)",
   "main": "dist/index.js",
   "type": "module",

package/studio-plugin/MCPInspectorPlugin.rbxmx

@@ -154,7 +154,6 @@ local function setupClientBroker()
 		}
 		return _arg0
 	end
-	print("[MCPFork] client broker ready")
 end
 local proxyByPlayer = {}
 local function pollProxy(proxyId, player, rf)
@@ -238,7 +237,6 @@ local function registerProxy(player, rf)
 		role = assigned,
 	}
 	proxyByPlayer[_player_1] = _arg1
-	print(`[MCPFork] proxy {assigned} -> {player.Name}`)
 	task.spawn(pollProxy, proxyId, player, rf)
 end
 local function startEditProxyLoop()
@@ -246,13 +244,12 @@ local function startEditProxyLoop()
 		local proxyId = HttpService:GenerateGUID(false)
 		local ok, res = postJson("/ready", {
 			instanceId = proxyId,
-			role = "edit",
+			role = "edit-proxy",
 		})
 		if not ok or not res or not res.Success then
 			warn("[MCPFork] edit-proxy register failed")
 			return nil
 		end
-		print("[MCPFork] edit-proxy ready (stop-playtest interceptor)")
 		while true do
 			local okPoll, pollRes = pcall(function()
 				return HttpService:RequestAsync({
@@ -323,7 +320,6 @@ local function setupServerBroker()
 		table.clear(proxyByPlayer)
 	end)
 	startEditProxyLoop()
-	print("[MCPFork] server broker ready")
 end
 return {
 	MCP_URL = MCP_URL,
@@ -5208,31 +5204,16 @@ local function startPlaytest(requestData)
 	}
 end
 local function stopPlaytest(_requestData)
-	-- Stop requests are normally intercepted by the server-peer edit-proxy in
-	-- modules/ClientBroker - that proxy runs inside the play server DM, the
-	-- only DM where StudioTestService:EndTest is legal. If we reach this
-	-- handler the broker either hasn't started yet or there's no active
-	-- playtest. Try EndTest directly as a fallback (works for manually
-	-- started playtests where the server-peer plugin happens to be polling).
-	local endTest = StudioTestService
-	local endOk, endErr = pcall(function()
-		endTest:EndTest("stopped_by_mcp")
-	end)
-	if endOk then
-		local _object = {
-			success = true,
-		}
-		local _left = "output"
-		local _array = {}
-		local _length = #_array
-		table.move(outputBuffer, 1, #outputBuffer, _length + 1, _array)
-		_object[_left] = _array
-		_object.outputCount = #outputBuffer
-		_object.message = "Playtest stopped via StudioTestService."
-		return _object
-	end
+	-- Server-side routing (tools/index.ts:stopPlaytest) sends /api/stop-playtest
+	-- to the role="edit-proxy" instance whenever one is registered. This handler
+	-- is only reached when there's no edit-proxy - i.e. no active playtest, or
+	-- the play DMs haven't completed plugin auto-activation yet. Calling
+	-- StudioTestService:EndTest from the edit DM is illegal ("can only be
+	-- called from the server DataModel of a running Studio play session"), so
+	-- don't try - return a clean "no active playtest" response instead.
 	return {
-		error = `stopPlaytest fell through to edit DM (broker should have handled it). EndTest reported: {tostring(endErr)}`,
+		error = "No active playtest to stop (edit-proxy not registered).",
+		hint = "If a playtest is running, the play-server DM may not have completed plugin auto-activation yet. " .. "Wait a moment and retry, or call execute_luau target=server with StudioTestService:EndTest as a manual fallback.",
 	}
 end
 local function getPlaytestOutput(_requestData)
@@ -5360,7 +5341,7 @@ return {
         <Properties>
           <string name="Name">State</string>
           <string name="Source"><![CDATA[-- Compiled with roblox-ts v3.0.0
-local CURRENT_VERSION = "2.8.0"
+local CURRENT_VERSION = "2.8.1"
 local MAX_CONNECTIONS = 5
 local BASE_PORT = 58741
 local activeTabIndex = 0
@@ -5674,7 +5655,7 @@ local function updateTabLabel(connIndex)
 end
 local function init(pluginRef)
 	local CURRENT_VERSION = State.CURRENT_VERSION
-	local screenGui = pluginRef:CreateDockWidgetPluginGuiAsync("MCPServerInterface", DockWidgetPluginGuiInfo.new(Enum.InitialDockState.Float, false, false, 300, 260, 260, 200))
+	local screenGui = pluginRef:CreateDockWidgetPluginGuiAsync("MCPServerInterface", DockWidgetPluginGuiInfo.new(Enum.InitialDockState.Float, false, true, 300, 260, 260, 200))
 	screenGui.Title = `MCP Server v{CURRENT_VERSION}`
 	local mainFrame = Instance.new("Frame")
 	mainFrame.Size = UDim2.new(1, 0, 1, 0)

package/studio-plugin/MCPPlugin.rbxmx

@@ -154,7 +154,6 @@ local function setupClientBroker()
 		}
 		return _arg0
 	end
-	print("[MCPFork] client broker ready")
 end
 local proxyByPlayer = {}
 local function pollProxy(proxyId, player, rf)
@@ -238,7 +237,6 @@ local function registerProxy(player, rf)
 		role = assigned,
 	}
 	proxyByPlayer[_player_1] = _arg1
-	print(`[MCPFork] proxy {assigned} -> {player.Name}`)
 	task.spawn(pollProxy, proxyId, player, rf)
 end
 local function startEditProxyLoop()
@@ -246,13 +244,12 @@ local function startEditProxyLoop()
 		local proxyId = HttpService:GenerateGUID(false)
 		local ok, res = postJson("/ready", {
 			instanceId = proxyId,
-			role = "edit",
+			role = "edit-proxy",
 		})
 		if not ok or not res or not res.Success then
 			warn("[MCPFork] edit-proxy register failed")
 			return nil
 		end
-		print("[MCPFork] edit-proxy ready (stop-playtest interceptor)")
 		while true do
 			local okPoll, pollRes = pcall(function()
 				return HttpService:RequestAsync({
@@ -323,7 +320,6 @@ local function setupServerBroker()
 		table.clear(proxyByPlayer)
 	end)
 	startEditProxyLoop()
-	print("[MCPFork] server broker ready")
 end
 return {
 	MCP_URL = MCP_URL,
@@ -5208,31 +5204,16 @@ local function startPlaytest(requestData)
 	}
 end
 local function stopPlaytest(_requestData)
-	-- Stop requests are normally intercepted by the server-peer edit-proxy in
-	-- modules/ClientBroker - that proxy runs inside the play server DM, the
-	-- only DM where StudioTestService:EndTest is legal. If we reach this
-	-- handler the broker either hasn't started yet or there's no active
-	-- playtest. Try EndTest directly as a fallback (works for manually
-	-- started playtests where the server-peer plugin happens to be polling).
-	local endTest = StudioTestService
-	local endOk, endErr = pcall(function()
-		endTest:EndTest("stopped_by_mcp")
-	end)
-	if endOk then
-		local _object = {
-			success = true,
-		}
-		local _left = "output"
-		local _array = {}
-		local _length = #_array
-		table.move(outputBuffer, 1, #outputBuffer, _length + 1, _array)
-		_object[_left] = _array
-		_object.outputCount = #outputBuffer
-		_object.message = "Playtest stopped via StudioTestService."
-		return _object
-	end
+	-- Server-side routing (tools/index.ts:stopPlaytest) sends /api/stop-playtest
+	-- to the role="edit-proxy" instance whenever one is registered. This handler
+	-- is only reached when there's no edit-proxy - i.e. no active playtest, or
+	-- the play DMs haven't completed plugin auto-activation yet. Calling
+	-- StudioTestService:EndTest from the edit DM is illegal ("can only be
+	-- called from the server DataModel of a running Studio play session"), so
+	-- don't try - return a clean "no active playtest" response instead.
 	return {
-		error = `stopPlaytest fell through to edit DM (broker should have handled it). EndTest reported: {tostring(endErr)}`,
+		error = "No active playtest to stop (edit-proxy not registered).",
+		hint = "If a playtest is running, the play-server DM may not have completed plugin auto-activation yet. " .. "Wait a moment and retry, or call execute_luau target=server with StudioTestService:EndTest as a manual fallback.",
 	}
 end
 local function getPlaytestOutput(_requestData)
@@ -5360,7 +5341,7 @@ return {
         <Properties>
           <string name="Name">State</string>
           <string name="Source"><![CDATA[-- Compiled with roblox-ts v3.0.0
-local CURRENT_VERSION = "2.8.0"
+local CURRENT_VERSION = "2.8.1"
 local MAX_CONNECTIONS = 5
 local BASE_PORT = 58741
 local activeTabIndex = 0
@@ -5674,7 +5655,7 @@ local function updateTabLabel(connIndex)
 end
 local function init(pluginRef)
 	local CURRENT_VERSION = State.CURRENT_VERSION
-	local screenGui = pluginRef:CreateDockWidgetPluginGuiAsync("MCPServerInterface", DockWidgetPluginGuiInfo.new(Enum.InitialDockState.Float, false, false, 300, 260, 260, 200))
+	local screenGui = pluginRef:CreateDockWidgetPluginGuiAsync("MCPServerInterface", DockWidgetPluginGuiInfo.new(Enum.InitialDockState.Float, false, true, 300, 260, 260, 200))
 	screenGui.Title = `MCP Server v{CURRENT_VERSION}`
 	local mainFrame = Instance.new("Frame")
 	mainFrame.Size = UDim2.new(1, 0, 1, 0)

package/studio-plugin/src/modules/ClientBroker.ts

@@ -94,7 +94,6 @@ function setupClientBroker() {
 		}
 		return identity<ExecuteResult>({ success: false, error: tostring(result) });
 	};
-	print("[MCPFork] client broker ready");
 }
 
 const proxyByPlayer = new Map<Player, ProxyEntry>();
@@ -141,19 +140,17 @@ function registerProxy(player: Player, rf: RemoteFunction) {
 	const body = HttpService.JSONDecode(res.Body) as ReadyResponseBody;
 	const assigned = body.assignedRole ?? "client";
 	proxyByPlayer.set(player, { instanceId: proxyId, role: assigned });
-	print(`[MCPFork] proxy ${assigned} -> ${player.Name}`);
 	task.spawn(pollProxy, proxyId, player, rf);
 }
 
 function startEditProxyLoop() {
 	task.spawn(() => {
 		const proxyId = HttpService.GenerateGUID(false);
-		const [ok, res] = postJson("/ready", { instanceId: proxyId, role: "edit" });
+		const [ok, res] = postJson("/ready", { instanceId: proxyId, role: "edit-proxy" });
 		if (!ok || !res || !res.Success) {
 			warn("[MCPFork] edit-proxy register failed");
 			return;
 		}
-		print("[MCPFork] edit-proxy ready (stop-playtest interceptor)");
 		while (true) {
 			const [okPoll, pollRes] = pcall(() =>
 				HttpService.RequestAsync({
@@ -210,7 +207,6 @@ function setupServerBroker() {
 		proxyByPlayer.clear();
 	});
 	startEditProxyLoop();
-	print("[MCPFork] server broker ready");
 }
 
 export = {

package/studio-plugin/src/modules/UI.ts

@@ -226,7 +226,9 @@ function init(pluginRef: Plugin) {
 
 	const screenGui = pluginRef.CreateDockWidgetPluginGuiAsync(
 		"MCPServerInterface",
-		new DockWidgetPluginGuiInfo(Enum.InitialDockState.Float, false, false, 300, 260, 260, 200),
+		// 3rd arg (initialEnabledShouldOverrideRestore=true) forces the dock closed
+		// at every Studio launch. User can still open via the toolbar button.
+		new DockWidgetPluginGuiInfo(Enum.InitialDockState.Float, false, true, 300, 260, 260, 200),
 	);
 	(screenGui as unknown as { Title: string }).Title = `MCP Server v${CURRENT_VERSION}`;
 

package/studio-plugin/src/modules/handlers/TestHandlers.ts

@@ -189,27 +189,18 @@ function startPlaytest(requestData: Record<string, unknown>) {
 }
 
 function stopPlaytest(_requestData: Record<string, unknown>) {
-	// Stop requests are normally intercepted by the server-peer edit-proxy in
-	// modules/ClientBroker - that proxy runs inside the play server DM, the
-	// only DM where StudioTestService:EndTest is legal. If we reach this
-	// handler the broker either hasn't started yet or there's no active
-	// playtest. Try EndTest directly as a fallback (works for manually
-	// started playtests where the server-peer plugin happens to be polling).
-	const endTest = StudioTestService as unknown as Instance & { EndTest(reason: string): void };
-	const [endOk, endErr] = pcall(() => {
-		endTest.EndTest("stopped_by_mcp");
-	});
-	if (endOk) {
-		return {
-			success: true,
-			output: [...outputBuffer],
-			outputCount: outputBuffer.size(),
-			message: "Playtest stopped via StudioTestService.",
-		};
-	}
-
+	// Server-side routing (tools/index.ts:stopPlaytest) sends /api/stop-playtest
+	// to the role="edit-proxy" instance whenever one is registered. This handler
+	// is only reached when there's no edit-proxy - i.e. no active playtest, or
+	// the play DMs haven't completed plugin auto-activation yet. Calling
+	// StudioTestService:EndTest from the edit DM is illegal ("can only be
+	// called from the server DataModel of a running Studio play session"), so
+	// don't try - return a clean "no active playtest" response instead.
 	return {
-		error: `stopPlaytest fell through to edit DM (broker should have handled it). EndTest reported: ${tostring(endErr)}`,
+		error: "No active playtest to stop (edit-proxy not registered).",
+		hint:
+			"If a playtest is running, the play-server DM may not have completed plugin auto-activation yet. " +
+			"Wait a moment and retry, or call execute_luau target=server with StudioTestService:EndTest as a manual fallback.",
 	};
 }