@christianmorup/review-intent 0.1.0 → 0.1.3

package/dist/review-order.js

@@ -0,0 +1,78 @@
+import { isNoisePath } from "./scorecard.js";
+const norm = (p) => p.replace(/\\/g, "/");
+/** Stable, unique, deterministic anchor id for a file section. */
+export function fileSlug(index) {
+    return `file-${index}`;
+}
+/** Highest CCN of a measured hotspot matching this file, or null. Matches
+ *  lizard's (possibly differently-rooted) path by suffix/basename — same
+ *  heuristic the change-map uses. */
+function hotspotCcn(model, path) {
+    const cx = model.complexity;
+    if (!cx.available || cx.hotspots.length === 0)
+        return null;
+    const p = norm(path);
+    const base = p.split("/").pop() ?? p;
+    let max = null;
+    for (const h of cx.hotspots) {
+        const hp = norm(h.file);
+        const hit = hp === p ||
+            hp.endsWith("/" + p) ||
+            p.endsWith("/" + hp) ||
+            (hp.split("/").pop() ?? hp) === base;
+        if (hit)
+            max = max === null ? h.ccn : Math.max(max, h.ccn);
+    }
+    return max;
+}
+/** Pure: one signal record per changed file, in original diff order. */
+export function collectSignals(model) {
+    return model.files.map((f, i) => {
+        let added = 0;
+        let removed = 0;
+        for (const h of f.hunks)
+            for (const l of h.lines) {
+                if (l.type === "add")
+                    added++;
+                else if (l.type === "del")
+                    removed++;
+            }
+        const fanIn = model.reach.edges.reduce((n, e) => (norm(e.to) === norm(f.path) ? n + 1 : n), 0);
+        const maxCcn = hotspotCcn(model, f.path);
+        const missingIntent = !f.why || f.hunks.some((h) => h.intents.length === 0);
+        return {
+            path: f.path,
+            index: i,
+            slug: fileSlug(i),
+            status: f.status,
+            added,
+            removed,
+            churn: added + removed,
+            hunks: f.hunks.length,
+            fanIn,
+            hotspot: maxCcn !== null,
+            maxCcn,
+            missingIntent,
+            isNoise: isNoisePath(f.path),
+        };
+    });
+}
+/** Pure: files ranked by review priority (most attention-worthy first). Score
+ *  blends normalized churn + reach with flat bonuses for a complexity hotspot
+ *  and for unexplained changes, then demotes noise. Ties break by churn, then
+ *  original diff order — fully deterministic. */
+export function reviewOrder(model) {
+    const sig = collectSignals(model);
+    const maxChurn = Math.max(1, ...sig.map((s) => s.churn));
+    const maxFan = Math.max(1, ...sig.map((s) => s.fanIn));
+    const sq = (v, max) => Math.sqrt(v) / Math.sqrt(max);
+    const scored = sig.map((s, i) => {
+        const base = sq(s.churn, maxChurn) +
+            sq(s.fanIn, maxFan) +
+            (s.hotspot ? 0.6 : 0) +
+            (s.missingIntent ? 0.5 : 0);
+        return { sig: s, i, score: s.isNoise ? base * 0.25 : base };
+    });
+    scored.sort((a, b) => b.score - a.score || b.sig.churn - a.sig.churn || a.i - b.i);
+    return scored.map((x, idx) => ({ ...x.sig, score: x.score, rank: idx + 1 }));
+}

package/dist/skill.js

@@ -8,7 +8,7 @@ const SKILL_NAME = "review-intent-authoring";
 // against it (line-ending-normalized) to decide whether the file is still ours.
 export const SKILL_CONTENT = `---
 name: review-intent-authoring
-description: Use when you have just finished a set of code changes on a branch and the user (or another reviewer) is about to review the diff. Author a .review/intent.json that captures the genuine intent behind the changes — why, what you rejected, what it rests on — keyed to files and hunks, plus mermaid class and sequence diagrams. Then offer to render it with review-intent so the reviewer adjudicates decisions instead of skimming lines.
+description: Use when you have just finished a set of code changes on a branch and the user (or another reviewer) is about to review the diff. Author a .review/intent.json that captures the genuine intent behind the changes — why, what you rejected, what it rests on — keyed to files and hunks, plus mermaid class and sequence diagrams. Then render it with review-intent (run it, don't ask) so the reviewer adjudicates decisions instead of skimming lines.
 ---
 
 # Authoring an honest intent artifact
@@ -131,13 +131,12 @@ This is the reviewer's highest-value target, so write it to honesty-rule #3:
   "low risk" while the scorecard flags \`touches auth/, 0 test files\` or a
   changed function jumps to CCN 30 and you never mention it, the contradiction is
   visible at a glance.
-- **There is an "honesty quadrant"** that plots your *claimed* candor (declared
-  risks + intent coverage) against the *measured* blast radius (churn + reach). A
-  large, far-reaching change that declared little lands in a red corner. Padding
-  the ledger with throwaway risks to nudge the dot is pointless — a human reads
-  the prose. Write a ledger the measured facts won't embarrass: address the gap,
-  or name it as a risk. If a hunk added real branching/complexity, the *why* is
-  the place to justify it.
+- **There is a "change map"** that plots each changed file by *measured*
+  downstream reach (how many files import it) against *measured* churn, flagging
+  the ones that also carry a complexity hotspot. The biggest, most depended-on
+  files land in the top-right — that's where a reviewer looks first, so those are
+  the files whose *why* had better be airtight. If a hunk added real
+  branching/complexity, the *why* is the place to justify it.
 
 ### The tests section (\`tests\`)
 
@@ -183,13 +182,19 @@ don't draw a trivial two-box diagram to fill the slot.
 
 ## After writing it
 
-Offer to render — never auto-launch:
+Render it — don't ask first. You're inside this skill because a review is
+wanted; writing the artifact and *then* asking "should I open it?" just adds a
+round-trip the user did not want. Run \`review-intent\` via Bash from the repo
+root — it diffs the current branch against main, writes \`review.html\`, and opens
+it in the browser. Then tell the user you've opened it (and where the file is);
+don't ask permission to.
 
-> I've written the review intent to \`.review/intent.json\`. Want me to open the
-> side-by-side review? (\`review-intent\`)
+The only times you don't run it: the change was trivial/mechanical so you
+skipped the artifact entirely (say so in chat), or the user has explicitly
+declined review-intent for this change set.
 
-If the user accepts, run \`review-intent\` via Bash from the repo root. It diffs
-the current branch against main and opens the rendered page in the browser.
+If the completeness gate refuses to render because intent is missing, fix the
+gaps and run again — do **not** reach for \`--allow-gaps\` to get past it.
 
 ## Why this exists
 

package/dist/themes.js

@@ -0,0 +1,176 @@
+/** Pure: visual theme catalog + CSS emitter. No I/O, no Date/random.
+ *  `paper` (the default) lives in render.ts `:root`; this module supplies
+ *  every *other* theme as a `[data-theme="id"]` override block. */
+/** Canonical token contract — every theme must define all of these. */
+export const TOKEN_KEYS = [
+    "--paper", "--surface", "--surface-2", "--ink", "--ink-soft", "--muted",
+    "--line", "--line-2", "--accent", "--accent-soft",
+    "--add", "--add-soft", "--del", "--del-soft", "--warn", "--warn-soft",
+    "--add-border", "--del-border", "--warn-border", "--accent-border",
+    "--accent-shadow", "--on-accent", "--glass", "--code-add", "--code-del",
+    "--viz-add", "--viz-add-ink", "--viz-del", "--viz-del-ink", "--viz-warn",
+    "--viz-accent", "--viz-line", "--viz-node", "--viz-node-stroke",
+    "--viz-accent-stroke", "--viz-cell-stroke", "--viz-noise", "--viz-other",
+    "--viz-cell-label", "--viz-zone", "--kind-e2e",
+    "--viz-s1", "--viz-s2", "--viz-s3", "--viz-s4",
+    "--viz-s5", "--viz-s6", "--viz-s7", "--viz-s8",
+];
+const DEFAULT_SERIES = [
+    "#5b7db1", "#5fa389", "#b08a5a", "#a07ba6",
+    "#c47d72", "#7fa86a", "#d0a85a", "#7a93b8",
+];
+/** Expand core palette into the full token record. Derived tokens alias core
+ *  values (no color math) so a theme stays ~16 lines; any token can still be
+ *  overridden by adding it to the returned record after the fact. */
+export function makeTheme(id, label, group, c) {
+    const s = c.series ?? DEFAULT_SERIES;
+    const tokens = {
+        "--paper": c.paper, "--surface": c.surface, "--surface-2": c.surface2,
+        "--ink": c.ink, "--ink-soft": c.inkSoft, "--muted": c.muted,
+        "--line": c.line, "--line-2": c.line2,
+        "--accent": c.accent, "--accent-soft": c.accentSoft,
+        "--add": c.add, "--add-soft": c.addSoft,
+        "--del": c.del, "--del-soft": c.delSoft,
+        "--warn": c.warn, "--warn-soft": c.warnSoft,
+        "--add-border": c.add, "--del-border": c.del,
+        "--warn-border": c.warn, "--accent-border": c.accent,
+        "--accent-shadow": c.accentShadow ?? "rgba(0,0,0,.2)",
+        "--on-accent": c.onAccent ?? "#fff",
+        "--glass": c.glass ?? c.surface,
+        "--code-add": c.codeAdd ?? c.add,
+        "--code-del": c.codeDel ?? c.del,
+        "--viz-add": c.add, "--viz-add-ink": c.add,
+        "--viz-del": c.del, "--viz-del-ink": c.del,
+        "--viz-warn": c.warn, "--viz-accent": c.accent, "--viz-line": c.line,
+        "--viz-node": c.surface, "--viz-node-stroke": c.line2,
+        "--viz-accent-stroke": c.accent, "--viz-cell-stroke": c.surface,
+        "--viz-noise": c.muted, "--viz-other": c.muted,
+        "--viz-cell-label": c.cellLabel ?? c.ink,
+        "--viz-zone": c.delSoft, "--kind-e2e": c.accent,
+        "--viz-s1": s[0], "--viz-s2": s[1], "--viz-s3": s[2], "--viz-s4": s[3],
+        "--viz-s5": s[4], "--viz-s6": s[5], "--viz-s7": s[6], "--viz-s8": s[7],
+    };
+    if (c.sans)
+        tokens["--sans"] = c.sans;
+    if (c.mono)
+        tokens["--mono"] = c.mono;
+    return { id, label, group, tokens };
+}
+export const THEMES = [
+    makeTheme("dark", "Dark", "Playful", {
+        paper: "#1b1a17", surface: "#232220", surface2: "#2c2a26",
+        ink: "#ece9e1", inkSoft: "#b8b2a6", muted: "#847d6f",
+        line: "#34322c", line2: "#44413a",
+        accent: "#6fa3e0", accentSoft: "#20303f",
+        add: "#56c07a", addSoft: "#18301f", del: "#e8786c", delSoft: "#3a201d",
+        warn: "#d6a64a", warnSoft: "#332a16", onAccent: "#000",
+    }),
+    makeTheme("hacker", "Hacker", "Playful", {
+        paper: "#000800", surface: "#021202", surface2: "#001a00",
+        ink: "#33ff66", inkSoft: "#1faf47", muted: "#0f7a2e",
+        line: "#093d12", line2: "#0e5a1c",
+        accent: "#7dff7d", accentSoft: "#00270c",
+        add: "#39ff77", addSoft: "#002a0e", del: "#ff5f56", delSoft: "#2a0a08",
+        warn: "#d4ff3a", warnSoft: "#1d2a00", onAccent: "#000",
+        mono: 'ui-monospace, "JetBrains Mono", "Cascadia Code", Consolas, monospace',
+    }),
+    makeTheme("solarized-light", "Solarized Light", "Dev favorites", {
+        paper: "#fdf6e3", surface: "#fdf6e3", surface2: "#eee8d5",
+        ink: "#586e75", inkSoft: "#657b83", muted: "#6c7b7b",
+        line: "#eee8d5", line2: "#d6cfbb",
+        accent: "#268bd2", accentSoft: "#dcebf2",
+        add: "#5f6d00", addSoft: "#eef0d8", del: "#dc322f", delSoft: "#f6e0db",
+        warn: "#8a6700", warnSoft: "#f3ead0", onAccent: "#000",
+    }),
+    makeTheme("solarized-dark", "Solarized Dark", "Dev favorites", {
+        paper: "#002b36", surface: "#073642", surface2: "#003744",
+        ink: "#93a1a1", inkSoft: "#839496", muted: "#6c8088",
+        line: "#0a4250", line2: "#135561",
+        accent: "#268bd2", accentSoft: "#03323e",
+        add: "#859900", addSoft: "#14331f", del: "#dc322f", delSoft: "#33161a",
+        warn: "#b58900", warnSoft: "#2e2812", onAccent: "#000",
+    }),
+    makeTheme("nord", "Nord", "Dev favorites", {
+        paper: "#2e3440", surface: "#3b4252", surface2: "#434c5e",
+        ink: "#eceff4", inkSoft: "#d8dee9", muted: "#9aa5b5",
+        line: "#434c5e", line2: "#4c566a",
+        accent: "#88c0d0", accentSoft: "#2b333f",
+        add: "#a3be8c", addSoft: "#2c3a2e", del: "#bf616a", delSoft: "#3a2a2c",
+        warn: "#ebcb8b", warnSoft: "#3a3424", onAccent: "#000",
+    }),
+    makeTheme("gruvbox", "Gruvbox", "Dev favorites", {
+        paper: "#282828", surface: "#32302f", surface2: "#3c3836",
+        ink: "#ebdbb2", inkSoft: "#d5c4a1", muted: "#a89984",
+        line: "#3c3836", line2: "#504945",
+        accent: "#83a598", accentSoft: "#2b3331",
+        add: "#b8bb26", addSoft: "#2f3318", del: "#fb4934", delSoft: "#3a201c",
+        warn: "#fabd2f", warnSoft: "#3a3014", onAccent: "#000",
+    }),
+    makeTheme("catppuccin", "Catppuccin", "Dev favorites", {
+        paper: "#1e1e2e", surface: "#313244", surface2: "#45475a",
+        ink: "#cdd6f4", inkSoft: "#bac2de", muted: "#9399b2",
+        line: "#313244", line2: "#585b70",
+        accent: "#89b4fa", accentSoft: "#2a2c41",
+        add: "#a6e3a1", addSoft: "#26342a", del: "#f38ba8", delSoft: "#361f2a",
+        warn: "#f9e2af", warnSoft: "#36321f", onAccent: "#000",
+    }),
+    makeTheme("github", "GitHub", "Professional", {
+        paper: "#ffffff", surface: "#ffffff", surface2: "#f6f8fa",
+        ink: "#1f2328", inkSoft: "#656d76", muted: "#8c959f",
+        line: "#d0d7de", line2: "#afb8c1",
+        accent: "#0969da", accentSoft: "#ddf4ff",
+        add: "#1a7f37", addSoft: "#dafbe1", del: "#cf222e", delSoft: "#ffebe9",
+        warn: "#9a6700", warnSoft: "#fff8c5",
+    }),
+    makeTheme("high-contrast", "High Contrast", "Professional", {
+        paper: "#ffffff", surface: "#ffffff", surface2: "#f0f0f0",
+        ink: "#000000", inkSoft: "#000000", muted: "#3a3a3a",
+        line: "#000000", line2: "#000000",
+        accent: "#0000cc", accentSoft: "#e6e6ff",
+        add: "#006400", addSoft: "#e6f5e6", del: "#b00000", delSoft: "#ffe6e6",
+        warn: "#7a4d00", warnSoft: "#fff3e0",
+    }),
+    makeTheme("blueprint", "Blueprint", "Professional", {
+        paper: "#0d2747", surface: "#123257", surface2: "#16395f",
+        ink: "#dbeafe", inkSoft: "#a9c7ee", muted: "#6f93c0",
+        line: "#1d4373", line2: "#2a558c",
+        accent: "#5ad1ff", accentSoft: "#0e2c4d",
+        add: "#5ee0a0", addSoft: "#103a2c", del: "#ff8a8a", delSoft: "#3a1d22",
+        warn: "#ffd166", warnSoft: "#33301a", onAccent: "#000",
+    }),
+    makeTheme("newsprint", "Newsprint", "Editorial", {
+        paper: "#f7f5ef", surface: "#ffffff", surface2: "#ece9e1",
+        ink: "#111111", inkSoft: "#333333", muted: "#6b6b6b",
+        line: "#cfcabf", line2: "#b3ada0",
+        accent: "#8a1f11", accentSoft: "#f1e3e0",
+        add: "#1a6b34", addSoft: "#e6f0e8", del: "#a31d12", delSoft: "#f6e3e0",
+        warn: "#8a6400", warnSoft: "#f1ead4",
+        sans: 'Iowan Old Style, Georgia, "Times New Roman", Times, serif',
+    }),
+    makeTheme("sepia", "Sepia", "Editorial", {
+        paper: "#e9dcc3", surface: "#f3e9d6", surface2: "#ddcfb2",
+        ink: "#4a3b28", inkSoft: "#5f4d34", muted: "#776344",
+        line: "#d4c4a3", line2: "#c4b08a",
+        accent: "#8a5a2b", accentSoft: "#ead9bf",
+        add: "#4f5e24", addSoft: "#dfe0bf", del: "#9c3b28", delSoft: "#ecd5cc",
+        warn: "#7e5e22", warnSoft: "#ece0c0",
+    }),
+    makeTheme("synthwave", "Synthwave", "Playful", {
+        paper: "#1a1033", surface: "#251447", surface2: "#2f1a57",
+        ink: "#f6e6ff", inkSoft: "#d3b8f0", muted: "#9a7fc0",
+        line: "#3a2470", line2: "#4d2f8f",
+        accent: "#ff5fd2", accentSoft: "#2e1450",
+        add: "#36f9c5", addSoft: "#0e3a32", del: "#ff5f6d", delSoft: "#3a1622",
+        warn: "#ffd23f", warnSoft: "#332a10", onAccent: "#000",
+    }),
+];
+/** Emit a `[data-theme="id"]{…}` block per theme. `paper` (default) is NOT
+ *  emitted — it lives in render.ts `:root`. Deterministic string output. */
+export function themeCss() {
+    return THEMES.map((t) => {
+        const decls = Object.entries(t.tokens)
+            .map(([k, v]) => `  ${k}: ${v};`)
+            .join("\n");
+        return `[data-theme="${t.id}"] {\n${decls}\n}`;
+    }).join("\n");
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@christianmorup/review-intent",
-  "version": "0.1.0",
+  "version": "0.1.3",
   "description": "Render the diff between the current branch and main as an intent-annotated HTML review page with mermaid class & sequence diagrams.",
   "type": "module",
   "license": "MIT",