@chrischall/pickuppatrol-mcp 0.0.0 → 0.1.1

package/.claude-plugin/marketplace.json

@@ -6,7 +6,7 @@
   },
   "metadata": {
     "description": "PickUp Patrol school-dismissal tools for Claude Code",
-    "version": "0.0.0"
+    "version": "0.1.1"
   },
   "plugins": [
     {
@@ -14,7 +14,7 @@
       "displayName": "PickUp Patrol",
       "source": "./",
       "description": "Read and change your children's school dismissal plans in PickUp Patrol — defaults, day-by-day changes and school cutoff times — via MCP",
-      "version": "0.0.0",
+      "version": "0.1.1",
       "author": {
         "name": "Chris Chall"
       },

package/.claude-plugin/plugin.json

@@ -1,7 +1,7 @@
 {
   "name": "pickuppatrol",
   "displayName": "PickUp Patrol",
-  "version": "0.0.0",
+  "version": "0.1.1",
   "description": "Read and change your children's school dismissal plans in PickUp Patrol — defaults, day-by-day changes and school cutoff times — via MCP",
   "author": {
     "name": "Chris Chall"

package/README.md

@@ -16,7 +16,8 @@ no captcha. The server signs in with your own email and password and holds the
 resulting session in memory.
 
 Every request shape is captured in [`docs/PICKUPPATROL-API.md`](docs/PICKUPPATROL-API.md),
-read off the shipped client rather than guessed.
+read off the shipped client rather than guessed, and exercised against a real
+account — reads, a write, and its restore.
 
 ## Install
 
@@ -78,10 +79,12 @@ a validation message rather than an opaque 400.
 
 **Writes are verified by re-reading.** A 2xx from PickUp Patrol is not proof: a
 change made after the school's cutoff is accepted and silently ignored. Every
-write re-reads the affected dates and compares the transportation id — never
-`ModifiedDate`, which advances on its own and would make every write look
-successful. The result says `verified: true/false`, and names the dates that did
-not move.
+write re-reads the affected dates and compares the transportation id **and the
+note** — never `ModifiedDate`, which advances on its own and would make every
+write look successful. The note is part of the proof because every dismissal
+option seen so far requires one, which makes a note-only edit ordinary: an
+id-only comparison would report success from a field that never had to move.
+The result says `verified: true/false`, and names the dates that did not move.
 
 ## Without the MCP server
 
@@ -100,6 +103,18 @@ npm run test:coverage # coverage-enforced at 100%
 Tests never touch the network: the transport is injected, and the MCP tools run
 through a real in-memory client/server pair.
 
+## Two things about the API worth knowing
+
+**`GetPlanEdit` returns a date's override, not the effective plan.** A date with
+no specific plan reads back `TransportationId: null` even when the student has a
+weekly default for that weekday. `pup_get_plan` passes that through as-is;
+`pup_list_students` is where the weekly defaults live.
+
+**Sign-in is a session cookie, not a JWT.** `Authenticate` returns
+`BearerToken: null` on this deployment and sets `ss-id`/`ss-pid`/`ss-opt`. The
+client keeps whichever the server returns and sends both, so a future switch to
+JWTs needs no change here.
+
 ## Safety notes
 
 - A rejected sign-in is **never retried**. PickUp Patrol counts failed attempts

package/dist/bundle.js

@@ -31503,7 +31503,7 @@ var PickUpPatrolClient = class {
 var client = new PickUpPatrolClient();
 
 // src/version.ts
-var VERSION = "0.0.0";
+var VERSION = "0.1.1";
 
 // src/dates.ts
 var WEEKDAY_NAMES = [
@@ -31878,12 +31878,11 @@ Hint: ${err.hint}`);
 }
 
 // src/tools/plans.ts
-function expectedTransportationId(student, planDate, requested) {
-  if (requested !== null) return requested;
-  const dayId = dateToDayId(planDate);
-  if (dayId === null) return void 0;
-  const fallback = (student.DefaultPlans ?? []).find((plan) => plan.DayId === dayId);
-  return fallback === void 0 ? void 0 : fallback.TransportationId ?? null;
+function proofsMatch(a, b) {
+  return a.transportationId === b.transportationId && (a.note ?? "").trim() === (b.note ?? "").trim();
+}
+function expectedPlanState(requested) {
+  return requested.transportationId === null ? { transportationId: null, note: null } : requested;
 }
 async function resolveTransportation(client2, schoolId, transportationId) {
   const options = await client2.getTransportations(schoolId);
@@ -31951,24 +31950,30 @@ function registerPlanTools(server, client2) {
       const gate = previewUnlessConfirmed(confirm, action, "PUT", "UpdatePlans", { Plans: plans });
       if (gate) return gate;
       await client2.updatePlans(plans);
+      const expected = expectedPlanState({
+        transportationId: transportation_id,
+        note: plans[0]?.Note ?? null
+      });
       const verification = await Promise.all(
         dates.map(async (date5) => {
           const after = await client2.getPlanEdit(date5, student_id);
-          const expected = expectedTransportationId(student, date5, transportation_id);
-          const actual = after.TransportationId ?? null;
+          const actual = {
+            transportationId: after.TransportationId ?? null,
+            note: after.Note ?? null
+          };
           return {
             date: date5,
             weekday: weekdayOf(date5),
-            transportationId: actual,
+            transportationId: actual.transportationId,
             transportation: after.TransportationName ?? null,
-            note: after.Note ?? null,
+            note: actual.note,
             earlyDismissalTime: after.EarlyDismissalTime ?? null,
             locked: after.IsLocked ?? false,
-            verified: expected === void 0 ? null : actual === expected
+            verified: proofsMatch(actual, expected)
           };
         })
       );
-      const failed = verification.filter((v) => v.verified === false);
+      const failed = verification.filter((v) => !v.verified);
       return textResult({
         action,
         applied: verification,
@@ -32093,10 +32098,14 @@ function registerDefaultPlanTools(server, client2) {
       if (gate) return gate;
       await client2.updateStudent(payload);
       const after = await client2.getStudent(student_id);
-      const changed = new Set(dayIds);
-      const unchanged = [...changed].filter((dayId) => {
+      const sentNote = payload.DefaultPlans?.find((p) => p.DayId === dayIds[0])?.Note ?? null;
+      const unchanged = [...new Set(dayIds)].filter((dayId) => {
         const plan = (after.DefaultPlans ?? []).find((p) => p.DayId === dayId);
-        return plan?.TransportationId !== transportation.TransportationId;
+        if (plan === void 0) return true;
+        return !proofsMatch(
+          { transportationId: plan.TransportationId ?? null, note: plan.Note ?? null },
+          { transportationId: transportation.TransportationId, note: sentNote }
+        );
       });
       return textResult({
         action,

package/dist/lib.d.ts

@@ -6,6 +6,7 @@
 export { PickUpPatrolClient, type ClientOptions } from './client.js';
 export { PickUpPatrolAuth, describeResponseStatus, collectCookieHeader, BASE_URL, BASE_PATH, type AuthOptions, type PupSession, type FetchLike, } from './auth.js';
 export { buildPlanUpdates, applyDefaultPlans, clearDefaultPlans, assertTransportationAllowed, normalizeNote, normalizeEarlyDismissal, normalizeCarNumber, DEFAULT_PLAN_LABEL, type PlanInput, type DefaultPlanInput, } from './plans.js';
-export { dayIdToName, nameToDayId, dateToDayId, WEEKDAY_NAMES, type WeekdayName } from './dates.js';
+export { expectedPlanState, proofsMatch, resolveTransportation, type PlanProof, } from './tools/plans.js';
+export { dayIdToName, nameToDayId, dateToDayId, weekdayOf, WEEKDAY_NAMES, type WeekdayName } from './dates.js';
 export { VERSION } from './version.js';
 export type * from './types.js';

package/dist/lib.js

@@ -6,5 +6,6 @@
 export { PickUpPatrolClient } from './client.js';
 export { PickUpPatrolAuth, describeResponseStatus, collectCookieHeader, BASE_URL, BASE_PATH, } from './auth.js';
 export { buildPlanUpdates, applyDefaultPlans, clearDefaultPlans, assertTransportationAllowed, normalizeNote, normalizeEarlyDismissal, normalizeCarNumber, DEFAULT_PLAN_LABEL, } from './plans.js';
-export { dayIdToName, nameToDayId, dateToDayId, WEEKDAY_NAMES } from './dates.js';
+export { expectedPlanState, proofsMatch, resolveTransportation, } from './tools/plans.js';
+export { dayIdToName, nameToDayId, dateToDayId, weekdayOf, WEEKDAY_NAMES } from './dates.js';
 export { VERSION } from './version.js';

package/dist/tools/defaults.js

@@ -3,7 +3,7 @@ import { McpToolError, textResult } from '@chrischall/mcp-utils';
 import { applyDefaultPlans, clearDefaultPlans } from '../plans.js';
 import { dayIdToName, nameToDayId } from '../dates.js';
 import { summarizeDefaultPlans } from './account.js';
-import { resolveTransportation } from './plans.js';
+import { proofsMatch, resolveTransportation } from './plans.js';
 import { previewUnlessConfirmed, schemaConfirm } from './_confirm.js';
 import { withHints } from './_errors.js';
 /**
@@ -125,13 +125,19 @@ export function registerDefaultPlanTools(server, client) {
         if (gate)
             return gate;
         await client.updateStudent(payload);
-        // Re-read and check the weekdays we changed actually hold the new
-        // option. DefaultsModifiedDate is not compared — it advances by itself.
+        // Re-read and check the weekdays we changed actually hold the new option
+        // AND the new note. The note alone is a normal edit here — every option at
+        // this school requires one — so comparing the id by itself would report
+        // success without observing the change. DefaultsModifiedDate stays out of
+        // the comparison entirely: it advances by itself, which would make every
+        // write look successful.
         const after = await client.getStudent(student_id);
-        const changed = new Set(dayIds);
-        const unchanged = [...changed].filter((dayId) => {
+        const sentNote = payload.DefaultPlans?.find((p) => p.DayId === dayIds[0])?.Note ?? null;
+        const unchanged = [...new Set(dayIds)].filter((dayId) => {
             const plan = (after.DefaultPlans ?? []).find((p) => p.DayId === dayId);
-            return plan?.TransportationId !== transportation.TransportationId;
+            if (plan === undefined)
+                return true;
+            return !proofsMatch({ transportationId: plan.TransportationId ?? null, note: plan.Note ?? null }, { transportationId: transportation.TransportationId, note: sentNote });
         });
         return textResult({
             action,

package/dist/tools/plans.d.ts

@@ -1,15 +1,28 @@
 import type { McpServer } from '@modelcontextprotocol/sdk/server/mcp.js';
 import type { PickUpPatrolClient } from '../client.js';
-import type { Student, Transportation } from '../types.js';
+import type { Transportation } from '../types.js';
+/** The fields whose change proves a plan write actually landed. */
+export interface PlanProof {
+    transportationId: number | null;
+    note: string | null;
+}
+/** Compare two proofs, ignoring whitespace the service may normalise off a note. */
+export declare function proofsMatch(a: PlanProof, b: PlanProof): boolean;
 /**
- * The transportation id a date should show once a write has landed.
+ * What `GetPlanEdit` should report once a write has landed.
  *
- * For a normal change that is the id we asked for. For a revert
- * (`TransportationId: null`) the date falls back to the student's default for
- * that weekday, so the id to expect is that default's — and when the student
- * has no default for the day there is nothing to assert, hence `undefined`.
+ * Deliberately more than the transportation id: every dismissal option at the
+ * schools seen so far requires a note, so changing only the note is an ordinary
+ * edit — and an id-only comparison would report success without ever observing
+ * it. Same false-green as diffing a field that cannot move.
+ *
+ * A revert expects an EMPTY slot, not the weekday default. `GetPlanEdit`
+ * reports the date's override, not the effective plan: verified live on a
+ * Friday where the student had a Friday default and the date still read back
+ * `TransportationId: null`. Expecting the default here would report every
+ * successful revert as a failure.
  */
-export declare function expectedTransportationId(student: Student, planDate: string, requested: number | null): number | null | undefined;
+export declare function expectedPlanState(requested: PlanProof): PlanProof;
 /** Resolve a transportation id against the school's list, or fail with the options. */
 export declare function resolveTransportation(client: PickUpPatrolClient, schoolId: number, transportationId: number): Promise<Transportation>;
 export declare function registerPlanTools(server: McpServer, client: PickUpPatrolClient): void;

package/dist/tools/plans.js

@@ -1,25 +1,31 @@
 import { z } from 'zod';
 import { McpToolError, textResult } from '@chrischall/mcp-utils';
 import { buildPlanUpdates } from '../plans.js';
-import { dateToDayId, weekdayOf } from '../dates.js';
+import { weekdayOf } from '../dates.js';
 import { previewUnlessConfirmed, schemaConfirm } from './_confirm.js';
 import { withHints } from './_errors.js';
+/** Compare two proofs, ignoring whitespace the service may normalise off a note. */
+export function proofsMatch(a, b) {
+    return a.transportationId === b.transportationId && (a.note ?? '').trim() === (b.note ?? '').trim();
+}
 /**
- * The transportation id a date should show once a write has landed.
+ * What `GetPlanEdit` should report once a write has landed.
+ *
+ * Deliberately more than the transportation id: every dismissal option at the
+ * schools seen so far requires a note, so changing only the note is an ordinary
+ * edit — and an id-only comparison would report success without ever observing
+ * it. Same false-green as diffing a field that cannot move.
  *
- * For a normal change that is the id we asked for. For a revert
- * (`TransportationId: null`) the date falls back to the student's default for
- * that weekday, so the id to expect is that default's — and when the student
- * has no default for the day there is nothing to assert, hence `undefined`.
+ * A revert expects an EMPTY slot, not the weekday default. `GetPlanEdit`
+ * reports the date's override, not the effective plan: verified live on a
+ * Friday where the student had a Friday default and the date still read back
+ * `TransportationId: null`. Expecting the default here would report every
+ * successful revert as a failure.
  */
-export function expectedTransportationId(student, planDate, requested) {
-    if (requested !== null)
-        return requested;
-    const dayId = dateToDayId(planDate);
-    if (dayId === null)
-        return undefined;
-    const fallback = (student.DefaultPlans ?? []).find((plan) => plan.DayId === dayId);
-    return fallback === undefined ? undefined : (fallback.TransportationId ?? null);
+export function expectedPlanState(requested) {
+    return requested.transportationId === null
+        ? { transportationId: null, note: null }
+        : requested;
 }
 /** Resolve a transportation id against the school's list, or fail with the options. */
 export async function resolveTransportation(client, schoolId, transportationId) {
@@ -102,22 +108,30 @@ export function registerPlanTools(server, client) {
         // compare the one field that proves it. ModifiedDate is deliberately not
         // compared: it advances on its own, which would make every write look
         // successful.
+        // One expectation for the whole call: every date in a single UpdatePlans
+        // gets the same option and note, so this does not vary per date.
+        const expected = expectedPlanState({
+            transportationId: transportation_id,
+            note: plans[0]?.Note ?? null,
+        });
         const verification = await Promise.all(dates.map(async (date) => {
             const after = await client.getPlanEdit(date, student_id);
-            const expected = expectedTransportationId(student, date, transportation_id);
-            const actual = after.TransportationId ?? null;
+            const actual = {
+                transportationId: after.TransportationId ?? null,
+                note: after.Note ?? null,
+            };
             return {
                 date,
                 weekday: weekdayOf(date),
-                transportationId: actual,
+                transportationId: actual.transportationId,
                 transportation: after.TransportationName ?? null,
-                note: after.Note ?? null,
+                note: actual.note,
                 earlyDismissalTime: after.EarlyDismissalTime ?? null,
                 locked: after.IsLocked ?? false,
-                verified: expected === undefined ? null : actual === expected,
+                verified: proofsMatch(actual, expected),
             };
         }));
-        const failed = verification.filter((v) => v.verified === false);
+        const failed = verification.filter((v) => !v.verified);
         return textResult({
             action,
             applied: verification,

package/dist/version.d.ts

@@ -7,4 +7,4 @@
  * annotation, so there is exactly one line to keep in sync and
  * `versionSyncTest` has exactly one line to check.
  */
-export declare const VERSION = "0.0.0";
+export declare const VERSION = "0.1.1";

package/dist/version.js

@@ -7,4 +7,4 @@
  * annotation, so there is exactly one line to keep in sync and
  * `versionSyncTest` has exactly one line to check.
  */
-export const VERSION = '0.0.0'; // x-release-please-version
+export const VERSION = '0.1.1'; // x-release-please-version

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@chrischall/pickuppatrol-mcp",
-  "version": "0.0.0",
+  "version": "0.1.1",
   "license": "MIT",
   "mcpName": "io.github.chrischall/pickuppatrol-mcp",
   "description": "PickUp Patrol MCP server for Claude — developed and maintained by AI (Claude Code)",

package/server.json

@@ -6,12 +6,12 @@
     "url": "https://github.com/chrischall/pickuppatrol-mcp",
     "source": "github"
   },
-  "version": "0.0.0",
+  "version": "0.1.1",
   "packages": [
     {
       "registryType": "npm",
       "identifier": "@chrischall/pickuppatrol-mcp",
-      "version": "0.0.0",
+      "version": "0.1.1",
       "transport": {
         "type": "stdio"
       }

package/skills/pickuppatrol-api/SKILL.md

@@ -28,6 +28,8 @@ pup_login() {
     -o /tmp/pup_auth.json -w '%{http_code}' >/tmp/pup_code
   [ "$(cat /tmp/pup_code)" = 200 ] || { jq -r '.ResponseStatus.Message' /tmp/pup_auth.json >&2; return 1; }
   export PUP_JAR="$jar"
+  # This deployment returns cookies only — BearerToken comes back null. The
+  # JWT path exists server-side, so keep a token if one ever appears.
   PUP_TOKEN=$(jq -r '.BearerToken // empty' /tmp/pup_auth.json); export PUP_TOKEN
 }
 
@@ -60,6 +62,8 @@ pup GET GetChildren | jq '.[] | select(.StudentId==1050046) | .DefaultPlans
 pup GET "GetTransportations?SchoolId=1703" | jq -r '.[] | select(.IsActive)
   | "\(.TransportationId)\t\(.Name)\tnote=\(.IsNoteRequired)\tcar=\(.UseCarNumbers)\tearly=\(.IsEarlyDismissal)"'
 
+# GetPlanEdit returns the date's OVERRIDE, not the effective plan: a date with
+# no specific plan reads back null even when a weekday default exists.
 pup GET "GetPlanEdit?PlanDate=2026-08-17&StudentId=1050046" | jq '{TransportationName,Note,IsLocked}'
 pup GET "GetInvalidPlanDates?SchoolId=1703" | jq 'length'   # non-school days
 ```
@@ -103,5 +107,8 @@ A 2xx is not proof. The school silently ignores a change past its cutoff time.
 pup GET "GetPlanEdit?PlanDate=2026-08-17&StudentId=1050046" | jq '.TransportationId'
 ```
 
-Compare `TransportationId` — **not** `ModifiedDate`, which advances on its own
-and would make every write look successful.
+Compare `TransportationId` **and `Note`** — never `ModifiedDate`, which advances
+on its own and would make every write look successful. The note matters: every
+option seen so far is `IsNoteRequired`, so a note-only edit is ordinary, and an
+id-only comparison would pass without observing it. After *clearing* a date,
+expect `null` — not the weekday default.

package/skills/pickuppatrol-api/references/api.md

@@ -6,8 +6,9 @@ token value is recorded.
 
 - Base: `https://app.pickuppatrol.net/api/json/reply/<DtoName>`
 - GET args on the query string; POST/PUT/PATCH args in a JSON body
-- Auth: session cookies from `Authenticate`, plus `Authorization: Bearer <jwt>`
-  when the deployment issues one
+- Auth: session cookies from `Authenticate` (`ss-id`, `ss-pid`, `ss-opt`). This
+  deployment returns `BearerToken: null`; send `Authorization: Bearer …` too if
+  one ever appears
 - Errors: ServiceStack `{"ResponseStatus":{"ErrorCode","Message","Errors":[…]}}`;
   an unauthenticated call to any authorised DTO is a bare `401`
 
@@ -21,7 +22,8 @@ curl -sS -c jar -X POST "$PUP/Authenticate" -H 'Content-Type: application/json'
 ```
 
 Response: `{UserId, SessionId, UserName, DisplayName, BearerToken, RefreshToken,
-Roles, Permissions, ResponseStatus}`.
+Roles, Permissions, ResponseStatus}` — `BearerToken` and `RefreshToken` come
+back null here; the session is the cookies.
 
 Two-factor accounts (`User.OtpTypeId` set) need `POST /CreateOtp {OtpTypeId}`
 then `PUT /VerifyOtp {Otp, RememberMe}`. Token refresh is
@@ -85,6 +87,11 @@ TransportationName SchoolName BusRouteUrl ValidationErrors EarlyDismissalTime
 CarNumber LimitedIds IsNotePrivate
 ```
 
+Returns the date's **override**, not the effective plan: a date with no specific
+plan reads back `TransportationId: null` even when the student has a weekly
+default for that weekday. Merge with `GetStudent(...).DefaultPlans` yourself to
+know what actually happens on a date.
+
 ## Write DTOs
 
 | DTO | Verb | Body |
@@ -159,10 +166,16 @@ dropped field is a field cleared.
 
 ## Verifying a write
 
-Re-read and compare the field that proves the change:
+Re-read and compare the fields that prove the change — the transportation id
+**and the note**. Every option seen so far is `IsNoteRequired`, so a note-only
+edit is an ordinary change and an id-only comparison would pass without ever
+observing it.
+
+- one-off plan → `GetPlanEdit(PlanDate, StudentId)` → `.TransportationId`, `.Note`
+- weekly defaults → `GetStudent(StudentId).DefaultPlans[]` → `.TransportationId`, `.Note`
 
-- one-off plan → `GetPlanEdit(PlanDate, StudentId).TransportationId`
-- weekly defaults → `GetStudent(StudentId).DefaultPlans[].TransportationId`
+After *clearing* a date, expect `TransportationId: null` — not the weekday
+default, which `GetPlanEdit` does not merge in.
 
 Exclude `ModifiedDate` and `DefaultsModifiedDate`: they advance on their own, so
 including them makes every write look successful.