@chorus-aidlc/chorus 0.8.2 → 0.9.1

package/.next/standalone/public/chorus-plugin/bin/tests/test-on-post-verify-task.sh

@@ -12,7 +12,11 @@
 # hook into a sandbox dir alongside our shim wrapper — the hook's
 # `dirname "$0"` lookup then picks up our shim, not the real wrapper.
 #
-# Fixtures cover all gating branches:
+# Two independent reminder branches share the post-verify trigger:
+#   - Branch A (OpenSpec archive trigger) — emits `openspec archive`
+#   - Branch B (Idea-completion report)   — emits `create idea-completion report`
+#
+# Fixtures for Branch A (legacy):
 #   positive       — last task verified, slug present, openspec/ folder + CLI both present
 #                    -> stdout MUST contain `openspec archive my-feature`
 #   not-last-task  — slug present, both signals present, but one task still in_progress
@@ -26,6 +30,30 @@
 #   mode-off       — CHORUS_OPENSPEC_MODE=off (explicit opt-out), even with both signals present
 #                    -> stdout MUST NOT contain `openspec archive`
 #
+# Fixtures for Branch B (idea-completion report — see spec
+# idea-completion-report scenarios "Hook injects a reminder ..."):
+#   report-positive    — idea-rooted proposal, all its tasks are
+#                        done|closed, no report Document on this proposal
+#                        -> stdout MUST contain `create idea-completion report`
+#   report-existing    — same as report-positive but a `type=report`
+#                        Document already exists on this proposal
+#                        -> stdout MUST NOT contain `create idea-completion report`
+#   report-not-last    — idea-rooted, but one task is still in_progress
+#                        -> stdout MUST NOT contain `create idea-completion report`
+#   report-quick-task  — proposal's inputType is not "idea" (e.g. a
+#                        non-idea-rooted proposal); branch B must skip
+#                        regardless of task status
+#                        -> stdout MUST NOT contain `create idea-completion report`
+#   report-task-overflow — chorus_list_tasks returns total > tasks.length
+#                          (page-1 of a wider task set, all returned tasks
+#                          are done but more remain). Hook MUST refuse to
+#                          conclude "all done" — silent skip.
+#                          -> stdout MUST NOT contain `create idea-completion report`
+#   report-doc-overflow  — chorus_get_documents returns total > documents.length
+#                          (existing report sits on a later page). Hook MUST
+#                          refuse to conclude "no report" — silent skip.
+#                          -> stdout MUST NOT contain `create idea-completion report`
+#
 # All fixtures must end with exit 0.
 #
 # Bash 3.2 compatible. Run:
@@ -90,11 +118,18 @@ case "$cmd" in
       mode-off|no-folder|no-cli) fixture=positive ;;
     esac
     case "${fixture}:${tool}" in
+      # ----- Branch A fixtures (existing) -----
+      # NOTE: Branch B's idea-rooted check requires `inputType:"idea"`. We
+      # set it on the OpenSpec fixtures too because real proposals always
+      # carry inputType. To keep Branch A fixtures independent of Branch B,
+      # we deliberately DO NOT register chorus_get_proposals /
+      # chorus_get_documents responses for them — Branch B hits the default
+      # "unhandled" case (empty body) and silent-skips.
       positive:chorus_get_task)
         echo '{"uuid":"task-3","title":"Task 3","status":"done","proposalUuid":"prop-1","project":{"uuid":"proj-1","name":"P"}}'
         ;;
       positive:chorus_get_proposal)
-        printf '%s' '{"uuid":"prop-1","title":"P1","description":"Some intro line.\nOpenSpec change slug: my-feature\nMore body.","inputUuids":["idea-1"]}'
+        printf '%s' '{"uuid":"prop-1","title":"P1","description":"Some intro line.\nOpenSpec change slug: my-feature\nMore body.","inputType":"idea","inputUuids":["idea-1"]}'
         ;;
       positive:chorus_list_tasks)
         echo '{"tasks":[{"uuid":"task-1","status":"done"},{"uuid":"task-2","status":"done"},{"uuid":"task-3","status":"done"}],"total":3,"page":1,"pageSize":200}'
@@ -103,7 +138,7 @@ case "$cmd" in
         echo '{"uuid":"task-2","title":"Task 2","status":"done","proposalUuid":"prop-1","project":{"uuid":"proj-1","name":"P"}}'
         ;;
       not-last-task:chorus_get_proposal)
-        printf '%s' '{"uuid":"prop-1","title":"P1","description":"Intro.\nOpenSpec change slug: my-feature\nMore.","inputUuids":["idea-1"]}'
+        printf '%s' '{"uuid":"prop-1","title":"P1","description":"Intro.\nOpenSpec change slug: my-feature\nMore.","inputType":"idea","inputUuids":["idea-1"]}'
         ;;
       not-last-task:chorus_list_tasks)
         echo '{"tasks":[{"uuid":"task-1","status":"done"},{"uuid":"task-2","status":"done"},{"uuid":"task-3","status":"in_progress"}],"total":3,"page":1,"pageSize":200}'
@@ -112,11 +147,104 @@ case "$cmd" in
         echo '{"uuid":"task-3","title":"Task 3","status":"done","proposalUuid":"prop-2","project":{"uuid":"proj-1","name":"P"}}'
         ;;
       no-slug:chorus_get_proposal)
-        printf '%s' '{"uuid":"prop-2","title":"P2","description":"Free-form proposal description with no slug marker.","inputUuids":["idea-2"]}'
+        printf '%s' '{"uuid":"prop-2","title":"P2","description":"Free-form proposal description with no slug marker.","inputType":"idea","inputUuids":["idea-2"]}'
         ;;
       no-slug:chorus_list_tasks)
         echo '{"tasks":[{"uuid":"task-1","status":"done"},{"uuid":"task-2","status":"done"},{"uuid":"task-3","status":"done"}],"total":3,"page":1,"pageSize":200}'
         ;;
+
+      # ----- Branch B fixtures (idea-completion report reminder) -----
+      # report-positive: idea-rooted proposal whose tasks are all
+      # done|closed, no report Document on it -> emit.
+      report-positive:chorus_get_task)
+        echo '{"uuid":"task-9","title":"Task 9","status":"done","proposalUuid":"prop-9","project":{"uuid":"proj-1","name":"P"}}'
+        ;;
+      report-positive:chorus_get_proposal)
+        printf '%s' '{"uuid":"prop-9","title":"P9","description":"Free-form proposal — no OpenSpec slug here.","inputType":"idea","inputUuids":["idea-9"]}'
+        ;;
+      report-positive:chorus_list_tasks)
+        echo '{"tasks":[{"uuid":"task-7","status":"done","proposalUuid":"prop-9"},{"uuid":"task-8","status":"closed","proposalUuid":"prop-9"},{"uuid":"task-9","status":"done","proposalUuid":"prop-9"}],"total":3,"page":1,"pageSize":200}'
+        ;;
+      report-positive:chorus_get_documents)
+        echo '{"documents":[],"total":0,"page":1,"pageSize":200}'
+        ;;
+
+      # report-existing: same as positive but a report Document already
+      # exists on this proposal -> silent skip.
+      report-existing:chorus_get_task)
+        echo '{"uuid":"task-9","title":"Task 9","status":"done","proposalUuid":"prop-9","project":{"uuid":"proj-1","name":"P"}}'
+        ;;
+      report-existing:chorus_get_proposal)
+        printf '%s' '{"uuid":"prop-9","title":"P9","description":"Free-form proposal.","inputType":"idea","inputUuids":["idea-9"]}'
+        ;;
+      report-existing:chorus_list_tasks)
+        echo '{"tasks":[{"uuid":"task-7","status":"done","proposalUuid":"prop-9"},{"uuid":"task-8","status":"closed","proposalUuid":"prop-9"},{"uuid":"task-9","status":"done","proposalUuid":"prop-9"}],"total":3,"page":1,"pageSize":200}'
+        ;;
+      report-existing:chorus_get_documents)
+        echo '{"documents":[{"uuid":"doc-r1","type":"report","title":"Idea 9 — completion report","proposalUuid":"prop-9"}],"total":1,"page":1,"pageSize":200}'
+        ;;
+
+      # report-not-last: a task is still in_progress -> silent skip.
+      report-not-last:chorus_get_task)
+        echo '{"uuid":"task-9","title":"Task 9","status":"done","proposalUuid":"prop-9","project":{"uuid":"proj-1","name":"P"}}'
+        ;;
+      report-not-last:chorus_get_proposal)
+        printf '%s' '{"uuid":"prop-9","title":"P9","description":"Free-form proposal.","inputType":"idea","inputUuids":["idea-9"]}'
+        ;;
+      report-not-last:chorus_list_tasks)
+        echo '{"tasks":[{"uuid":"task-7","status":"done","proposalUuid":"prop-9"},{"uuid":"task-8","status":"in_progress","proposalUuid":"prop-9"},{"uuid":"task-9","status":"done","proposalUuid":"prop-9"}],"total":3,"page":1,"pageSize":200}'
+        ;;
+      report-not-last:chorus_get_documents)
+        echo '{"documents":[],"total":0,"page":1,"pageSize":200}'
+        ;;
+
+      # report-quick-task: proposal.inputType != "idea" -> Branch B must
+      # skip at the first gate, before any further calls.
+      report-quick-task:chorus_get_task)
+        echo '{"uuid":"task-9","title":"Task 9","status":"done","proposalUuid":"prop-9","project":{"uuid":"proj-1","name":"P"}}'
+        ;;
+      report-quick-task:chorus_get_proposal)
+        printf '%s' '{"uuid":"prop-9","title":"P9","description":"Free-form proposal.","inputType":"manual","inputUuids":[]}'
+        ;;
+      report-quick-task:chorus_list_tasks)
+        echo '{"tasks":[{"uuid":"task-9","status":"done","proposalUuid":"prop-9"}],"total":1,"page":1,"pageSize":200}'
+        ;;
+      report-quick-task:chorus_get_documents)
+        echo '{"documents":[],"total":0,"page":1,"pageSize":200}'
+        ;;
+
+      # report-task-overflow: chorus_list_tasks returns 5 done tasks but
+      # total=25 — more tasks exist on later pages. Hook MUST refuse to
+      # conclude "all done" and silent-skip Branch B.
+      report-task-overflow:chorus_get_task)
+        echo '{"uuid":"task-9","title":"Task 9","status":"done","proposalUuid":"prop-9","project":{"uuid":"proj-1","name":"P"}}'
+        ;;
+      report-task-overflow:chorus_get_proposal)
+        printf '%s' '{"uuid":"prop-9","title":"P9","description":"Free-form proposal.","inputType":"idea","inputUuids":["idea-9"]}'
+        ;;
+      report-task-overflow:chorus_list_tasks)
+        echo '{"tasks":[{"uuid":"t1","status":"done","proposalUuid":"prop-9"},{"uuid":"t2","status":"done","proposalUuid":"prop-9"},{"uuid":"t3","status":"done","proposalUuid":"prop-9"},{"uuid":"t4","status":"done","proposalUuid":"prop-9"},{"uuid":"t5","status":"done","proposalUuid":"prop-9"}],"total":25,"page":1,"pageSize":200}'
+        ;;
+      report-task-overflow:chorus_get_documents)
+        echo '{"documents":[],"total":0,"page":1,"pageSize":200}'
+        ;;
+
+      # report-doc-overflow: chorus_get_documents returns 1 unrelated
+      # report but total=25 — this proposal's existing report sits on a
+      # later page. Hook MUST refuse to conclude "no report" and silent-skip.
+      report-doc-overflow:chorus_get_task)
+        echo '{"uuid":"task-9","title":"Task 9","status":"done","proposalUuid":"prop-9","project":{"uuid":"proj-1","name":"P"}}'
+        ;;
+      report-doc-overflow:chorus_get_proposal)
+        printf '%s' '{"uuid":"prop-9","title":"P9","description":"Free-form proposal.","inputType":"idea","inputUuids":["idea-9"]}'
+        ;;
+      report-doc-overflow:chorus_list_tasks)
+        echo '{"tasks":[{"uuid":"task-7","status":"done","proposalUuid":"prop-9"},{"uuid":"task-8","status":"closed","proposalUuid":"prop-9"},{"uuid":"task-9","status":"done","proposalUuid":"prop-9"}],"total":3,"page":1,"pageSize":200}'
+        ;;
+      report-doc-overflow:chorus_get_documents)
+        echo '{"documents":[{"uuid":"doc-other","type":"report","title":"Some other report","proposalUuid":"prop-OTHER"}],"total":25,"page":1,"pageSize":200}'
+        ;;
+
       *)
         # Unhandled (tool, fixture) — return empty, hook should silent-skip.
         echo ""
@@ -153,11 +281,12 @@ case "$fixture" in
   mode-off|no-folder|no-cli) fixture=positive ;;
 esac
 case "${fixture}:${tool}" in
+  # ----- Branch A fixtures (existing) -----
   positive:chorus_get_task)
     echo '{"uuid":"task-3","title":"Task 3","status":"done","proposalUuid":"prop-1","project":{"uuid":"proj-1","name":"P"}}'
     ;;
   positive:chorus_get_proposal)
-    printf '%s' '{"uuid":"prop-1","title":"P1","description":"Some intro line.\nOpenSpec change slug: my-feature\nMore body.","inputUuids":["idea-1"]}'
+    printf '%s' '{"uuid":"prop-1","title":"P1","description":"Some intro line.\nOpenSpec change slug: my-feature\nMore body.","inputType":"idea","inputUuids":["idea-1"]}'
     ;;
   positive:chorus_list_tasks)
     echo '{"tasks":[{"uuid":"task-1","status":"done"},{"uuid":"task-2","status":"done"},{"uuid":"task-3","status":"done"}],"total":3,"page":1,"pageSize":200}'
@@ -166,7 +295,7 @@ case "${fixture}:${tool}" in
     echo '{"uuid":"task-2","title":"Task 2","status":"done","proposalUuid":"prop-1","project":{"uuid":"proj-1","name":"P"}}'
     ;;
   not-last-task:chorus_get_proposal)
-    printf '%s' '{"uuid":"prop-1","title":"P1","description":"Intro.\nOpenSpec change slug: my-feature\nMore.","inputUuids":["idea-1"]}'
+    printf '%s' '{"uuid":"prop-1","title":"P1","description":"Intro.\nOpenSpec change slug: my-feature\nMore.","inputType":"idea","inputUuids":["idea-1"]}'
     ;;
   not-last-task:chorus_list_tasks)
     echo '{"tasks":[{"uuid":"task-1","status":"done"},{"uuid":"task-2","status":"done"},{"uuid":"task-3","status":"in_progress"}],"total":3,"page":1,"pageSize":200}'
@@ -175,11 +304,93 @@ case "${fixture}:${tool}" in
     echo '{"uuid":"task-3","title":"Task 3","status":"done","proposalUuid":"prop-2","project":{"uuid":"proj-1","name":"P"}}'
     ;;
   no-slug:chorus_get_proposal)
-    printf '%s' '{"uuid":"prop-2","title":"P2","description":"Free-form proposal description with no slug marker.","inputUuids":["idea-2"]}'
+    printf '%s' '{"uuid":"prop-2","title":"P2","description":"Free-form proposal description with no slug marker.","inputType":"idea","inputUuids":["idea-2"]}'
     ;;
   no-slug:chorus_list_tasks)
     echo '{"tasks":[{"uuid":"task-1","status":"done"},{"uuid":"task-2","status":"done"},{"uuid":"task-3","status":"done"}],"total":3,"page":1,"pageSize":200}'
     ;;
+
+  # ----- Branch B fixtures (idea-completion report reminder) -----
+  report-positive:chorus_get_task)
+    echo '{"uuid":"task-9","title":"Task 9","status":"done","proposalUuid":"prop-9","project":{"uuid":"proj-1","name":"P"}}'
+    ;;
+  report-positive:chorus_get_proposal)
+    printf '%s' '{"uuid":"prop-9","title":"P9","description":"Free-form proposal — no OpenSpec slug here.","inputType":"idea","inputUuids":["idea-9"]}'
+    ;;
+  report-positive:chorus_list_tasks)
+    echo '{"tasks":[{"uuid":"task-7","status":"done","proposalUuid":"prop-9"},{"uuid":"task-8","status":"closed","proposalUuid":"prop-9"},{"uuid":"task-9","status":"done","proposalUuid":"prop-9"}],"total":3,"page":1,"pageSize":200}'
+    ;;
+  report-positive:chorus_get_documents)
+    echo '{"documents":[],"total":0,"page":1,"pageSize":200}'
+    ;;
+
+  report-existing:chorus_get_task)
+    echo '{"uuid":"task-9","title":"Task 9","status":"done","proposalUuid":"prop-9","project":{"uuid":"proj-1","name":"P"}}'
+    ;;
+  report-existing:chorus_get_proposal)
+    printf '%s' '{"uuid":"prop-9","title":"P9","description":"Free-form proposal.","inputType":"idea","inputUuids":["idea-9"]}'
+    ;;
+  report-existing:chorus_list_tasks)
+    echo '{"tasks":[{"uuid":"task-7","status":"done","proposalUuid":"prop-9"},{"uuid":"task-8","status":"closed","proposalUuid":"prop-9"},{"uuid":"task-9","status":"done","proposalUuid":"prop-9"}],"total":3,"page":1,"pageSize":200}'
+    ;;
+  report-existing:chorus_get_documents)
+    echo '{"documents":[{"uuid":"doc-r1","type":"report","title":"Idea 9 — completion report","proposalUuid":"prop-9"}],"total":1,"page":1,"pageSize":200}'
+    ;;
+
+  report-not-last:chorus_get_task)
+    echo '{"uuid":"task-9","title":"Task 9","status":"done","proposalUuid":"prop-9","project":{"uuid":"proj-1","name":"P"}}'
+    ;;
+  report-not-last:chorus_get_proposal)
+    printf '%s' '{"uuid":"prop-9","title":"P9","description":"Free-form proposal.","inputType":"idea","inputUuids":["idea-9"]}'
+    ;;
+  report-not-last:chorus_list_tasks)
+    echo '{"tasks":[{"uuid":"task-7","status":"done","proposalUuid":"prop-9"},{"uuid":"task-8","status":"in_progress","proposalUuid":"prop-9"},{"uuid":"task-9","status":"done","proposalUuid":"prop-9"}],"total":3,"page":1,"pageSize":200}'
+    ;;
+  report-not-last:chorus_get_documents)
+    echo '{"documents":[],"total":0,"page":1,"pageSize":200}'
+    ;;
+
+  report-quick-task:chorus_get_task)
+    echo '{"uuid":"task-9","title":"Task 9","status":"done","proposalUuid":"prop-9","project":{"uuid":"proj-1","name":"P"}}'
+    ;;
+  report-quick-task:chorus_get_proposal)
+    printf '%s' '{"uuid":"prop-9","title":"P9","description":"Free-form proposal.","inputType":"manual","inputUuids":[]}'
+    ;;
+  report-quick-task:chorus_list_tasks)
+    echo '{"tasks":[{"uuid":"task-9","status":"done","proposalUuid":"prop-9"}],"total":1,"page":1,"pageSize":200}'
+    ;;
+  report-quick-task:chorus_get_documents)
+    echo '{"documents":[],"total":0,"page":1,"pageSize":200}'
+    ;;
+
+  # report-task-overflow: tasks total > returned -> silent skip.
+  report-task-overflow:chorus_get_task)
+    echo '{"uuid":"task-9","title":"Task 9","status":"done","proposalUuid":"prop-9","project":{"uuid":"proj-1","name":"P"}}'
+    ;;
+  report-task-overflow:chorus_get_proposal)
+    printf '%s' '{"uuid":"prop-9","title":"P9","description":"Free-form proposal.","inputType":"idea","inputUuids":["idea-9"]}'
+    ;;
+  report-task-overflow:chorus_list_tasks)
+    echo '{"tasks":[{"uuid":"t1","status":"done","proposalUuid":"prop-9"},{"uuid":"t2","status":"done","proposalUuid":"prop-9"},{"uuid":"t3","status":"done","proposalUuid":"prop-9"},{"uuid":"t4","status":"done","proposalUuid":"prop-9"},{"uuid":"t5","status":"done","proposalUuid":"prop-9"}],"total":25,"page":1,"pageSize":200}'
+    ;;
+  report-task-overflow:chorus_get_documents)
+    echo '{"documents":[],"total":0,"page":1,"pageSize":200}'
+    ;;
+
+  # report-doc-overflow: docs total > returned -> silent skip.
+  report-doc-overflow:chorus_get_task)
+    echo '{"uuid":"task-9","title":"Task 9","status":"done","proposalUuid":"prop-9","project":{"uuid":"proj-1","name":"P"}}'
+    ;;
+  report-doc-overflow:chorus_get_proposal)
+    printf '%s' '{"uuid":"prop-9","title":"P9","description":"Free-form proposal.","inputType":"idea","inputUuids":["idea-9"]}'
+    ;;
+  report-doc-overflow:chorus_list_tasks)
+    echo '{"tasks":[{"uuid":"task-7","status":"done","proposalUuid":"prop-9"},{"uuid":"task-8","status":"closed","proposalUuid":"prop-9"},{"uuid":"task-9","status":"done","proposalUuid":"prop-9"}],"total":3,"page":1,"pageSize":200}'
+    ;;
+  report-doc-overflow:chorus_get_documents)
+    echo '{"documents":[{"uuid":"doc-other","type":"report","title":"Some other report","proposalUuid":"prop-OTHER"}],"total":25,"page":1,"pageSize":200}'
+    ;;
+
   *)
     echo "" ;;
 esac
@@ -203,16 +414,20 @@ EVENT_JSON='{"tool_name":"chorus_admin_verify_task","tool_input":{"taskUuid":"ta
 
 # ----- Test runner -----
 
-# Args: name fixture variant expected_substring should_contain
+# Args: name fixture variant assertion_mode expected_substring forbidden_substring
 # variant in {claude, codex}
-# should_contain: "yes" -> stdout MUST contain expected_substring
-# should_contain: "no"  -> stdout MUST NOT contain "openspec archive"
+# assertion_mode:
+#   "must-contain"  -> stdout MUST contain $expected_substring
+#   "must-not-contain" -> stdout MUST NOT contain $forbidden_substring
+# (For Branch B fixtures, $forbidden_substring is `create idea-completion report`.
+#  For Branch A "no" fixtures, $forbidden_substring is `openspec archive`.)
 run_one() {
   local name="$1"
   local fixture="$2"
   local variant="$3"
-  local should_contain="$4"
+  local assertion_mode="$4"
   local expected="$5"
+  local forbidden="${6:-openspec archive}"
 
   local hook_dir
   if [ "$variant" = "claude" ]; then
@@ -292,7 +507,7 @@ run_one() {
   stdout=$(cat "$stdout_file")
   rm -f "$stdout_file" "$stderr_file"
 
-  if [ "$should_contain" = "yes" ]; then
+  if [ "$assertion_mode" = "must-contain" ]; then
     if printf '%s' "$stdout" | grep -q "$expected"; then
       echo "  PASS  $name [$variant]"
       PASS=$((PASS + 1))
@@ -303,9 +518,9 @@ run_one() {
       FAILED="$FAILED $name[$variant]"
     fi
   else
-    # should_contain == "no": archive reminder MUST be absent.
-    if printf '%s' "$stdout" | grep -q "openspec archive"; then
-      echo "  FAIL  $name [$variant]: stdout unexpectedly contains 'openspec archive'"
+    # must-not-contain: $forbidden MUST be absent.
+    if printf '%s' "$stdout" | grep -q "$forbidden"; then
+      echo "  FAIL  $name [$variant]: stdout unexpectedly contains '$forbidden'"
       printf '%s\n' "$stdout" | sed 's/^/         /'
       FAIL=$((FAIL + 1))
       FAILED="$FAILED $name[$variant]"
@@ -319,41 +534,78 @@ run_one() {
 echo "Sandbox: $SANDBOX"
 echo ""
 
-# ----- Branch 1: positive (slug + last task + CLI) -----
-run_one "positive"      "positive"      "claude" "yes" "openspec archive my-feature"
-run_one "positive"      "positive"      "codex"  "yes" "openspec archive my-feature"
-
-# ----- Branch 2: not-last-task -----
-run_one "not-last-task" "not-last-task" "claude" "no"  ""
-run_one "not-last-task" "not-last-task" "codex"  "no"  ""
-
-# ----- Branch 3: no-slug (free-form proposal) -----
-run_one "no-slug"       "no-slug"       "claude" "no"  ""
-run_one "no-slug"       "no-slug"       "codex"  "no"  ""
-
-# ----- Branch 4: no-cli (folder present, CLI absent) -----
-# Strip $SANDBOX/bin from PATH so `command -v openspec` fails. Folder is
-# still there in $SANDBOX/project/openspec. Hook must short-circuit at
-# step 4 (CLI gate) and emit no archive reminder.
-run_one "no-cli"        "no-cli"        "claude" "no"  ""
-run_one "no-cli"        "no-cli"        "codex"  "no"  ""
-
-# ----- Branch 5: no-folder (CLI present, folder absent) -----
-# CLAUDE_PROJECT_DIR points at $SANDBOX (no openspec/ dir there). Hook
-# must short-circuit at step 4 (folder gate) before trying any MCP calls.
-# We don't actually exercise any MCP fixture here — the hook should bail
-# before reaching the wrappers. We pass "positive" only because the
-# unhandled-fixture branch in the shim returns an empty body and the hook
-# would then silent-skip on get_task. Either way the assertion ("no
-# archive reminder") holds.
-run_one "no-folder"     "no-folder"     "claude" "no"  ""
-run_one "no-folder"     "no-folder"     "codex"  "no"  ""
-
-# ----- Branch 6: mode-off (explicit opt-out via env) -----
-# Both folder and CLI are present, but CHORUS_OPENSPEC_MODE=off. Hook
-# must honor the opt-out and exit silently.
-run_one "mode-off"      "mode-off"      "claude" "no"  ""
-run_one "mode-off"      "mode-off"      "codex"  "no"  ""
+# ===== Branch A: OpenSpec archive trigger fixtures =====
+# (assertion: must-contain `openspec archive my-feature` / must-not-contain `openspec archive`)
+
+# A1: positive (slug + last task + CLI)
+run_one "positive"      "positive"      "claude" "must-contain" "openspec archive my-feature"
+run_one "positive"      "positive"      "codex"  "must-contain" "openspec archive my-feature"
+
+# A2: not-last-task
+run_one "not-last-task" "not-last-task" "claude" "must-not-contain" "" "openspec archive"
+run_one "not-last-task" "not-last-task" "codex"  "must-not-contain" "" "openspec archive"
+
+# A3: no-slug (free-form proposal)
+run_one "no-slug"       "no-slug"       "claude" "must-not-contain" "" "openspec archive"
+run_one "no-slug"       "no-slug"       "codex"  "must-not-contain" "" "openspec archive"
+
+# A4: no-cli (folder present, CLI absent). Strip $SANDBOX/bin from PATH
+# so `command -v openspec` fails. Folder is still there in
+# $SANDBOX/project/openspec. Hook must short-circuit at the CLI gate.
+run_one "no-cli"        "no-cli"        "claude" "must-not-contain" "" "openspec archive"
+run_one "no-cli"        "no-cli"        "codex"  "must-not-contain" "" "openspec archive"
+
+# A5: no-folder (CLI present, folder absent). CLAUDE_PROJECT_DIR points
+# at $SANDBOX (no openspec/ dir there). Hook must short-circuit at the
+# folder gate before reaching any MCP call.
+run_one "no-folder"     "no-folder"     "claude" "must-not-contain" "" "openspec archive"
+run_one "no-folder"     "no-folder"     "codex"  "must-not-contain" "" "openspec archive"
+
+# A6: mode-off (explicit opt-out via env). Both folder and CLI are
+# present, but CHORUS_OPENSPEC_MODE=off. Hook must honor the opt-out.
+run_one "mode-off"      "mode-off"      "claude" "must-not-contain" "" "openspec archive"
+run_one "mode-off"      "mode-off"      "codex"  "must-not-contain" "" "openspec archive"
+
+# ===== Branch B: Idea-completion report reminder fixtures =====
+# (assertion: must-contain `create idea-completion report` /
+#  must-not-contain `create idea-completion report`)
+# These fixtures all use a non-OpenSpec proposal description (no slug
+# line), so Branch A silent-skips. The PATH still has the fake openspec
+# CLI and the synthetic project dir still has openspec/ so Branch A's
+# folder/CLI gates pass — the slug gate is what blocks Branch A here,
+# isolating the assertion to Branch B's behavior.
+
+# B1: report-positive — last task of an Idea verified, no report
+# Document yet -> reminder MUST fire.
+run_one "report-positive"   "report-positive"   "claude" "must-contain" "create idea-completion report"
+run_one "report-positive"   "report-positive"   "codex"  "must-contain" "create idea-completion report"
+
+# B2: report-existing — same conditions but a report Document already
+# exists for the Idea -> reminder MUST be silent.
+run_one "report-existing"   "report-existing"   "claude" "must-not-contain" "" "create idea-completion report"
+run_one "report-existing"   "report-existing"   "codex"  "must-not-contain" "" "create idea-completion report"
+
+# B3: report-not-last — at least one task is still in_progress
+# (non-terminal) -> reminder MUST be silent.
+run_one "report-not-last"   "report-not-last"   "claude" "must-not-contain" "" "create idea-completion report"
+run_one "report-not-last"   "report-not-last"   "codex"  "must-not-contain" "" "create idea-completion report"
+
+# B4: report-quick-task — proposal.inputType != "idea" (e.g. a
+# manually-created proposal) -> reminder MUST be silent at first gate.
+run_one "report-quick-task" "report-quick-task" "claude" "must-not-contain" "" "create idea-completion report"
+run_one "report-quick-task" "report-quick-task" "codex"  "must-not-contain" "" "create idea-completion report"
+
+# B5: report-task-overflow — chorus_list_tasks total > returned (more
+# tasks remain on later pages). Hook must refuse to assume "all done"
+# and silent-skip Branch B.
+run_one "report-task-overflow" "report-task-overflow" "claude" "must-not-contain" "" "create idea-completion report"
+run_one "report-task-overflow" "report-task-overflow" "codex"  "must-not-contain" "" "create idea-completion report"
+
+# B6: report-doc-overflow — chorus_get_documents total > returned (the
+# proposal's existing report could be on a later page). Hook must refuse
+# to assume "no report" and silent-skip Branch B.
+run_one "report-doc-overflow" "report-doc-overflow" "claude" "must-not-contain" "" "create idea-completion report"
+run_one "report-doc-overflow" "report-doc-overflow" "codex"  "must-not-contain" "" "create idea-completion report"
 
 echo ""
 echo "Results: $PASS passed, $FAIL failed"

package/.next/standalone/public/chorus-plugin/skills/brainstorm/SKILL.md

@@ -0,0 +1,166 @@
+---
+name: brainstorm
+description: Optional divergent-then-convergent dialogue for fuzzy ideas. Invoked from the idea skill as a prelude to structured elaboration; produces one ElaborationRound of decision-point Q&A and returns control. Never writes files, never posts comments, never validates elaboration.
+license: AGPL-3.0
+metadata:
+  author: chorus
+  version: "0.9.0"
+  category: project-management
+  mcp_server: chorus
+---
+
+# Brainstorm Skill
+
+A divergent-then-convergent dialogue cadence for ideas whose direction is still being formed. Compresses the conversation into one `ElaborationRound` of decision-point Q&A — same shape as a structured elaboration round, but the questions, options and answers are synthesized at the end of the conversation rather than asked up front.
+
+This skill is a **producer** of one elaboration round; the **scheduler** decision (validate vs. follow-up) belongs to the calling idea skill.
+
+---
+
+## When invoked
+
+Only as a sub-step of the idea skill, only after the user has explicitly opted in via `AskUserQuestion`. Never run standalone, never run without user opt-in. The expected entry point is the idea skill's "Step 4.5: Brainstorm Mode (Optional Prelude)" — see the idea skill for the surrounding flow.
+
+---
+
+## Hard rules
+
+1. **One question at a time.** Each `AskUserQuestion` call MUST contain exactly one question entry. Wait for the answer before asking the next.
+2. **Multi-choice preferred.** Frame each question as 2-4 options where possible. Open-ended is acceptable when options would be premature, but lean toward concrete choices.
+3. **Propose 2-3 directions before stopping divergence.** Once the requirement direction is clear enough to enumerate, present 2-3 distinct approaches in a single `AskUserQuestion`. Mark exactly one as the recommended option per the host tool's `AskUserQuestion` recommendation convention (the spec does not dictate a specific marking format — follow the tool's documentation).
+4. **Explicit user approval required to exit divergence.** Do NOT proceed to synthesis until the user has selected one of the proposed directions.
+5. **No files written.** Do NOT write any markdown, design doc, scratch file, or any other file to disk. The conversation produces an `ElaborationRound` and nothing else on disk.
+6. **No comments posted.** Do NOT call `chorus_add_comment` from this skill. Comments belong to the idea skill or the user, not to the brainstorm step.
+7. **No design-doc handoff.** Do NOT invoke `writing-plans`, `writing-skills`, or any skill whose purpose is to produce a design document. The brainstorm output is the synthesized round — there is no separate doc.
+8. **No `validate_elaboration` call.** Do NOT call `chorus_pm_validate_elaboration` from this skill. Whether to validate (resolve elaboration) or follow up (issues + followUpQuestions) is the calling idea skill's decision, not this skill's.
+
+---
+
+## Step-by-step
+
+### 1. Gather context
+
+Before asking the first divergent question, read the idea and surrounding project state. Mirror the idea skill's gather-context list:
+
+```
+chorus_get_idea({ ideaUuid })
+chorus_get_documents({ projectUuid })
+chorus_get_document({ documentUuid })   # for any document worth reading in full
+chorus_get_proposals({ projectUuid, status: "approved" })   # to understand patterns
+chorus_list_tasks({ projectUuid })   # to avoid duplicating existing work
+chorus_get_comments({ targetType: "idea", targetUuid: ideaUuid })
+```
+
+Skim each result for: stated background, stated requirements, stated constraints, and what is conspicuously NOT stated. The gaps are the questions worth asking.
+
+### 2. Divergent Q&A
+
+Ask one question at a time via `AskUserQuestion`. Aim to surface:
+
+- The **goal** the idea is trying to serve (often more abstract than the idea statement).
+- The **constraints** that exclude entire branches of solution space (deadlines, compatibility, scope).
+- The **success criteria** — how will the user know this is done.
+
+Keep each question single-purpose. If you need to ask three things, that is three rounds, not one combined `AskUserQuestion`.
+
+### 3. Propose 2-3 directions
+
+When the goal, constraints, and success criteria are clear enough that you can name distinct approaches, present them in a single `AskUserQuestion`:
+
+```
+AskUserQuestion({
+  questions: [
+    {
+      question: "<the convergence question>",
+      header: "<short header>",
+      options: [
+        { label: "Option A (Recommended)", description: "<what + tradeoff>" },
+        { label: "Option B", description: "<what + tradeoff>" },
+        { label: "Option C", description: "<what + tradeoff>" }
+      ],
+      multiSelect: false
+    }
+  ]
+})
+```
+
+The recommendation must be visibly marked to the user using the host tool's `AskUserQuestion` convention. State **why** you recommend it — usually a sentence about the dominant tradeoff.
+
+### 4. Wait for explicit approval
+
+Do not proceed to synthesis if the user has not selected one of the options. If the user picks "Other" with free text, treat that as a new constraint — go back to step 2 or step 3 with the refined direction.
+
+### 5. Synthesize decision-point Q&A
+
+For each material decision the user made during the conversation, build one `ElaborationQuestion`. A "material decision" is a moment where the user chose between alternatives or set scope explicitly. Map each decision per the synthesis spec below.
+
+### 6. Persist the round
+
+Call `chorus_pm_start_elaboration` with the synthesized questions:
+
+```
+chorus_pm_start_elaboration({
+  ideaUuid,
+  depth: "standard",
+  questions: [
+    { id: "q1", text: "...", category: "...", options: [...] },
+    ...
+  ]
+})
+```
+
+Then submit the answers in one call:
+
+```
+chorus_answer_elaboration({
+  ideaUuid,
+  roundUuid,
+  answers: [
+    { questionId: "q1", selectedOptionId: "...", customText: "<rationale>" },
+    ...
+  ]
+})
+```
+
+### 7. Return control
+
+Stop here. Do **NOT** call `chorus_pm_validate_elaboration`. The idea skill's caller now decides:
+
+- If the synthesized round answers cover everything → caller validates with `issues: []`.
+- If gaps remain → caller validates with `issues + followUpQuestions` to start a structured Round 2.
+
+The depth of any follow-up round is the caller's call, not yours.
+
+---
+
+## Synthesis spec
+
+Each material decision becomes exactly one `ElaborationQuestion` with these fields:
+
+| Field | Source |
+|---|---|
+| `text` | The decision question, phrased neutrally. Example: "Which depth-model placement?" |
+| `category` | `functional`, `non_functional`, `business_context`, `technical_context`, `user_scenario`, or `scope` — derived from the topic. |
+| `options` | All directions that were considered, length 2-5. Collapse near-duplicates into one option. |
+| `selectedOptionId` | The id of the option the user approved. |
+| `customText` | A 1-3 sentence rationale capturing the constraint or tradeoff that drove the choice. Not a transcript dump. |
+
+Rules:
+
+- A `customText` longer than ~3 sentences is a sign you are summarizing transcript instead of capturing rationale. Cut.
+- An `options` array of length 2 with binary "yes / no" framing is a sign you pre-narrowed alternatives. Re-examine — there are usually at least three meaningfully different paths, even if two of them get rejected quickly.
+- Skip "decisions" that were never genuinely contested. If the user agreed instantly to the only proposal, that is information for the idea content, not a decision-point Q&A.
+
+---
+
+## Anti-patterns
+
+Do not do any of the following. Each has a specific failure mode that this skill must prevent:
+
+- **Single-summary `customText` blob.** Compressing the entire conversation into one ElaborationQuestion with a long markdown summary in `customText`. The schema is multi-question for a reason — preserve the decision granularity.
+- **Transcript-as-comment.** Posting the raw conversation log as a comment on the idea (or anywhere). The synthesized round IS the artifact. Raw transcripts pollute the audit trail with noise.
+- **File writes.** Writing any markdown, design doc, plan, or scratch file to disk. There is no design doc in this flow. This is a deliberate divergence from the upstream `superpowers/brainstorming` cadence — read the design.md if confused.
+- **`validate_elaboration` calls.** Closing the elaboration phase from this skill. The lifecycle decision belongs to the idea skill. Calling validate here strips the caller of its scheduler role.
+- **`writing-plans` / design-doc handoff.** Invoking any skill that produces an implementation plan or design document. The Chorus pipeline already has Proposal → Document Drafts → Task Drafts for that — the brainstorm output feeds them through ElaborationRound, not through external doc skills.
+- **Length-2 binary "yes / no" framings.** Reducing every decision to "do this thing — yes / no". Almost always the genuine alternatives are 3+ approaches with meaningfully different tradeoffs. Length-2 framings often mean the divergent phase ended too early.
+- **Asking multiple questions in one `AskUserQuestion`.** The cadence is one question per turn during divergence, then one final convergence question with 2-3 options. Combining unrelated questions is a sign you are rushing.