@chisquare-tech/origine-ngx-apps-code 0.11.1 → 0.11.2

package/fesm2022/chisquare-tech-origine-ngx-apps-code.mjs

@@ -1692,7 +1692,9 @@ function matchesPattern(pattern, branch) {
 }
 // The web editor's commit box (prototype code_file "Commit and open PR", DEV-13): a message, and
 // either the branch itself or a new branch with a pull request. A branch whose rules block direct
-// pushes only offers the second.
+// pushes only offers the second. The rules load asynchronously: until they have, nothing can be
+// committed (a quick commit straight to a protected branch was refused by the server); when they
+// cannot be loaded, the change goes to a new branch with a pull request, which any branch takes.
 class CommitBox {
     constructor() {
         this.api = inject(CodeApi);
@@ -1707,8 +1709,14 @@ class CommitBox {
         this.toNew = signal(false, ...(ngDevMode ? [{ debugName: "toNew" }] : /* istanbul ignore next */ []));
         this.newBranch = signal('', ...(ngDevMode ? [{ debugName: "newBranch" }] : /* istanbul ignore next */ []));
         this.rules = signal([], ...(ngDevMode ? [{ debugName: "rules" }] : /* istanbul ignore next */ []));
-        /** Direct commits are refused: the rules block direct pushes, or require signed commits (a browser commit is unsigned). */
-        this.blocked = computed(() => this.rules().some((r) => (r.blockDirectPush || r.requireSignedCommits) && matchesPattern(r.pattern, this.branch())), ...(ngDevMode ? [{ debugName: "blocked" }] : /* istanbul ignore next */ []));
+        /** Whether the branch's rules are known yet. */
+        this.rulesState = signal('loading', ...(ngDevMode ? [{ debugName: "rulesState" }] : /* istanbul ignore next */ []));
+        /**
+         * Direct commits are refused (or may be): the rules block direct pushes, or require signed
+         * commits (a browser commit is unsigned), or they could not be loaded.
+         */
+        this.blocked = computed(() => this.rulesState() === 'failed' || this.rules().some((r) => (r.blockDirectPush || r.requireSignedCommits) && matchesPattern(r.pattern, this.branch())), ...(ngDevMode ? [{ debugName: "blocked" }] : /* istanbul ignore next */ []));
+        this.rulesFor = null;
         effect(() => {
             const m = this.defaultMessage();
             untracked(() => this.message.set(m));
@@ -1719,20 +1727,45 @@ class CommitBox {
             if (!p || !repo)
                 return;
             untracked(() => {
-                this.api.protections(p.id, repo).subscribe({ next: (r) => this.rules.set(r), error: () => undefined });
+                this.rulesFor = { project: p.id, repo };
+                this.loadRules();
                 const me = (this.host.people().find((x) => x.id === this.host.meId())?.name || 'patch').toLowerCase().replace(/[^a-z0-9]+/g, '-').replace(/^-|-$/g, '') || 'patch';
                 this.newBranch.set(`${me}/patch-${Math.floor(Date.now() / 1000) % 100000}`);
             });
         });
     }
+    loadRules() {
+        const at = this.rulesFor;
+        if (!at)
+            return;
+        this.rulesState.set('loading');
+        this.api.protections(at.project, at.repo).subscribe({
+            next: (r) => {
+                if (this.rulesFor !== at)
+                    return;
+                this.rules.set(r);
+                this.rulesState.set('loaded');
+            },
+            error: () => {
+                if (this.rulesFor === at)
+                    this.rulesState.set('failed');
+            },
+        });
+    }
     send() {
+        if (this.rulesState() === 'loading')
+            return;
         const toNew = this.toNew() || this.blocked();
         this.commit.emit({ message: this.message().trim(), newBranch: toNew ? this.newBranch().trim() : undefined });
     }
     static { this.ɵfac = i0.ɵɵngDeclareFactory({ minVersion: "12.0.0", version: "21.2.12", ngImport: i0, type: CommitBox, deps: [], target: i0.ɵɵFactoryTarget.Component }); }
     static { this.ɵcmp = i0.ɵɵngDeclareComponent({ minVersion: "17.0.0", version: "21.2.12", type: CommitBox, isStandalone: true, selector: "o-commit-box", inputs: { repo: { classPropertyName: "repo", publicName: "repo", isSignal: true, isRequired: true, transformFunction: null }, branch: { classPropertyName: "branch", publicName: "branch", isSignal: true, isRequired: true, transformFunction: null }, defaultMessage: { classPropertyName: "defaultMessage", publicName: "defaultMessage", isSignal: true, isRequired: false, transformFunction: null }, busy: { classPropertyName: "busy", publicName: "busy", isSignal: true, isRequired: false, transformFunction: null } }, outputs: { commit: "commit", cancel: "cancel" }, ngImport: i0, template: `
     <div class="o-col" style="gap:10px" data-testid="commit-box">
-      @if (blocked()) {<div class="o-note o-blu">Your change is committed to a new branch with a pull request because <b>{{ branch() }}</b> is protected.</div>}
+      @switch (rulesState()) {
+        @case ('loading') {<div class="o-note" role="status" data-testid="commit-rules">Checking the rules of {{ branch() }}…</div>}
+        @case ('failed') {<div class="o-note o-amb" role="status">Could not check the rules of <b>{{ branch() }}</b>, so your change is committed to a new branch with a pull request. <button type="button" class="o-lnk" (click)="loadRules()" data-testid="commit-rules-retry">Retry</button></div>}
+        @default {@if (blocked()) {<div class="o-note o-blu">Your change is committed to a new branch with a pull request because <b>{{ branch() }}</b> is protected.</div>}}
+      }
       <div class="o-fld"><label for="cb-msg">Commit message</label><input id="cb-msg" class="o-in" [ngModel]="message()" (ngModelChange)="message.set($event)" data-testid="commit-message" /></div>
       @if (!blocked()) {
         <label class="o-flex o-sm"><input type="radio" name="cb-where" [checked]="!toNew()" (change)="toNew.set(false)" /> Commit directly to <b class="o-mono">{{ branch() }}</b></label>
@@ -1743,7 +1776,7 @@ class CommitBox {
       }
       <div class="o-flex">
         <button type="button" class="o-btn o-sm o-r" (click)="cancel.emit()">Cancel</button>
-        <button type="button" class="o-btn o-sm o-pri" [disabled]="busy() || !message().trim() || ((toNew() || blocked()) && !newBranch().trim())" (click)="send()" data-testid="commit-submit">{{ toNew() || blocked() ? 'Commit and open PR' : 'Commit changes' }}</button>
+        <button type="button" class="o-btn o-sm o-pri" [disabled]="busy() || rulesState() === 'loading' || !message().trim() || ((toNew() || blocked()) && !newBranch().trim())" (click)="send()" data-testid="commit-submit">{{ toNew() || blocked() ? 'Commit and open PR' : 'Commit changes' }}</button>
       </div>
     </div>
   `, isInline: true, dependencies: [{ kind: "ngmodule", type: FormsModule }, { kind: "directive", type: i1.DefaultValueAccessor, selector: "input:not([type=checkbox])[formControlName],textarea[formControlName],input:not([type=checkbox])[formControl],textarea[formControl],input:not([type=checkbox])[ngModel],textarea[ngModel],[ngDefaultControl]" }, { kind: "directive", type: i1.NgControlStatus, selector: "[formControlName],[ngModel],[formControl]" }, { kind: "directive", type: i1.NgModel, selector: "[ngModel]:not([formControlName]):not([formControl])", inputs: ["name", "disabled", "ngModel", "ngModelOptions"], outputs: ["ngModelChange"], exportAs: ["ngModel"] }], changeDetection: i0.ChangeDetectionStrategy.OnPush }); }
@@ -1756,7 +1789,11 @@ i0.ɵɵngDeclareClassMetadata({ minVersion: "12.0.0", version: "21.2.12", ngImpo
                     changeDetection: ChangeDetectionStrategy.OnPush,
                     template: `
     <div class="o-col" style="gap:10px" data-testid="commit-box">
-      @if (blocked()) {<div class="o-note o-blu">Your change is committed to a new branch with a pull request because <b>{{ branch() }}</b> is protected.</div>}
+      @switch (rulesState()) {
+        @case ('loading') {<div class="o-note" role="status" data-testid="commit-rules">Checking the rules of {{ branch() }}…</div>}
+        @case ('failed') {<div class="o-note o-amb" role="status">Could not check the rules of <b>{{ branch() }}</b>, so your change is committed to a new branch with a pull request. <button type="button" class="o-lnk" (click)="loadRules()" data-testid="commit-rules-retry">Retry</button></div>}
+        @default {@if (blocked()) {<div class="o-note o-blu">Your change is committed to a new branch with a pull request because <b>{{ branch() }}</b> is protected.</div>}}
+      }
       <div class="o-fld"><label for="cb-msg">Commit message</label><input id="cb-msg" class="o-in" [ngModel]="message()" (ngModelChange)="message.set($event)" data-testid="commit-message" /></div>
       @if (!blocked()) {
         <label class="o-flex o-sm"><input type="radio" name="cb-where" [checked]="!toNew()" (change)="toNew.set(false)" /> Commit directly to <b class="o-mono">{{ branch() }}</b></label>
@@ -1767,7 +1804,7 @@ i0.ɵɵngDeclareClassMetadata({ minVersion: "12.0.0", version: "21.2.12", ngImpo
       }
       <div class="o-flex">
         <button type="button" class="o-btn o-sm o-r" (click)="cancel.emit()">Cancel</button>
-        <button type="button" class="o-btn o-sm o-pri" [disabled]="busy() || !message().trim() || ((toNew() || blocked()) && !newBranch().trim())" (click)="send()" data-testid="commit-submit">{{ toNew() || blocked() ? 'Commit and open PR' : 'Commit changes' }}</button>
+        <button type="button" class="o-btn o-sm o-pri" [disabled]="busy() || rulesState() === 'loading' || !message().trim() || ((toNew() || blocked()) && !newBranch().trim())" (click)="send()" data-testid="commit-submit">{{ toNew() || blocked() ? 'Commit and open PR' : 'Commit changes' }}</button>
       </div>
     </div>
   `,