@chevre/domain 24.0.0-alpha.0 → 24.0.0-alpha.2

package/lib/chevre/service/order/onOrderStatusChanged/onOrderPaymentDue.js

@@ -37,7 +37,7 @@ const debug = (0, debug_1.default)('chevre-domain:service:order');
 function onOrderPaymentDue(params) {
     return async (repos) => {
         debug('onOrderStatusChanged called.', params.order.orderNumber, params.order.orderStatus, params.order.orderDate);
-        let tasks = [];
+        let tasks;
         // const maskedCustomer = createMaskedCustomer(params.order, { noProfile: true });
         const simpleOrder = {
             typeOf: params.order.typeOf,

package/lib/chevre/service/order/onOrderStatusChanged/onOrderProcessing.js

@@ -43,7 +43,7 @@ function onOrderProcessing(params) {
         const setting = await repos.setting.findOne({ project: { id: { $eq: '*' } } }, ['onOrderStatusChanged']);
         const { numTryConfirmReserveTransaction } = settings;
         debug('onOrderStatusChanged called.', params.order.orderNumber, params.order.orderStatus, params.order.orderDate);
-        let tasks = [];
+        let tasks;
         let creatingCheckResourceTask;
         const sendEmailMessageByOnOrderProcessing = params.placeOrderTransaction?.potentialActions?.order?.onOrderProcessing?.sendEmailMessage;
         switch (params.order.orderStatus) {

package/lib/chevre/service/order/onOrderStatusChanged/onOrderReturned.js

@@ -43,7 +43,7 @@ function onOrderReturned(params) {
     ) => {
         const setting = await repos.setting.findOne({ project: { id: { $eq: '*' } } }, ['onOrderStatusChanged']);
         debug('onOrderStatusChanged called.', params.order.orderNumber, params.order.orderStatus, params.order.orderDate);
-        let tasks = [];
+        let tasks;
         // const maskedCustomer = createMaskedCustomer(params.order, { noProfile: true });
         const simpleOrder = {
             typeOf: params.order.typeOf,

package/lib/chevre/service/order/onOrderUpdated.js

@@ -32,8 +32,7 @@ function onOrderUpdated(params) {
     // settings: Settings
     ) => {
         const setting = await repos.setting.findOne({ project: { id: { $eq: '*' } } }, ['onOrderStatusChanged']);
-        let tasks = [];
-        tasks = (0, factory_1.createInformTasks)({
+        const tasks = (0, factory_1.createInformTasks)({
             typeOf: factory.order.OrderType.Order,
             orderNumber: params.orderNumber,
             project: { id: params.project.id, typeOf: factory.organizationType.Project },

package/lib/chevre/service/order/placeOrder/createPlacingOrderFromExistingTransaction.js

@@ -30,7 +30,6 @@ function createPlacingOrderFromExistingTransaction(params) {
     return async (repos) => {
         const confirmationNumber = String(params.confirmationNumber);
         const orderNumber = params.orderNumber;
-        let order;
         const placeOrderTransactions = await repos.transaction.projectFields({
             limit: 1,
             page: 1,
@@ -102,7 +101,7 @@ function createPlacingOrderFromExistingTransaction(params) {
                 throw error;
             }
         }
-        order = (0, factory_1.createPlacingOrder)({ transaction: placeOrderTransactionWithResult, authorizePaymentActions, acceptedOffers });
+        const order = (0, factory_1.createPlacingOrder)({ transaction: placeOrderTransactionWithResult, authorizePaymentActions, acceptedOffers });
         return { order, placeOrderTransaction: placeOrderTransactionWithResult, serialNumbers };
     };
 }

package/lib/chevre/service/order/returnOrder.js

@@ -105,7 +105,7 @@ function returnOrder(params) {
             recipient,
             typeOf: factory.actionType.ReturnAction
         };
-        let returnedOwnershipInfos = [];
+        let returnedOwnershipInfos;
         let returnedOrder;
         const action = await repos.action.start(returnOrderActionAttributes);
         try {

package/lib/chevre/service/payment/any/fixOrderAsNeeded.js

@@ -33,9 +33,8 @@ function fixOrderAsNeeded(params) {
         // publish always(2025-02-12~)
         // MovieTicketの場合、確認番号を発行(着券に連携するため)(2024-05-27~)
         // let confirmationNumber: string | undefined;
-        let confirmationNumber;
         // if (params.paymentServiceType === factory.service.paymentService.PaymentServiceType.MovieTicket) {
-        confirmationNumber = await (0, publishConfirmationNumberIfNotExist_1.publishConfirmationNumberIfNotExist)({
+        const confirmationNumber = await (0, publishConfirmationNumberIfNotExist_1.publishConfirmationNumberIfNotExist)({
             id: params.purpose.id,
             status: { $in: [factory.transactionStatusType.InProgress] },
             object: { orderDate }

package/lib/chevre/service/payment/any.js

@@ -370,7 +370,6 @@ function publishPaymentUrl(params) {
             //     const publishTransactionNumberResult = await repos.transactionNumber.publishByTimestamp({ startDate: new Date() });
             //     transactionNumber = publishTransactionNumberResult.transactionNumber;
             // }
-            let result;
             // URL発行
             const authorizeObject = {
                 ...params.object,
@@ -393,7 +392,7 @@ function publishPaymentUrl(params) {
                 ...(typeof ticketToken === 'string') ? { ticketToken } : undefined
             });
             const taskId = params.sameAs?.id;
-            result = await PayTransactionService.publishPaymentUrl(startParams, {
+            const result = await PayTransactionService.publishPaymentUrl(startParams, {
                 purposeAsTransaction: { id: transaction.id },
                 executor: (typeof taskId === 'string') ? { id: taskId } : {} // タスク関連付け(2024-05-22~)
             })(repos, settings);

package/lib/chevre/service/payment/creditCard/authorize/processAuthorizeCreditCard.js

@@ -94,7 +94,6 @@ function processAuthorizeCreditCard(params) {
                 siteId: params.availableChannel.credentials?.siteId,
                 sitePass: params.availableChannel.credentials?.sitePass
             };
-            let action;
             let recipe = (0, processAuthorizeCreditCardResult2recipe_1.processAuthorizeCreditCardResult2recipe)({
                 project: { id: params.project.id },
                 result: { entryTranArgs }
@@ -110,7 +109,7 @@ function processAuthorizeCreditCard(params) {
                 sameAs: { id: params.payTransaction.id, typeOf: factory.assetTransactionType.Pay }
             };
             // add action(2024-06-12~)
-            action = await repos.action.start(actionAttributes, { recipe });
+            const action = await repos.action.start(actionAttributes, { recipe });
             try {
                 entryTranResult = await repos.creditCardService.entryTran(entryTranArgs);
                 execTranArgs = {

package/lib/chevre/service/payment/creditCard/authorize/processAuthorizeCreditCard3ds.d.ts

@@ -1,4 +1,4 @@
-import * as GMO from '@motionpicture/gmo-service';
+import type * as GMO from '@motionpicture/gmo-service';
 import { ActionRepo } from '../../../../repo/action';
 import * as factory from '../../../../factory';
 interface ICreditCardPaymentAgencyTransaction3ds {

package/lib/chevre/service/payment/creditCard/authorize/processAuthorizeCreditCard3ds.js

@@ -32,7 +32,6 @@ function processAuthorizeCreditCard3ds(params) {
         const { accessId, accessPass } = entryTranResult;
         const secureTran2Args = { accessId, accessPass };
         let secureTran2Result;
-        let action;
         let recipe = (0, processAuthorizeCreditCard3dsResult2recipe_1.processAuthorizeCreditCard3dsResult2recipe)({
             project: { id: params.project.id },
             result: { secureTran2Args }
@@ -48,7 +47,7 @@ function processAuthorizeCreditCard3ds(params) {
             sameAs: { id: params.payTransaction.id, typeOf: factory.assetTransactionType.Pay }
         };
         // add action(2024-06-12~)
-        action = await repos.action.start(actionAttributes, { recipe });
+        const action = await repos.action.start(actionAttributes, { recipe });
         try {
             secureTran2Result = await repos.creditCardService.secureTran2(secureTran2Args);
         }

package/lib/chevre/service/payment/creditCard/authorize/processAuthorizeCreditCard3dsResult2recipe.d.ts

@@ -1,4 +1,4 @@
-import * as GMO from '@motionpicture/gmo-service';
+import type * as GMO from '@motionpicture/gmo-service';
 import * as factory from '../../../../factory';
 interface IProcessAuthorizeCreditCard3dsResult {
     secureTran2Args?: GMO.factory.credit.ISecureTran2Args;

package/lib/chevre/service/payment/creditCard/authorize/processAuthorizeCreditCardResult2recipe.d.ts

@@ -1,4 +1,4 @@
-import * as GMO from '@motionpicture/gmo-service';
+import type * as GMO from '@motionpicture/gmo-service';
 import * as factory from '../../../../factory';
 interface IProcessAuthorizeCreditCardResult {
     entryTranArgs?: GMO.factory.credit.IEntryTranArgs;

package/lib/chevre/service/payment/creditCard/factory.d.ts

@@ -1,4 +1,4 @@
-import * as GMO from '@motionpicture/gmo-service';
+import type * as GMO from '@motionpicture/gmo-service';
 import * as factory from '../../../factory';
 interface IProcessAlterTranResult {
     searchTradeArgs?: GMO.factory.credit.ISearchTradeArgs & GMO.factory.credit.IOptionalSiteArgs;

package/lib/chevre/service/payment/movieTicket/authorize.js

@@ -35,7 +35,7 @@ const validation_1 = require("./validation");
 function authorize(params, transaction, paymentServiceId, options) {
     return async (repos, settings) => {
         let accountId;
-        let accountsReceivablesByServiceType = [];
+        let accountsReceivablesByServiceType;
         try {
             // MovieTicket決済の場合、認証
             const validateMovieTicketResult = await (0, validation_1.validateMovieTicket)(params, paymentServiceId, options.checkedAction, options.purpose)(repos, settings);

package/lib/chevre/service/payment/movieTicket/processPurchaseNumberAuth.js

@@ -33,8 +33,6 @@ const factory = __importStar(require("../../../factory"));
 const getCredentials_1 = require("./getCredentials");
 function processPurchaseNumberAuth(params) {
     return async (repos, settings) => {
-        let purchaseNumberAuthIn;
-        let purchaseNumberAuthResult;
         // movieTickets.typeOfへの依存廃止(2024-03-15~)
         // MovieTicket系統の決済方法タイプは動的
         // const paymentMethodType = params.movieTickets[0]?.typeOf;
@@ -77,7 +75,7 @@ function processPurchaseNumberAuth(params) {
             seller: { id: String(params.seller.id), project: { id: params.screeningEvent.project.id } },
             paymentServiceId: params.paymentServiceId
         })(repos);
-        purchaseNumberAuthIn = {
+        const purchaseNumberAuthIn = {
             kgygishCd: sellerCredentials.kgygishCd,
             jhshbtsCd: surfrock.factory.service.auth.purchaseNumberAuth.InformationTypeCode.All,
             knyknrNoInfoIn: knyknrNoInfoIn,
@@ -99,7 +97,7 @@ function processPurchaseNumberAuth(params) {
             endpoint: String(availableChannel.serviceUrl),
             auth: mvtkReserveAuthClient
         }, { timeout: settings.movieticketReserve.timeoutCheck });
-        purchaseNumberAuthResult = await authService.purchaseNumberAuth(purchaseNumberAuthIn);
+        const purchaseNumberAuthResult = await authService.purchaseNumberAuth(purchaseNumberAuthIn);
         return { purchaseNumberAuthIn, purchaseNumberAuthResult };
     };
 }

package/lib/chevre/service/payment/movieTicket/refundMovieTicket.js

@@ -152,8 +152,8 @@ function refundMovieTicket(params, options) {
             catch (__) {
                 // 失敗したら仕方ない
             }
-            error = (0, errorHandler_1.handleMvtkReserveError)({ ...error, message: message });
-            throw error;
+            const handledError = (0, errorHandler_1.handleMvtkReserveError)({ ...error, message: message });
+            throw handledError;
         }
         // アクションとしてはFailedだが後続処理を実行するケースに対応(2024-03-21~)
         const seatInfoSyncResultAsError = processSeatInfoSyncResult?.seatInfoSyncResultAsError;
@@ -196,9 +196,8 @@ function createSeatInfoSyncInOnRefund(params) {
         if (seatInfoSyncInOnPay === undefined) {
             throw new factory.errors.NotFound('PayAction.recipe.step.itemListElement.itemListElement.beforeMedia');
         }
-        let seatInfoSyncIn;
         // 着券時のseatInfoSyncInに対してtrkshFlgだけ変更してリクエストする
-        seatInfoSyncIn = {
+        const seatInfoSyncIn = {
             ...seatInfoSyncInOnPay,
             trkshFlg: surfrock.factory.service.seat.seatInfoSync.DeleteFlag.True // 取消フラグ
         };
@@ -215,8 +214,7 @@ function createSeatInfoSyncCancelInOnRefund(params) {
         if (seatInfoSyncInOnPay === undefined) {
             throw new factory.errors.NotFound('PayAction.recipe.step.itemListElement.itemListElement.beforeMedia');
         }
-        let seatInfoSyncCancelIn;
-        seatInfoSyncCancelIn = {
+        const seatInfoSyncCancelIn = {
             kgygishCd: seatInfoSyncInOnPay.kgygishCd,
             kgysystmzskyykNo: seatInfoSyncInOnPay.kgygishSstmZskyykNo,
             kgysystmzskyykNoIkktsCnclFlg: '1',

package/lib/chevre/service/payment/movieTicket/voidTransaction.js

@@ -52,7 +52,6 @@ function voidTransaction(params) {
             }
         });
         if (payAction !== undefined) {
-            let refundAction;
             const seller = transaction.recipient;
             if (typeof seller?.id !== 'string') {
                 throw new factory.errors.NotFound('payTransaction.recipient');
@@ -60,7 +59,7 @@ function voidTransaction(params) {
             if (payAction.purpose.typeOf !== factory.order.OrderType.Order) {
                 throw new factory.errors.Internal(`unexpected payAction.purpose.typeOf ${payAction.purpose.typeOf}`);
             }
-            refundAction = {
+            const refundAction = {
                 project: transaction.project,
                 typeOf: factory.actionType.RefundAction,
                 object: [{

package/lib/chevre/service/payment/paymentCard.js

@@ -149,7 +149,6 @@ function validatePaymentMethod(params, paymentServiceId) {
 }
 function processAccountTransaction(params) {
     return async (repos) => {
-        let pendingTransaction;
         const defaultName = `${factory.assetTransactionType.Pay} Transaction ${params.transactionNumber}`;
         const agent = {
             // ...params.agent,
@@ -186,7 +185,7 @@ function processAccountTransaction(params) {
             })
         });
         // ひとまず出金取引に限定
-        pendingTransaction = await accountTransactionService.start({
+        const pendingTransaction = await accountTransactionService.start({
             transactionNumber: params.transactionNumber,
             project: { typeOf: params.project.typeOf, id: params.project.id },
             typeOf: factory.account.transactionType.Withdraw,
@@ -303,8 +302,7 @@ function refundPaymentCard(params) {
             transactionNumber: paymentMethodId
         });
         // accountNumberをpendingTransactionから取得する
-        let accountNumber;
-        accountNumber = payTransaction.object.pendingTransaction?.object.fromLocation?.accountNumber;
+        const accountNumber = payTransaction.object.pendingTransaction?.object.fromLocation?.accountNumber;
         if (typeof accountNumber !== 'string') {
             throw new factory.errors.ArgumentNull('serviceOutput.paymentAccount.accountNumber');
         }

package/lib/chevre/service/reserve/potentialActions/onReservationUsed.js

@@ -48,14 +48,10 @@ function onReservationUsed(attendedReservation, action) {
         const informReservations = setting?.onReservationStatusChanged?.informReservation;
         const informTaskRunsAt = now;
         // support notification.reservation.IUseAction(2024-11-11~)
-        let action4inform;
-        let reservation4inform;
-        // let reservation4inform: factory.notification.reservation.IReservation4informUsed
-        //     | factory.notification.reservation.IUseAction;
         const useForTheFirstTime = attendedReservation.reservedTicket.dateUsed !== undefined
             && (0, moment_1.default)(action.startDate)
                 .isSame((0, moment_1.default)(attendedReservation.reservedTicket.dateUsed), 'milliseconds');
-        reservation4inform = {
+        const reservation4inform = {
             typeOf: attendedReservation.typeOf,
             id: attendedReservation.id,
             // dateUsedの通知は初使用時のみで十分(2024-11-27~)
@@ -66,7 +62,7 @@ function onReservationUsed(attendedReservation, action) {
                 }
                 : undefined
         };
-        action4inform = {
+        const action4inform = {
             typeOf: action.typeOf,
             project: action.project,
             id: action.id,

package/lib/chevre/service/task/confirmReserveTransaction.js

@@ -146,7 +146,6 @@ function createConfirmObject4COAByOrder(params) {
 }
 function fixOrderAsPurpose(params) {
     return async (repos) => {
-        let order;
         const purposeOrderNumber = params.purpose.orderNumber;
         const orders = await repos.order.projectFields({
             limit: 1,
@@ -154,7 +153,7 @@ function fixOrderAsPurpose(params) {
             project: { id: { $eq: params.project.id } },
             orderNumbers: [purposeOrderNumber]
         }, { inclusion: ['customer', 'orderNumber', 'typeOf'] });
-        order = orders.shift();
+        const order = orders.shift();
         if (order === undefined) {
             throw new factory.errors.NotFound('Order as purpose');
         }

package/lib/chevre/service/task/onResourceDeleted/deleteResourcesByProduct.js

@@ -40,21 +40,18 @@ function deleteResourcesByProduct(params) {
             let deleteResult;
             const action = await repos.action.start(deleteActionAttributes);
             try {
-                let deleteEventResult;
-                let updateOfferResult;
-                let deleteNoteResult;
                 // 興行を設定されたイベント削除
-                deleteEventResult = await repos.event.deleteManyEventsByItemOfferedId({
+                const deleteEventResult = await repos.event.deleteManyEventsByItemOfferedId({
                     project: { id: params.project.id },
                     offers: { itemOffered: { id: { $in: [productId] } } }
                 });
                 // アドオンから除外
-                updateOfferResult = await repos.aggregateOffer.pullAddOns({
+                const updateOfferResult = await repos.aggregateOffer.pullAddOns({
                     project: { id: params.project.id },
                     addOn: { itemOffered: { id: { $in: [productId] } } }
                 });
                 // メモを削除(2025-09-18~)
-                deleteNoteResult = await repos.note.deleteNotesByAbout({
+                const deleteNoteResult = await repos.note.deleteNotesByAbout({
                     about: { id: productId, typeOf: params.typeOf }
                 });
                 deleteResult = { deleteEventResult, updateOfferResult, deleteNoteResult };

package/lib/chevre/service/task/onResourceUpdated/onOfferCatalogUpdated.js

@@ -34,7 +34,7 @@ function createInformOfferCatalogTasks(params, setting) {
         if (params.ids.length === 0) {
             return;
         }
-        let offerCatalogs = [];
+        let offerCatalogs;
         if (params.isOfferCatalogItem) {
             offerCatalogs = await repos.offerCatalogItem.projectFields({ id: { $in: params.ids } }, ['identifier', 'name', 'numberOfItems', 'project', 'typeOf']);
         }

package/lib/chevre/service/task/onResourceUpdated/syncOfferCatalog.js

@@ -46,7 +46,7 @@ function syncOfferCatalog(params) {
         }
         else {
             for (const offerCatalogId of params.ids) {
-                let offerCatalogs = [];
+                let offerCatalogs;
                 if (params.isOfferCatalogItem) {
                     offerCatalogs = await repos.offerCatalogItem.projectFields({ id: { $in: [offerCatalogId] } }, ['id', 'itemListElementTypeOf']);
                 }

package/lib/chevre/service/task/pay.js

@@ -47,8 +47,7 @@ function call(params) {
         if (redisClient === undefined) {
             throw new factory.errors.Argument('settings', 'redisClient required');
         }
-        let payActionAttributes;
-        payActionAttributes = await (0, payByTask_1.payTask2payActionAttributes)({
+        const payActionAttributes = await (0, payByTask_1.payTask2payActionAttributes)({
             ...params.data,
             sameAs: { id: params.id, typeOf: 'Task' } // タスクIDを関連付け(2024-04-20~)
         })({

package/lib/chevre/service/task/voidReserveTransaction.js

@@ -91,7 +91,7 @@ function call(params) {
                 reserveService
             }, settings);
         }
-        catch (error) {
+        catch (error) { // eslint-disable-line no-useless-catch
             throw error;
         }
         finally {

package/lib/chevre/service/transaction/deleteTransaction.js

@@ -60,7 +60,7 @@ function createDeleteTransactionTasksByAgentId(params) {
                 inclusion: ['typeOf', 'startDate', 'endDate', 'object', 'project']
             });
             const deleteAt = new Date();
-            let deleteTransactionTasks = [];
+            let deleteTransactionTasks;
             switch (transactionTypeOf) {
                 case factory.transactionType.PlaceOrder:
                     deleteTransactionTasks = transactions.map((transaction) => {

package/lib/chevre/service/transaction/moneyTransfer.js

@@ -72,23 +72,17 @@ function start(params) {
         const { transactionNumber } = await repos.transactionNumber.publishByTimestamp({ startDate: new Date() });
         // 取引開始
         const startParams = (0, factory_2.createStartParams)(params, passport, seller, amount, fromLocation, toLocation, transactionNumber);
-        let transaction;
-        try {
-            transaction = await repos.transaction.start(startParams);
-            await authorizePaymentCard({
-                transaction: {
-                    ...transaction,
-                    object: startParams.object,
-                    seller: startParams.seller,
-                    agent: startParams.agent,
-                    project: startParams.project,
-                    typeOf: startParams.typeOf
-                }
-            })(repos);
-        }
-        catch (error) {
-            throw error;
-        }
+        const transaction = await repos.transaction.start(startParams);
+        await authorizePaymentCard({
+            transaction: {
+                ...transaction,
+                object: startParams.object,
+                seller: startParams.seller,
+                agent: startParams.agent,
+                project: startParams.project,
+                typeOf: startParams.typeOf
+            }
+        })(repos);
         return transaction;
     };
 }
@@ -467,7 +461,6 @@ function validateFromLocation(project, fromLocationBeforeStart, issuedThrough) {
         else {
             // fromLocationが注文の場合に対応
             if (fromLocation.typeOf === factory.order.OrderType.Order) {
-                fromLocation = fromLocation;
                 // 注文検索
                 const orders = await repos.order.projectFields({
                     limit: 1,
@@ -523,7 +516,6 @@ function validateToLocation(project, toLocationBeforeStart, issuedThrough) {
         else {
             // fromLocationが注文の場合に対応
             if (toLocation.typeOf === factory.order.OrderType.Order) {
-                toLocation = toLocation;
                 // 注文検索
                 const orders = await repos.order.projectFields({
                     limit: 1,

package/lib/chevre/service/transaction/placeOrder/confirm/publishCode.js

@@ -33,7 +33,7 @@ function publishCode(params) {
         };
         const issuedBy = { id: params.object.seller.id, typeOf: factory.organizationType.Corporation };
         let authorizations;
-        try {
+        try { // eslint-disable-line no-useless-catch
             authorizations = await repos.authorization.issueAuthorization([{
                     project: { id: params.project.id, typeOf: factory.organizationType.Project },
                     object: authorizationObject,

package/lib/chevre/service/transaction/placeOrder/confirm.js

@@ -115,12 +115,11 @@ function confirm(params, options) {
                 author: { id: transaction.agent.id, typeOf: transaction.agent.typeOf }
             })(repos);
         }
-        let acceptedOffers;
         const { 
         // acceptedOffersFromAuthorizeAction, // discontinue(2024-06-17~)
         authorizePaymentActions, authorizeEventServiceOfferActions, authorizeMoneyTansferActions, authorizeProductOfferActions, serialNumbers } = dissolveAuthorizeActions(completedAuthorizeActions);
         // orderInTransactionから検索する(2024-03-04~)
-        acceptedOffers = (await repos.orderInTransaction.findAcceptedOffersByOrderNumber({ orderNumber: { $eq: orderNumber } }))
+        const acceptedOffers = (await repos.orderInTransaction.findAcceptedOffersByOrderNumber({ orderNumber: { $eq: orderNumber } }))
             .filter(({ serialNumber }) => typeof serialNumber === 'string' && serialNumbers.includes(serialNumber));
         // authorizePaymentActionsからpayTransactionsを参照(2024-06-20~)
         let payTransactions = [];
@@ -446,7 +445,6 @@ function searchAuthorizeActions(params) {
 function createConfirmationNumber(params) {
     const confirmationNumber = params.transaction.object.confirmationNumber;
     let url = '';
-    let identifier = [];
     // 取引に確認番号が保管されていなければ、確認番号を発行
     if (typeof confirmationNumber !== 'string') {
         // 事前に発行済なはずなので、ありえないフロー
@@ -462,7 +460,7 @@ function createConfirmationNumber(params) {
         url = params.result.order.url(params.order);
     }
     // 識別子の指定があれば上書き
-    identifier = [
+    const identifier = [
         ...(Array.isArray(params.result.order.identifier)) ? params.result.order.identifier : [],
         // 取引に指定があれば追加
         ...(Array.isArray(params.transaction.object.identifier)) ? params.transaction.object.identifier : []

package/lib/chevre/service/transaction/placeOrder/start/validateStartRequest.js

@@ -67,8 +67,7 @@ function validateStartRequest(params) {
         if (typeof clientId !== 'string' || clientId.length === 0) {
             throw new factory.errors.ArgumentNull('client_id');
         }
-        let projectMakesOffer;
-        projectMakesOffer = (await repos.projectMakesOffer.search({
+        const projectMakesOffer = (await repos.projectMakesOffer.search({
             limit: 1,
             page: 1,
             offeredBy: { id: { $eq: params.project.id } },

package/lib/chevre/service/transaction/returnOrder/potentialActions.js

@@ -32,9 +32,8 @@ const sendEmailMessage_1 = require("./potentialActions/sendEmailMessage");
 async function createPotentialActions(params, 
 // settings: Settings
 setting) {
-    let returnOrderActions = [];
     const emailMessages = [];
-    returnOrderActions = await Promise.all(params.orders.map(async (order) => {
+    const returnOrderActions = await Promise.all(params.orders.map(async (order) => {
         let returnOrderParams = params.potentialActions?.returnOrder;
         // 互換性維持対応
         if (!Array.isArray(returnOrderParams)) {

package/lib/chevre/service/transaction/returnOrder/preStart/getReturnPolicyByProject.js

@@ -72,7 +72,7 @@ const TIMEOUT = 5000;
  */
 async function getReturnPolicyByProject(params) {
     // implement with fetch(2024-01-20~)
-    try {
+    try { // eslint-disable-line no-useless-catch
         const { identifier, sameAs } = params;
         const res = await fetch(sameAs, {
             method: 'POST',

package/package.json

@@ -15,7 +15,6 @@
     "@cinerino/sdk": "13.0.0",
     "@motionpicture/coa-service": "9.6.0",
     "@motionpicture/gmo-service": "5.4.0-alpha.1",
-    "@rollup/rollup-linux-x64-gnu": "^4.57.1",
     "@sendgrid/client": "8.1.4",
     "@surfrock/sdk": "1.4.0-alpha.1",
     "debug": "^3.2.7",
@@ -45,30 +44,24 @@
     "@types/mocha": "10.0.7",
     "@types/moment-timezone": "^0.5.30",
     "@types/node": "22.19.7",
-    "@types/power-assert": "^1.5.3",
     "@types/pug": "2.0.10",
     "@types/sinon": "^4.3.3",
     "@types/sinon-mongoose": "^1.3.11",
     "@types/uniqid": "^4.1.3",
     "@types/uuid": "^3.4.10",
     "@vitest/coverage-v8": "4.0.18",
-    "coveralls": "^3.1.0",
     "csvtojson": "^2.0.10",
     "dependency-cruiser": "17.3.8",
     "eslint": "9.39.2",
     "googleapis": "^85.0.0",
     "jose": "6.0.12",
     "json2csv": "4.5.4",
-    "mocha": "10.6.0",
     "mongoose": "8.0.4",
-    "nyc": "17.0.0",
-    "power-assert": "^1.6.1",
     "redis": "4.6.5",
     "rimraf": "^2.7.1",
     "sinon": "4.5.0",
     "sinon-mongoose": "^2.3.0",
     "size-limit": "12.0.0",
-    "ts-node": "^10.9.1",
     "typescript": "5.6.3",
     "typescript-eslint": "8.55.0",
     "vitest": "4.0.18"
@@ -96,21 +89,19 @@
   "scripts": {
     "build": "tsc",
     "build:example": "tsc --watch --project tsconfig.example.json --declaration false",
+    "check:all": "npm run clean && npm run build && npm run depcruise && npm run size && npm test",
     "clean": "rimraf ./lib \"npm-debug.log*\" ./doc ./coverage ./.nyc_output ./example/dst",
     "depcruise": "depcruise src",
     "doc": "echo \"implementing...\" && exit 0",
     "eslint": "eslint \"src/**/*.ts\"",
-    "mocha": "mocha",
-    "nyc": "nyc mocha \"src/**/*.spec.ts\"",
-    "coverage:nyc": "npm run nyc && nyc report --reporter=text-lcov | coveralls",
     "coverage": "vitest run --coverage",
-    "test": "npm run eslint && npm run coverage && npm run coverage:nyc",
-    "preversion": "npm run clean && npm run build && npm run depcruise && npm run size && npm test && npm run doc",
+    "test": "npm run eslint && npm run coverage",
+    "preversion": "npm run check:all",
     "size": "size-limit",
     "version": "git add -A",
     "vitest": "vitest",
     "postversion": "git push origin --tags",
-    "prepublishOnly": "npm run clean && npm run build && npm run depcruise && npm run size && npm test && npm run doc"
+    "prepublishOnly": "npm run clean && npm run build"
   },
-  "version": "24.0.0-alpha.0"
+  "version": "24.0.0-alpha.2"
 }