@checkstack/ui 1.1.3 → 1.1.4

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @checkstack/ui
 
+## 1.1.4
+
+### Patch Changes
+
+- c0c0ed2: Fix LDAP group-to-role mapping not assigning roles on login. The LDAP search now explicitly requests the `memberOf` operational attribute, which is not returned by default. Also fixes array flattening that discarded multi-valued group memberships, and adds case-insensitive DN comparison for group matching. The test LDAP environment now uses `groupOfUniqueNames` to enable the memberOf overlay. Additionally, the DynamicForm validation no longer blocks saving when optional array fields (like group mappings) are empty.
+
 ## 1.1.3
 
 ### Patch Changes

package/package.json

@@ -1,11 +1,11 @@
 {
   "name": "@checkstack/ui",
-  "version": "1.1.3",
+  "version": "1.1.4",
   "type": "module",
   "main": "src/index.ts",
   "dependencies": {
-    "@checkstack/common": "0.6.3",
-    "@checkstack/frontend-api": "0.3.7",
+    "@checkstack/common": "0.6.4",
+    "@checkstack/frontend-api": "0.3.8",
     "@monaco-editor/react": "^4.7.0",
     "@radix-ui/react-accordion": "^1.2.12",
     "@radix-ui/react-dialog": "^1.1.15",
@@ -30,9 +30,9 @@
     "typescript": "^5.0.0",
     "@types/react": "^18.2.0",
     "@testing-library/react": "^16.0.0",
-    "@checkstack/test-utils-frontend": "0.0.3",
-    "@checkstack/tsconfig": "0.0.3",
-    "@checkstack/scripts": "0.1.1"
+    "@checkstack/test-utils-frontend": "0.0.4",
+    "@checkstack/tsconfig": "0.0.4",
+    "@checkstack/scripts": "0.1.2"
   },
   "scripts": {
     "typecheck": "tsc --noEmit",

package/src/components/DynamicForm/utils.test.ts

@@ -155,13 +155,23 @@ describe("isValueEmpty", () => {
   });
 
   describe("arrays", () => {
-    it("treats empty array as empty", () => {
-      expect(isValueEmpty([], arraySchema)).toBe(true);
+    it("treats empty array as valid when no minItems specified", () => {
+      expect(isValueEmpty([], arraySchema)).toBe(false);
+    });
+
+    it("treats empty array as empty when minItems > 0", () => {
+      const requiredArraySchema: JsonSchemaProperty = { type: "array", minItems: 1 } as JsonSchemaProperty;
+      expect(isValueEmpty([], requiredArraySchema)).toBe(true);
     });
 
     it("treats non-empty array as not empty", () => {
       expect(isValueEmpty([1, 2, 3], arraySchema)).toBe(false);
     });
+
+    it("treats non-empty array as not empty even with minItems", () => {
+      const requiredArraySchema: JsonSchemaProperty = { type: "array", minItems: 1 } as JsonSchemaProperty;
+      expect(isValueEmpty([1], requiredArraySchema)).toBe(false);
+    });
   });
 
   describe("objects", () => {

package/src/components/DynamicForm/utils.ts

@@ -48,8 +48,13 @@ export function isValueEmpty(
 ): boolean {
   if (val === undefined || val === null) return true;
   if (typeof val === "string" && val.trim() === "") return true;
-  // For arrays, check if empty
-  if (Array.isArray(val) && val.length === 0) return true;
+  // For arrays, only consider empty if schema requires minimum items
+  if (Array.isArray(val) && val.length === 0) {
+    const minItems = (propSchema as JsonSchemaProperty & { minItems?: number }).minItems;
+    if (minItems !== undefined && minItems > 0) return true;
+    // Empty arrays are valid by default (e.g., optional mappings lists)
+    return false;
+  }
   // For objects (nested schemas), recursively check required fields
   if (propSchema.type === "object" && propSchema.properties) {
     const objVal = val as Record<string, unknown>;