@checkstack/notification-frontend 0.2.22 → 0.2.23

package/CHANGELOG.md

@@ -1,5 +1,42 @@
 # @checkstack/notification-frontend
 
+## 0.2.23
+
+### Patch Changes
+
+- d1a2796: Enforce stricter code quality standards and eliminate AI slop anti-patterns.
+
+  **New utility**
+
+  - `extractErrorMessage(error, fallback?)` in `@checkstack/common` for consistent error extraction
+
+  **ESLint rules**
+
+  - `react-hooks/rules-of-hooks` and `exhaustive-deps` for hook correctness
+  - `no-console` in frontend packages — forces `toast` over silent `console.error`
+  - `no-restricted-syntax` banning `instanceof Error` — forces `extractErrorMessage`
+  - Custom `no-eslint-disable-any` rule preventing `@typescript-eslint/no-explicit-any` circumvention
+
+  **Refactoring**
+
+  - Replace 141 `instanceof Error` boilerplate patterns across the codebase
+  - Replace swallowed `console.error` with user-visible `toast.error()` feedback
+  - Remove 15 redundant `as` type casts in IntegrationsPage and ProviderConnectionsPage
+  - Consolidate 3 identical callback handlers into `handleDialogClose`
+  - Fix conditional React hook call in `FormField.tsx`
+  - Fix unstable useMemo deps in `Dashboard.tsx`
+  - Replace `useEffect`→`setState` with derived `useMemo` in `RegisterPage.tsx`
+  - Rewrite `keystore.test.ts` with typed `DrizzleMockChain` (eliminating 7 `any` suppressions)
+  - Delete obvious comments in `encryption.ts` and Teams `provider.ts`
+
+- Updated dependencies [d1a2796]
+  - @checkstack/common@0.6.5
+  - @checkstack/ui@1.2.1
+  - @checkstack/auth-frontend@0.5.18
+  - @checkstack/frontend-api@0.3.9
+  - @checkstack/notification-common@0.2.8
+  - @checkstack/signal-frontend@0.0.15
+
 ## 0.2.22
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@checkstack/notification-frontend",
-  "version": "0.2.22",
+  "version": "0.2.23",
   "type": "module",
   "main": "src/index.tsx",
   "checkstack": {
@@ -14,10 +14,10 @@
   "dependencies": {
     "@checkstack/notification-common": "0.2.7",
     "@checkstack/frontend-api": "0.3.8",
-    "@checkstack/auth-frontend": "0.5.13",
+    "@checkstack/auth-frontend": "0.5.17",
     "@checkstack/signal-frontend": "0.0.14",
     "@checkstack/common": "0.6.4",
-    "@checkstack/ui": "1.1.3",
+    "@checkstack/ui": "1.2.0",
     "react": "^18.2.0",
     "react-router-dom": "^6.22.0",
     "lucide-react": "^0.344.0"
@@ -25,7 +25,7 @@
   "devDependencies": {
     "typescript": "^5.0.0",
     "@types/react": "^18.2.0",
-    "@checkstack/tsconfig": "0.0.4",
+    "@checkstack/tsconfig": "0.0.5",
     "@checkstack/scripts": "0.1.2"
   }
 }

package/src/components/NotificationBell.tsx

@@ -10,6 +10,7 @@ import {
   DropdownMenuSeparator,
   Button,
   stripMarkdown,
+  useToast,
 } from "@checkstack/ui";
 import { useApi, usePluginClient } from "@checkstack/frontend-api";
 import { useSignal } from "@checkstack/signal-frontend";
@@ -28,6 +29,7 @@ export const NotificationBell = () => {
   const authApi = useApi(authApiRef);
   const { data: session, isPending: isAuthLoading } = authApi.useSession();
   const notificationClient = usePluginClient(NotificationApi);
+  const toast = useToast();
 
   const [isOpen, setIsOpen] = useState(false);
 
@@ -130,8 +132,8 @@ export const NotificationBell = () => {
       await markAsReadMutation.mutateAsync({});
       setSignalUnreadCount(0);
       setSignalNotifications([]);
-    } catch (error) {
-      console.error("Failed to mark all as read:", error);
+    } catch {
+      toast.error("Failed to mark all as read");
     }
   };
 

package/src/pages/NotificationSettingsPage.tsx

@@ -26,6 +26,7 @@ import {
   UserChannelCard,
   type UserDeliveryChannel,
 } from "../components/UserChannelCard";
+import { extractErrorMessage } from "@checkstack/common";
 
 export const NotificationSettingsPage = () => {
   const notificationClient = usePluginClient(NotificationApi);
@@ -97,7 +98,7 @@ export const NotificationSettingsPage = () => {
       },
       onError: (error) => {
         toast.error(
-          error instanceof Error ? error.message : "Failed to save settings",
+          extractErrorMessage(error, "Failed to save settings"),
         );
       },
     });
@@ -109,7 +110,7 @@ export const NotificationSettingsPage = () => {
     },
     onError: (error) => {
       toast.error(
-        error instanceof Error ? error.message : "Failed to unsubscribe",
+        extractErrorMessage(error, "Failed to unsubscribe"),
       );
     },
   });
@@ -123,7 +124,7 @@ export const NotificationSettingsPage = () => {
       },
       onError: (error) => {
         toast.error(
-          error instanceof Error ? error.message : "Failed to update channel",
+          extractErrorMessage(error, "Failed to update channel"),
         );
         setStrategySaving(undefined);
       },
@@ -138,9 +139,7 @@ export const NotificationSettingsPage = () => {
       },
       onError: (error) => {
         toast.error(
-          error instanceof Error
-            ? error.message
-            : "Failed to update preference",
+          extractErrorMessage(error, "Failed to update preference"),
         );
         setChannelSaving(undefined);
       },
@@ -155,7 +154,7 @@ export const NotificationSettingsPage = () => {
       },
       onError: (error) => {
         toast.error(
-          error instanceof Error ? error.message : "Failed to disconnect",
+          extractErrorMessage(error, "Failed to disconnect"),
         );
         setChannelSaving(undefined);
       },
@@ -168,7 +167,7 @@ export const NotificationSettingsPage = () => {
       },
       onError: (error) => {
         toast.error(
-          error instanceof Error ? error.message : "Failed to start OAuth flow",
+          extractErrorMessage(error, "Failed to start OAuth flow"),
         );
         setChannelConnecting(undefined);
       },

package/src/pages/NotificationsPage.tsx

@@ -16,6 +16,7 @@ import {
 import { usePluginClient } from "@checkstack/frontend-api";
 import type { Notification } from "@checkstack/notification-common";
 import { NotificationApi } from "@checkstack/notification-common";
+import { extractErrorMessage } from "@checkstack/common";
 
 export const NotificationsPage = () => {
   const notificationClient = usePluginClient(NotificationApi);
@@ -48,7 +49,7 @@ export const NotificationsPage = () => {
     },
     onError: (error) => {
       toast.error(
-        error instanceof Error ? error.message : "Failed to mark as read",
+        extractErrorMessage(error, "Failed to mark as read"),
       );
     },
   });
@@ -61,9 +62,7 @@ export const NotificationsPage = () => {
     },
     onError: (error) => {
       toast.error(
-        error instanceof Error
-          ? error.message
-          : "Failed to delete notification",
+        extractErrorMessage(error, "Failed to delete notification"),
       );
     },
   });
@@ -76,7 +75,7 @@ export const NotificationsPage = () => {
     },
     onError: (error) => {
       toast.error(
-        error instanceof Error ? error.message : "Failed to mark all as read",
+        extractErrorMessage(error, "Failed to mark all as read"),
       );
     },
   });