@checkstack/notification-backend 0.1.19 → 0.1.21

package/CHANGELOG.md

@@ -1,5 +1,52 @@
 # @checkstack/notification-backend
 
+## 0.1.21
+
+### Patch Changes
+
+- d1a2796: Enforce stricter code quality standards and eliminate AI slop anti-patterns.
+
+  **New utility**
+
+  - `extractErrorMessage(error, fallback?)` in `@checkstack/common` for consistent error extraction
+
+  **ESLint rules**
+
+  - `react-hooks/rules-of-hooks` and `exhaustive-deps` for hook correctness
+  - `no-console` in frontend packages — forces `toast` over silent `console.error`
+  - `no-restricted-syntax` banning `instanceof Error` — forces `extractErrorMessage`
+  - Custom `no-eslint-disable-any` rule preventing `@typescript-eslint/no-explicit-any` circumvention
+
+  **Refactoring**
+
+  - Replace 141 `instanceof Error` boilerplate patterns across the codebase
+  - Replace swallowed `console.error` with user-visible `toast.error()` feedback
+  - Remove 15 redundant `as` type casts in IntegrationsPage and ProviderConnectionsPage
+  - Consolidate 3 identical callback handlers into `handleDialogClose`
+  - Fix conditional React hook call in `FormField.tsx`
+  - Fix unstable useMemo deps in `Dashboard.tsx`
+  - Replace `useEffect`→`setState` with derived `useMemo` in `RegisterPage.tsx`
+  - Rewrite `keystore.test.ts` with typed `DrizzleMockChain` (eliminating 7 `any` suppressions)
+  - Delete obvious comments in `encryption.ts` and Teams `provider.ts`
+
+- Updated dependencies [d1a2796]
+  - @checkstack/common@0.6.5
+  - @checkstack/backend-api@0.11.1
+  - @checkstack/auth-backend@0.4.17
+  - @checkstack/auth-common@0.6.1
+  - @checkstack/notification-common@0.2.8
+  - @checkstack/signal-common@0.1.9
+  - @checkstack/queue-api@0.2.12
+
+## 0.1.20
+
+### Patch Changes
+
+- Updated dependencies [54a5f80]
+  - @checkstack/backend-api@0.11.0
+  - @checkstack/auth-backend@0.4.16
+  - @checkstack/queue-api@0.2.11
+
 ## 0.1.19
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@checkstack/notification-backend",
-  "version": "0.1.19",
+  "version": "0.1.21",
   "type": "module",
   "main": "src/index.ts",
   "checkstack": {
@@ -15,10 +15,10 @@
   },
   "dependencies": {
     "@checkstack/notification-common": "0.2.7",
-    "@checkstack/backend-api": "0.10.0",
+    "@checkstack/backend-api": "0.11.0",
     "@checkstack/signal-common": "0.1.8",
-    "@checkstack/queue-api": "0.2.9",
-    "@checkstack/auth-backend": "0.4.14",
+    "@checkstack/queue-api": "0.2.11",
+    "@checkstack/auth-backend": "0.4.16",
     "@checkstack/auth-common": "0.6.0",
     "drizzle-orm": "^0.45.0",
     "zod": "^4.2.1",
@@ -28,8 +28,8 @@
   "devDependencies": {
     "@checkstack/drizzle-helper": "0.0.4",
     "@checkstack/scripts": "0.1.2",
-    "@checkstack/tsconfig": "0.0.4",
-    "@checkstack/test-utils-backend": "0.1.15",
+    "@checkstack/tsconfig": "0.0.5",
+    "@checkstack/test-utils-backend": "0.1.17",
     "@types/node": "^20.0.0",
     "typescript": "^5.0.0"
   }

package/src/router.ts

@@ -39,6 +39,7 @@ import {
   createStrategyService,
   type StrategyService,
 } from "./strategy-service";
+import { extractErrorMessage } from "@checkstack/common";
 
 /**
  * Helper: Resolve user contact information based on strategy's contactResolution type.
@@ -345,10 +346,8 @@ export const createNotificationRouter = (
         await subscribeToGroup(database, userId, input.groupId);
       } catch (error) {
         // Convert group-not-found errors to proper ORPC errors
-        if (
-          error instanceof Error &&
-          error.message.includes("does not exist")
-        ) {
+        const message = extractErrorMessage(error);
+        if (message.includes("does not exist")) {
           throw new ORPCError("NOT_FOUND", {
             message: `Notification group '${input.groupId}' does not exist. It may not have been created yet.`,
           });
@@ -680,7 +679,7 @@ export const createNotificationRouter = (
           results.push({
             strategyId: strategy.qualifiedId,
             success: false,
-            error: error instanceof Error ? error.message : "Unknown error",
+            error: extractErrorMessage(error, "Unknown error"),
           });
         }
       }
@@ -1077,9 +1076,7 @@ export const createNotificationRouter = (
           return {
             success: false,
             error:
-              error instanceof Error
-                ? error.message
-                : "Failed to send test notification",
+              extractErrorMessage(error, "Failed to send test notification"),
           };
         }
       }