@checkstack/integration-teams-backend 0.0.21 → 0.0.23

package/CHANGELOG.md

@@ -1,5 +1,47 @@
 # @checkstack/integration-teams-backend
 
+## 0.0.23
+
+### Patch Changes
+
+- d1a2796: Enforce stricter code quality standards and eliminate AI slop anti-patterns.
+
+  **New utility**
+
+  - `extractErrorMessage(error, fallback?)` in `@checkstack/common` for consistent error extraction
+
+  **ESLint rules**
+
+  - `react-hooks/rules-of-hooks` and `exhaustive-deps` for hook correctness
+  - `no-console` in frontend packages — forces `toast` over silent `console.error`
+  - `no-restricted-syntax` banning `instanceof Error` — forces `extractErrorMessage`
+  - Custom `no-eslint-disable-any` rule preventing `@typescript-eslint/no-explicit-any` circumvention
+
+  **Refactoring**
+
+  - Replace 141 `instanceof Error` boilerplate patterns across the codebase
+  - Replace swallowed `console.error` with user-visible `toast.error()` feedback
+  - Remove 15 redundant `as` type casts in IntegrationsPage and ProviderConnectionsPage
+  - Consolidate 3 identical callback handlers into `handleDialogClose`
+  - Fix conditional React hook call in `FormField.tsx`
+  - Fix unstable useMemo deps in `Dashboard.tsx`
+  - Replace `useEffect`→`setState` with derived `useMemo` in `RegisterPage.tsx`
+  - Rewrite `keystore.test.ts` with typed `DrizzleMockChain` (eliminating 7 `any` suppressions)
+  - Delete obvious comments in `encryption.ts` and Teams `provider.ts`
+
+- Updated dependencies [d1a2796]
+  - @checkstack/common@0.6.5
+  - @checkstack/backend-api@0.11.1
+  - @checkstack/integration-backend@0.1.18
+
+## 0.0.22
+
+### Patch Changes
+
+- Updated dependencies [54a5f80]
+  - @checkstack/backend-api@0.11.0
+  - @checkstack/integration-backend@0.1.17
+
 ## 0.0.21
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@checkstack/integration-teams-backend",
-  "version": "0.0.21",
+  "version": "0.0.23",
   "type": "module",
   "main": "src/index.ts",
   "checkstack": {
@@ -12,14 +12,14 @@
     "lint:code": "eslint . --max-warnings 0"
   },
   "dependencies": {
-    "@checkstack/backend-api": "0.10.0",
-    "@checkstack/integration-backend": "0.1.15",
+    "@checkstack/backend-api": "0.11.0",
+    "@checkstack/integration-backend": "0.1.17",
     "@checkstack/common": "0.6.4",
     "zod": "^4.2.1"
   },
   "devDependencies": {
     "@types/bun": "^1.0.0",
     "typescript": "^5.0.0",
-    "@checkstack/tsconfig": "0.0.4"
+    "@checkstack/tsconfig": "0.0.5"
   }
 }

package/src/provider.ts

@@ -8,6 +8,7 @@ import type {
   ConnectionOption,
   TestConnectionResult,
 } from "@checkstack/integration-backend";
+import { extractErrorMessage } from "@checkstack/common";
 
 // ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 // Resolver Names
@@ -124,7 +125,7 @@ async function getAppToken(
     const data = (await response.json()) as TokenResponse;
     return { success: true, token: data.access_token };
   } catch (error) {
-    const message = error instanceof Error ? error.message : "Unknown error";
+    const message = extractErrorMessage(error, "Unknown error");
     return { success: false, error: message };
   }
 }
@@ -149,7 +150,7 @@ async function fetchTeams(
     const data = (await response.json()) as GraphTeamsResponse;
     return { success: true, teams: data.value ?? [] };
   } catch (error) {
-    const message = error instanceof Error ? error.message : "Unknown error";
+    const message = extractErrorMessage(error, "Unknown error");
     return { success: false, error: message };
   }
 }
@@ -176,7 +177,7 @@ async function fetchChannels(
     const data = (await response.json()) as GraphChannelsResponse;
     return { success: true, channels: data.value ?? [] };
   } catch (error) {
-    const message = error instanceof Error ? error.message : "Unknown error";
+    const message = extractErrorMessage(error, "Unknown error");
     return { success: false, error: message };
   }
 }
@@ -297,7 +298,7 @@ For the app to send messages, it must be installed in the target Team:
       getConnectionWithCredentials,
     } = params;
 
-    // Get connection credentials
+
     const connection = await getConnectionWithCredentials(connectionId);
     if (!connection) {
       return [];
@@ -305,7 +306,7 @@ For the app to send messages, it must be installed in the target Team:
 
     const config = connection.config as TeamsConnectionConfig;
 
-    // Get app token
+
     const tokenResult = await getAppToken(config);
     if (!tokenResult.success) {
       return [];
@@ -353,7 +354,7 @@ For the app to send messages, it must be installed in the target Team:
         };
       }
 
-      // Verify we can list teams
+      // Verify Graph API access by listing teams
       const teamsResult = await fetchTeams(tokenResult.token);
       if (!teamsResult.success) {
         return {
@@ -368,7 +369,7 @@ For the app to send messages, it must be installed in the target Team:
       };
     } catch (error) {
       const message =
-        error instanceof Error ? error.message : "Invalid configuration";
+        extractErrorMessage(error, "Invalid configuration");
       return {
         success: false,
         message: `Validation failed: ${message}`,
@@ -381,10 +382,8 @@ For the app to send messages, it must be installed in the target Team:
   ): Promise<IntegrationDeliveryResult> {
     const { event, subscription, providerConfig, logger } = context;
 
-    // Parse and validate config
     const config = TeamsSubscriptionSchema.parse(providerConfig);
 
-    // Get connection with credentials
     if (!context.getConnectionWithCredentials) {
       return {
         success: false,
@@ -405,7 +404,7 @@ For the app to send messages, it must be installed in the target Team:
 
     const connectionConfig = connection.config as TeamsConnectionConfig;
 
-    // Get app token
+
     const tokenResult = await getAppToken(connectionConfig);
     if (!tokenResult.success) {
       logger.error("Failed to get Graph API token", {
@@ -417,7 +416,7 @@ For the app to send messages, it must be installed in the target Team:
       };
     }
 
-    // Build Adaptive Card
+
     const adaptiveCard = buildAdaptiveCard({
       eventId: event.eventId,
       payload: event.payload as Record<string, unknown>,
@@ -425,7 +424,7 @@ For the app to send messages, it must be installed in the target Team:
       timestamp: event.timestamp,
     });
 
-    // Send message to channel
+
     try {
       const response = await fetch(
         `${GRAPH_API_BASE}/teams/${config.teamId}/channels/${config.channelId}/messages`,
@@ -476,7 +475,7 @@ For the app to send messages, it must be installed in the target Team:
       };
     } catch (error) {
       const message =
-        error instanceof Error ? error.message : "Unknown Graph API error";
+        extractErrorMessage(error, "Unknown Graph API error");
       logger.error("Teams delivery error", { error: message });
       return {
         success: false,