@checkstack/incident-frontend 0.4.15 → 0.4.16

package/CHANGELOG.md

@@ -1,5 +1,45 @@
 # @checkstack/incident-frontend
 
+## 0.4.16
+
+### Patch Changes
+
+- d1a2796: Enforce stricter code quality standards and eliminate AI slop anti-patterns.
+
+  **New utility**
+
+  - `extractErrorMessage(error, fallback?)` in `@checkstack/common` for consistent error extraction
+
+  **ESLint rules**
+
+  - `react-hooks/rules-of-hooks` and `exhaustive-deps` for hook correctness
+  - `no-console` in frontend packages — forces `toast` over silent `console.error`
+  - `no-restricted-syntax` banning `instanceof Error` — forces `extractErrorMessage`
+  - Custom `no-eslint-disable-any` rule preventing `@typescript-eslint/no-explicit-any` circumvention
+
+  **Refactoring**
+
+  - Replace 141 `instanceof Error` boilerplate patterns across the codebase
+  - Replace swallowed `console.error` with user-visible `toast.error()` feedback
+  - Remove 15 redundant `as` type casts in IntegrationsPage and ProviderConnectionsPage
+  - Consolidate 3 identical callback handlers into `handleDialogClose`
+  - Fix conditional React hook call in `FormField.tsx`
+  - Fix unstable useMemo deps in `Dashboard.tsx`
+  - Replace `useEffect`→`setState` with derived `useMemo` in `RegisterPage.tsx`
+  - Rewrite `keystore.test.ts` with typed `DrizzleMockChain` (eliminating 7 `any` suppressions)
+  - Delete obvious comments in `encryption.ts` and Teams `provider.ts`
+
+- Updated dependencies [d1a2796]
+- Updated dependencies [3c34b07]
+  - @checkstack/common@0.6.5
+  - @checkstack/ui@1.2.1
+  - @checkstack/auth-frontend@0.5.18
+  - @checkstack/dashboard-frontend@0.3.26
+  - @checkstack/frontend-api@0.3.9
+  - @checkstack/catalog-common@1.3.1
+  - @checkstack/incident-common@0.4.7
+  - @checkstack/signal-frontend@0.0.15
+
 ## 0.4.15
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@checkstack/incident-frontend",
-  "version": "0.4.15",
+  "version": "0.4.16",
   "type": "module",
   "main": "src/index.tsx",
   "checkstack": {
@@ -13,9 +13,9 @@
   },
   "dependencies": {
     "@checkstack/auth-frontend": "0.5.17",
-    "@checkstack/catalog-common": "1.2.11",
+    "@checkstack/catalog-common": "1.3.0",
     "@checkstack/common": "0.6.4",
-    "@checkstack/dashboard-frontend": "0.3.23",
+    "@checkstack/dashboard-frontend": "0.3.25",
     "@checkstack/frontend-api": "0.3.8",
     "@checkstack/incident-common": "0.4.6",
     "@checkstack/signal-frontend": "0.0.14",
@@ -28,7 +28,7 @@
   "devDependencies": {
     "typescript": "^5.0.0",
     "@types/react": "^18.2.0",
-    "@checkstack/tsconfig": "0.0.4",
+    "@checkstack/tsconfig": "0.0.5",
     "@checkstack/scripts": "0.1.2"
   }
 }

package/src/components/IncidentEditor.tsx

@@ -31,6 +31,7 @@ import { Plus, MessageSquare, Loader2, AlertCircle } from "lucide-react";
 import { IncidentUpdateForm } from "./IncidentUpdateForm";
 import { getIncidentStatusBadge } from "../utils/badges";
 import { TeamAccessEditor } from "@checkstack/auth-frontend";
+import { extractErrorMessage } from "@checkstack/common";
 
 interface Props {
   open: boolean;
@@ -71,7 +72,7 @@ export const IncidentEditor: React.FC<Props> = ({
       onSave();
     },
     onError: (error) => {
-      toast.error(error instanceof Error ? error.message : "Failed to save");
+      toast.error(extractErrorMessage(error, "Failed to save"));
     },
   });
 
@@ -81,7 +82,7 @@ export const IncidentEditor: React.FC<Props> = ({
       onSave();
     },
     onError: (error) => {
-      toast.error(error instanceof Error ? error.message : "Failed to save");
+      toast.error(extractErrorMessage(error, "Failed to save"));
     },
   });
 

package/src/components/IncidentUpdateForm.tsx

@@ -14,6 +14,7 @@ import {
   useToast,
 } from "@checkstack/ui";
 import { Loader2 } from "lucide-react";
+import { extractErrorMessage } from "@checkstack/common";
 
 interface IncidentUpdateFormProps {
   incidentId: string;
@@ -45,7 +46,7 @@ export const IncidentUpdateForm: React.FC<IncidentUpdateFormProps> = ({
     },
     onError: (error) => {
       toast.error(
-        error instanceof Error ? error.message : "Failed to post update"
+        extractErrorMessage(error, "Failed to post update")
       );
     },
   });

package/src/pages/IncidentConfigPage.tsx

@@ -47,6 +47,7 @@ import {
 } from "lucide-react";
 import { formatDistanceToNow } from "date-fns";
 import { IncidentEditor } from "../components/IncidentEditor";
+import { extractErrorMessage } from "@checkstack/common";
 
 const IncidentConfigPageContent: React.FC = () => {
   const incidentClient = usePluginClient(IncidentApi);
@@ -114,7 +115,7 @@ const IncidentConfigPageContent: React.FC = () => {
       setDeleteId(undefined);
     },
     onError: (error) => {
-      toast.error(error instanceof Error ? error.message : "Failed to delete");
+      toast.error(extractErrorMessage(error, "Failed to delete"));
     },
   });
 
@@ -125,7 +126,7 @@ const IncidentConfigPageContent: React.FC = () => {
       setResolveId(undefined);
     },
     onError: (error) => {
-      toast.error(error instanceof Error ? error.message : "Failed to resolve");
+      toast.error(extractErrorMessage(error, "Failed to resolve"));
     },
   });
 

package/src/pages/IncidentDetailPage.tsx

@@ -7,7 +7,7 @@ import {
   wrapInSuspense,
 } from "@checkstack/frontend-api";
 import { useSignal } from "@checkstack/signal-frontend";
-import { resolveRoute } from "@checkstack/common";
+import { resolveRoute, extractErrorMessage} from "@checkstack/common";
 import { IncidentApi } from "../api";
 import {
   incidentRoutes,
@@ -91,7 +91,7 @@ const IncidentDetailPageContent: React.FC = () => {
       void refetchIncident();
     },
     onError: (error) => {
-      toast.error(error instanceof Error ? error.message : "Failed to resolve");
+      toast.error(extractErrorMessage(error, "Failed to resolve"));
     },
   });