@checkstack/incident-common 0.3.1 → 0.3.3

package/CHANGELOG.md

@@ -1,5 +1,27 @@
 # @checkstack/incident-common
 
+## 0.3.3
+
+### Patch Changes
+
+- 8a87cd4: Updated access rules to use new `accessPair` interface
+
+  Migrated to the new `accessPair` interface with per-level options objects for cleaner access rule definitions.
+
+- Updated dependencies [8a87cd4]
+  - @checkstack/common@0.5.0
+  - @checkstack/frontend-api@0.3.2
+  - @checkstack/signal-common@0.1.3
+
+## 0.3.2
+
+### Patch Changes
+
+- Updated dependencies [83557c7]
+  - @checkstack/common@0.4.0
+  - @checkstack/frontend-api@0.3.1
+  - @checkstack/signal-common@0.1.2
+
 ## 0.3.1
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@checkstack/incident-common",
-  "version": "0.3.1",
+  "version": "0.3.3",
   "type": "module",
   "exports": {
     ".": {

package/src/access.ts

@@ -1,4 +1,4 @@
-import { access, accessPair } from "@checkstack/common";
+import { accessPair } from "@checkstack/common";
 
 /**
  * Access rules for the Incident plugin.
@@ -8,29 +8,26 @@ export const incidentAccess = {
    * Incident access with both read and manage levels.
    * Read is public by default.
    * Uses system-level instance access for team-based filtering.
+   *
+   * Bulk endpoints should use the same access rule with instanceAccess
+   * override at the contract level.
    */
   incident: accessPair(
     "incident",
     {
-      read: "View incidents",
-      manage: "Manage incidents - create, edit, resolve, and delete",
+      read: {
+        description: "View incidents",
+        isDefault: true,
+        isPublic: true,
+      },
+      manage: {
+        description: "Manage incidents - create, edit, resolve, and delete",
+      },
     },
     {
       idParam: "systemId",
-      readIsDefault: true,
-      readIsPublic: true,
-    }
+    },
   ),
-
-  /**
-   * Bulk incident access for viewing incidents for multiple systems.
-   * Uses recordKey for filtering the output record by accessible system IDs.
-   */
-  bulkIncident: access("incident.incident", "read", "View incidents", {
-    recordKey: "incidents",
-    isDefault: true,
-    isPublic: true,
-  }),
 };
 
 /**

package/src/rpc-contract.ts

@@ -26,7 +26,7 @@ export const incidentContract = {
           systemId: z.string().optional(),
           includeResolved: z.boolean().optional().default(false),
         })
-        .optional()
+        .optional(),
     )
     .output(z.object({ incidents: z.array(IncidentWithSystemsSchema) })),
 
@@ -54,13 +54,14 @@ export const incidentContract = {
   getBulkIncidentsForSystems: proc({
     operationType: "query",
     userType: "public",
-    access: [incidentAccess.bulkIncident],
+    access: [incidentAccess.incident.read],
+    instanceAccess: { recordKey: "incidents" },
   })
     .input(z.object({ systemIds: z.array(z.string()) }))
     .output(
       z.object({
         incidents: z.record(z.string(), z.array(IncidentWithSystemsSchema)),
-      })
+      }),
     ),
 
   /** Create a new incident */
@@ -116,5 +117,5 @@ export type IncidentContract = typeof incidentContract;
 // Use: const client = rpcApi.forPlugin(IncidentApi);
 export const IncidentApi = createClientDefinition(
   incidentContract,
-  pluginMetadata
+  pluginMetadata,
 );