@checkstack/healthcheck-ssh-backend 0.1.14 → 0.2.1

package/CHANGELOG.md

@@ -1,5 +1,53 @@
 # @checkstack/healthcheck-ssh-backend
 
+## 0.2.1
+
+### Patch Changes
+
+- 869b4ab: ## Health Check Execution Improvements
+
+  ### Breaking Changes (backend-api)
+
+  - `HealthCheckStrategy.createClient()` now accepts `unknown` instead of `TConfig` due to TypeScript contravariance constraints. Implementations should use `this.config.validate(config)` to narrow the type.
+
+  ### Features
+
+  - **Platform-level hard timeout**: The executor now wraps the entire health check execution (connection + all collectors) in a single timeout, ensuring checks never hang indefinitely.
+  - **Parallel collector execution**: Collectors now run in parallel using `Promise.allSettled()`, improving performance while ensuring all collectors complete regardless of individual failures.
+  - **Base strategy config schema**: All strategy configs now extend `baseStrategyConfigSchema` which provides a standardized `timeout` field with sensible defaults (30s, min 100ms).
+
+  ### Fixes
+
+  - Fixed HTTP and Jenkins strategies clearing timeouts before reading the full response body.
+  - Simplified registry type signatures by using default type parameters.
+
+- Updated dependencies [869b4ab]
+  - @checkstack/backend-api@0.8.0
+
+## 0.2.0
+
+### Minor Changes
+
+- 3dd1914: Migrate health check strategies to VersionedAggregated with \_type discriminator
+
+  All 13 health check strategies now use `VersionedAggregated` for their `aggregatedResult` property, enabling automatic bucket merging with 100% mathematical fidelity.
+
+  **Key changes:**
+
+  - **`_type` discriminator**: All aggregated state objects now include a required `_type` field (`"average"`, `"rate"`, `"counter"`, `"minmax"`) for reliable type detection
+  - The `HealthCheckStrategy` interface now requires `aggregatedResult` to be a `VersionedAggregated<AggregatedResultShape>`
+  - Strategy/collector `mergeResult` methods return state objects with `_type` (e.g., `{ _type: "average", _sum, _count, avg }`)
+  - `mergeAggregatedBucketResults`, `combineBuckets`, and `reaggregateBuckets` now require `registry` and `strategyId` parameters
+  - `HealthCheckService` constructor now requires both `registry` and `collectorRegistry` parameters
+  - Frontend `extractComputedValue` now uses `_type` discriminator for robust type detection
+
+  **Breaking Change**: State objects now require `_type`. Merge functions automatically add `_type` to output. The bucket merging functions and `HealthCheckService` now require additional required parameters.
+
+### Patch Changes
+
+- Updated dependencies [3dd1914]
+  - @checkstack/backend-api@0.7.0
+
 ## 0.1.14
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@checkstack/healthcheck-ssh-backend",
-  "version": "0.1.14",
+  "version": "0.2.1",
   "type": "module",
   "main": "src/index.ts",
   "scripts": {
@@ -9,10 +9,10 @@
     "lint:code": "eslint . --max-warnings 0"
   },
   "dependencies": {
-    "@checkstack/backend-api": "0.5.2",
-    "@checkstack/common": "0.6.1",
-    "@checkstack/healthcheck-common": "0.8.1",
-    "@checkstack/healthcheck-ssh-common": "0.1.7",
+    "@checkstack/backend-api": "0.7.0",
+    "@checkstack/common": "0.6.2",
+    "@checkstack/healthcheck-common": "0.8.2",
+    "@checkstack/healthcheck-ssh-common": "0.1.8",
     "ssh2": "^1.15.0"
   },
   "devDependencies": {

package/src/command-collector.test.ts

@@ -104,8 +104,8 @@ describe("CommandCollector", () => {
       let aggregated = collector.mergeResult(undefined, runs[0]);
       aggregated = collector.mergeResult(aggregated, runs[1]);
 
-      expect(aggregated.avgExecutionTimeMs).toBe(75);
-      expect(aggregated.successRate).toBe(100);
+      expect(aggregated.avgExecutionTimeMs.avg).toBe(75);
+      expect(aggregated.successRate.rate).toBe(100);
     });
 
     it("should calculate success rate based on exit codes", () => {
@@ -142,7 +142,7 @@ describe("CommandCollector", () => {
       let aggregated = collector.mergeResult(undefined, runs[0]);
       aggregated = collector.mergeResult(aggregated, runs[1]);
 
-      expect(aggregated.successRate).toBe(50);
+      expect(aggregated.successRate.rate).toBe(50);
     });
   });
 

package/src/command-collector.ts

@@ -5,11 +5,11 @@ import {
   type CollectorResult,
   type CollectorStrategy,
   mergeAverage,
-  averageStateSchema,
   mergeRate,
-  rateStateSchema,
-  type AverageState,
-  type RateState,
+  VersionedAggregated,
+  aggregatedAverage,
+  aggregatedRate,
+  type InferAggregatedResult,
 } from "@checkstack/backend-api";
 import {
   healthResultNumber,
@@ -55,31 +55,24 @@ const commandResultSchema = healthResultSchema({
 
 export type CommandResult = z.infer<typeof commandResultSchema>;
 
-const commandAggregatedDisplaySchema = healthResultSchema({
-  avgExecutionTimeMs: healthResultNumber({
+// Aggregated result fields definition
+const commandAggregatedFields = {
+  avgExecutionTimeMs: aggregatedAverage({
     "x-chart-type": "line",
     "x-chart-label": "Avg Execution Time",
     "x-chart-unit": "ms",
   }),
-  successRate: healthResultNumber({
+  successRate: aggregatedRate({
     "x-chart-type": "gauge",
     "x-chart-label": "Success Rate",
     "x-chart-unit": "%",
   }),
-});
-
-const commandAggregatedInternalSchema = z.object({
-  _executionTime: averageStateSchema
-    .optional(),
-  _success: rateStateSchema
-    .optional(),
-});
+};
 
-const commandAggregatedSchema = commandAggregatedDisplaySchema.merge(
-  commandAggregatedInternalSchema,
-);
-
-export type CommandAggregatedResult = z.infer<typeof commandAggregatedSchema>;
+// Type inferred from field definitions
+export type CommandAggregatedResult = InferAggregatedResult<
+  typeof commandAggregatedFields
+>;
 
 // ============================================================================
 // COMMAND COLLECTOR (PSEUDO-COLLECTOR)
@@ -112,9 +105,9 @@ export class CommandCollector implements CollectorStrategy<
 
   config = new Versioned({ version: 1, schema: commandConfigSchema });
   result = new Versioned({ version: 1, schema: commandResultSchema });
-  aggregatedResult = new Versioned({
+  aggregatedResult = new VersionedAggregated({
     version: 1,
-    schema: commandAggregatedSchema,
+    fields: commandAggregatedFields,
   });
 
   async execute({
@@ -145,22 +138,13 @@ export class CommandCollector implements CollectorStrategy<
   ): CommandAggregatedResult {
     const metadata = run.metadata;
 
-    const executionTimeState = mergeAverage(
-      existing?._executionTime as AverageState | undefined,
-      metadata?.executionTimeMs,
-    );
-
     // Success is exit code 0
-    const successState = mergeRate(
-      existing?._success as RateState | undefined,
-      metadata?.exitCode === 0,
-    );
-
     return {
-      avgExecutionTimeMs: executionTimeState.avg,
-      successRate: successState.rate,
-      _executionTime: executionTimeState,
-      _success: successState,
+      avgExecutionTimeMs: mergeAverage(
+        existing?.avgExecutionTimeMs,
+        metadata?.executionTimeMs,
+      ),
+      successRate: mergeRate(existing?.successRate, metadata?.exitCode === 0),
     };
   }
 }

package/src/strategy.test.ts

@@ -142,9 +142,9 @@ describe("SshHealthCheckStrategy", () => {
       let aggregated = strategy.mergeResult(undefined, runs[0]);
       aggregated = strategy.mergeResult(aggregated, runs[1]);
 
-      expect(aggregated.avgConnectionTime).toBe(75);
-      expect(aggregated.successRate).toBe(100);
-      expect(aggregated.errorCount).toBe(0);
+      expect(aggregated.avgConnectionTime.avg).toBe(75);
+      expect(aggregated.successRate.rate).toBe(100);
+      expect(aggregated.errorCount.count).toBe(0);
     });
 
     it("should count errors", () => {
@@ -164,8 +164,8 @@ describe("SshHealthCheckStrategy", () => {
 
       const aggregated = strategy.mergeResult(undefined, run);
 
-      expect(aggregated.errorCount).toBe(1);
-      expect(aggregated.successRate).toBe(0);
+      expect(aggregated.errorCount.count).toBe(1);
+      expect(aggregated.successRate.rate).toBe(0);
     });
   });
 });

package/src/strategy.ts

@@ -3,22 +3,20 @@ import {
   HealthCheckStrategy,
   HealthCheckRunForAggregation,
   Versioned,
-  z,
-  configString,
-  configNumber,
-  type ConnectedClient,
+  VersionedAggregated,
+  aggregatedAverage,
+  aggregatedMinMax,
+  aggregatedRate,
+  aggregatedCounter,
   mergeAverage,
-  averageStateSchema,
   mergeRate,
-  rateStateSchema,
   mergeCounter,
-  counterStateSchema,
   mergeMinMax,
-  minMaxStateSchema,
-  type AverageState,
-  type RateState,
-  type CounterState,
-  type MinMaxState,
+  z,
+  configString,
+  type ConnectedClient,
+  type InferAggregatedResult,
+  baseStrategyConfigSchema,
 } from "@checkstack/backend-api";
 import {
   healthResultBoolean,
@@ -35,7 +33,7 @@ import type { SshTransportClient, SshCommandResult } from "./transport-client";
 /**
  * Configuration schema for SSH health checks.
  */
-export const sshConfigSchema = z.object({
+export const sshConfigSchema = baseStrategyConfigSchema.extend({
   host: z.string().describe("SSH server hostname"),
   port: z.number().int().min(1).max(65_535).default(22).describe("SSH port"),
   username: z.string().describe("SSH username"),
@@ -48,10 +46,6 @@ export const sshConfigSchema = z.object({
   passphrase: configString({ "x-secret": true })
     .describe("Passphrase for private key")
     .optional(),
-  timeout: configNumber({})
-    .min(100)
-    .default(10_000)
-    .describe("Connection timeout in milliseconds"),
 });
 
 export type SshConfig = z.infer<typeof sshConfigSchema>;
@@ -78,45 +72,30 @@ const sshResultSchema = healthResultSchema({
 
 type SshResult = z.infer<typeof sshResultSchema>;
 
-/**
- * Aggregated metadata for buckets.
- */
-const sshAggregatedDisplaySchema = healthResultSchema({
-  avgConnectionTime: healthResultNumber({
+/** Aggregated field definitions for bucket merging */
+const sshAggregatedFields = {
+  avgConnectionTime: aggregatedAverage({
     "x-chart-type": "line",
     "x-chart-label": "Avg Connection Time",
     "x-chart-unit": "ms",
   }),
-  maxConnectionTime: healthResultNumber({
+  maxConnectionTime: aggregatedMinMax({
     "x-chart-type": "line",
     "x-chart-label": "Max Connection Time",
     "x-chart-unit": "ms",
   }),
-  successRate: healthResultNumber({
+  successRate: aggregatedRate({
     "x-chart-type": "gauge",
     "x-chart-label": "Success Rate",
     "x-chart-unit": "%",
   }),
-  errorCount: healthResultNumber({
+  errorCount: aggregatedCounter({
     "x-chart-type": "counter",
     "x-chart-label": "Errors",
   }),
-});
-
-const sshAggregatedInternalSchema = z.object({
-  _connectionTime: averageStateSchema
-    .optional(),
-  _maxConnectionTime: minMaxStateSchema.optional(),
-  _success: rateStateSchema
-    .optional(),
-  _errors: counterStateSchema.optional(),
-});
-
-const sshAggregatedSchema = sshAggregatedDisplaySchema.merge(
-  sshAggregatedInternalSchema,
-);
+};
 
-type SshAggregatedResult = z.infer<typeof sshAggregatedSchema>;
+type SshAggregatedResult = InferAggregatedResult<typeof sshAggregatedFields>;
 
 // ============================================================================
 // SSH CLIENT INTERFACE (for testability)
@@ -207,7 +186,7 @@ export class SshHealthCheckStrategy implements HealthCheckStrategy<
   SshConfig,
   SshTransportClient,
   SshResult,
-  SshAggregatedResult
+  typeof sshAggregatedFields
 > {
   id = "ssh";
   displayName = "SSH Health Check";
@@ -229,9 +208,9 @@ export class SshHealthCheckStrategy implements HealthCheckStrategy<
     schema: sshResultSchema,
   });
 
-  aggregatedResult: Versioned<SshAggregatedResult> = new Versioned({
+  aggregatedResult = new VersionedAggregated({
     version: 1,
-    schema: sshAggregatedSchema,
+    fields: sshAggregatedFields,
   });
 
   mergeResult(
@@ -240,36 +219,23 @@ export class SshHealthCheckStrategy implements HealthCheckStrategy<
   ): SshAggregatedResult {
     const metadata = run.metadata;
 
-    const connectionTimeState = mergeAverage(
-      existing?._connectionTime as AverageState | undefined,
+    const avgConnectionTime = mergeAverage(
+      existing?.avgConnectionTime,
       metadata?.connectionTimeMs,
     );
 
-    const maxConnectionTimeState = mergeMinMax(
-      existing?._maxConnectionTime as MinMaxState | undefined,
+    const maxConnectionTime = mergeMinMax(
+      existing?.maxConnectionTime,
       metadata?.connectionTimeMs,
     );
 
-    const successState = mergeRate(
-      existing?._success as RateState | undefined,
-      metadata?.connected,
-    );
+    const isSuccess = metadata?.connected ?? false;
+    const successRate = mergeRate(existing?.successRate, isSuccess);
 
-    const errorState = mergeCounter(
-      existing?._errors as CounterState | undefined,
-      metadata?.error !== undefined,
-    );
+    const hasError = metadata?.error !== undefined;
+    const errorCount = mergeCounter(existing?.errorCount, hasError);
 
-    return {
-      avgConnectionTime: connectionTimeState.avg,
-      maxConnectionTime: maxConnectionTimeState.max,
-      successRate: successState.rate,
-      errorCount: errorState.count,
-      _connectionTime: connectionTimeState,
-      _maxConnectionTime: maxConnectionTimeState,
-      _success: successState,
-      _errors: errorState,
-    };
+    return { avgConnectionTime, maxConnectionTime, successRate, errorCount };
   }
 
   /**