@checkstack/healthcheck-script-backend 0.8.3 → 0.8.4

package/CHANGELOG.md

@@ -1,5 +1,23 @@
 # @checkstack/healthcheck-script-backend
 
+## 0.8.4
+
+### Patch Changes
+
+- Updated dependencies [52c55bf]
+- Updated dependencies [d9f4654]
+- Updated dependencies [21e0d88]
+- Updated dependencies [52c55bf]
+- Updated dependencies [e430fbe]
+- Updated dependencies [eab80e3]
+- Updated dependencies [d2d49cf]
+- Updated dependencies [0d912a3]
+  - @checkstack/healthcheck-common@1.10.0
+  - @checkstack/common@0.19.0
+  - @checkstack/backend-api@0.27.0
+  - @checkstack/script-packages-backend@0.3.19
+  - @checkstack/secrets-common@0.2.8
+
 ## 0.8.3
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@checkstack/healthcheck-script-backend",
-  "version": "0.8.3",
+  "version": "0.8.4",
   "type": "module",
   "main": "src/index.ts",
   "checkstack": {
@@ -14,17 +14,17 @@
     "pack": "bunx @checkstack/scripts plugin-pack"
   },
   "dependencies": {
-    "@checkstack/backend-api": "0.26.1",
-    "@checkstack/common": "0.18.0",
-    "@checkstack/healthcheck-common": "1.9.0",
-    "@checkstack/script-packages-backend": "0.3.18",
-    "@checkstack/secrets-common": "0.2.7"
+    "@checkstack/backend-api": "0.27.0",
+    "@checkstack/common": "0.19.0",
+    "@checkstack/healthcheck-common": "1.10.0",
+    "@checkstack/script-packages-backend": "0.3.19",
+    "@checkstack/secrets-common": "0.2.8"
   },
   "devDependencies": {
     "@types/bun": "^1.0.0",
     "typescript": "^5.0.0",
     "@checkstack/tsconfig": "0.0.7",
-    "@checkstack/scripts": "0.6.5"
+    "@checkstack/scripts": "0.7.0"
   },
   "description": "Checkstack healthcheck-script-backend plugin",
   "author": {

package/src/concurrency.test.ts

@@ -1,6 +1,7 @@
 import { describe, expect, it } from "bun:test";
-import { readdir } from "node:fs/promises";
+import { mkdtemp, readdir, rm } from "node:fs/promises";
 import { tmpdir } from "node:os";
+import { join } from "node:path";
 import { InlineScriptCollector } from "./inline-script-collector";
 import { ScriptHealthCheckStrategy } from "./strategy";
 import type { ScriptTransportClient } from "./transport-client";
@@ -18,9 +19,31 @@ import type { ScriptTransportClient } from "./transport-client";
 const PARALLELISM = 20;
 const TMP_PREFIX = "checkstack-script-";
 
-async function countLeakedTmpDirs(): Promise<number> {
-  const entries = await readdir(tmpdir());
-  return entries.filter((name) => name.startsWith(TMP_PREFIX)).length;
+/**
+ * Create a throwaway base dir and a collector whose per-run scratch dirs are
+ * created *inside* it (via `resolutionRoot`). This isolates the leak check
+ * from every other test file that also spawns scripts into the shared
+ * `os.tmpdir()` — the main source of cross-file flakes. Returns the base dir
+ * (caller removes it) plus a `countLeaked()` that only counts dirs under it.
+ */
+async function isolatedScope(): Promise<{
+  collector: InlineScriptCollector;
+  countLeaked: () => Promise<number>;
+  cleanup: () => Promise<void>;
+}> {
+  const base = await mkdtemp(join(tmpdir(), "cs-concurrency-test-"));
+  const collector = new InlineScriptCollector(
+    undefined,
+    () => Promise.resolve({ mode: "ready" as const, root: base }),
+  );
+  return {
+    collector,
+    countLeaked: async () =>
+      (await readdir(base)).filter((n) => n.startsWith(TMP_PREFIX)).length,
+    cleanup: async () => {
+      await rm(base, { recursive: true, force: true });
+    },
+  };
 }
 
 const mockClient: ScriptTransportClient = {
@@ -68,8 +91,8 @@ describe("inline-script concurrency", () => {
   }, 60_000);
 
   it("cleans up temp dirs even when scripts throw", async () => {
-    const collector = new InlineScriptCollector();
-    const before = await countLeakedTmpDirs();
+    const { collector, countLeaked, cleanup } = await isolatedScope();
+    const before = await countLeaked();
 
     await Promise.all(
       Array.from({ length: PARALLELISM }, () =>
@@ -88,13 +111,14 @@ describe("inline-script concurrency", () => {
       ),
     );
 
-    const after = await countLeakedTmpDirs();
+    const after = await countLeaked();
     expect(after).toBe(before);
+    await cleanup();
   }, 60_000);
 
   it("cleans up temp dirs when scripts time out", async () => {
-    const collector = new InlineScriptCollector();
-    const before = await countLeakedTmpDirs();
+    const { collector, countLeaked, cleanup } = await isolatedScope();
+    const before = await countLeaked();
 
     await Promise.all(
       Array.from({ length: 5 }, () =>
@@ -114,8 +138,9 @@ describe("inline-script concurrency", () => {
     // the kernel can be slow to drop fds on macOS.
     await new Promise((r) => setTimeout(r, 100));
 
-    const after = await countLeakedTmpDirs();
+    const after = await countLeaked();
     expect(after).toBe(before);
+    await cleanup();
   }, 30_000);
 });