@checkstack/healthcheck-frontend 0.9.0 → 0.10.0

package/CHANGELOG.md

@@ -1,5 +1,38 @@
 # @checkstack/healthcheck-frontend
 
+## 0.10.0
+
+### Minor Changes
+
+- 3dd1914: Migrate health check strategies to VersionedAggregated with \_type discriminator
+
+  All 13 health check strategies now use `VersionedAggregated` for their `aggregatedResult` property, enabling automatic bucket merging with 100% mathematical fidelity.
+
+  **Key changes:**
+
+  - **`_type` discriminator**: All aggregated state objects now include a required `_type` field (`"average"`, `"rate"`, `"counter"`, `"minmax"`) for reliable type detection
+  - The `HealthCheckStrategy` interface now requires `aggregatedResult` to be a `VersionedAggregated<AggregatedResultShape>`
+  - Strategy/collector `mergeResult` methods return state objects with `_type` (e.g., `{ _type: "average", _sum, _count, avg }`)
+  - `mergeAggregatedBucketResults`, `combineBuckets`, and `reaggregateBuckets` now require `registry` and `strategyId` parameters
+  - `HealthCheckService` constructor now requires both `registry` and `collectorRegistry` parameters
+  - Frontend `extractComputedValue` now uses `_type` discriminator for robust type detection
+
+  **Breaking Change**: State objects now require `_type`. Merge functions automatically add `_type` to output. The bucket merging functions and `HealthCheckService` now require additional required parameters.
+
+## 0.9.1
+
+### Patch Changes
+
+- Updated dependencies [f676e11]
+  - @checkstack/ui@1.0.0
+  - @checkstack/common@0.6.2
+  - @checkstack/auth-frontend@0.5.9
+  - @checkstack/dashboard-frontend@0.3.15
+  - @checkstack/catalog-common@1.2.7
+  - @checkstack/frontend-api@0.3.5
+  - @checkstack/healthcheck-common@0.8.2
+  - @checkstack/signal-frontend@0.0.12
+
 ## 0.9.0
 
 ### Minor Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@checkstack/healthcheck-frontend",
-  "version": "0.9.0",
+  "version": "0.10.0",
   "type": "module",
   "main": "src/index.tsx",
   "scripts": {
@@ -9,14 +9,14 @@
     "lint:code": "eslint . --max-warnings 0"
   },
   "dependencies": {
-    "@checkstack/auth-frontend": "0.5.7",
-    "@checkstack/catalog-common": "1.2.5",
+    "@checkstack/auth-frontend": "0.5.8",
+    "@checkstack/catalog-common": "1.2.6",
     "@checkstack/common": "0.6.1",
-    "@checkstack/dashboard-frontend": "0.3.13",
+    "@checkstack/dashboard-frontend": "0.3.14",
     "@checkstack/frontend-api": "0.3.4",
     "@checkstack/healthcheck-common": "0.8.1",
     "@checkstack/signal-frontend": "0.0.11",
-    "@checkstack/ui": "0.5.2",
+    "@checkstack/ui": "0.5.3",
     "ajv": "^8.17.1",
     "ajv-formats": "^3.0.1",
     "date-fns": "^4.1.0",

package/src/auto-charts/schema-parser.ts

@@ -17,8 +17,7 @@ import type {
  * JSON Schema property with healthcheck result-specific x-* extensions.
  * Uses the generic core type for proper recursive typing.
  */
-export interface ResultSchemaProperty
-  extends JsonSchemaPropertyCore<ResultSchemaProperty> {
+export interface ResultSchemaProperty extends JsonSchemaPropertyCore<ResultSchemaProperty> {
   // Result-specific x-* extensions for chart rendering
   "x-chart-type"?: ChartType;
   "x-chart-label"?: string;
@@ -58,7 +57,7 @@ export interface ChartField {
  * @returns Array of chart fields with metadata
  */
 export function extractChartFields(
-  schema: Record<string, unknown> | null | undefined
+  schema: Record<string, unknown> | null | undefined,
 ): ChartField[] {
   if (!schema) return [];
 
@@ -72,13 +71,13 @@ export function extractChartFields(
     if (name === "collectors" && prop.type === "object" && prop.properties) {
       // Traverse each collector's schema
       for (const [collectorId, collectorProp] of Object.entries(
-        prop.properties
+        prop.properties,
       )) {
         if (collectorProp.type === "object" && collectorProp.properties) {
           // Extract fields from the collector's result schema
           const collectorFields = extractFieldsFromProperties(
             collectorProp.properties,
-            collectorId
+            collectorId,
           );
           fields.push(...collectorFields);
         }
@@ -100,7 +99,7 @@ export function extractChartFields(
  */
 function extractFieldsFromProperties(
   properties: Record<string, ResultSchemaProperty>,
-  collectorId: string
+  collectorId: string,
 ): ChartField[] {
   const fields: ChartField[] = [];
 
@@ -126,7 +125,7 @@ function extractFieldsFromProperties(
  */
 function extractSingleField(
   name: string,
-  prop: ResultSchemaProperty
+  prop: ResultSchemaProperty,
 ): ChartField {
   let schemaType = prop.type ?? "unknown";
   if (prop.type === "array" && prop.items?.type) {
@@ -164,6 +163,7 @@ function formatFieldName(name: string): string {
 /**
  * Get the value for a field from a data object.
  * For strategy-level fields, also searches inside collectors as fallback.
+ * Automatically extracts computed values from aggregated state objects.
  *
  * @param data - The metadata object
  * @param fieldName - Simple field name (no dot notation for collector fields)
@@ -172,7 +172,7 @@ function formatFieldName(name: string): string {
 export function getFieldValue(
   data: Record<string, unknown> | undefined,
   fieldName: string,
-  collectorInstanceId?: string
+  collectorInstanceId?: string,
 ): unknown {
   if (!data) return undefined;
 
@@ -184,7 +184,7 @@ export function getFieldValue(
     if (collectors && typeof collectors === "object") {
       const collectorData = collectors[collectorInstanceId];
       if (collectorData && typeof collectorData === "object") {
-        return collectorData[fieldName];
+        return extractComputedValue(collectorData[fieldName]);
       }
     }
     return undefined;
@@ -193,7 +193,7 @@ export function getFieldValue(
   // For non-collector fields, try direct lookup first
   const directValue = data[fieldName];
   if (directValue !== undefined) {
-    return directValue;
+    return extractComputedValue(directValue);
   }
 
   // Fallback: search all collectors for the field (for strategy schema fields)
@@ -205,7 +205,7 @@ export function getFieldValue(
       if (collectorData && typeof collectorData === "object") {
         const value = collectorData[fieldName];
         if (value !== undefined) {
-          return value;
+          return extractComputedValue(value);
         }
       }
     }
@@ -213,3 +213,49 @@ export function getFieldValue(
 
   return undefined;
 }
+
+/**
+ * Extract the computed value from an aggregated state object.
+ * Uses the required `_type` discriminator field for type detection.
+ * Logs errors instead of throwing to avoid breaking the app.
+ *
+ * @param value - Value from API data (unknown type from JSON parsing)
+ */
+function extractComputedValue(value: unknown): unknown {
+  if (!value || typeof value !== "object" || Array.isArray(value)) {
+    return value;
+  }
+
+  const obj = value as Record<string, unknown>;
+
+  // _type is required for all aggregated state objects
+  if (!("_type" in obj)) {
+    console.error(
+      "[AutoChart] Missing _type discriminator in aggregated state:",
+      obj,
+    );
+    return value;
+  }
+
+  switch (obj._type) {
+    case "average": {
+      return obj.avg;
+    }
+    case "rate": {
+      return obj.rate;
+    }
+    case "counter": {
+      return obj.count;
+    }
+    case "minmax": {
+      // Default to max for minmax; caller can access min directly if needed
+      return obj.max;
+    }
+    default: {
+      console.error(
+        `[AutoChart] Unrecognized aggregated state type: ${String(obj._type)}`,
+      );
+      return value;
+    }
+  }
+}