@checkstack/healthcheck-backend 0.1.0 → 0.2.0

package/CHANGELOG.md

@@ -1,5 +1,106 @@
 # @checkstack/healthcheck-backend
 
+## 0.2.0
+
+### Minor Changes
+
+- 8e43507: # Teams and Resource-Level Access Control
+
+  This release introduces a comprehensive Teams system for organizing users and controlling access to resources at a granular level.
+
+  ## Features
+
+  ### Team Management
+
+  - Create, update, and delete teams with name and description
+  - Add/remove users from teams
+  - Designate team managers with elevated privileges
+  - View team membership and manager status
+
+  ### Resource-Level Access Control
+
+  - Grant teams access to specific resources (systems, health checks, incidents, maintenances)
+  - Configure read-only or manage permissions per team
+  - Resource-level "Team Only" mode that restricts access exclusively to team members
+  - Separate `resourceAccessSettings` table for resource-level settings (not per-grant)
+  - Automatic cleanup of grants when teams are deleted (database cascade)
+
+  ### Middleware Integration
+
+  - Extended `autoAuthMiddleware` to support resource access checks
+  - Single-resource pre-handler validation for detail endpoints
+  - Automatic list filtering for collection endpoints
+  - S2S endpoints for access verification
+
+  ### Frontend Components
+
+  - `TeamsTab` component for managing teams in Auth Settings
+  - `TeamAccessEditor` component for assigning team access to resources
+  - Resource-level "Team Only" toggle in `TeamAccessEditor`
+  - Integration into System, Health Check, Incident, and Maintenance editors
+
+  ## Breaking Changes
+
+  ### API Response Format Changes
+
+  List endpoints now return objects with named keys instead of arrays directly:
+
+  ```typescript
+  // Before
+  const systems = await catalogApi.getSystems();
+
+  // After
+  const { systems } = await catalogApi.getSystems();
+  ```
+
+  Affected endpoints:
+
+  - `catalog.getSystems` → `{ systems: [...] }`
+  - `healthcheck.getConfigurations` → `{ configurations: [...] }`
+  - `incident.listIncidents` → `{ incidents: [...] }`
+  - `maintenance.listMaintenances` → `{ maintenances: [...] }`
+
+  ### User Identity Enrichment
+
+  `RealUser` and `ApplicationUser` types now include `teamIds: string[]` field with team memberships.
+
+  ## Documentation
+
+  See `docs/backend/teams.md` for complete API reference and integration guide.
+
+- 97c5a6b: Add UUID-based collector identification for better multiple collector support
+
+  **Breaking Change**: Existing health check configurations with collectors need to be recreated.
+
+  - Each collector instance now has a unique UUID assigned on creation
+  - Collector results are stored under the UUID key with `_collectorId` and `_assertionFailed` metadata
+  - Auto-charts correctly display separate charts for each collector instance
+  - Charts are now grouped by collector instance with clear headings
+  - Assertion status card shows pass/fail for each collector
+  - Renamed "Success" to "HTTP Success" to clarify it's about HTTP request success
+  - Fixed deletion of collectors not persisting to database
+  - Fixed duplicate React key warnings in auto-chart grid
+
+### Patch Changes
+
+- 97c5a6b: Fix collector lookup when health check is assigned to a system
+
+  Collectors are now stored in the registry with their fully-qualified ID format (ownerPluginId.collectorId) to match how they are referenced in health check configurations. Added `qualifiedId` field to `RegisteredCollector` interface to avoid re-constructing the ID at query time. This fixes the "Collector not found" warning that occurred when executing health checks with assigned systems.
+
+- Updated dependencies [97c5a6b]
+- Updated dependencies [8e43507]
+- Updated dependencies [8e43507]
+- Updated dependencies [97c5a6b]
+  - @checkstack/backend-api@0.2.0
+  - @checkstack/catalog-common@1.0.0
+  - @checkstack/catalog-backend@0.1.0
+  - @checkstack/common@0.1.0
+  - @checkstack/healthcheck-common@0.2.0
+  - @checkstack/command-backend@0.0.4
+  - @checkstack/integration-backend@0.0.4
+  - @checkstack/queue-api@0.0.4
+  - @checkstack/signal-common@0.0.4
+
 ## 0.1.0
 
 ### Minor Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@checkstack/healthcheck-backend",
-  "version": "0.1.0",
+  "version": "0.2.0",
   "type": "module",
   "main": "src/index.ts",
   "scripts": {

package/src/queue-executor.test.ts

@@ -61,7 +61,7 @@ const createMockCatalogClient = () => ({
   notifySystemSubscribers: mock(async () => ({ notifiedCount: 0 })),
   // Other methods not used in queue-executor
   getEntities: mock(async () => ({ systems: [], groups: [] })),
-  getSystems: mock(async () => []),
+  getSystems: mock(async () => ({ systems: [] })),
   getGroups: mock(async () => []),
   createSystem: mock(async () => ({})),
   updateSystem: mock(async () => ({})),

package/src/queue-executor.ts

@@ -316,6 +316,9 @@ async function executeHealthCheckJob(props: {
           continue;
         }
 
+        // Use the collector's UUID as the storage key
+        const storageKey = collectorEntry.id;
+
         try {
           const collectorResult = await registered.collector.execute({
             config: collectorEntry.config,
@@ -323,9 +326,6 @@ async function executeHealthCheckJob(props: {
             pluginId: configRow.strategyId,
           });
 
-          // Store result under collector ID
-          collectorResults[collectorEntry.collectorId] = collectorResult.result;
-
           // Check for collector-level error
           if (collectorResult.error) {
             hasCollectorError = true;
@@ -333,6 +333,7 @@ async function executeHealthCheckJob(props: {
           }
 
           // Evaluate per-collector assertions
+          let assertionFailed: string | undefined;
           if (
             collectorEntry.assertions &&
             collectorEntry.assertions.length > 0 &&
@@ -345,23 +346,31 @@ async function executeHealthCheckJob(props: {
             );
             if (failedAssertion) {
               hasCollectorError = true;
-              errorMessage = `Assertion failed: ${failedAssertion.field} ${
+              assertionFailed = `${failedAssertion.field} ${
                 failedAssertion.operator
               } ${failedAssertion.value ?? ""}`;
+              errorMessage = `Assertion failed: ${assertionFailed}`;
               logger.debug(
-                `Collector ${collectorEntry.collectorId} assertion failed: ${errorMessage}`
+                `Collector ${storageKey} assertion failed: ${errorMessage}`
               );
             }
           }
+
+          // Store result under the collector's UUID, with collector type and assertion metadata
+          collectorResults[storageKey] = {
+            _collectorId: collectorEntry.collectorId, // Store the type for frontend schema linking
+            _assertionFailed: assertionFailed, // null if no assertion failed
+            ...collectorResult.result,
+          };
         } catch (error) {
           hasCollectorError = true;
           errorMessage = error instanceof Error ? error.message : String(error);
-          collectorResults[collectorEntry.collectorId] = {
+          collectorResults[storageKey] = {
+            _collectorId: collectorEntry.collectorId,
+            _assertionFailed: undefined,
             error: errorMessage,
           };
-          logger.debug(
-            `Collector ${collectorEntry.collectorId} failed: ${errorMessage}`
-          );
+          logger.debug(`Collector ${storageKey} failed: ${errorMessage}`);
         }
       }
     } finally {

package/src/router.test.ts

@@ -82,11 +82,13 @@ describe("HealthCheck Router", () => {
     });
 
     const result = await call(router.getConfigurations, undefined, { context });
-    expect(Array.isArray(result)).toBe(true);
+    expect(result).toHaveProperty("configurations");
+    expect(Array.isArray(result.configurations)).toBe(true);
   });
 
   it("getCollectors returns collectors for strategy", async () => {
     const mockCollector = {
+      qualifiedId: "collector-hardware.cpu",
       collector: {
         id: "cpu",
         displayName: "CPU Metrics",

package/src/router.ts

@@ -68,9 +68,8 @@ export const createHealthCheckRouter = (
           pluginId,
         });
 
-      return registeredCollectors.map(({ collector, ownerPlugin }) => ({
-        // Fully-qualified ID: ownerPluginId.collectorId
-        id: `${ownerPlugin.pluginId}.${collector.id}`,
+      return registeredCollectors.map(({ qualifiedId, collector }) => ({
+        id: qualifiedId,
         displayName: collector.displayName,
         description: collector.description,
         configSchema: toJsonSchema(collector.config.schema),
@@ -80,7 +79,7 @@ export const createHealthCheckRouter = (
     }),
 
     getConfigurations: os.getConfigurations.handler(async () => {
-      return service.getConfigurations();
+      return { configurations: await service.getConfigurations() };
     }),
 
     createConfiguration: os.createConfiguration.handler(async ({ input }) => {