@checkstack/frontend-api 0.3.8 → 0.3.10

package/CHANGELOG.md

@@ -1,5 +1,48 @@
 # @checkstack/frontend-api
 
+## 0.3.10
+
+### Patch Changes
+
+- c4e7560: Fix data integrity, cache invalidation, and mobile UI issues
+
+  - **Centralized mutation cache invalidation**: Every mutation now automatically invalidates its plugin's query cache on success via the shared `createProcedureHook` in `orpc-query.tsx`. This ensures all views stay in sync without requiring individual components to remember manual `invalidateQueries` calls.
+  - **Fixed oRPC query key matching**: Query keys use nested arrays (`[["pluginId"]]`) to correctly match oRPC's `[pathArray, options]` key structure. Fixed the broken flat-string pattern in `SystemBadgeDataProvider`.
+  - **Fixed hourly aggregation duplication**: Added `NULLS NOT DISTINCT` to the `health_check_aggregates` unique constraint so local runs (`source_id = NULL`) correctly conflict-match instead of creating duplicate hourly buckets. Includes a migration to clean up existing duplicates.
+  - **Fixed modal scrolling on mobile**: Added `max-height` + `overflow-y-auto` to `ConfirmationModal`, and refactored `Dialog` from translate-centering to flex-centering with `dvh` units for reliable mobile scroll containment.
+
+## 0.3.9
+
+### Patch Changes
+
+- d1a2796: Enforce stricter code quality standards and eliminate AI slop anti-patterns.
+
+  **New utility**
+
+  - `extractErrorMessage(error, fallback?)` in `@checkstack/common` for consistent error extraction
+
+  **ESLint rules**
+
+  - `react-hooks/rules-of-hooks` and `exhaustive-deps` for hook correctness
+  - `no-console` in frontend packages — forces `toast` over silent `console.error`
+  - `no-restricted-syntax` banning `instanceof Error` — forces `extractErrorMessage`
+  - Custom `no-eslint-disable-any` rule preventing `@typescript-eslint/no-explicit-any` circumvention
+
+  **Refactoring**
+
+  - Replace 141 `instanceof Error` boilerplate patterns across the codebase
+  - Replace swallowed `console.error` with user-visible `toast.error()` feedback
+  - Remove 15 redundant `as` type casts in IntegrationsPage and ProviderConnectionsPage
+  - Consolidate 3 identical callback handlers into `handleDialogClose`
+  - Fix conditional React hook call in `FormField.tsx`
+  - Fix unstable useMemo deps in `Dashboard.tsx`
+  - Replace `useEffect`→`setState` with derived `useMemo` in `RegisterPage.tsx`
+  - Rewrite `keystore.test.ts` with typed `DrizzleMockChain` (eliminating 7 `any` suppressions)
+  - Delete obvious comments in `encryption.ts` and Teams `provider.ts`
+
+- Updated dependencies [d1a2796]
+  - @checkstack/common@0.6.5
+
 ## 0.3.8
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@checkstack/frontend-api",
-  "version": "0.3.8",
+  "version": "0.3.10",
   "type": "module",
   "main": "./src/index.ts",
   "scripts": {
@@ -12,7 +12,7 @@
     "react": "^18.0.0"
   },
   "dependencies": {
-    "@checkstack/common": "0.6.3",
+    "@checkstack/common": "0.6.5",
     "@orpc/client": "^1.13.14",
     "@orpc/react-query": "1.13.4",
     "@orpc/tanstack-query": "^1.13.2",
@@ -22,8 +22,8 @@
     "@types/bun": "^1.3.5",
     "@types/react": "^18.0.0",
     "typescript": "^5.0.0",
-    "@checkstack/tsconfig": "0.0.3",
-    "@checkstack/scripts": "0.1.1"
+    "@checkstack/tsconfig": "0.0.5",
+    "@checkstack/scripts": "0.1.2"
   },
   "checkstack": {
     "type": "tooling"

package/src/components/ExtensionSlot.tsx

@@ -37,8 +37,7 @@ export function ExtensionSlot<TSlot extends SlotDefinition<unknown>>({
   return (
     <>
       {extensions.map((ext) => {
-        // eslint-disable-next-line @typescript-eslint/no-explicit-any
-        const Component = ext.component as React.ComponentType<any>;
+        const Component = ext.component as React.ComponentType<Record<string, unknown>>;
         return <Component key={ext.id} {...(context ?? {})} />;
       })}
     </>

package/src/orpc-query.tsx

@@ -14,9 +14,8 @@ import {
   type UseMutationOptions,
 } from "@tanstack/react-query";
 
-// Re-export useQueryClient for cache invalidation in consuming packages
-// This ensures all packages use the same React Query instance
 export { useQueryClient } from "@tanstack/react-query";
+import { useQueryClient } from "@tanstack/react-query";
 import { useApi } from "./api-context";
 import { rpcApiRef } from "./core-apis";
 import type { ClientDefinition, InferClient } from "@checkstack/common";
@@ -71,7 +70,7 @@ function useOrpcUtils(): OrpcUtils {
   if (!context) {
     throw new Error(
       "usePluginClient must be used within OrpcQueryProvider. " +
-        "Wrap your app with <OrpcQueryProvider>."
+        "Wrap your app with <OrpcQueryProvider>.",
     );
   }
   return context;
@@ -88,7 +87,7 @@ function useOrpcUtils(): OrpcUtils {
 interface QueryProcedure<TInput, TOutput> {
   useQuery: (
     input?: TInput,
-    options?: Omit<UseQueryOptions<TOutput, Error>, "queryKey" | "queryFn">
+    options?: Omit<UseQueryOptions<TOutput, Error>, "queryKey" | "queryFn">,
   ) => UseQueryResult<TOutput, Error>;
 }
 
@@ -101,7 +100,7 @@ interface MutationProcedure<TInput, TOutput> {
     options?: Omit<
       UseMutationOptions<TOutput, Error, TInput>,
       "mutationFn" | "mutationKey"
-    >
+    >,
   ) => UseMutationResult<TOutput, Error, TInput>;
 }
 
@@ -148,14 +147,15 @@ type InferSchemaOutputType<T> = T extends { _output: infer O } ? O : unknown;
 /**
  * Check if a contract type is a procedure (not a nested router).
  */
-type IsContractProcedure<T> = T extends ContractProcedure<
-  infer _TInput,
-  infer _TOutput,
-  infer _TErrors,
-  infer _TMeta
->
-  ? true
-  : false;
+type IsContractProcedure<T> =
+  T extends ContractProcedure<
+    infer _TInput,
+    infer _TOutput,
+    infer _TErrors,
+    infer _TMeta
+  >
+    ? true
+    : false;
 
 /**
  * Maps a contract router to wrapped procedures based on operationType.
@@ -167,10 +167,10 @@ type WrappedClient<TContract extends AnyContractRouter, TClient> = {
   > extends true
     ? WrappedProcedure<TContract[K], TClient[K]>
     : TClient[K] extends object
-    ? TContract[K] extends AnyContractRouter
-      ? WrappedClient<TContract[K], TClient[K]>
-      : never
-    : never;
+      ? TContract[K] extends AnyContractRouter
+        ? WrappedClient<TContract[K], TClient[K]>
+        : never
+      : never;
 };
 
 // =============================================================================
@@ -202,7 +202,7 @@ type WrappedClient<TContract extends AnyContractRouter, TClient> = {
  * ```
  */
 export function usePluginClient<T extends ClientDefinition>(
-  definition: T
+  definition: T,
 ): WrappedClient<NonNullable<T["__contractType"]>, InferClient<T>> {
   const orpcUtils = useOrpcUtils();
 
@@ -213,7 +213,7 @@ export function usePluginClient<T extends ClientDefinition>(
   if (!pluginUtils) {
     throw new Error(
       `Plugin "${definition.pluginId}" not found. ` +
-        `Ensure the plugin is registered and the backend is running.`
+        `Ensure the plugin is registered and the backend is running.`,
     );
   }
 
@@ -221,8 +221,8 @@ export function usePluginClient<T extends ClientDefinition>(
   const contract = definition.contract as Record<string, unknown>;
 
   return useMemo(() => {
-    return wrapPluginUtils(pluginUtils, contract);
-  }, [pluginUtils, contract]) as WrappedClient<
+    return wrapPluginUtils(pluginUtils, contract, definition.pluginId);
+  }, [pluginUtils, contract, definition.pluginId]) as WrappedClient<
     NonNullable<T["__contractType"]>,
     InferClient<T>
   >;
@@ -234,7 +234,8 @@ export function usePluginClient<T extends ClientDefinition>(
 
 function wrapPluginUtils(
   utils: Record<string, unknown>,
-  contract: Record<string, unknown>
+  contract: Record<string, unknown>,
+  pluginId: string,
 ): Record<string, unknown> {
   const wrapped: Record<string, unknown> = {};
 
@@ -276,13 +277,15 @@ function wrapPluginUtils(
           unknown,
           Error
         >,
-        operationType
+        operationType,
+        pluginId,
       );
     } else {
       // Nested namespace - recurse
       wrapped[key] = wrapPluginUtils(
         procedureUtils as Record<string, unknown>,
-        (contractProcedure || {}) as Record<string, unknown>
+        (contractProcedure || {}) as Record<string, unknown>,
+        pluginId,
       );
     }
   }
@@ -296,7 +299,7 @@ function wrapPluginUtils(
  */
 function getOperationType(
   contractProcedure: Record<string, unknown> | undefined,
-  procedureName?: string
+  procedureName?: string,
 ): "query" | "mutation" {
   const orpcMeta = contractProcedure?.["~orpc"] as
     | { meta?: { operationType?: "query" | "mutation" } }
@@ -309,7 +312,7 @@ function getOperationType(
       `Procedure ${
         procedureName ? `"${procedureName}" ` : ""
       }is missing required "operationType" in contract metadata. ` +
-        `Add operationType: "query" or operationType: "mutation" to the procedure's .meta() call.`
+        `Add operationType: "query" or operationType: "mutation" to the procedure's .meta() call.`,
     );
   }
 
@@ -321,13 +324,31 @@ function getOperationType(
  */
 function createProcedureHook<TInput, TOutput>(
   proc: ProcedureUtils<ClientContext, TInput, TOutput, Error>,
-  operationType: "query" | "mutation"
+  operationType: "query" | "mutation",
+  pluginId: string,
 ): QueryProcedure<TInput, TOutput> | MutationProcedure<TInput, TOutput> {
   if (operationType === "mutation") {
     return {
       useMutation: (options) => {
-        const mutationOpts = proc.mutationOptions(options);
-        return useMutation(mutationOpts);
+        const queryClient = useQueryClient();
+        const mutationOpts = proc.mutationOptions({
+          ...options,
+          onSuccess: (...args) => {
+            // Automatically invalidate all queries for this plugin
+            // so every view showing this plugin's data stays fresh.
+            // oRPC query keys are [pathArray, options] where pathArray
+            // starts with the pluginId, e.g. ["healthcheck", "getConfigurations"].
+            void queryClient.invalidateQueries({
+              queryKey: [[pluginId]],
+            });
+            // Call the user-provided onSuccess handler if present
+            options?.onSuccess?.(...args);
+          },
+        });
+        // Remove the duplicate onSuccess from the outer options to avoid
+        // double-invocation — it's already integrated above.
+        const { onSuccess: _, ...restOptions } = options ?? {};
+        return useMutation({ ...mutationOpts, ...restOptions });
       },
     };
   }

package/src/runtime-config.tsx

@@ -116,6 +116,7 @@ export const RuntimeConfigProvider: React.FC<RuntimeConfigProviderProps> = ({
       } catch (error_) {
         console.error("RuntimeConfigProvider: Failed to load config", error_);
         setError(
+          // eslint-disable-next-line no-restricted-syntax -- Needs Error object for state, not just message
           error_ instanceof Error ? error_ : new Error(String(error_))
         );
         // Do NOT set a fallback — surface the error visibly.