@checkstack/dependency-frontend 0.2.1 → 0.2.3

package/CHANGELOG.md

@@ -1,5 +1,59 @@
 # @checkstack/dependency-frontend
 
+## 0.2.3
+
+### Patch Changes
+
+- d1a2796: Enforce stricter code quality standards and eliminate AI slop anti-patterns.
+
+  **New utility**
+
+  - `extractErrorMessage(error, fallback?)` in `@checkstack/common` for consistent error extraction
+
+  **ESLint rules**
+
+  - `react-hooks/rules-of-hooks` and `exhaustive-deps` for hook correctness
+  - `no-console` in frontend packages — forces `toast` over silent `console.error`
+  - `no-restricted-syntax` banning `instanceof Error` — forces `extractErrorMessage`
+  - Custom `no-eslint-disable-any` rule preventing `@typescript-eslint/no-explicit-any` circumvention
+
+  **Refactoring**
+
+  - Replace 141 `instanceof Error` boilerplate patterns across the codebase
+  - Replace swallowed `console.error` with user-visible `toast.error()` feedback
+  - Remove 15 redundant `as` type casts in IntegrationsPage and ProviderConnectionsPage
+  - Consolidate 3 identical callback handlers into `handleDialogClose`
+  - Fix conditional React hook call in `FormField.tsx`
+  - Fix unstable useMemo deps in `Dashboard.tsx`
+  - Replace `useEffect`→`setState` with derived `useMemo` in `RegisterPage.tsx`
+  - Rewrite `keystore.test.ts` with typed `DrizzleMockChain` (eliminating 7 `any` suppressions)
+  - Delete obvious comments in `encryption.ts` and Teams `provider.ts`
+
+- Updated dependencies [d1a2796]
+- Updated dependencies [3c34b07]
+  - @checkstack/common@0.6.5
+  - @checkstack/ui@1.2.1
+  - @checkstack/dashboard-frontend@0.3.26
+  - @checkstack/frontend-api@0.3.9
+  - @checkstack/catalog-common@1.3.1
+  - @checkstack/healthcheck-common@0.10.1
+  - @checkstack/dependency-common@0.2.1
+  - @checkstack/signal-frontend@0.0.15
+
+## 0.2.2
+
+### Patch Changes
+
+- c0935d8: Fix dependency map node positions resetting when connecting two nodes. The graph-building effect was rebuilding all nodes from scratch on every data change, discarding unsaved drag positions. Node and edge construction are now split into separate effects with a clear position resolution priority: in-memory positions → saved positions → auto-layout fallback for new systems only.
+  - @checkstack/catalog-common@1.3.0
+  - @checkstack/common@0.6.4
+  - @checkstack/dashboard-frontend@0.3.25
+  - @checkstack/dependency-common@0.2.0
+  - @checkstack/frontend-api@0.3.8
+  - @checkstack/healthcheck-common@0.10.0
+  - @checkstack/signal-frontend@0.0.14
+  - @checkstack/ui@1.2.0
+
 ## 0.2.1
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@checkstack/dependency-frontend",
-  "version": "0.2.1",
+  "version": "0.2.3",
   "type": "module",
   "main": "src/index.tsx",
   "checkstack": {
@@ -12,12 +12,12 @@
     "lint:code": "eslint . --max-warnings 0"
   },
   "dependencies": {
-    "@checkstack/catalog-common": "1.2.11",
+    "@checkstack/catalog-common": "1.3.0",
     "@checkstack/common": "0.6.4",
-    "@checkstack/dashboard-frontend": "0.3.23",
-    "@checkstack/dependency-common": "0.1.0",
+    "@checkstack/dashboard-frontend": "0.3.25",
+    "@checkstack/dependency-common": "0.2.0",
     "@checkstack/frontend-api": "0.3.8",
-    "@checkstack/healthcheck-common": "0.8.4",
+    "@checkstack/healthcheck-common": "0.10.0",
     "@checkstack/signal-frontend": "0.0.14",
     "@checkstack/ui": "1.2.0",
     "@xyflow/react": "^12.10.2",
@@ -28,7 +28,7 @@
   "devDependencies": {
     "typescript": "^5.0.0",
     "@types/react": "^18.2.0",
-    "@checkstack/tsconfig": "0.0.4",
+    "@checkstack/tsconfig": "0.0.5",
     "@checkstack/scripts": "0.1.2"
   }
 }

package/src/components/DependencyMapPage.tsx

@@ -46,6 +46,7 @@ import {
   type DependencyEdge,
   type DependencyEdgeData,
 } from "./canvas/DependencyEdge";
+import { extractErrorMessage } from "@checkstack/common";
 
 const nodeTypes = { system: SystemNodeComponent };
 const edgeTypes = { dependency: DependencyEdgeComponent };
@@ -171,7 +172,7 @@ function DependencyMapContent() {
     },
     onError: (error) => {
       const message =
-        error instanceof Error ? error.message : "Failed to create dependency";
+        extractErrorMessage(error, "Failed to create dependency");
 
       // Check for cycle error and resolve names
       if (message.includes("circular chain")) {
@@ -193,7 +194,7 @@ function DependencyMapContent() {
       void refetchWarnings();
     },
     onError: (error) => {
-      toast.error(error instanceof Error ? error.message : "Failed to update");
+      toast.error(extractErrorMessage(error, "Failed to update"));
     },
   });
 
@@ -206,7 +207,7 @@ function DependencyMapContent() {
       void refetchWarnings();
     },
     onError: (error) => {
-      toast.error(error instanceof Error ? error.message : "Failed to delete");
+      toast.error(extractErrorMessage(error, "Failed to delete"));
     },
   });
 
@@ -227,21 +228,44 @@ function DependencyMapContent() {
     [createDependency],
   );
 
-  // Build graph from data
+  // Track node positions for saving and for preserving in-memory positions
+  const nodesRef = useRef(nodes);
+  nodesRef.current = nodes;
+
+  // Build nodes from systems, positions, warnings, and health data.
+  // Position resolution priority:
+  //   1. Current in-memory position (user may have dragged but not saved yet)
+  //   2. Saved position from the backend
+  //   3. Auto-layout fallback for brand-new systems with no position at all
+
   useEffect(() => {
-    if (!systemsData?.systems || !depsData?.dependencies) return;
+    if (!systemsData?.systems) return;
 
     const savedPositions = posData?.positions ?? [];
-    const positions = autoLayout(
-      systemsData.systems.map((s) => s.id),
-      savedPositions,
-    );
-
     const warnings = warningsData?.warnings ?? {};
     const healthStatuses = healthData?.statuses ?? {};
 
+    // Lookup maps for position resolution
+    const savedPositionMap = new Map(
+      savedPositions.map((p) => [p.systemId, { x: p.x, y: p.y }]),
+    );
+    const currentPositionMap = new Map<string, { x: number; y: number }>();
+    for (const node of nodesRef.current) {
+      currentPositionMap.set(node.id, node.position);
+    }
+
+    // Auto-layout only for systems that have no saved and no in-memory position
+    const unpositioned = systemsData.systems
+      .map((s) => s.id)
+      .filter((id) => !savedPositionMap.has(id) && !currentPositionMap.has(id));
+    const fallbackPositions = autoLayout(unpositioned, []);
+
     const newNodes: SystemNode[] = systemsData.systems.map((system) => {
-      const pos = positions.get(system.id) ?? { x: 0, y: 0 };
+      const pos =
+        currentPositionMap.get(system.id) ??
+        savedPositionMap.get(system.id) ??
+        fallbackPositions.get(system.id) ?? { x: 0, y: 0 };
+
       const warning = warnings[system.id];
 
       // Map real health status to node status
@@ -270,6 +294,13 @@ function DependencyMapContent() {
       };
     });
 
+    setNodes(newNodes);
+  }, [systemsData, posData, warningsData, healthData, setNodes]);
+
+  // Build edges separately — only depends on dependency data
+  useEffect(() => {
+    if (!depsData?.dependencies) return;
+
     const newEdges: DependencyEdge[] = depsData.dependencies.map(
       (dep: Dependency) => {
         const edgeData: DependencyEdgeData = {
@@ -294,13 +325,10 @@ function DependencyMapContent() {
       },
     );
 
-    setNodes(newNodes);
     setEdges(newEdges);
-  }, [systemsData, depsData, posData, warningsData, healthData, setNodes, setEdges]);
+  }, [depsData, setEdges]);
 
   // Track node position changes for saving
-  const nodesRef = useRef(nodes);
-  nodesRef.current = nodes;
 
   const handleNodesChange = useCallback(
     (changes: NodeChange<SystemNode>[]) => {
@@ -323,6 +351,7 @@ function DependencyMapContent() {
         }, 2000);
       }
     },
+    // eslint-disable-next-line react-hooks/exhaustive-deps -- handleSave reads from nodesRef (always current); including it would cause infinite re-render loops via setHasUnsaved
     [onNodesChange],
   );