@checkstack/dashboard-frontend 0.5.0 → 0.6.0

package/CHANGELOG.md

@@ -1,5 +1,127 @@
 # @checkstack/dashboard-frontend
 
+## 0.6.0
+
+### Minor Changes
+
+- 32d52c6: feat: unified notification-subscription manager dialog driven by spec registry
+
+  Replaces the bell-toggle UX (which only managed a single legacy
+  catalog group) with a modal that lists every notification type
+  registered against a target — system or group — and exposes both
+  per-type toggles and a bulk "Subscribe to all / Unsubscribe from all"
+  action. Both surfaces (system detail page header bell, dashboard group
+  header bell) now open the same `NotificationSubscriptionsManager`
+  component.
+
+  **Key change vs. the prior slot-based approach**: rows are now driven
+  by `notificationClient.listSubscriptionSpecs` — the backend's spec
+  registry is the single source of truth. Previously, a row only
+  appeared if a frontend plugin had remembered to register a
+  `createNotificationSubscriptionExtension`; this caused silent drift
+  (healthcheck and dependency registered backend specs without frontend
+  extensions, so the dialog counted them but never rendered rows). Now,
+  every spec the platform knows about renders a row using the spec's
+  `display` metadata (title, description, iconName resolved via
+  `DynamicIcon`).
+
+  **Sub-controls registry** (`@checkstack/notification-frontend`):
+  plugins that want sub-granularity (anomaly's per-field mute list,
+  future severity / channel filters) call
+  `registerSubscriptionSubControls(spec, Component)` at module load —
+  the manager looks the component up by `specId` when expanding a row.
+
+  **Removed (no compat)**:
+
+  - `createNotificationSubscriptionExtension` (replaced by the
+    spec-driven manager + the SubControls registry)
+  - `target.slot` field on `NotificationTarget` and the
+    `NotificationTargetInput.slot` parameter on
+    `defineNotificationTarget`
+  - `SystemNotificationSubscriptionsSlot` and
+    `GroupNotificationSubscriptionsSlot` from `@checkstack/catalog-common`
+  - `SystemNotificationsCard` from the system detail page's main column
+  - `SubscribeButton` wiring on dashboard group cards and the system
+    detail page header
+
+  **Migrated frontends**: anomaly (now registers `AnomalyFieldMuteList`
+  via the SubControls registry), incident, maintenance — all dropped
+  their `createNotificationSubscriptionExtension` calls. healthcheck and
+  dependency now show up automatically via the spec registry — no
+  frontend changes needed for them to render.
+
+  The trigger button reflects aggregate state — filled bell when at
+  least one spec is subscribed for the resource, ghost bell when none.
+
+### Patch Changes
+
+- Updated dependencies [32d52c6]
+- Updated dependencies [32d52c6]
+- Updated dependencies [32d52c6]
+- Updated dependencies [32d52c6]
+- Updated dependencies [32d52c6]
+- Updated dependencies [32d52c6]
+- Updated dependencies [32d52c6]
+  - @checkstack/anomaly-common@1.0.0
+  - @checkstack/notification-common@1.0.0
+  - @checkstack/notification-frontend@0.3.0
+  - @checkstack/catalog-common@2.0.0
+  - @checkstack/catalog-frontend@0.9.0
+  - @checkstack/incident-common@1.0.0
+  - @checkstack/maintenance-common@1.0.0
+  - @checkstack/healthcheck-common@1.0.0
+  - @checkstack/frontend-api@0.4.1
+  - @checkstack/auth-frontend@0.5.32
+  - @checkstack/ui@1.7.0
+  - @checkstack/command-frontend@0.2.33
+  - @checkstack/queue-frontend@0.3.2
+
+## 0.5.1
+
+### Patch Changes
+
+- 208ad71: Centralize realtime cache invalidation: signals now carry their owning `pluginId` end-to-end, and a single `SignalAutoInvalidator` mounted near the React Query client invalidates `[[pluginId]]` for every incoming signal automatically.
+
+  **Breaking change to `createSignal`** (`@checkstack/signal-common`): the factory now takes a single object argument with `pluginMetadata`, `event`, and `payloadSchema`. The signal id is constructed as `${pluginMetadata.pluginId}.${event}` and the resulting `Signal` carries a `pluginId` field. The `SignalMessage` wire envelope and `ServerToClientMessage` `signal` variant gained a `pluginId` field so the frontend can route invalidations without parsing the id.
+
+  ```ts
+  // Before
+  export const ANOMALY_STATE_CHANGED = createSignal(
+    "anomaly.state_changed",
+    z.object({ ... }),
+  );
+
+  // After
+  export const ANOMALY_STATE_CHANGED = createSignal({
+    pluginMetadata,
+    event: "state_changed",
+    payloadSchema: z.object({ ... }),
+  });
+  ```
+
+  **New plugin field**: `FrontendPlugin.foreignSignals?: Signal<unknown>[]` lets a plugin opt its `[[pluginId]]` cache into invalidation when another plugin's signal fires (e.g. `dependency-frontend` declares `[SYSTEM_STATUS_CHANGED]` because dependency payloads embed system status). Same-plugin signals must NOT be listed — they are always auto-invalidated.
+
+  **Removed boilerplate**: per-component `useSignal(X, () => refetch())` and `useSignal(X, () => queryClient.invalidateQueries(...))` calls have been removed across `incident-frontend`, `maintenance-frontend`, `healthcheck-frontend`, `slo-frontend`, `dependency-frontend`, `satellite-frontend`, `announcement-frontend`, `notification-frontend`, and `dashboard-frontend`. The `NotificationBell` unread count is now derived directly from the `getUnreadCount` query (auto-invalidated) instead of a local state mirror.
+
+  **User-visible bug fix**: the system detail page anomaly widget (`SystemAnomalyWidget`) now updates in real-time when anomalies change, with no per-widget signal subscription required. The dashboard status page also stays fresh on `ANOMALY_STATE_CHANGED`, `ANOMALY_BASELINE_UPDATED`, and `ANOMALY_TREND_DETECTED`.
+
+  UI-state consumers that legitimately need a `useSignal` (the dashboard activity terminal, the queue lag alert, and the rolling-preset date refresh in `useHealthCheckData`) keep their handlers; the auto-invalidator runs alongside them.
+
+- Updated dependencies [208ad71]
+  - @checkstack/signal-frontend@0.1.0
+  - @checkstack/frontend-api@0.4.0
+  - @checkstack/anomaly-common@0.3.0
+  - @checkstack/healthcheck-common@0.13.0
+  - @checkstack/incident-common@0.5.0
+  - @checkstack/maintenance-common@0.5.0
+  - @checkstack/notification-common@0.3.0
+  - @checkstack/queue-frontend@0.3.1
+  - @checkstack/auth-frontend@0.5.31
+  - @checkstack/catalog-common@1.5.3
+  - @checkstack/catalog-frontend@0.8.7
+  - @checkstack/command-frontend@0.2.32
+  - @checkstack/ui@1.6.1
+
 ## 0.5.0
 
 ### Minor Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@checkstack/dashboard-frontend",
-  "version": "0.5.0",
+  "version": "0.6.0",
   "type": "module",
   "main": "src/index.tsx",
   "checkstack": {
@@ -13,21 +13,22 @@
     "lint:code": "eslint . --max-warnings 0"
   },
   "dependencies": {
-    "@checkstack/anomaly-common": "0.1.0",
-    "@checkstack/auth-frontend": "0.5.29",
-    "@checkstack/catalog-common": "1.5.1",
-    "@checkstack/catalog-frontend": "0.8.5",
-    "@checkstack/command-common": "0.2.8",
-    "@checkstack/command-frontend": "0.2.30",
-    "@checkstack/common": "0.6.5",
-    "@checkstack/frontend-api": "0.3.10",
-    "@checkstack/healthcheck-common": "0.11.0",
-    "@checkstack/incident-common": "0.4.8",
-    "@checkstack/maintenance-common": "0.4.10",
-    "@checkstack/notification-common": "0.2.8",
-    "@checkstack/queue-frontend": "0.2.31",
-    "@checkstack/signal-frontend": "0.0.15",
-    "@checkstack/ui": "1.5.1",
+    "@checkstack/anomaly-common": "0.3.0",
+    "@checkstack/auth-frontend": "0.5.31",
+    "@checkstack/catalog-common": "1.5.3",
+    "@checkstack/catalog-frontend": "0.8.7",
+    "@checkstack/command-common": "0.2.9",
+    "@checkstack/command-frontend": "0.2.32",
+    "@checkstack/common": "0.7.0",
+    "@checkstack/frontend-api": "0.4.0",
+    "@checkstack/healthcheck-common": "0.13.0",
+    "@checkstack/incident-common": "0.5.0",
+    "@checkstack/maintenance-common": "0.5.0",
+    "@checkstack/notification-common": "0.3.0",
+    "@checkstack/notification-frontend": "0.2.36",
+    "@checkstack/queue-frontend": "0.3.1",
+    "@checkstack/signal-frontend": "0.1.0",
+    "@checkstack/ui": "1.6.1",
     "date-fns": "^4.1.0",
     "lucide-react": "^0.344.0",
     "react": "^18.2.0",

package/src/Dashboard.tsx

@@ -11,12 +11,10 @@ import {
   SystemStateBadgesSlot,
   System,
   Group,
+  catalogGroupTarget,
 } from "@checkstack/catalog-common";
 import { resolveRoute } from "@checkstack/common";
-import {
-  NotificationApi,
-  type EnrichedSubscription,
-} from "@checkstack/notification-common";
+import { NotificationSubscriptionsManager } from "@checkstack/notification-frontend";
 import { IncidentApi } from "@checkstack/incident-common";
 import { MaintenanceApi } from "@checkstack/maintenance-common";
 import { AnomalyApi } from "@checkstack/anomaly-common";
@@ -31,8 +29,6 @@ import {
   StatusCard,
   EmptyState,
   LoadingSpinner,
-  SubscribeButton,
-  useToast,
   AnimatedCounter,
   TerminalFeed,
   type TerminalEntry,
@@ -56,15 +52,12 @@ import { IncidentOverviewSheet } from "./components/IncidentOverviewSheet";
 import { MaintenanceOverviewSheet } from "./components/MaintenanceOverviewSheet";
 import { AnomalyOverviewSheet } from "./components/AnomalyOverviewSheet";
 
-const CATALOG_PLUGIN_ID = "catalog";
 const MAX_TERMINAL_ENTRIES = 8;
 
 interface GroupWithSystems extends Group {
   systems: System[];
 }
 
-const getGroupId = (groupId: string) => `${CATALOG_PLUGIN_ID}.group.${groupId}`;
-
 const statusToVariant = (
   status: string,
 ): "default" | "success" | "warning" | "error" => {
@@ -87,24 +80,17 @@ const statusToVariant = (
 export const Dashboard: React.FC = () => {
   const { isLowPower } = usePerformance();
   const catalogClient = usePluginClient(CatalogApi);
-  const notificationClient = usePluginClient(NotificationApi);
   const incidentClient = usePluginClient(IncidentApi);
   const maintenanceClient = usePluginClient(MaintenanceApi);
   const anomalyClient = usePluginClient(AnomalyApi);
 
   const navigate = useNavigate();
-  const toast = useToast();
   const authApi = useApi(authApiRef);
   const { data: session } = authApi.useSession();
 
   // Terminal feed entries from real healthcheck signals
   const [terminalEntries, setTerminalEntries] = useState<TerminalEntry[]>([]);
 
-  // Track per-group loading state for subscribe buttons
-  const [subscriptionLoading, setSubscriptionLoading] = useState<
-    Record<string, boolean>
-  >({});
-
   const [isIncidentSheetOpen, setIncidentSheetOpen] = useState(false);
   const [isMaintenanceSheetOpen, setMaintenanceSheetOpen] = useState(false);
   const [isAnomalySheetOpen, setAnomalySheetOpen] = useState(false);
@@ -158,13 +144,6 @@ export const Dashboard: React.FC = () => {
       { staleTime: 30_000 },
     );
 
-  // Fetch subscriptions (only when logged in)
-  const { data: subscriptions = [], refetch: refetchSubscriptions } =
-    notificationClient.getSubscriptions.useQuery(
-      {},
-      { enabled: !!session, staleTime: 60_000 },
-    );
-
   // Combined loading state
   const loading =
     entitiesLoading ||
@@ -172,30 +151,6 @@ export const Dashboard: React.FC = () => {
     maintenancesLoading ||
     anomaliesLoading;
 
-  // -------------------------------------------------------------------------
-  // MUTATIONS
-  // -------------------------------------------------------------------------
-
-  const subscribeMutation = notificationClient.subscribe.useMutation({
-    onSuccess: () => {
-      toast.success("Subscribed to group notifications");
-      void refetchSubscriptions();
-    },
-    onError: (error: Error) => {
-      toast.error(error.message || "Failed to subscribe");
-    },
-  });
-
-  const unsubscribeMutation = notificationClient.unsubscribe.useMutation({
-    onSuccess: () => {
-      toast.success("Unsubscribed from group notifications");
-      void refetchSubscriptions();
-    },
-    onError: (error: Error) => {
-      toast.error(error.message || "Failed to unsubscribe");
-    },
-  });
-
   // -------------------------------------------------------------------------
   // COMPUTED DATA
   // -------------------------------------------------------------------------
@@ -248,39 +203,6 @@ export const Dashboard: React.FC = () => {
     navigate(resolveRoute(catalogRoutes.routes.systemDetail, { systemId }));
   };
 
-  const isSubscribed = (groupId: string) => {
-    const fullId = getGroupId(groupId);
-    return subscriptions.some(
-      (s: EnrichedSubscription) => s.groupId === fullId,
-    );
-  };
-
-  const handleSubscribe = (groupId: string) => {
-    const fullId = getGroupId(groupId);
-    setSubscriptionLoading((prev) => ({ ...prev, [groupId]: true }));
-    subscribeMutation.mutate(
-      { groupId: fullId },
-      {
-        onSettled: () => {
-          setSubscriptionLoading((prev) => ({ ...prev, [groupId]: false }));
-        },
-      },
-    );
-  };
-
-  const handleUnsubscribe = (groupId: string) => {
-    const fullId = getGroupId(groupId);
-    setSubscriptionLoading((prev) => ({ ...prev, [groupId]: true }));
-    unsubscribeMutation.mutate(
-      { groupId: fullId },
-      {
-        onSettled: () => {
-          setSubscriptionLoading((prev) => ({ ...prev, [groupId]: false }));
-        },
-      },
-    );
-  };
-
   // -------------------------------------------------------------------------
   // RENDER
   // -------------------------------------------------------------------------
@@ -324,11 +246,12 @@ export const Dashboard: React.FC = () => {
                     {group.systems.length === 1 ? "system" : "systems"}
                   </span>
                   {session && (
-                    <SubscribeButton
-                      isSubscribed={isSubscribed(group.id)}
-                      onSubscribe={() => handleSubscribe(group.id)}
-                      onUnsubscribe={() => handleUnsubscribe(group.id)}
-                      loading={subscriptionLoading[group.id] || false}
+                    <NotificationSubscriptionsManager
+                      target={catalogGroupTarget}
+                      resource={{
+                        groupId: group.id,
+                        groupName: group.name,
+                      }}
                     />
                   )}
                 </div>

package/src/components/SystemBadgeDataProvider.tsx

@@ -1,19 +1,15 @@
 import React, { createContext, useContext, useCallback, useMemo } from "react";
-import { usePluginClient, useQueryClient } from "@checkstack/frontend-api";
-import { useSignal } from "@checkstack/signal-frontend";
+import { usePluginClient } from "@checkstack/frontend-api";
 import {
   HealthCheckApi,
-  SYSTEM_STATUS_CHANGED,
   type SystemHealthStatusResponse,
 } from "@checkstack/healthcheck-common";
 import {
   IncidentApi,
-  INCIDENT_UPDATED,
   type IncidentWithSystems,
 } from "@checkstack/incident-common";
 import {
   MaintenanceApi,
-  MAINTENANCE_UPDATED,
   type MaintenanceWithSystems,
 } from "@checkstack/maintenance-common";
 
@@ -46,11 +42,14 @@ interface SystemBadgeDataProviderProps {
 /**
  * Provider that bulk-fetches badge data (health, incidents, maintenances)
  * for multiple systems using TanStack Query and provides it via context.
+ *
+ * Realtime invalidation of `[["healthcheck"]]`, `[["incident"]]`, and
+ * `[["maintenance"]]` is handled centrally by SignalAutoInvalidator — no
+ * per-component signal handlers needed here.
  */
 export const SystemBadgeDataProvider: React.FC<
   SystemBadgeDataProviderProps
 > = ({ systemIds, children }) => {
-  const queryClient = useQueryClient();
   const healthCheckClient = usePluginClient(HealthCheckApi);
   const incidentClient = usePluginClient(IncidentApi);
   const maintenanceClient = usePluginClient(MaintenanceApi);
@@ -82,56 +81,6 @@ export const SystemBadgeDataProvider: React.FC<
 
   const loading = healthLoading || incidentLoading || maintenanceLoading;
 
-  // -------------------------------------------------------------------------
-  // SIGNAL HANDLERS - Invalidate queries on updates
-  // -------------------------------------------------------------------------
-
-  const refetchHealth = useCallback(
-    (systemId: string) => {
-      if (systemIds.includes(systemId)) {
-        // Invalidate the bulk query to refetch
-        queryClient.invalidateQueries({ queryKey: [["healthcheck"]] });
-      }
-    },
-    [systemIds, queryClient]
-  );
-
-  useSignal(SYSTEM_STATUS_CHANGED, ({ systemId }) => {
-    refetchHealth(systemId);
-  });
-
-  const refetchIncidents = useCallback(
-    (affectedSystemIds: string[]) => {
-      const hasAffected = affectedSystemIds.some((id) =>
-        systemIds.includes(id)
-      );
-      if (hasAffected) {
-        queryClient.invalidateQueries({ queryKey: [["incident"]] });
-      }
-    },
-    [systemIds, queryClient]
-  );
-
-  useSignal(INCIDENT_UPDATED, ({ systemIds: affectedIds }) => {
-    refetchIncidents(affectedIds);
-  });
-
-  const refetchMaintenances = useCallback(
-    (affectedSystemIds: string[]) => {
-      const hasAffected = affectedSystemIds.some((id) =>
-        systemIds.includes(id)
-      );
-      if (hasAffected) {
-        queryClient.invalidateQueries({ queryKey: [["maintenance"]] });
-      }
-    },
-    [systemIds, queryClient]
-  );
-
-  useSignal(MAINTENANCE_UPDATED, ({ systemIds: affectedIds }) => {
-    refetchMaintenances(affectedIds);
-  });
-
   // -------------------------------------------------------------------------
   // CONTEXT VALUE
   // -------------------------------------------------------------------------