@checkstack/common 0.6.4 → 0.7.0

package/CHANGELOG.md

@@ -1,5 +1,44 @@
 # @checkstack/common
 
+## 0.7.0
+
+### Minor Changes
+
+- 8d1ef12: Phase 2 of anomaly detection: trend drift detection.
+
+  The background baseline analyzer now computes a linear regression slope across each field's chronologically-ordered history and runs a `detectDrift` evaluator that catches gradual "creeping degradation" never reaching the 3σ spike threshold. Drifts share the same `anomalies` table as spike anomalies via a new `kind` column (`spike` | `drift`, default `spike`); the existing suspicious → anomaly → recovered lifecycle is reused, ticking at the analyzer's hourly cadence with a default 2-run confirmation window.
+
+  User-facing additions: a Trend Drift toggle and threshold slider on both the template and assignment anomaly settings panels (with per-field overrides), drift rows in the System Anomaly widget, dashed regression-line overlays on the auto-generated line charts, and a new `ANOMALY_TREND_DETECTED` signal for live UI updates. Plugin authors can disable drift per chartable field via `x-anomaly-drift-enabled: false` or tighten/loosen it via `x-anomaly-drift-threshold`.
+
+## 0.6.5
+
+### Patch Changes
+
+- d1a2796: Enforce stricter code quality standards and eliminate AI slop anti-patterns.
+
+  **New utility**
+
+  - `extractErrorMessage(error, fallback?)` in `@checkstack/common` for consistent error extraction
+
+  **ESLint rules**
+
+  - `react-hooks/rules-of-hooks` and `exhaustive-deps` for hook correctness
+  - `no-console` in frontend packages — forces `toast` over silent `console.error`
+  - `no-restricted-syntax` banning `instanceof Error` — forces `extractErrorMessage`
+  - Custom `no-eslint-disable-any` rule preventing `@typescript-eslint/no-explicit-any` circumvention
+
+  **Refactoring**
+
+  - Replace 141 `instanceof Error` boilerplate patterns across the codebase
+  - Replace swallowed `console.error` with user-visible `toast.error()` feedback
+  - Remove 15 redundant `as` type casts in IntegrationsPage and ProviderConnectionsPage
+  - Consolidate 3 identical callback handlers into `handleDialogClose`
+  - Fix conditional React hook call in `FormField.tsx`
+  - Fix unstable useMemo deps in `Dashboard.tsx`
+  - Replace `useEffect`→`setState` with derived `useMemo` in `RegisterPage.tsx`
+  - Rewrite `keystore.test.ts` with typed `DrizzleMockChain` (eliminating 7 `any` suppressions)
+  - Delete obvious comments in `encryption.ts` and Teams `provider.ts`
+
 ## 0.6.4
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@checkstack/common",
-  "version": "0.6.4",
+  "version": "0.7.0",
   "type": "module",
   "main": "./src/index.ts",
   "types": "./src/index.ts",
@@ -18,8 +18,8 @@
   },
   "devDependencies": {
     "typescript": "^5.7.2",
-    "@checkstack/tsconfig": "0.0.3",
-    "@checkstack/scripts": "0.1.1"
+    "@checkstack/tsconfig": "0.0.5",
+    "@checkstack/scripts": "0.1.2"
   },
   "scripts": {
     "typecheck": "tsc --noEmit",

package/src/chart-types.ts

@@ -23,12 +23,9 @@ export type ChartType =
   | "status";
 
 /**
- * Metadata type for health check result schemas.
- * Provides autocompletion for chart-related metadata on result fields.
+ * Base metadata for all health check result schema fields.
  */
-export interface HealthResultMeta {
-  /** The type of chart to render for this field */
-  "x-chart-type"?: ChartType;
+export interface BaseHealthResultMeta {
   /** Human-readable label for the chart (defaults to field name) */
   "x-chart-label"?: string;
   /** Unit suffix for values (e.g., 'ms', '%', 'req/s') */
@@ -40,4 +37,65 @@ export interface HealthResultMeta {
    * Ephemeral fields are stripped before storing results in the database.
    */
   "x-ephemeral"?: boolean;
+  /**
+   * Sensitivity multiplier for this field (default: 1.0).
+   * Higher values = fewer alerts (wider threshold).
+   * Lower values = more alerts (tighter threshold).
+   * Applied as: threshold = μ ± (3σ × sensitivity)
+   */
+  "x-anomaly-sensitivity"?: number;
+  /**
+   * Override the default confirmation window for this field.
+   * Number of consecutive anomalous data points required before an alert is raised.
+   */
+  "x-anomaly-confirmation-window"?: number;
+  /**
+   * Enable trend drift detection for this field. Default true (when anomaly
+   * detection is enabled). Set false to suppress drift alerts but keep spike
+   * detection active.
+   */
+  "x-anomaly-drift-enabled"?: boolean;
+  /**
+   * Sigma multiplier on the drift trigger band (default 2). Drift fires when
+   * |slope × sampleCount| > threshold × σ × sensitivity.
+   */
+  "x-anomaly-drift-threshold"?: number;
+}
+
+/**
+ * Metadata for a field that exposes a chart AND has anomaly detection enabled.
+ */
+export interface ChartMetaAnomalyEnabled extends BaseHealthResultMeta {
+  "x-chart-type": ChartType;
+  "x-anomaly-enabled": true;
+  "x-anomaly-direction": "higher-is-better" | "lower-is-better" | "deviation" | "dominance";
 }
+
+/**
+ * Metadata for a field that exposes a chart but explicitly disables anomaly detection.
+ */
+export interface ChartMetaAnomalyDisabled extends BaseHealthResultMeta {
+  "x-chart-type": ChartType;
+  "x-anomaly-enabled": false;
+  "x-anomaly-direction"?: never;
+}
+
+/**
+ * Metadata for a field that does NOT expose a chart.
+ */
+export interface NonChartMeta extends BaseHealthResultMeta {
+  "x-chart-type"?: never;
+  "x-anomaly-enabled"?: never;
+  "x-anomaly-direction"?: never;
+}
+
+/**
+ * Metadata type for health check result schemas.
+ * Provides autocompletion and enforces that ANY field exposing a chart
+ * MUST explicitly define its anomaly behavior.
+ */
+export type HealthResultMeta = 
+  | ChartMetaAnomalyEnabled 
+  | ChartMetaAnomalyDisabled 
+  | NonChartMeta;
+

package/src/error-utils.test.ts

@@ -0,0 +1,30 @@
+import { describe, it, expect } from "bun:test";
+import { extractErrorMessage } from "./error-utils";
+
+describe("extractErrorMessage", () => {
+  it("should extract message from Error instances", () => {
+    const error = new Error("something went wrong");
+    expect(extractErrorMessage(error)).toBe("something went wrong");
+  });
+
+  it("should extract message from Error subclasses", () => {
+    const error = new TypeError("invalid type");
+    expect(extractErrorMessage(error)).toBe("invalid type");
+  });
+
+  it("should return string errors directly", () => {
+    expect(extractErrorMessage("network failure")).toBe("network failure");
+  });
+
+  it("should return the default fallback for non-Error, non-string values", () => {
+    expect(extractErrorMessage(42)).toBe("An error occurred");
+    expect(extractErrorMessage(undefined)).toBe("An error occurred");
+    // eslint-disable-next-line unicorn/no-null
+    expect(extractErrorMessage(null)).toBe("An error occurred");
+    expect(extractErrorMessage({ code: 500 })).toBe("An error occurred");
+  });
+
+  it("should return custom fallback when provided", () => {
+    expect(extractErrorMessage(42, "Custom fallback")).toBe("Custom fallback");
+  });
+});

package/src/error-utils.ts

@@ -0,0 +1,16 @@
+/**
+ * Extracts a human-readable message from an unknown error value.
+ *
+ * Handles Error instances, plain strings, and arbitrary values.
+ * Designed as a single source of truth — use this instead of
+ * inline `error instanceof Error ? error.message : fallback` patterns.
+ */
+export function extractErrorMessage(
+  error: unknown,
+  fallback = "An error occurred",
+): string {
+  // eslint-disable-next-line no-restricted-syntax -- This IS the canonical implementation
+  if (error instanceof Error) return error.message;
+  if (typeof error === "string") return error;
+  return fallback;
+}

package/src/index.ts

@@ -9,3 +9,4 @@ export * from "./transport-client";
 export * from "./json-schema";
 export * from "./chart-types";
 export * from "./procedure-builder";
+export * from "./error-utils";