@checkstack/catalog-frontend 0.5.7 → 0.5.8

package/CHANGELOG.md

@@ -1,5 +1,44 @@
 # @checkstack/catalog-frontend
 
+## 0.5.8
+
+### Patch Changes
+
+- d1a2796: Enforce stricter code quality standards and eliminate AI slop anti-patterns.
+
+  **New utility**
+
+  - `extractErrorMessage(error, fallback?)` in `@checkstack/common` for consistent error extraction
+
+  **ESLint rules**
+
+  - `react-hooks/rules-of-hooks` and `exhaustive-deps` for hook correctness
+  - `no-console` in frontend packages — forces `toast` over silent `console.error`
+  - `no-restricted-syntax` banning `instanceof Error` — forces `extractErrorMessage`
+  - Custom `no-eslint-disable-any` rule preventing `@typescript-eslint/no-explicit-any` circumvention
+
+  **Refactoring**
+
+  - Replace 141 `instanceof Error` boilerplate patterns across the codebase
+  - Replace swallowed `console.error` with user-visible `toast.error()` feedback
+  - Remove 15 redundant `as` type casts in IntegrationsPage and ProviderConnectionsPage
+  - Consolidate 3 identical callback handlers into `handleDialogClose`
+  - Fix conditional React hook call in `FormField.tsx`
+  - Fix unstable useMemo deps in `Dashboard.tsx`
+  - Replace `useEffect`→`setState` with derived `useMemo` in `RegisterPage.tsx`
+  - Rewrite `keystore.test.ts` with typed `DrizzleMockChain` (eliminating 7 `any` suppressions)
+  - Delete obvious comments in `encryption.ts` and Teams `provider.ts`
+
+- Updated dependencies [d1a2796]
+- Updated dependencies [3c34b07]
+  - @checkstack/common@0.6.5
+  - @checkstack/ui@1.2.1
+  - @checkstack/auth-frontend@0.5.18
+  - @checkstack/frontend-api@0.3.9
+  - @checkstack/catalog-common@1.3.1
+  - @checkstack/auth-common@0.6.1
+  - @checkstack/notification-common@0.2.8
+
 ## 0.5.7
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@checkstack/catalog-frontend",
-  "version": "0.5.7",
+  "version": "0.5.8",
   "type": "module",
   "main": "src/index.tsx",
   "checkstack": {
@@ -14,7 +14,7 @@
   "dependencies": {
     "@checkstack/auth-common": "0.6.0",
     "@checkstack/auth-frontend": "0.5.17",
-    "@checkstack/catalog-common": "1.2.11",
+    "@checkstack/catalog-common": "1.3.0",
     "@checkstack/common": "0.6.4",
     "@checkstack/frontend-api": "0.3.8",
     "@checkstack/notification-common": "0.2.7",
@@ -28,7 +28,7 @@
   "devDependencies": {
     "typescript": "^5.0.0",
     "@types/react": "^18.2.0",
-    "@checkstack/tsconfig": "0.0.4",
+    "@checkstack/tsconfig": "0.0.5",
     "@checkstack/scripts": "0.1.2"
   }
 }

package/src/components/CatalogConfigPage.tsx

@@ -35,6 +35,7 @@ import { SystemEditor } from "./SystemEditor";
 import { GroupEditor } from "./GroupEditor";
 import { DraggableSystem, SystemDragOverlay } from "./DraggableSystem";
 import { DroppableGroup } from "./DroppableGroup";
+import { extractErrorMessage } from "@checkstack/common";
 
 export const CatalogConfigPage = () => {
   const catalogClient = usePluginClient(CatalogApi);
@@ -118,7 +119,7 @@ export const CatalogConfigPage = () => {
     },
     onError: (error) => {
       toast.error(
-        error instanceof Error ? error.message : "Failed to create system",
+        extractErrorMessage(error, "Failed to create system"),
       );
     },
   });
@@ -132,7 +133,7 @@ export const CatalogConfigPage = () => {
     },
     onError: (error) => {
       toast.error(
-        error instanceof Error ? error.message : "Failed to update system",
+        extractErrorMessage(error, "Failed to update system"),
       );
     },
   });
@@ -145,7 +146,7 @@ export const CatalogConfigPage = () => {
     },
     onError: (error) => {
       toast.error(
-        error instanceof Error ? error.message : "Failed to delete system",
+        extractErrorMessage(error, "Failed to delete system"),
       );
     },
   });
@@ -158,7 +159,7 @@ export const CatalogConfigPage = () => {
     },
     onError: (error) => {
       toast.error(
-        error instanceof Error ? error.message : "Failed to create group",
+        extractErrorMessage(error, "Failed to create group"),
       );
     },
   });
@@ -171,7 +172,7 @@ export const CatalogConfigPage = () => {
     },
     onError: (error) => {
       toast.error(
-        error instanceof Error ? error.message : "Failed to delete group",
+        extractErrorMessage(error, "Failed to delete group"),
       );
     },
   });
@@ -183,7 +184,7 @@ export const CatalogConfigPage = () => {
     },
     onError: (error) => {
       toast.error(
-        error instanceof Error ? error.message : "Failed to update group name",
+        extractErrorMessage(error, "Failed to update group name"),
       );
       throw error;
     },
@@ -198,9 +199,7 @@ export const CatalogConfigPage = () => {
     },
     onError: (error) => {
       toast.error(
-        error instanceof Error
-          ? error.message
-          : "Failed to add system to group",
+        extractErrorMessage(error, "Failed to add system to group"),
       );
     },
   });
@@ -213,9 +212,7 @@ export const CatalogConfigPage = () => {
       },
       onError: (error) => {
         toast.error(
-          error instanceof Error
-            ? error.message
-            : "Failed to remove system from group",
+          extractErrorMessage(error, "Failed to remove system from group"),
         );
       },
     });

package/src/components/ContactsEditor.tsx

@@ -21,6 +21,7 @@ import {
 import { CatalogApi, type SystemContact } from "@checkstack/catalog-common";
 import { AuthApi, authAccess } from "@checkstack/auth-common";
 import { User, Mail, Trash2, Plus } from "lucide-react";
+import { extractErrorMessage } from "@checkstack/common";
 
 interface ContactsEditorProps {
   systemId: string;
@@ -79,7 +80,7 @@ export const ContactsEditor: React.FC<ContactsEditorProps> = ({ systemId }) => {
     },
     onError: (error) => {
       toast.error(
-        error instanceof Error ? error.message : "Failed to add contact",
+        extractErrorMessage(error, "Failed to add contact"),
       );
     },
   });
@@ -92,7 +93,7 @@ export const ContactsEditor: React.FC<ContactsEditorProps> = ({ systemId }) => {
     },
     onError: (error) => {
       toast.error(
-        error instanceof Error ? error.message : "Failed to remove contact",
+        extractErrorMessage(error, "Failed to remove contact"),
       );
     },
   });

package/src/components/GroupEditor.tsx

@@ -11,6 +11,7 @@ import {
   DialogFooter,
   useToast,
 } from "@checkstack/ui";
+import { extractErrorMessage } from "@checkstack/common";
 
 interface GroupEditorProps {
   open: boolean;
@@ -46,7 +47,7 @@ export const GroupEditor: React.FC<GroupEditorProps> = ({
       onClose();
     } catch (error) {
       const message =
-        error instanceof Error ? error.message : "Failed to save group";
+        extractErrorMessage(error, "Failed to save group");
       toast.error(message);
     } finally {
       setLoading(false);

package/src/components/SystemDetailPage.tsx

@@ -33,6 +33,7 @@ import {
   Mail,
   User,
 } from "lucide-react";
+import { extractErrorMessage } from "@checkstack/common";
 
 const CATALOG_PLUGIN_ID = "catalog";
 
@@ -88,7 +89,7 @@ export const SystemDetailPage: React.FC = () => {
     },
     onError: (error) => {
       toast.error(
-        error instanceof Error ? error.message : "Failed to subscribe",
+        extractErrorMessage(error, "Failed to subscribe"),
       );
     },
   });
@@ -101,7 +102,7 @@ export const SystemDetailPage: React.FC = () => {
     },
     onError: (error) => {
       toast.error(
-        error instanceof Error ? error.message : "Failed to unsubscribe",
+        extractErrorMessage(error, "Failed to unsubscribe"),
       );
     },
   });

package/src/components/SystemEditor.tsx

@@ -15,6 +15,7 @@ import { TeamAccessEditor } from "@checkstack/auth-frontend";
 import { ContactsEditor } from "./ContactsEditor";
 import { ExtensionSlot } from "@checkstack/frontend-api";
 import { SystemEditorSlot } from "@checkstack/catalog-common";
+import { extractErrorMessage } from "@checkstack/common";
 
 interface SystemEditorProps {
   open: boolean;
@@ -57,7 +58,7 @@ export const SystemEditor: React.FC<SystemEditorProps> = ({
       onClose();
     } catch (error) {
       const message =
-        error instanceof Error ? error.message : "Failed to save system";
+        extractErrorMessage(error, "Failed to save system");
       toast.error(message);
     } finally {
       setLoading(false);