@checkstack/backend 0.9.0 → 0.10.0

package/src/services/cache-manager.ts

@@ -1,4 +1,10 @@
-import type { CacheManager, CacheProvider } from "@checkstack/cache-api";
+import type {
+  CacheManager,
+  CacheProvider,
+  CacheStats,
+  ListEntriesOptions,
+  ListEntriesResult,
+} from "@checkstack/cache-api";
 import type { CachePluginRegistryImpl } from "./cache-plugin-registry";
 import type { Logger, ConfigService } from "@checkstack/backend-api";
 import { z } from "zod";
@@ -18,6 +24,10 @@ type ActiveCachePointer = z.infer<typeof activeCachePointerSchema>;
 /**
  * A no-op CacheProvider used before any backend is configured.
  * All operations are safe to call but behave as if the cache is empty.
+ *
+ * Held only as the initial value of `activeProvider` until
+ * `loadConfiguration()` runs; consumers always interact with the stable
+ * proxy below, so they pick up the real provider as soon as it's ready.
  */
 const nullProvider: CacheProvider = {
   // eslint-disable-next-line unicorn/no-useless-undefined
@@ -31,8 +41,18 @@ const nullProvider: CacheProvider = {
 /**
  * CacheManagerImpl handles cache provider lifecycle and backend switching.
  *
- * Simpler than QueueManagerImpl — no proxy pattern needed since cache is
- * stateless key/value. The active provider is replaced atomically on backend switch.
+ * `getProvider()` returns a single stable proxy whose methods delegate to
+ * whichever provider is currently active. This means:
+ *
+ *  - Plugins that capture the proxy at init time (e.g. via
+ *    `createCachedScope`) keep functioning across backend switches and
+ *    don't write into orphaned providers.
+ *  - The Infrastructure runtime panel reads stats from the same instance
+ *    plugins write to — no split-brain.
+ *
+ * The earlier "no proxy pattern needed since cache is stateless key/value"
+ * comment was wrong: in-memory backends are stateful and replacing the
+ * active reference would orphan their state.
  */
 export class CacheManagerImpl implements CacheManager {
   private activePluginId: string = "memory";
@@ -42,12 +62,49 @@ export class CacheManagerImpl implements CacheManager {
   };
   private configVersion: number = 0;
   private activeProvider: CacheProvider = nullProvider;
+  private readonly providerProxy: CacheProvider;
 
   constructor(
     private registry: CachePluginRegistryImpl,
     private configService: ConfigService,
     private logger: Logger,
-  ) {}
+  ) {
+    this.providerProxy = this.createProviderProxy();
+  }
+
+  private createProviderProxy(): CacheProvider {
+    return {
+      get: <T>(key: string) => this.activeProvider.get<T>(key),
+      set: <T>(key: string, value: T, ttlMs?: number) =>
+        this.activeProvider.set<T>(key, value, ttlMs),
+      delete: (key: string) => this.activeProvider.delete(key),
+      deleteByPrefix: (prefix: string) =>
+        this.activeProvider.deleteByPrefix(prefix),
+      has: (key: string) => this.activeProvider.has(key),
+      getStats: async (): Promise<CacheStats> => {
+        const provider = this.activeProvider;
+        if (provider.getStats) {
+          return provider.getStats();
+        }
+        return {
+          keyCount: null,
+          sizeBytes: null,
+          hits: null,
+          misses: null,
+          scope: "instance",
+        };
+      },
+      listEntries: async (
+        opts: ListEntriesOptions,
+      ): Promise<ListEntriesResult> => {
+        const provider = this.activeProvider;
+        if (!provider.listEntries) {
+          return { items: [], total: 0, hasMore: false };
+        }
+        return provider.listEntries(opts);
+      },
+    };
+  }
 
   async loadConfiguration(): Promise<void> {
     try {
@@ -83,11 +140,10 @@ export class CacheManagerImpl implements CacheManager {
         );
       }
 
-      // Initialize the active provider
       this.initializeProvider();
     } catch (error) {
       this.logger.error("Failed to load cache configuration", error);
-      // Continue with defaults — nullProvider is already set
+      // Continue with defaults — nullProvider is already set behind the proxy.
     }
   }
 
@@ -113,8 +169,12 @@ export class CacheManagerImpl implements CacheManager {
     }
   }
 
+  /**
+   * Returns the stable proxy. The same instance is returned for the
+   * lifetime of the manager, so callers can safely capture it once.
+   */
   getProvider(): CacheProvider {
-    return this.activeProvider;
+    return this.providerProxy;
   }
 
   getActivePlugin(): string {
@@ -126,21 +186,17 @@ export class CacheManagerImpl implements CacheManager {
   }
 
   async setActiveBackend(pluginId: string, config: unknown): Promise<void> {
-    // 1. Validate plugin exists
     const newPlugin = this.registry.getPlugin(pluginId);
     if (!newPlugin) {
       throw new Error(`Cache plugin '${pluginId}' not found`);
     }
 
-    // 2. Validate config against schema
     newPlugin.configSchema.parse(config);
 
-    // 3. Create new provider (acts as connection test)
     this.logger.info("🔍 Testing new cache provider...");
     let newProvider: CacheProvider;
     try {
       newProvider = newPlugin.createProvider(config, this.logger);
-      // Quick smoke test
       await newProvider.set("__test__", true, 1000);
       await newProvider.delete("__test__");
       this.logger.info("✅ Cache provider test successful");
@@ -150,20 +206,17 @@ export class CacheManagerImpl implements CacheManager {
       throw new Error(`Failed to create cache provider: ${message}`);
     }
 
-    // 4. Stop old provider if it has a stop method
     const oldProvider = this.activeProvider;
     if ("stop" in oldProvider && typeof oldProvider.stop === "function") {
       await (oldProvider as { stop: () => Promise<void> }).stop();
     }
 
-    // 5. Switch to new provider
     const oldPluginId = this.activePluginId;
     this.activePluginId = pluginId;
     this.activeConfig = config;
     this.configVersion++;
     this.activeProvider = newProvider;
 
-    // 6. Persist configuration
     await this.configService.set(
       pluginId,
       newPlugin.configSchema,

package/src/services/event-bus.test.ts

@@ -465,5 +465,57 @@ describe("EventBus", () => {
         `No local listeners for hook: ${testHook.id}`
       );
     });
+
+    it("should drop emit (not enqueue) when no listeners are registered", async () => {
+      const testHook = createHook<{ value: number }>(
+        "test.emit.no.listeners",
+      );
+
+      // Capture queue creation: getQueue is invoked lazily on enqueue.
+      const before = (mockQueueManager as any).getQueue?.mock?.calls?.length ?? 0;
+
+      await eventBus.emit(testHook, { value: 1 });
+      await eventBus.emit(testHook, { value: 2 });
+
+      const after = (mockQueueManager as any).getQueue?.mock?.calls?.length ?? 0;
+      // No queue should be created and no enqueue should occur for an
+      // entirely unsubscribed hook — otherwise jobs would pile up forever.
+      expect(after).toBe(before);
+
+      expect(mockLogger.debug).toHaveBeenCalledWith(
+        `Dropped hook ${testHook.id}: no listeners registered`,
+      );
+    });
+
+    it("should enqueue when at least one distributed listener is registered", async () => {
+      const testHook = createHook<{ value: number }>(
+        "test.emit.with.listener",
+      );
+      const received: number[] = [];
+      await eventBus.subscribe("test-plugin", testHook, async (payload) => {
+        received.push(payload.value);
+      });
+
+      await eventBus.emit(testHook, { value: 7 });
+      // Allow the mock queue to deliver synchronously.
+      await new Promise((resolve) => setTimeout(resolve, 10));
+      expect(received).toContain(7);
+    });
+
+    it("should enqueue when at least one instance-local listener is registered", async () => {
+      const testHook = createHook<{ value: number }>(
+        "test.emit.with.local.listener",
+      );
+      await eventBus.subscribe("test-plugin", testHook, async () => {}, {
+        mode: "instance-local",
+      });
+
+      // emit (distributed) should still enqueue because a local listener
+      // exists — drops are based on absence of *any* listener.
+      await eventBus.emit(testHook, { value: 1 });
+      expect(mockLogger.debug).not.toHaveBeenCalledWith(
+        `Dropped hook ${testHook.id}: no listeners registered`,
+      );
+    });
   });
 });

package/src/services/event-bus.ts

@@ -185,9 +185,35 @@ export class EventBus implements IEventBus {
   }
 
   /**
-   * Emit a hook
+   * Emit a hook.
+   *
+   * Skips the underlying queue enqueue when no listener has been
+   * registered for the hook in this process. Without this guard, hooks
+   * with no subscribers (e.g. `core.plugin.initialized` when no plugin
+   * has registered a listener) would accumulate jobs in the in-memory
+   * queue forever — they'd be enqueued, no consumer group exists to
+   * process them, and `processNext` short-circuits before its cleanup
+   * pass when `consumerGroups.size === 0`.
+   *
+   * Note: this checks listeners in the *local process*. In distributed
+   * deployments with a Redis-backed queue, a subscriber on another
+   * replica would never see the event under this rule. Callers that
+   * need cross-process delivery must therefore ensure at least one
+   * listener registers on every replica that should receive the hook.
    */
   async emit<T>(hook: Hook<T>, payload: T): Promise<void> {
+    const hasDistributedListeners =
+      (this.listeners.get(hook.id)?.length ?? 0) > 0;
+    const hasLocalListeners =
+      (this.localListeners.get(hook.id)?.length ?? 0) > 0;
+
+    if (!hasDistributedListeners && !hasLocalListeners) {
+      this.logger.debug(
+        `Dropped hook ${hook.id}: no listeners registered`,
+      );
+      return;
+    }
+
     let channel = this.queueChannels.get(hook.id);
 
     // Create channel lazily if not exists

package/src/services/queue-manager.ts

@@ -4,6 +4,9 @@ import type {
   SwitchResult,
   RecurringJobInfo,
   QueueStats,
+  JobSummary,
+  ListJobsOptions,
+  ListJobsResult,
 } from "@checkstack/queue-api";
 import type { QueuePluginRegistryImpl } from "./queue-plugin-registry";
 import type { Logger, ConfigService } from "@checkstack/backend-api";
@@ -276,7 +279,11 @@ export class QueueManagerImpl implements QueueManager {
   }
 
   async getAggregatedStats(): Promise<QueueStats> {
-    const aggregated: QueueStats = {
+    // The narrowest scope wins: if any queue reports `instance`, the
+    // aggregate cannot claim cluster-wide accuracy.
+    let scope: "instance" | "cluster" = "cluster";
+    let sawAny = false;
+    const aggregated: Omit<QueueStats, "scope"> = {
       pending: 0,
       processing: 0,
       completed: 0,
@@ -294,13 +301,81 @@ export class QueueManagerImpl implements QueueManager {
           aggregated.completed += stats.completed;
           aggregated.failed += stats.failed;
           aggregated.consumerGroups += stats.consumerGroups;
+          if (stats.scope === "instance") {
+            scope = "instance";
+          }
+          sawAny = true;
+        }
+      } catch {
+        // Queue may not be initialized yet
+      }
+    }
+
+    return { ...aggregated, scope: sawAny ? scope : "instance" };
+  }
+
+  /**
+   * Aggregate `listJobs` across every queue proxy. For deployments with a
+   * single queue (the common case) this is a straight pass-through; with
+   * multiple queues we over-fetch [0, offset+limit) per queue, merge-sort
+   * by the same key the per-queue impls use, then slice the requested
+   * window. Sort key:
+   *  - completed/failed → finishedAt desc (most-recent first)
+   *  - active           → startedAt asc (oldest still-running first)
+   *  - waiting/delayed  → enqueuedAt asc (FIFO)
+   */
+  async listJobs(opts: ListJobsOptions): Promise<ListJobsResult> {
+    const limit = Math.max(0, opts.limit);
+    const offset = Math.max(0, opts.offset);
+    if (limit === 0) {
+      return { items: [], total: 0, hasMore: false };
+    }
+
+    const fetchUpTo = offset + limit;
+    const merged: JobSummary[] = [];
+    let totalSum = 0;
+    let totalIsNull = false;
+
+    for (const proxy of this.queueProxies.values()) {
+      try {
+        const delegate = proxy.getDelegate();
+        if (delegate) {
+          const part = await delegate.listJobs({
+            state: opts.state,
+            offset: 0,
+            limit: fetchUpTo,
+          });
+          merged.push(...part.items);
+          if (part.total === null) {
+            totalIsNull = true;
+          } else {
+            totalSum += part.total;
+          }
         }
       } catch {
         // Queue may not be initialized yet
       }
     }
 
-    return aggregated;
+    const sortKey = (j: JobSummary): number => {
+      if (opts.state === "completed" || opts.state === "failed") {
+        return -(j.finishedAt?.getTime() ?? 0);
+      }
+      if (opts.state === "active") {
+        return j.startedAt?.getTime() ?? 0;
+      }
+      return j.enqueuedAt.getTime();
+    };
+    merged.sort((a, b) => sortKey(a) - sortKey(b));
+
+    const items = merged.slice(offset, offset + limit);
+    const total = totalIsNull ? null : totalSum;
+    const hasMore =
+      total === null
+        ? merged.length > offset + items.length
+        : offset + items.length < total;
+
+    return { items, total, hasMore };
   }
 
   async listAllRecurringJobs(): Promise<RecurringJobInfo[]> {

package/src/services/queue-proxy.ts

@@ -5,6 +5,8 @@ import type {
   QueueStats,
   RecurringJobDetails,
   RecurringSchedule,
+  ListJobsOptions,
+  ListJobsResult,
 } from "@checkstack/queue-api";
 import { rootLogger } from "../logger";
 
@@ -173,6 +175,11 @@ export class QueueProxy<T = unknown> implements Queue<T> {
     return delegate.getStats();
   }
 
+  async listJobs(opts: ListJobsOptions): Promise<ListJobsResult> {
+    const delegate = this.ensureDelegate();
+    return delegate.listJobs(opts);
+  }
+
   /**
    * Get subscription count (for testing/debugging)
    */