@checkstack/backend 0.5.2 → 0.5.3

package/CHANGELOG.md

@@ -1,5 +1,43 @@
 # @checkstack/backend
 
+## 0.5.3
+
+### Patch Changes
+
+- d1a2796: Enforce stricter code quality standards and eliminate AI slop anti-patterns.
+
+  **New utility**
+
+  - `extractErrorMessage(error, fallback?)` in `@checkstack/common` for consistent error extraction
+
+  **ESLint rules**
+
+  - `react-hooks/rules-of-hooks` and `exhaustive-deps` for hook correctness
+  - `no-console` in frontend packages — forces `toast` over silent `console.error`
+  - `no-restricted-syntax` banning `instanceof Error` — forces `extractErrorMessage`
+  - Custom `no-eslint-disable-any` rule preventing `@typescript-eslint/no-explicit-any` circumvention
+
+  **Refactoring**
+
+  - Replace 141 `instanceof Error` boilerplate patterns across the codebase
+  - Replace swallowed `console.error` with user-visible `toast.error()` feedback
+  - Remove 15 redundant `as` type casts in IntegrationsPage and ProviderConnectionsPage
+  - Consolidate 3 identical callback handlers into `handleDialogClose`
+  - Fix conditional React hook call in `FormField.tsx`
+  - Fix unstable useMemo deps in `Dashboard.tsx`
+  - Replace `useEffect`→`setState` with derived `useMemo` in `RegisterPage.tsx`
+  - Rewrite `keystore.test.ts` with typed `DrizzleMockChain` (eliminating 7 `any` suppressions)
+  - Delete obvious comments in `encryption.ts` and Teams `provider.ts`
+
+- Updated dependencies [d1a2796]
+  - @checkstack/common@0.6.5
+  - @checkstack/backend-api@0.11.1
+  - @checkstack/api-docs-common@0.1.9
+  - @checkstack/auth-common@0.6.1
+  - @checkstack/signal-backend@0.1.18
+  - @checkstack/signal-common@0.1.9
+  - @checkstack/queue-api@0.2.12
+
 ## 0.5.2
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@checkstack/backend",
-  "version": "0.5.2",
+  "version": "0.5.3",
   "checkstack": {
     "type": "backend"
   },
@@ -15,11 +15,11 @@
   "dependencies": {
     "@checkstack/api-docs-common": "0.1.8",
     "@checkstack/auth-common": "0.6.0",
-    "@checkstack/backend-api": "0.10.0",
+    "@checkstack/backend-api": "0.11.0",
     "@checkstack/common": "0.6.4",
     "@checkstack/drizzle-helper": "0.0.4",
-    "@checkstack/queue-api": "0.2.9",
-    "@checkstack/signal-backend": "0.1.15",
+    "@checkstack/queue-api": "0.2.11",
+    "@checkstack/signal-backend": "0.1.17",
     "@checkstack/signal-common": "0.1.8",
     "@hono/zod-validator": "^0.7.6",
     "@orpc/client": "^1.13.14",
@@ -38,8 +38,8 @@
   "devDependencies": {
     "@types/pg": "^8.11.0",
     "@types/bun": "latest",
-    "@checkstack/tsconfig": "0.0.4",
+    "@checkstack/tsconfig": "0.0.5",
     "@checkstack/scripts": "0.1.2",
-    "@checkstack/test-utils-backend": "0.1.15"
+    "@checkstack/test-utils-backend": "0.1.17"
   }
 }

package/src/plugin-manager/api-router.ts

@@ -68,11 +68,15 @@ export function createApiRouteHandler({
               return await next(rest);
             } catch (error) {
               if (logger) {
-                (logger as Logger).error(
-                  `RPC procedure error: ${String(error)}`,
-                );
-                if (error instanceof Error && error.stack) {
-                  (logger as Logger).error(`Stack trace: ${error.stack}`);
+                logger.error(`RPC procedure error: ${String(error)}`);
+                const stack =
+                  error !== null &&
+                  typeof error === "object" &&
+                  "stack" in error
+                    ? (error as { stack: string }).stack
+                    : undefined;
+                if (stack) {
+                  logger.error(`Stack trace: ${stack}`);
                 }
               }
               throw error;

package/src/services/keystore.test.ts

@@ -1,76 +1,74 @@
 import { describe, it, expect, mock, beforeEach } from "bun:test";
 import { KeyStore } from "./keystore";
 
-// 1. Mock the DB module
-const mockDb = {
-  insert: mock(() => ({
+/**
+ * Drizzle fluent-chain mock factory.
+ *
+ * Drizzle's API returns `this` from every query-builder method (select, from,
+ * where, …). The final object is thenable — awaiting it resolves the query.
+ * This factory builds a single object that satisfies that pattern without
+ * resorting to `any`.
+ */
+interface DrizzleMockChain {
+  insert: ReturnType<typeof mock>;
+  values: ReturnType<typeof mock>;
+  update: ReturnType<typeof mock>;
+  set: ReturnType<typeof mock>;
+  delete: ReturnType<typeof mock>;
+  select: ReturnType<typeof mock>;
+  from: ReturnType<typeof mock>;
+  where: ReturnType<typeof mock>;
+  orderBy: ReturnType<typeof mock>;
+  limit: ReturnType<typeof mock>;
+  // eslint-disable-next-line unicorn/no-thenable -- Required: Drizzle chains are awaitable via a custom .then()
+  then: (resolve: (rows: unknown[]) => void) => void;
+}
+
+function createDrizzleMockChain(): DrizzleMockChain {
+  const chain: DrizzleMockChain = {
+    insert: mock(() => chain),
     values: mock(() => Promise.resolve()),
-  })),
-  select: mock(() => mockDb),
-  from: mock(() => mockDb),
-  where: mock(() => mockDb),
-  orderBy: mock(() => mockDb),
-  limit: mock(() => mockDb),
-};
-
-// Return empty list by default for selects
-// We will override implementation per test if needed
-// But since the chain returns `mockDb` (itself), the final await needs to return data.
-// Wait, `await db.select()...` means the object must be thenable or the last method returns a Promise.
-// Drizzle: .execute() or await directly.
-// In the code: `const validKeys = await db.select()...`
-// So the object returned by `limit()` must be thenable.
-
-const mockChain = () => {
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  const chain: any = {};
-  chain.insert = mock(() => chain);
-  chain.values = mock(() => Promise.resolve());
-  chain.update = mock(() => chain);
-  chain.set = mock(() => chain);
-  chain.delete = mock(() => chain);
-
-  chain.select = mock(() => chain);
-  chain.from = mock(() => chain);
-  chain.where = mock(() => chain);
-  chain.orderBy = mock(() => chain);
-  chain.limit = mock(() => chain); // limit is the last one called in getSigningKey
-
-  // Make it thenable to simulate 'await'
-  // eslint-disable-next-line unicorn/no-thenable, @typescript-eslint/no-explicit-any
-  chain.then = (resolve: any) => resolve([]); // Default empty array
+    update: mock(() => chain),
+    set: mock(() => chain),
+    delete: mock(() => chain),
+    select: mock(() => chain),
+    from: mock(() => chain),
+    where: mock(() => chain),
+    orderBy: mock(() => chain),
+    limit: mock(() => chain),
+    // eslint-disable-next-line unicorn/no-thenable -- Required: Drizzle chains are awaitable via a custom .then()
+    then: (resolve) => resolve([]),
+  };
 
   return chain;
-};
+}
 
-const dbMockInstance = mockChain();
+const dbMock = createDrizzleMockChain();
 
-mock.module("../db", () => {
-  return {
-    db: dbMockInstance,
-  };
-});
+mock.module("../db", () => ({
+  db: dbMock,
+}));
 
 describe("KeyStore", () => {
   let store: KeyStore;
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  let mockKeyForGeneration: any;
+  let mockKeyForGeneration: Record<string, unknown>;
 
   beforeEach(async () => {
     store = new KeyStore();
+
     // Reset mocks
-    dbMockInstance.select.mockClear();
-    dbMockInstance.insert.mockClear();
-    dbMockInstance.update.mockClear();
-    dbMockInstance.set.mockClear();
-    dbMockInstance.delete.mockClear();
-    dbMockInstance.where.mockClear();
-
-    // Reset default behavior
-    // eslint-disable-next-line unicorn/no-thenable, @typescript-eslint/no-explicit-any
-    dbMockInstance.then = (resolve: any) => resolve([]);
-
-    // Pre-generate a valid key for mocking responses
+    dbMock.select.mockClear();
+    dbMock.insert.mockClear();
+    dbMock.update.mockClear();
+    dbMock.set.mockClear();
+    dbMock.delete.mockClear();
+    dbMock.where.mockClear();
+
+    // Reset default behavior — empty result set
+    // eslint-disable-next-line unicorn/no-thenable -- Required: Drizzle chains are awaitable via a custom .then()
+    dbMock.then = (resolve) => resolve([]);
+
+    // Pre-generate a valid RSA keypair for mock responses
     const { generateKeyPair, exportJWK } = await import("jose");
     const { publicKey, privateKey } = await generateKeyPair("RS256", {
       extractable: true,
@@ -90,10 +88,9 @@ describe("KeyStore", () => {
   });
 
   it("should generate a new key if no active key exists", async () => {
-    // Mock DB returning empty array for existing keys first, then the new key
     let callCount = 0;
-    // eslint-disable-next-line unicorn/no-thenable, @typescript-eslint/no-explicit-any
-    dbMockInstance.then = (resolve: any) => {
+    // eslint-disable-next-line unicorn/no-thenable -- Required: Drizzle chains are awaitable via a custom .then()
+    dbMock.then = (resolve) => {
       callCount++;
       if (callCount === 1) {
         return resolve([]); // First call: no active key
@@ -103,9 +100,9 @@ describe("KeyStore", () => {
 
     const result = await store.getSigningKey();
 
-    expect(result.kid).toBe("generated-kid"); // The mock key ID
+    expect(result.kid).toBe("generated-kid");
     expect(result.key).toBeTruthy();
-    expect(dbMockInstance.insert).toHaveBeenCalled();
+    expect(dbMock.insert).toHaveBeenCalled();
   });
 
   it("should return the existing key if it is valid", async () => {
@@ -122,24 +119,21 @@ describe("KeyStore", () => {
       publicKey: JSON.stringify(publicJwk),
       privateKey: JSON.stringify(privateJwk),
       algorithm: "RS256",
-      createdAt: new Date().toISOString(), // Fresh
+      createdAt: new Date().toISOString(),
       expiresAt: undefined,
       revokedAt: undefined,
     };
 
-    // Mock DB return
-    // eslint-disable-next-line unicorn/no-thenable, @typescript-eslint/no-explicit-any
-    dbMockInstance.then = (resolve: any) => resolve([mockKeyRow]);
+    // eslint-disable-next-line unicorn/no-thenable -- Required: Drizzle chains are awaitable via a custom .then()
+    dbMock.then = (resolve) => resolve([mockKeyRow]);
 
     const result = await store.getSigningKey();
 
     expect(result.kid).toBe(kid);
-    // Should NOT have called insert (no rotation)
-    expect(dbMockInstance.insert).not.toHaveBeenCalled();
+    expect(dbMock.insert).not.toHaveBeenCalled();
   });
 
   it("should rotate key if the existing one is too old", async () => {
-    // Generate a real key
     const { generateKeyPair, exportJWK } = await import("jose");
     const { publicKey, privateKey } = await generateKeyPair("RS256", {
       extractable: true,
@@ -148,7 +142,6 @@ describe("KeyStore", () => {
     const privateJwk = await exportJWK(privateKey);
     const kid = "old-kid";
 
-    // Create an OLD date > 1 hour ago
     const oldDate = new Date(Date.now() - 1000 * 60 * 60 * 2).toISOString();
 
     const mockKeyRow = {
@@ -162,14 +155,12 @@ describe("KeyStore", () => {
     };
 
     let callCount = 0;
-    // eslint-disable-next-line unicorn/no-thenable, @typescript-eslint/no-explicit-any
-    dbMockInstance.then = (resolve: any) => {
+    // eslint-disable-next-line unicorn/no-thenable -- Required: Drizzle chains are awaitable via a custom .then()
+    dbMock.then = (resolve) => {
       callCount++;
       if (callCount === 1) {
-        return resolve([mockKeyRow]); // First call: check active
+        return resolve([mockKeyRow]);
       }
-      // Second call: fetch new key (in rotate logic)
-      // We need to return a valid new key so it doesn't crash
       return resolve([
         {
           ...mockKeyRow,
@@ -181,10 +172,10 @@ describe("KeyStore", () => {
 
     const result = await store.getSigningKey();
 
-    expect(result.kid).toBe("new-kid"); // Should return the NEW key
-    expect(dbMockInstance.insert).toHaveBeenCalled();
-    expect(dbMockInstance.update).toHaveBeenCalled(); // Should set expiresAt on old key
-    expect(dbMockInstance.set).toHaveBeenCalledWith(
+    expect(result.kid).toBe("new-kid");
+    expect(dbMock.insert).toHaveBeenCalled();
+    expect(dbMock.update).toHaveBeenCalled();
+    expect(dbMock.set).toHaveBeenCalledWith(
       expect.objectContaining({ expiresAt: expect.any(String) })
     );
   });
@@ -192,7 +183,7 @@ describe("KeyStore", () => {
   it("should delete expired keys in cleanupKeys", async () => {
     await store.cleanupKeys();
 
-    expect(dbMockInstance.delete).toHaveBeenCalled();
-    expect(dbMockInstance.where).toHaveBeenCalled();
+    expect(dbMock.delete).toHaveBeenCalled();
+    expect(dbMock.where).toHaveBeenCalled();
   });
 });

package/src/services/queue-manager.ts

@@ -9,6 +9,7 @@ import type { QueuePluginRegistryImpl } from "./queue-plugin-registry";
 import type { Logger, ConfigService } from "@checkstack/backend-api";
 import { z } from "zod";
 import { QueueProxy } from "./queue-proxy";
+import { extractErrorMessage } from "@checkstack/common";
 
 // Schema for active plugin pointer with version for multi-instance coordination
 const activePluginPointerSchema = z.object({
@@ -151,7 +152,7 @@ export class QueueManagerImpl implements QueueManager {
       await testQueue.stop();
       this.logger.info("✅ Connection test successful");
     } catch (error) {
-      const message = error instanceof Error ? error.message : String(error);
+      const message = extractErrorMessage(error);
       this.logger.error(`❌ Connection test failed: ${message}`);
       throw new Error(`Failed to connect to queue: ${message}`);
     }