@checkly/playwright-core 1.48.22 → 1.51.11-beta.2

package/lib/server/fetch.js

@@ -8,24 +8,26 @@ exports.createProxyAgent = createProxyAgent;
 var _http = _interopRequireDefault(require("http"));
 var _https = _interopRequireDefault(require("https"));
 var _stream = require("stream");
+var _tls = require("tls");
 var _url = _interopRequireDefault(require("url"));
-var _zlib = _interopRequireDefault(require("zlib"));
-var _perf_hooks = require("perf_hooks");
-var _timeoutSettings = require("../common/timeoutSettings");
-var _userAgent = require("../utils/userAgent");
+var zlib = _interopRequireWildcard(require("zlib"));
+var _timeoutSettings = require("./timeoutSettings");
 var _utils = require("../utils");
+var _crypto = require("./utils/crypto");
+var _userAgent = require("./utils/userAgent");
 var _utilsBundle = require("../utilsBundle");
 var _browserContext = require("./browserContext");
 var _cookieStore = require("./cookieStore");
 var _formData = require("./formData");
-var _happyEyeballs = require("../utils/happy-eyeballs");
 var _instrumentation = require("./instrumentation");
 var _progress = require("./progress");
-var _tracing = require("./trace/recorder/tracing");
 var _socksClientCertificatesInterceptor = require("./socksClientCertificatesInterceptor");
-var _tls = require("tls");
+var _happyEyeballs = require("./utils/happyEyeballs");
+var _tracing = require("./trace/recorder/tracing");
 var _fetch = require("../checkly/fetch");
-function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
+function _getRequireWildcardCache(e) { if ("function" != typeof WeakMap) return null; var r = new WeakMap(), t = new WeakMap(); return (_getRequireWildcardCache = function (e) { return e ? t : r; })(e); }
+function _interopRequireWildcard(e, r) { if (!r && e && e.__esModule) return e; if (null === e || "object" != typeof e && "function" != typeof e) return { default: e }; var t = _getRequireWildcardCache(r); if (t && t.has(e)) return t.get(e); var n = { __proto__: null }, a = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var u in e) if ("default" !== u && {}.hasOwnProperty.call(e, u)) { var i = a ? Object.getOwnPropertyDescriptor(e, u) : null; i && (i.get || i.set) ? Object.defineProperty(n, u, i) : n[u] = e[u]; } return n.default = e, t && t.set(e, n), n; }
+function _interopRequireDefault(e) { return e && e.__esModule ? e : { default: e }; }
 /**
  * Copyright (c) Microsoft Corporation.
  *
@@ -69,7 +71,7 @@ class APIRequestContext extends _instrumentation.SdkObject {
     this.fetchLog.delete(fetchUid);
   }
   _storeResponseBody(body) {
-    const uid = (0, _utils.createGuid)();
+    const uid = (0, _crypto.createGuid)();
     this.fetchResponses.set(uid, body);
     return uid;
   }
@@ -93,7 +95,7 @@ class APIRequestContext extends _instrumentation.SdkObject {
         value
       } of params.headers) setHeader(headers, name, value);
     }
-    const requestUrl = new URL(params.url, defaults.baseURL);
+    const requestUrl = new URL((0, _utils.constructURLBasedOnBaseURL)(defaults.baseURL, params.url));
     if (params.encodedParams) {
       requestUrl.search = params.encodedParams;
     } else if (params.params) {
@@ -134,7 +136,8 @@ class APIRequestContext extends _instrumentation.SdkObject {
     });
     const fetchUid = this._storeResponseBody(fetchResponse.body);
     this.fetchLog.set(fetchUid, controller.metadata.log);
-    if (params.failOnStatusCode && (fetchResponse.status < 200 || fetchResponse.status >= 400)) {
+    const failOnStatusCode = params.failOnStatusCode !== undefined ? params.failOnStatusCode : !!defaults.failOnStatusCode;
+    if (failOnStatusCode && (fetchResponse.status < 200 || fetchResponse.status >= 400)) {
       let responseText = '';
       if (fetchResponse.body.byteLength) {
         let text = fetchResponse.body.toString('utf8');
@@ -184,8 +187,7 @@ class APIRequestContext extends _instrumentation.SdkObject {
     }
   }
   async _sendRequestWithRetries(progress, url, options, postData, maxRetries) {
-    var _maxRetries;
-    (_maxRetries = maxRetries) !== null && _maxRetries !== void 0 ? _maxRetries : maxRetries = 0;
+    maxRetries !== null && maxRetries !== void 0 ? maxRetries : maxRetries = 0;
     let backoff = 250;
     for (let i = 0; i <= maxRetries; i++) {
       try {
@@ -231,6 +233,7 @@ class APIRequestContext extends _instrumentation.SdkObject {
       };
       const checklyTimings = (0, _fetch.initializeTimings)();
       const startAt = (0, _utils.monotonicTime)();
+      let reusedSocketAt;
       let dnsLookupAt;
       let tcpConnectionAt;
       let tlsHandshakeAt;
@@ -241,20 +244,20 @@ class APIRequestContext extends _instrumentation.SdkObject {
       const listeners = [];
       const request = requestConstructor(url, requestOptions, async response => {
         const responseAt = (0, _utils.monotonicTime)();
-        checklyTimings.values.response = _perf_hooks.performance.now() - checklyTimings.values.startTimeNow;
+        checklyTimings.values.response = performance.now() - checklyTimings.values.startTimeNow;
         const notifyRequestFinished = body => {
-          var _tlsHandshakeAt;
           const endAt = (0, _utils.monotonicTime)();
           // spec: http://www.softwareishard.com/blog/har-12-spec/#timings
+          const connectEnd = tlsHandshakeAt !== null && tlsHandshakeAt !== void 0 ? tlsHandshakeAt : tcpConnectionAt;
           const timings = {
             send: requestFinishAt - startAt,
             wait: responseAt - requestFinishAt,
             receive: endAt - responseAt,
             dns: dnsLookupAt ? dnsLookupAt - startAt : -1,
-            connect: ((_tlsHandshakeAt = tlsHandshakeAt) !== null && _tlsHandshakeAt !== void 0 ? _tlsHandshakeAt : tcpConnectionAt) - startAt,
+            connect: connectEnd ? connectEnd - startAt : -1,
             // "If [ssl] is defined then the time is also included in the connect field "
             ssl: tlsHandshakeAt ? tlsHandshakeAt - tcpConnectionAt : -1,
-            blocked: -1
+            blocked: reusedSocketAt ? reusedSocketAt - startAt : -1
           };
           const requestFinishedEvent = {
             requestEvent,
@@ -355,7 +358,7 @@ class APIRequestContext extends _instrumentation.SdkObject {
         response.on('aborted', () => reject(new Error('aborted')));
         const chunks = [];
         const notifyBodyFinished = () => {
-          checklyTimings.values.endAt = _perf_hooks.performance.now();
+          checklyTimings.values.endAt = performance.now();
           const body = Buffer.concat(chunks);
           notifyRequestFinished(body);
           fulfill({
@@ -367,10 +370,9 @@ class APIRequestContext extends _instrumentation.SdkObject {
             timings: {
               //@ts-ignore
               values: {
-                ...checklyTimings.values,
-                ..._happyEyeballs.httpHappyEyeballsTimings.values
+                ...checklyTimings.values
               },
-              agent: _happyEyeballs.httpHappyEyeballsTimings.agent || checklyTimings.agent
+              agent: checklyTimings.agent
             }
           });
         };
@@ -378,17 +380,17 @@ class APIRequestContext extends _instrumentation.SdkObject {
         let transform;
         const encoding = response.headers['content-encoding'];
         if (encoding === 'gzip' || encoding === 'x-gzip') {
-          transform = _zlib.default.createGunzip({
-            flush: _zlib.default.constants.Z_SYNC_FLUSH,
-            finishFlush: _zlib.default.constants.Z_SYNC_FLUSH
+          transform = zlib.createGunzip({
+            flush: zlib.constants.Z_SYNC_FLUSH,
+            finishFlush: zlib.constants.Z_SYNC_FLUSH
           });
         } else if (encoding === 'br') {
-          transform = _zlib.default.createBrotliDecompress({
-            flush: _zlib.default.constants.BROTLI_OPERATION_FLUSH,
-            finishFlush: _zlib.default.constants.BROTLI_OPERATION_FLUSH
+          transform = zlib.createBrotliDecompress({
+            flush: zlib.constants.BROTLI_OPERATION_FLUSH,
+            finishFlush: zlib.constants.BROTLI_OPERATION_FLUSH
           });
         } else if (encoding === 'deflate') {
-          transform = _zlib.default.createInflate();
+          transform = zlib.createInflate();
         }
         if (transform) {
           // Brotli and deflate decompressors throw if the input stream is empty.
@@ -411,6 +413,11 @@ class APIRequestContext extends _instrumentation.SdkObject {
       }));
       request.on('close', () => _utils.eventsHelper.removeEventListeners(listeners));
       request.on('socket', socket => {
+        if (request.reusedSocket) {
+          reusedSocketAt = (0, _utils.monotonicTime)();
+          return;
+        }
+
         // happy eyeballs don't emit lookup and connect events, so we use our custom ones
         const happyEyeBallsTimings = (0, _happyEyeballs.timingForSocket)(socket);
         dnsLookupAt = happyEyeBallsTimings.dnsLookupAt;
@@ -507,6 +514,7 @@ class BrowserContextAPIRequestContext extends APIRequestContext {
     return {
       userAgent: this._context._options.userAgent || this._context._browser.userAgent(),
       extraHTTPHeaders: this._context._options.extraHTTPHeaders,
+      failOnStatusCode: undefined,
       httpCredentials: this._context._options.httpCredentials,
       proxy: this._context._options.proxy || this._context._browser.options.proxy,
       timeoutSettings: this._context._timeoutSettings,
@@ -521,8 +529,8 @@ class BrowserContextAPIRequestContext extends APIRequestContext {
   async _cookies(url) {
     return await this._context.cookies(url.toString());
   }
-  async storageState() {
-    return this._context.storageState();
+  async storageState(indexedDB) {
+    return this._context.storageState(indexedDB);
   }
 }
 exports.BrowserContextAPIRequestContext = BrowserContextAPIRequestContext;
@@ -544,7 +552,11 @@ class GlobalAPIRequestContext extends APIRequestContext {
       if (options.clientCertificates) throw new Error('Cannot specify both proxy and clientCertificates');
     }
     if (options.storageState) {
-      this._origins = options.storageState.origins;
+      var _options$storageState;
+      this._origins = (_options$storageState = options.storageState.origins) === null || _options$storageState === void 0 ? void 0 : _options$storageState.map(origin => ({
+        indexedDB: [],
+        ...origin
+      }));
       this._cookieStore.addCookies(options.storageState.cookies || []);
     }
     (0, _browserContext.verifyClientCertificates)(options.clientCertificates);
@@ -552,6 +564,7 @@ class GlobalAPIRequestContext extends APIRequestContext {
       baseURL: options.baseURL,
       userAgent: options.userAgent || (0, _userAgent.getUserAgent)(),
       extraHTTPHeaders: options.extraHTTPHeaders,
+      failOnStatusCode: !!options.failOnStatusCode,
       ignoreHTTPSErrors: !!options.ignoreHTTPSErrors,
       httpCredentials: options.httpCredentials,
       clientCertificates: options.clientCertificates,
@@ -578,10 +591,13 @@ class GlobalAPIRequestContext extends APIRequestContext {
   async _cookies(url) {
     return this._cookieStore.cookies(url);
   }
-  async storageState() {
+  async storageState(indexedDB = false) {
     return {
       cookies: this._cookieStore.allCookies(),
-      origins: this._origins || []
+      origins: (this._origins || []).map(origin => ({
+        ...origin,
+        indexedDB: indexedDB ? origin.indexedDB : []
+      }))
     };
   }
 }

package/lib/server/fileUploadUtils.js

@@ -3,12 +3,13 @@
 Object.defineProperty(exports, "__esModule", {
   value: true
 });
+exports.fileUploadSizeLimit = void 0;
 exports.prepareFilesForUpload = prepareFilesForUpload;
 var _fs = _interopRequireDefault(require("fs"));
 var _path = _interopRequireDefault(require("path"));
-var _utils = require("../utils");
+var _assert = require("../utils/isomorphic/assert");
 var _utilsBundle = require("../utilsBundle");
-function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
+function _interopRequireDefault(e) { return e && e.__esModule ? e : { default: e }; }
 /**
  * Copyright (c) Microsoft Corporation.
  *
@@ -25,9 +26,11 @@ function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { de
  * limitations under the License.
  */
 
+// Keep in sync with the client.
+const fileUploadSizeLimit = exports.fileUploadSizeLimit = 50 * 1024 * 1024;
 async function filesExceedUploadLimit(files) {
   const sizes = await Promise.all(files.map(async file => (await _fs.default.promises.stat(file)).size));
-  return sizes.reduce((total, size) => total + size, 0) >= _utils.fileUploadSizeLimit;
+  return sizes.reduce((total, size) => total + size, 0) >= fileUploadSizeLimit;
 }
 async function prepareFilesForUpload(frame, params) {
   var _fileBuffers;
@@ -44,7 +47,7 @@ async function prepareFilesForUpload(frame, params) {
   if (streams) localPaths = streams.map(c => c.path());
   if (directoryStream) localDirectory = directoryStream.path();
   if (localPaths) {
-    for (const p of localPaths) (0, _utils.assert)(_path.default.isAbsolute(p) && _path.default.resolve(p) === p, 'Paths provided to localPaths must be absolute and fully resolved.');
+    for (const p of localPaths) (0, _assert.assert)(_path.default.isAbsolute(p) && _path.default.resolve(p) === p, 'Paths provided to localPaths must be absolute and fully resolved.');
   }
   let fileBuffers = payloads;
   if (!frame._page._browserContext._browser._isCollocatedWithServer) {

package/lib/server/firefox/ffBrowser.js

@@ -4,16 +4,16 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.FFBrowserContext = exports.FFBrowser = void 0;
-var _errors = require("../errors");
 var _utils = require("../../utils");
 var _browser = require("../browser");
 var _browserContext = require("../browserContext");
+var _errors = require("../errors");
 var network = _interopRequireWildcard(require("../network"));
 var _page = require("../page");
 var _ffConnection = require("./ffConnection");
 var _ffPage = require("./ffPage");
 function _getRequireWildcardCache(e) { if ("function" != typeof WeakMap) return null; var r = new WeakMap(), t = new WeakMap(); return (_getRequireWildcardCache = function (e) { return e ? t : r; })(e); }
-function _interopRequireWildcard(e, r) { if (!r && e && e.__esModule) return e; if (null === e || "object" != typeof e && "function" != typeof e) return { default: e }; var t = _getRequireWildcardCache(r); if (t && t.has(e)) return t.get(e); var n = { __proto__: null }, a = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var u in e) if ("default" !== u && Object.prototype.hasOwnProperty.call(e, u)) { var i = a ? Object.getOwnPropertyDescriptor(e, u) : null; i && (i.get || i.set) ? Object.defineProperty(n, u, i) : n[u] = e[u]; } return n.default = e, t && t.set(e, n), n; }
+function _interopRequireWildcard(e, r) { if (!r && e && e.__esModule) return e; if (null === e || "object" != typeof e && "function" != typeof e) return { default: e }; var t = _getRequireWildcardCache(r); if (t && t.has(e)) return t.get(e); var n = { __proto__: null }, a = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var u in e) if ("default" !== u && {}.hasOwnProperty.call(e, u)) { var i = a ? Object.getOwnPropertyDescriptor(e, u) : null; i && (i.get || i.set) ? Object.defineProperty(n, u, i) : n[u] = e[u]; } return n.default = e, t && t.set(e, n), n; }
 /**
  * Copyright 2018 Google Inc. All rights reserved.
  * Modifications copyright (c) Microsoft Corporation.
@@ -132,13 +132,13 @@ class FFBrowser extends _browser.Browser {
 
     // Abort the navigation that turned into download.
     ffPage._page._frameManager.frameAbortedNavigation(payload.frameId, 'Download is starting');
-    let originPage = ffPage._initializedPage;
+    let originPage = ffPage._page.initializedOrUndefined();
     // If it's a new window download, report it on the opener page.
     if (!originPage) {
       // Resume the page creation with an error. The page will automatically close right
       // after the download begins.
       ffPage._markAsError(new Error('Starting new page download'));
-      if (ffPage._opener) originPage = ffPage._opener._initializedPage;
+      if (ffPage._opener) originPage = ffPage._opener._page.initializedOrUndefined();
     }
     if (!originPage) return;
     this._downloadCreated(originPage, payload.uuid, payload.url, payload.suggestedFileName);
@@ -244,6 +244,12 @@ class FFBrowserContext extends _browserContext.BrowserContext {
         forcedColors: this._options.forcedColors !== undefined ? this._options.forcedColors : 'none'
       }));
     }
+    if (this._options.contrast !== 'no-override') {
+      promises.push(this._browser.session.send('Browser.setContrast', {
+        browserContextId,
+        contrast: this._options.contrast !== undefined ? this._options.contrast : 'no-preference'
+      }));
+    }
     if (this._options.recordVideo) {
       promises.push(this._ensureVideosPath().then(() => {
         return this._browser.session.send('Browser.setVideoRecordingOptions', {
@@ -268,10 +274,10 @@ class FFBrowserContext extends _browserContext.BrowserContext {
   _ffPages() {
     return Array.from(this._browser._ffPages.values()).filter(ffPage => ffPage._browserContext === this);
   }
-  pages() {
-    return this._ffPages().map(ffPage => ffPage._initializedPage).filter(pageOrNull => !!pageOrNull);
+  possiblyUninitializedPages() {
+    return this._ffPages().map(ffPage => ffPage._page);
   }
-  async newPageDelegate() {
+  async doCreateNewPage() {
     (0, _browserContext.assertBrowserContextIsNotOwned)(this);
     const {
       targetId
@@ -281,7 +287,7 @@ class FFBrowserContext extends _browserContext.BrowserContext {
       if (e.message.includes('Failed to override timezone')) throw new Error(`Invalid timezone ID: ${this._options.timezoneId}`);
       throw e;
     });
-    return this._browser._ffPages.get(targetId);
+    return this._browser._ffPages.get(targetId)._page;
   }
   async doGetCookies(urls) {
     const {
@@ -457,4 +463,6 @@ function toJugglerProxyOptions(proxy) {
 
 // Prefs for quick fixes that didn't make it to the build.
 // Should all be moved to `playwright.cfg`.
-const kBandaidFirefoxUserPrefs = {};
+const kBandaidFirefoxUserPrefs = {
+  'dom.fetchKeepalive.enabled': false
+};

package/lib/server/firefox/ffConnection.js

@@ -5,7 +5,7 @@ Object.defineProperty(exports, "__esModule", {
 });
 exports.kBrowserCloseMessageId = exports.FFSession = exports.FFConnection = exports.ConnectionEvents = void 0;
 var _events = require("events");
-var _debugLogger = require("../../utils/debugLogger");
+var _debugLogger = require("../utils/debugLogger");
 var _helper = require("../helper");
 var _protocolError = require("../protocolError");
 /**

package/lib/server/firefox/ffExecutionContext.js

@@ -4,12 +4,15 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.FFExecutionContext = void 0;
-var js = _interopRequireWildcard(require("../javascript"));
-var _stackTrace = require("../../utils/stackTrace");
+exports.createHandle = createHandle;
+var _assert = require("../../utils/isomorphic/assert");
+var _stackTrace = require("../../utils/isomorphic/stackTrace");
 var _utilityScriptSerializers = require("../isomorphic/utilityScriptSerializers");
+var js = _interopRequireWildcard(require("../javascript"));
+var dom = _interopRequireWildcard(require("../dom"));
 var _protocolError = require("../protocolError");
 function _getRequireWildcardCache(e) { if ("function" != typeof WeakMap) return null; var r = new WeakMap(), t = new WeakMap(); return (_getRequireWildcardCache = function (e) { return e ? t : r; })(e); }
-function _interopRequireWildcard(e, r) { if (!r && e && e.__esModule) return e; if (null === e || "object" != typeof e && "function" != typeof e) return { default: e }; var t = _getRequireWildcardCache(r); if (t && t.has(e)) return t.get(e); var n = { __proto__: null }, a = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var u in e) if ("default" !== u && Object.prototype.hasOwnProperty.call(e, u)) { var i = a ? Object.getOwnPropertyDescriptor(e, u) : null; i && (i.get || i.set) ? Object.defineProperty(n, u, i) : n[u] = e[u]; } return n.default = e, t && t.set(e, n), n; }
+function _interopRequireWildcard(e, r) { if (!r && e && e.__esModule) return e; if (null === e || "object" != typeof e && "function" != typeof e) return { default: e }; var t = _getRequireWildcardCache(r); if (t && t.has(e)) return t.get(e); var n = { __proto__: null }, a = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var u in e) if ("default" !== u && {}.hasOwnProperty.call(e, u)) { var i = a ? Object.getOwnPropertyDescriptor(e, u) : null; i && (i.get || i.set) ? Object.defineProperty(n, u, i) : n[u] = e[u]; } return n.default = e, t && t.set(e, n), n; }
 /**
  * Copyright 2019 Google Inc. All rights reserved.
  * Modifications copyright (c) Microsoft Corporation.
@@ -43,28 +46,16 @@ class FFExecutionContext {
     checkException(payload.exceptionDetails);
     return payload.result.value;
   }
-  async rawEvaluateHandle(expression) {
+  async rawEvaluateHandle(context, expression) {
     const payload = await this._session.send('Runtime.evaluate', {
       expression,
       returnByValue: false,
       executionContextId: this._executionContextId
     }).catch(rewriteError);
     checkException(payload.exceptionDetails);
-    return payload.result.objectId;
-  }
-  rawCallFunctionNoReply(func, ...args) {
-    this._session.send('Runtime.callFunction', {
-      functionDeclaration: func.toString(),
-      args: args.map(a => a instanceof js.JSHandle ? {
-        objectId: a._objectId
-      } : {
-        value: a
-      }),
-      returnByValue: true,
-      executionContextId: this._executionContextId
-    }).catch(() => {});
+    return createHandle(context, payload.result);
   }
-  async evaluateWithArguments(expression, returnByValue, utilityScript, values, objectIds) {
+  async evaluateWithArguments(expression, returnByValue, utilityScript, values, handles) {
     const payload = await this._session.send('Runtime.callFunction', {
       functionDeclaration: expression,
       args: [{
@@ -72,8 +63,8 @@ class FFExecutionContext {
         value: undefined
       }, ...values.map(value => ({
         value
-      })), ...objectIds.map(objectId => ({
-        objectId,
+      })), ...handles.map(handle => ({
+        objectId: handle._objectId,
         value: undefined
       }))],
       returnByValue,
@@ -81,24 +72,22 @@ class FFExecutionContext {
     }).catch(rewriteError);
     checkException(payload.exceptionDetails);
     if (returnByValue) return (0, _utilityScriptSerializers.parseEvaluationResultValue)(payload.result.value);
-    return utilityScript._context.createHandle(payload.result);
+    return createHandle(utilityScript._context, payload.result);
   }
-  async getProperties(context, objectId) {
+  async getProperties(object) {
     const response = await this._session.send('Runtime.getObjectProperties', {
       executionContextId: this._executionContextId,
-      objectId
+      objectId: object._objectId
     });
     const result = new Map();
-    for (const property of response.properties) result.set(property.name, context.createHandle(property.value));
+    for (const property of response.properties) result.set(property.name, createHandle(object._context, property.value));
     return result;
   }
-  createHandle(context, remoteObject) {
-    return new js.JSHandle(context, remoteObject.subtype || remoteObject.type || '', renderPreview(remoteObject), remoteObject.objectId, potentiallyUnserializableValue(remoteObject));
-  }
-  async releaseHandle(objectId) {
+  async releaseHandle(handle) {
+    if (!handle._objectId) return;
     await this._session.send('Runtime.disposeObject', {
       executionContextId: this._executionContextId,
-      objectId
+      objectId: handle._objectId
     });
   }
 }
@@ -132,4 +121,11 @@ function renderPreview(object) {
   if (object.subtype === 'weakset') return 'WeakSet';
   if (object.subtype) return object.subtype[0].toUpperCase() + object.subtype.slice(1);
   if ('value' in object) return String(object.value);
+}
+function createHandle(context, remoteObject) {
+  if (remoteObject.subtype === 'node') {
+    (0, _assert.assert)(context instanceof dom.FrameExecutionContext);
+    return new dom.ElementHandle(context, remoteObject.objectId);
+  }
+  return new js.JSHandle(context, remoteObject.subtype || remoteObject.type || '', renderPreview(remoteObject), remoteObject.objectId, potentiallyUnserializableValue(remoteObject));
 }

package/lib/server/firefox/ffInput.js

@@ -47,12 +47,18 @@ class RawKeyboardImpl {
     this._client = void 0;
     this._client = client;
   }
-  async keydown(modifiers, code, keyCode, keyCodeWithoutLocation, key, location, autoRepeat, text) {
+  async keydown(modifiers, keyName, description, autoRepeat) {
+    let text = description.text;
     // Firefox will figure out Enter by itself
     if (text === '\r') text = '';
+    const {
+      code,
+      key,
+      location
+    } = description;
     await this._client.send('Page.dispatchKeyEvent', {
       type: 'keydown',
-      keyCode: keyCodeWithoutLocation,
+      keyCode: description.keyCodeWithoutLocation,
       code,
       key,
       repeat: autoRepeat,
@@ -60,11 +66,16 @@ class RawKeyboardImpl {
       text
     });
   }
-  async keyup(modifiers, code, keyCode, keyCodeWithoutLocation, key, location) {
+  async keyup(modifiers, keyName, description) {
+    const {
+      code,
+      key,
+      location
+    } = description;
     await this._client.send('Page.dispatchKeyEvent', {
       type: 'keyup',
       key,
-      keyCode: keyCodeWithoutLocation,
+      keyCode: description.keyCodeWithoutLocation,
       code,
       location,
       repeat: false

package/lib/server/firefox/ffNetworkManager.js

@@ -4,10 +4,10 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.FFNetworkManager = void 0;
-var _eventsHelper = require("../../utils/eventsHelper");
+var _eventsHelper = require("../utils/eventsHelper");
 var network = _interopRequireWildcard(require("../network"));
 function _getRequireWildcardCache(e) { if ("function" != typeof WeakMap) return null; var r = new WeakMap(), t = new WeakMap(); return (_getRequireWildcardCache = function (e) { return e ? t : r; })(e); }
-function _interopRequireWildcard(e, r) { if (!r && e && e.__esModule) return e; if (null === e || "object" != typeof e && "function" != typeof e) return { default: e }; var t = _getRequireWildcardCache(r); if (t && t.has(e)) return t.get(e); var n = { __proto__: null }, a = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var u in e) if ("default" !== u && Object.prototype.hasOwnProperty.call(e, u)) { var i = a ? Object.getOwnPropertyDescriptor(e, u) : null; i && (i.get || i.set) ? Object.defineProperty(n, u, i) : n[u] = e[u]; } return n.default = e, t && t.set(e, n), n; }
+function _interopRequireWildcard(e, r) { if (!r && e && e.__esModule) return e; if (null === e || "object" != typeof e && "function" != typeof e) return { default: e }; var t = _getRequireWildcardCache(r); if (t && t.has(e)) return t.get(e); var n = { __proto__: null }, a = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var u in e) if ("default" !== u && {}.hasOwnProperty.call(e, u)) { var i = a ? Object.getOwnPropertyDescriptor(e, u) : null; i && (i.get || i.set) ? Object.defineProperty(n, u, i) : n[u] = e[u]; } return n.default = e, t && t.set(e, n), n; }
 /**
  * Copyright 2019 Google Inc. All rights reserved.
  * Modifications copyright (c) Microsoft Corporation.
@@ -161,7 +161,7 @@ const causeToResourceType = {
   TYPE_XSLT: 'other',
   TYPE_BEACON: 'other',
   TYPE_FETCH: 'fetch',
-  TYPE_IMAGESET: 'images',
+  TYPE_IMAGESET: 'image',
   TYPE_WEB_MANIFEST: 'manifest'
 };
 const internalCauseToResourceType = {