@checkly/playwright-core 1.47.12 → 1.48.10-alpha

package/lib/server/bidi/third_party/firefoxPrefs.js

@@ -0,0 +1,221 @@
+"use strict";
+
+Object.defineProperty(exports, "__esModule", {
+  value: true
+});
+exports.createProfile = createProfile;
+var _fs = _interopRequireDefault(require("fs"));
+var _path = _interopRequireDefault(require("path"));
+function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
+/**
+ * @license
+ * Copyright 2023 Google Inc.
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+/* eslint-disable curly, indent */
+
+async function createProfile(options) {
+  if (!_fs.default.existsSync(options.path)) {
+    await _fs.default.promises.mkdir(options.path, {
+      recursive: true
+    });
+  }
+  await writePreferences({
+    preferences: {
+      ...defaultProfilePreferences(options.preferences),
+      ...options.preferences
+    },
+    path: options.path
+  });
+}
+function defaultProfilePreferences(extraPrefs) {
+  const server = 'dummy.test';
+  const defaultPrefs = {
+    // Make sure Shield doesn't hit the network.
+    'app.normandy.api_url': '',
+    // Disable Firefox old build background check
+    'app.update.checkInstallTime': false,
+    // Disable automatically upgrading Firefox
+    'app.update.disabledForTesting': true,
+    // Increase the APZ content response timeout to 1 minute
+    'apz.content_response_timeout': 60000,
+    // Prevent various error message on the console
+    // jest-puppeteer asserts that no error message is emitted by the console
+    'browser.contentblocking.features.standard': '-tp,tpPrivate,cookieBehavior0,-cm,-fp',
+    // Enable the dump function: which sends messages to the system
+    // console
+    // https://bugzilla.mozilla.org/show_bug.cgi?id=1543115
+    'browser.dom.window.dump.enabled': true,
+    // Disable topstories
+    'browser.newtabpage.activity-stream.feeds.system.topstories': false,
+    // Always display a blank page
+    'browser.newtabpage.enabled': false,
+    // Background thumbnails in particular cause grief: and disabling
+    // thumbnails in general cannot hurt
+    'browser.pagethumbnails.capturing_disabled': true,
+    // Disable safebrowsing components.
+    'browser.safebrowsing.blockedURIs.enabled': false,
+    'browser.safebrowsing.downloads.enabled': false,
+    'browser.safebrowsing.malware.enabled': false,
+    'browser.safebrowsing.phishing.enabled': false,
+    // Disable updates to search engines.
+    'browser.search.update': false,
+    // Do not restore the last open set of tabs if the browser has crashed
+    'browser.sessionstore.resume_from_crash': false,
+    // Skip check for default browser on startup
+    'browser.shell.checkDefaultBrowser': false,
+    // Disable newtabpage
+    'browser.startup.homepage': 'about:blank',
+    // Do not redirect user when a milstone upgrade of Firefox is detected
+    'browser.startup.homepage_override.mstone': 'ignore',
+    // Start with a blank page about:blank
+    'browser.startup.page': 0,
+    // Do not allow background tabs to be zombified on Android: otherwise for
+    // tests that open additional tabs: the test harness tab itself might get
+    // unloaded
+    'browser.tabs.disableBackgroundZombification': false,
+    // Do not warn when closing all other open tabs
+    'browser.tabs.warnOnCloseOtherTabs': false,
+    // Do not warn when multiple tabs will be opened
+    'browser.tabs.warnOnOpen': false,
+    // Do not automatically offer translations, as tests do not expect this.
+    'browser.translations.automaticallyPopup': false,
+    // Disable the UI tour.
+    'browser.uitour.enabled': false,
+    // Turn off search suggestions in the location bar so as not to trigger
+    // network connections.
+    'browser.urlbar.suggest.searches': false,
+    // Disable first run splash page on Windows 10
+    'browser.usedOnWindows10.introURL': '',
+    // Do not warn on quitting Firefox
+    'browser.warnOnQuit': false,
+    // Defensively disable data reporting systems
+    'datareporting.healthreport.documentServerURI': `http://${server}/dummy/healthreport/`,
+    'datareporting.healthreport.logging.consoleEnabled': false,
+    'datareporting.healthreport.service.enabled': false,
+    'datareporting.healthreport.service.firstRun': false,
+    'datareporting.healthreport.uploadEnabled': false,
+    // Do not show datareporting policy notifications which can interfere with tests
+    'datareporting.policy.dataSubmissionEnabled': false,
+    'datareporting.policy.dataSubmissionPolicyBypassNotification': true,
+    // DevTools JSONViewer sometimes fails to load dependencies with its require.js.
+    // This doesn't affect Puppeteer but spams console (Bug 1424372)
+    'devtools.jsonview.enabled': false,
+    // Disable popup-blocker
+    'dom.disable_open_during_load': false,
+    // Enable the support for File object creation in the content process
+    // Required for |Page.setFileInputFiles| protocol method.
+    'dom.file.createInChild': true,
+    // Disable the ProcessHangMonitor
+    'dom.ipc.reportProcessHangs': false,
+    // Disable slow script dialogues
+    'dom.max_chrome_script_run_time': 0,
+    'dom.max_script_run_time': 0,
+    // Only load extensions from the application and user profile
+    // AddonManager.SCOPE_PROFILE + AddonManager.SCOPE_APPLICATION
+    'extensions.autoDisableScopes': 0,
+    'extensions.enabledScopes': 5,
+    // Disable metadata caching for installed add-ons by default
+    'extensions.getAddons.cache.enabled': false,
+    // Disable installing any distribution extensions or add-ons.
+    'extensions.installDistroAddons': false,
+    // Disabled screenshots extension
+    'extensions.screenshots.disabled': true,
+    // Turn off extension updates so they do not bother tests
+    'extensions.update.enabled': false,
+    // Turn off extension updates so they do not bother tests
+    'extensions.update.notifyUser': false,
+    // Make sure opening about:addons will not hit the network
+    'extensions.webservice.discoverURL': `http://${server}/dummy/discoveryURL`,
+    // Allow the application to have focus even it runs in the background
+    'focusmanager.testmode': true,
+    // Disable useragent updates
+    'general.useragent.updates.enabled': false,
+    // Always use network provider for geolocation tests so we bypass the
+    // macOS dialog raised by the corelocation provider
+    'geo.provider.testing': true,
+    // Do not scan Wifi
+    'geo.wifi.scan': false,
+    // No hang monitor
+    'hangmonitor.timeout': 0,
+    // Show chrome errors and warnings in the error console
+    'javascript.options.showInConsole': true,
+    // Disable download and usage of OpenH264: and Widevine plugins
+    'media.gmp-manager.updateEnabled': false,
+    // Disable the GFX sanity window
+    'media.sanity-test.disabled': true,
+    // Disable experimental feature that is only available in Nightly
+    'network.cookie.sameSite.laxByDefault': false,
+    // Do not prompt for temporary redirects
+    'network.http.prompt-temp-redirect': false,
+    // Disable speculative connections so they are not reported as leaking
+    // when they are hanging around
+    'network.http.speculative-parallel-limit': 0,
+    // Do not automatically switch between offline and online
+    'network.manage-offline-status': false,
+    // Make sure SNTP requests do not hit the network
+    'network.sntp.pools': server,
+    // Disable Flash.
+    'plugin.state.flash': 0,
+    'privacy.trackingprotection.enabled': false,
+    // Can be removed once Firefox 89 is no longer supported
+    // https://bugzilla.mozilla.org/show_bug.cgi?id=1710839
+    'remote.enabled': true,
+    // Don't do network connections for mitm priming
+    'security.certerrors.mitm.priming.enabled': false,
+    // Local documents have access to all other local documents,
+    // including directory listings
+    'security.fileuri.strict_origin_policy': false,
+    // Do not wait for the notification button security delay
+    'security.notification_enable_delay': 0,
+    // Ensure blocklist updates do not hit the network
+    'services.settings.server': `http://${server}/dummy/blocklist/`,
+    // Do not automatically fill sign-in forms with known usernames and
+    // passwords
+    'signon.autofillForms': false,
+    // Disable password capture, so that tests that include forms are not
+    // influenced by the presence of the persistent doorhanger notification
+    'signon.rememberSignons': false,
+    // Disable first-run welcome page
+    'startup.homepage_welcome_url': 'about:blank',
+    // Disable first-run welcome page
+    'startup.homepage_welcome_url.additional': '',
+    // Disable browser animations (tabs, fullscreen, sliding alerts)
+    'toolkit.cosmeticAnimations.enabled': false,
+    // Prevent starting into safe mode after application crashes
+    'toolkit.startup.max_resumed_crashes': -1
+  };
+  return Object.assign(defaultPrefs, extraPrefs);
+}
+
+/**
+ * Populates the user.js file with custom preferences as needed to allow
+ * Firefox's CDP support to properly function. These preferences will be
+ * automatically copied over to prefs.js during startup of Firefox. To be
+ * able to restore the original values of preferences a backup of prefs.js
+ * will be created.
+ *
+ * @param prefs - List of preferences to add.
+ * @param profilePath - Firefox profile to write the preferences to.
+ */
+async function writePreferences(options) {
+  const prefsPath = _path.default.join(options.path, 'prefs.js');
+  const lines = Object.entries(options.preferences).map(([key, value]) => {
+    return `user_pref(${JSON.stringify(key)}, ${JSON.stringify(value)});`;
+  });
+
+  // Use allSettled to prevent corruption
+  const result = await Promise.allSettled([_fs.default.promises.writeFile(_path.default.join(options.path, 'user.js'), lines.join('\n')),
+  // Create a backup of the preferences file if it already exitsts.
+  _fs.default.promises.access(prefsPath, _fs.default.constants.F_OK).then(async () => {
+    await _fs.default.promises.copyFile(prefsPath, _path.default.join(options.path, 'prefs.js.playwright'));
+  },
+  // Swallow only if file does not exist
+  () => {})]);
+  for (const command of result) {
+    if (command.status === 'rejected') {
+      throw command.reason;
+    }
+  }
+}

package/lib/server/browser.js

@@ -9,6 +9,7 @@ var _page = require("./page");
 var _download = require("./download");
 var _instrumentation = require("./instrumentation");
 var _artifact = require("./artifact");
+var _socksClientCertificatesInterceptor = require("./socksClientCertificatesInterceptor");
 /**
  * Copyright (c) Microsoft Corporation.
  *
@@ -41,13 +42,23 @@ class Browser extends _instrumentation.SdkObject {
     this.instrumentation.onBrowserOpen(this);
   }
   async newContext(metadata, options) {
+    var _options$clientCertif;
     (0, _browserContext.validateBrowserContextOptions)(options, this.options);
-    const clientCertificatesProxy = await (0, _browserContext.createClientCertificatesProxyIfNeeded)(options, this.options);
+    let clientCertificatesProxy;
+    if ((_options$clientCertif = options.clientCertificates) !== null && _options$clientCertif !== void 0 && _options$clientCertif.length) {
+      clientCertificatesProxy = new _socksClientCertificatesInterceptor.ClientCertificatesProxy(options);
+      options = {
+        ...options
+      };
+      options.proxyOverride = await clientCertificatesProxy.listen();
+      options.internalIgnoreHTTPSErrors = true;
+    }
     let context;
     try {
       context = await this.doCreateNewContext(options);
     } catch (error) {
-      await (clientCertificatesProxy === null || clientCertificatesProxy === void 0 ? void 0 : clientCertificatesProxy.close());
+      var _clientCertificatesPr;
+      await ((_clientCertificatesPr = clientCertificatesProxy) === null || _clientCertificatesPr === void 0 ? void 0 : _clientCertificatesPr.close());
       throw error;
     }
     context._clientCertificatesProxy = clientCertificatesProxy;

package/lib/server/browserContext.js

@@ -5,7 +5,6 @@ Object.defineProperty(exports, "__esModule", {
 });
 exports.BrowserContext = void 0;
 exports.assertBrowserContextIsNotOwned = assertBrowserContextIsNotOwned;
-exports.createClientCertificatesProxyIfNeeded = createClientCertificatesProxyIfNeeded;
 exports.normalizeProxySettings = normalizeProxySettings;
 exports.validateBrowserContextOptions = validateBrowserContextOptions;
 exports.verifyClientCertificates = verifyClientCertificates;
@@ -26,7 +25,6 @@ var _recorder = require("./recorder");
 var consoleApiSource = _interopRequireWildcard(require("../generated/consoleApiSource"));
 var _fetch = require("./fetch");
 var _clock = require("./clock");
-var _socksClientCertificatesInterceptor = require("./socksClientCertificatesInterceptor");
 var _recorderApp = require("./recorder/recorderApp");
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
 function _getRequireWildcardCache(e) { if ("function" != typeof WeakMap) return null; var r = new WeakMap(), t = new WeakMap(); return (_getRequireWildcardCache = function (e) { return e ? t : r; })(e); }
@@ -104,14 +102,14 @@ class BrowserContext extends _instrumentation.SdkObject {
     this._debugger = new _debugger.Debugger(this);
 
     // When PWDEBUG=1, show inspector for each context.
-    if ((0, _utils.debugMode)() === 'inspector') await _recorder.Recorder.show(this, _recorderApp.RecorderApp.factory(this), {
+    if ((0, _utils.debugMode)() === 'inspector') await _recorder.Recorder.show('actions', this, _recorderApp.RecorderApp.factory(this), {
       pauseOnNextStatement: true
     });
 
     // When paused, show inspector.
-    if (this._debugger.isPaused()) _recorder.Recorder.showInspector(this, _recorderApp.RecorderApp.factory(this));
+    if (this._debugger.isPaused()) _recorder.Recorder.showInspectorNoReply(this, _recorderApp.RecorderApp.factory(this));
     this._debugger.on(_debugger.Debugger.Events.PausedStateChanged, () => {
-      if (this._debugger.isPaused()) _recorder.Recorder.showInspector(this, _recorderApp.RecorderApp.factory(this));
+      if (this._debugger.isPaused()) _recorder.Recorder.showInspectorNoReply(this, _recorderApp.RecorderApp.factory(this));
     });
     if ((0, _utils.debugMode)() === 'console') await this.extendInjectedScript(consoleApiSource.source);
     if (this._options.serviceWorkers === 'block') await this.addInitScript(`\nif (navigator.serviceWorker) navigator.serviceWorker.register = async () => { console.warn('Service Worker registration blocked by Playwright'); };\n`);
@@ -425,8 +423,7 @@ class BrowserContext extends _instrumentation.SdkObject {
       const page = await this.newPage(internalMetadata);
       await page._setServerRequestInterceptor(handler => {
         handler.fulfill({
-          body: '<html></html>',
-          requestUrl: handler.request().url()
+          body: '<html></html>'
         }).catch(() => {});
         return true;
       });
@@ -464,8 +461,7 @@ class BrowserContext extends _instrumentation.SdkObject {
     }));
     await page._setServerRequestInterceptor(handler => {
       handler.fulfill({
-        body: '<html></html>',
-        requestUrl: handler.request().url()
+        body: '<html></html>'
       }).catch(() => {});
       return true;
     });
@@ -495,8 +491,7 @@ class BrowserContext extends _instrumentation.SdkObject {
         const page = await this.newPage(internalMetadata);
         await page._setServerRequestInterceptor(handler => {
           handler.fulfill({
-            body: '<html></html>',
-            requestUrl: handler.request().url()
+            body: '<html></html>'
           }).catch(() => {});
           return true;
         });
@@ -574,18 +569,6 @@ function assertBrowserContextIsNotOwned(context) {
     if (page._ownedContext) throw new Error('Please use browser.newContext() for multi-page scripts that share the context.');
   }
 }
-async function createClientCertificatesProxyIfNeeded(options, browserOptions) {
-  var _options$clientCertif, _options$proxy, _options$proxy2, _browserOptions$proxy, _browserOptions$proxy2;
-  if (!((_options$clientCertif = options.clientCertificates) !== null && _options$clientCertif !== void 0 && _options$clientCertif.length)) return;
-  if ((_options$proxy = options.proxy) !== null && _options$proxy !== void 0 && _options$proxy.server && ((_options$proxy2 = options.proxy) === null || _options$proxy2 === void 0 ? void 0 : _options$proxy2.server) !== 'per-context' || browserOptions !== null && browserOptions !== void 0 && (_browserOptions$proxy = browserOptions.proxy) !== null && _browserOptions$proxy !== void 0 && _browserOptions$proxy.server && (browserOptions === null || browserOptions === void 0 || (_browserOptions$proxy2 = browserOptions.proxy) === null || _browserOptions$proxy2 === void 0 ? void 0 : _browserOptions$proxy2.server) !== 'http://per-context') throw new Error('Cannot specify both proxy and clientCertificates');
-  verifyClientCertificates(options.clientCertificates);
-  const clientCertificatesProxy = new _socksClientCertificatesInterceptor.ClientCertificatesProxy(options);
-  options.proxy = {
-    server: await clientCertificatesProxy.listen()
-  };
-  options.ignoreHTTPSErrors = true;
-  return clientCertificatesProxy;
-}
 function validateBrowserContextOptions(options, browserOptions) {
   if (options.noDefaultViewport && options.deviceScaleFactor !== undefined) throw new Error(`"deviceScaleFactor" option is not supported with null "viewport"`);
   if (options.noDefaultViewport && !!options.isMobile) throw new Error(`"isMobile" option is not supported with null "viewport"`);

package/lib/server/browserType.js

@@ -3,7 +3,7 @@
 Object.defineProperty(exports, "__esModule", {
   value: true
 });
-exports.kNoXServerRunningError = exports.BrowserType = void 0;
+exports.kNoXServerRunningError = exports.BrowserType = exports.BrowserReadyState = void 0;
 var _fs = _interopRequireDefault(require("fs"));
 var os = _interopRequireWildcard(require("os"));
 var _path = _interopRequireDefault(require("path"));
@@ -20,6 +20,7 @@ var _helper = require("./helper");
 var _debugLogger = require("../utils/debugLogger");
 var _instrumentation = require("./instrumentation");
 var _protocolError = require("./protocolError");
+var _socksClientCertificatesInterceptor = require("./socksClientCertificatesInterceptor");
 function _getRequireWildcardCache(e) { if ("function" != typeof WeakMap) return null; var r = new WeakMap(), t = new WeakMap(); return (_getRequireWildcardCache = function (e) { return e ? t : r; })(e); }
 function _interopRequireWildcard(e, r) { if (!r && e && e.__esModule) return e; if (null === e || "object" != typeof e && "function" != typeof e) return { default: e }; var t = _getRequireWildcardCache(r); if (t && t.has(e)) return t.get(e); var n = { __proto__: null }, a = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var u in e) if ("default" !== u && Object.prototype.hasOwnProperty.call(e, u)) { var i = a ? Object.getOwnPropertyDescriptor(e, u) : null; i && (i.get || i.set) ? Object.defineProperty(n, u, i) : n[u] = e[u]; } return n.default = e, t && t.set(e, n), n; }
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
@@ -40,6 +41,22 @@ function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { de
  */
 
 const kNoXServerRunningError = exports.kNoXServerRunningError = 'Looks like you launched a headed browser without having a XServer running.\n' + 'Set either \'headless: true\' or use \'xvfb-run <your-playwright-app>\' before running Playwright.\n\n<3 Playwright Team';
+class BrowserReadyState {
+  constructor() {
+    this._wsEndpoint = new _utils.ManualPromise();
+  }
+  onBrowserExit() {
+    // Unblock launch when browser prematurely exits.
+    this._wsEndpoint.resolve(undefined);
+  }
+  async waitUntilReady() {
+    const wsEndpoint = await this._wsEndpoint;
+    return {
+      wsEndpoint
+    };
+  }
+}
+exports.BrowserReadyState = BrowserReadyState;
 class BrowserType extends _instrumentation.SdkObject {
   constructor(parent, browserName) {
     super(parent, 'browser-type');
@@ -69,24 +86,33 @@ class BrowserType extends _instrumentation.SdkObject {
     return browser;
   }
   async launchPersistentContext(metadata, userDataDir, options) {
-    options = this._validateLaunchOptions(options);
-    if (this._useBidi) options.useWebSocket = true;
+    const launchOptions = this._validateLaunchOptions(options);
+    if (this._useBidi) launchOptions.useWebSocket = true;
     const controller = new _progress.ProgressController(metadata, this);
-    const persistent = {
-      ...options
-    };
     controller.setLogName('browser');
     const browser = await controller.run(async progress => {
+      var _options$clientCertif;
       // Note: Any initial TLS requests will fail since we rely on the Page/Frames initialize which sets ignoreHTTPSErrors.
-      const clientCertificatesProxy = await (0, _browserContext.createClientCertificatesProxyIfNeeded)(persistent);
-      if (clientCertificatesProxy) options.proxy = persistent.proxy;
-      progress.cleanupWhenAborted(() => clientCertificatesProxy === null || clientCertificatesProxy === void 0 ? void 0 : clientCertificatesProxy.close());
-      const browser = await this._innerLaunchWithRetries(progress, options, persistent, _helper.helper.debugProtocolLogger(), userDataDir).catch(e => {
+      let clientCertificatesProxy;
+      if ((_options$clientCertif = options.clientCertificates) !== null && _options$clientCertif !== void 0 && _options$clientCertif.length) {
+        var _clientCertificatesPr;
+        clientCertificatesProxy = new _socksClientCertificatesInterceptor.ClientCertificatesProxy(options);
+        launchOptions.proxyOverride = await ((_clientCertificatesPr = clientCertificatesProxy) === null || _clientCertificatesPr === void 0 ? void 0 : _clientCertificatesPr.listen());
+        options = {
+          ...options
+        };
+        options.internalIgnoreHTTPSErrors = true;
+      }
+      progress.cleanupWhenAborted(() => {
+        var _clientCertificatesPr2;
+        return (_clientCertificatesPr2 = clientCertificatesProxy) === null || _clientCertificatesPr2 === void 0 ? void 0 : _clientCertificatesPr2.close();
+      });
+      const browser = await this._innerLaunchWithRetries(progress, launchOptions, options, _helper.helper.debugProtocolLogger(), userDataDir).catch(e => {
         throw this._rewriteStartupLog(e);
       });
       browser._defaultContext._clientCertificatesProxy = clientCertificatesProxy;
       return browser;
-    }, _timeoutSettings.TimeoutSettings.launchTimeout(options));
+    }, _timeoutSettings.TimeoutSettings.launchTimeout(launchOptions));
     return browser._defaultContext;
   }
   async _innerLaunchWithRetries(progress, options, persistent, protocolLogger, userDataDir) {
@@ -164,6 +190,7 @@ class BrowserType extends _instrumentation.SdkObject {
       userDataDir = await _fs.default.promises.mkdtemp(_path.default.join(os.tmpdir(), `playwright_${this._name}dev_profile-`));
       tempDirectories.push(userDataDir);
     }
+    await this.prepareUserDataDir(options, userDataDir);
     const browserArguments = [];
     if (ignoreAllDefaultArgs) browserArguments.push(...args);else if (ignoreDefaultArgs) browserArguments.push(...this.defaultArgs(options, isPersistent, userDataDir).filter(arg => ignoreDefaultArgs.indexOf(arg) === -1));else browserArguments.push(...this.defaultArgs(options, isPersistent, userDataDir));
     let executable;
@@ -298,6 +325,7 @@ class BrowserType extends _instrumentation.SdkObject {
   readyState(options) {
     return undefined;
   }
+  async prepareUserDataDir(options, userDataDir) {}
 }
 exports.BrowserType = BrowserType;
 function copyTestHooks(from, to) {

package/lib/server/chromium/chromium.js

@@ -256,8 +256,7 @@ class Chromium extends _browserType.BrowserType {
   }
   _innerDefaultArgs(options) {
     const {
-      args = [],
-      proxy
+      args = []
     } = options;
     const userDataDirArg = args.find(arg => arg.startsWith('--user-data-dir'));
     if (userDataDirArg) throw this._createUserDataDirArgMisuseError('--user-data-dir');
@@ -276,6 +275,7 @@ class Chromium extends _browserType.BrowserType {
       chromeArguments.push('--hide-scrollbars', '--mute-audio', '--blink-settings=primaryHoverType=2,availableHoverTypes=2,primaryPointerType=4,availablePointerTypes=4');
     }
     if (options.chromiumSandbox !== true) chromeArguments.push('--no-sandbox');
+    const proxy = options.proxyOverride || options.proxy;
     if (proxy) {
       const proxyURL = new URL(proxy.server);
       const isSocks = proxyURL.protocol === 'socks5:';
@@ -302,23 +302,11 @@ class Chromium extends _browserType.BrowserType {
   }
 }
 exports.Chromium = Chromium;
-class ChromiumReadyState {
-  constructor() {
-    this._wsEndpoint = new _manualPromise.ManualPromise();
-  }
+class ChromiumReadyState extends _browserType.BrowserReadyState {
   onBrowserOutput(message) {
     const match = message.match(/DevTools listening on (.*)/);
     if (match) this._wsEndpoint.resolve(match[1]);
   }
-  onBrowserExit() {
-    this._wsEndpoint.resolve(undefined);
-  }
-  async waitUntilReady() {
-    const wsEndpoint = await this._wsEndpoint;
-    return {
-      wsEndpoint
-    };
-  }
 }
 async function urlToWSEndpoint(progress, endpointURL, headers) {
   if (endpointURL.startsWith('ws')) return endpointURL;

package/lib/server/chromium/chromiumSwitches.js

@@ -34,8 +34,10 @@ const chromiumSwitches = exports.chromiumSwitches = ['--disable-field-trial-conf
 // Translate - https://github.com/microsoft/playwright/issues/16126
 // HttpsUpgrades - https://github.com/microsoft/playwright/pull/27605
 // PaintHolding - https://github.com/microsoft/playwright/issues/28023
+// ThirdPartyStoragePartitioning - https://github.com/microsoft/playwright/issues/32230
+// LensOverlay - Hides the Lens feature in the URL address bar. Its not working in unofficial builds.
 // PlzDedicatedWorker - https://github.com/microsoft/playwright/issues/31747
-'--disable-features=ImprovedCookieControls,LazyFrameLoading,GlobalMediaControls,DestroyProfileOnBrowserClose,MediaRouter,DialMediaRouteProvider,AcceptCHFrame,AutoExpandDetailsElement,CertificateTransparencyComponentUpdater,AvoidUnnecessaryBeforeUnloadCheckSync,Translate,HttpsUpgrades,PaintHolding,PlzDedicatedWorker', '--allow-pre-commit-input', '--disable-hang-monitor', '--disable-ipc-flooding-protection', '--disable-popup-blocking', '--disable-prompt-on-repost', '--disable-renderer-backgrounding', '--force-color-profile=srgb', '--metrics-recording-only', '--no-first-run', '--enable-automation', '--password-store=basic', '--use-mock-keychain',
+'--disable-features=ImprovedCookieControls,LazyFrameLoading,GlobalMediaControls,DestroyProfileOnBrowserClose,MediaRouter,DialMediaRouteProvider,AcceptCHFrame,AutoExpandDetailsElement,CertificateTransparencyComponentUpdater,AvoidUnnecessaryBeforeUnloadCheckSync,Translate,HttpsUpgrades,PaintHolding,ThirdPartyStoragePartitioning,LensOverlay,PlzDedicatedWorker', '--allow-pre-commit-input', '--disable-hang-monitor', '--disable-ipc-flooding-protection', '--disable-popup-blocking', '--disable-prompt-on-repost', '--disable-renderer-backgrounding', '--force-color-profile=srgb', '--metrics-recording-only', '--no-first-run', '--enable-automation', '--password-store=basic', '--use-mock-keychain',
 // See https://chromium-review.googlesource.com/c/chromium/src/+/2436773
 '--no-service-autorun', '--export-tagged-pdf',
 // https://chromium-review.googlesource.com/c/chromium/src/+/4853540

package/lib/server/chromium/crBrowser.js

@@ -99,15 +99,16 @@ class CRBrowser extends _browser.Browser {
     this._session.on('Browser.downloadProgress', this._onDownloadProgress.bind(this));
   }
   async doCreateNewContext(options) {
+    const proxy = options.proxyOverride || options.proxy;
     let proxyBypassList = undefined;
-    if (options.proxy) {
-      if (process.env.PLAYWRIGHT_DISABLE_FORCED_CHROMIUM_PROXIED_LOOPBACK) proxyBypassList = options.proxy.bypass;else proxyBypassList = '<-loopback>' + (options.proxy.bypass ? `,${options.proxy.bypass}` : '');
+    if (proxy) {
+      if (process.env.PLAYWRIGHT_DISABLE_FORCED_CHROMIUM_PROXIED_LOOPBACK) proxyBypassList = proxy.bypass;else proxyBypassList = '<-loopback>' + (proxy.bypass ? `,${proxy.bypass}` : '');
     }
     const {
       browserContextId
     } = await this._session.send('Target.createBrowserContext', {
       disposeOnDetach: true,
-      proxyServer: options.proxy ? options.proxy.server : undefined,
+      proxyServer: proxy ? proxy.server : undefined,
       proxyBypassList
     });
     const context = new CRBrowserContext(this, browserContextId, options);

package/lib/server/chromium/crExecutionContext.js

@@ -110,13 +110,6 @@ class CRExecutionContext {
   async releaseHandle(objectId) {
     await (0, _crProtocolHelper.releaseObject)(this._client, objectId);
   }
-  async objectCount(objectId) {
-    const result = await this._client.send('Runtime.queryObjects', {
-      prototypeObjectId: objectId
-    });
-    const match = result.objects.description.match(/Array\((\d+)\)/);
-    return +match[1];
-  }
 }
 exports.CRExecutionContext = CRExecutionContext;
 function rewriteError(error) {

package/lib/server/chromium/crPage.js

@@ -214,6 +214,9 @@ class CRPage {
   goForward() {
     return this._go(+1);
   }
+  async requestGC() {
+    await this._mainFrameSession._client.send('HeapProfiler.collectGarbage');
+  }
   async addInitScript(initScript, world = 'main') {
     await this._forAllFrameSessions(frame => frame._evaluateOnNewDocument(initScript, world));
   }
@@ -463,7 +466,7 @@ class FrameSession {
       if (options.bypassCSP) promises.push(this._client.send('Page.setBypassCSP', {
         enabled: true
       }));
-      if (options.ignoreHTTPSErrors) promises.push(this._client.send('Security.setIgnoreCertificateErrors', {
+      if (options.ignoreHTTPSErrors || options.internalIgnoreHTTPSErrors) promises.push(this._client.send('Security.setIgnoreCertificateErrors', {
         ignore: true
       }));
       if (this._isMainFrame()) promises.push(this._updateViewport());
@@ -770,7 +773,7 @@ class FrameSession {
     const buffer = Buffer.from(payload.data, 'base64');
     this._page.emit(_page.Page.Events.ScreencastFrame, {
       buffer,
-      timestamp: payload.metadata.timestamp,
+      frameSwapWallTime: payload.metadata.timestamp ? payload.metadata.timestamp * 1000 : undefined,
       width: payload.metadata.deviceWidth,
       height: payload.metadata.deviceHeight
     });

package/lib/server/chromium/videoRecorder.js

@@ -50,7 +50,7 @@ class VideoRecorder {
     this._ffmpegPath = void 0;
     this._progress = progress;
     this._ffmpegPath = ffmpegPath;
-    page.on(_page.Page.Events.ScreencastFrame, frame => this.writeFrame(frame.buffer, frame.timestamp));
+    page.on(_page.Page.Events.ScreencastFrame, frame => this.writeFrame(frame.buffer, frame.frameSwapWallTime / 1000));
   }
   async _launch(options) {
     // How to tune the codec:

package/lib/server/codegen/csharp.js

@@ -60,7 +60,7 @@ class CSharpLanguageGenerator {
       if (action.url && action.url !== 'about:blank' && action.url !== 'chrome://newtab/') formatter.add(`await ${pageAlias}.GotoAsync(${quote(action.url)});`);
       return formatter.format();
     }
-    const locators = actionInContext.frame.framePath.map(selector => `.${this._asLocator(selector)}.ContentFrame()`);
+    const locators = actionInContext.frame.framePath.map(selector => `.${this._asLocator(selector)}.ContentFrame`);
     const subject = `${pageAlias}${locators.join('')}`;
     const signals = (0, _language.toSignalMap)(action);
     if (signals.dialog) {
@@ -96,7 +96,7 @@ class CSharpLanguageGenerator {
         {
           let method = 'Click';
           if (action.clickCount === 2) method = 'DblClick';
-          const options = (0, _language.toClickOptions)(action);
+          const options = (0, _language.toClickOptionsForSourceCode)(action);
           if (!Object.entries(options).length) return `await ${subject}.${this._asLocator(action.selector)}.${method}Async();`;
           const optionsString = formatObject(options, '    ', 'Locator' + method + 'Options');
           return `await ${subject}.${this._asLocator(action.selector)}.${method}Async(${optionsString});`;

package/lib/server/codegen/java.js

@@ -87,7 +87,7 @@ class JavaLanguageGenerator {
         {
           let method = 'click';
           if (action.clickCount === 2) method = 'dblclick';
-          const options = (0, _language.toClickOptions)(action);
+          const options = (0, _language.toClickOptionsForSourceCode)(action);
           const optionsText = formatClickOptions(options);
           return `${subject}.${this._asLocator(action.selector, inFrameLocator)}.${method}(${optionsText});`;
         }

package/lib/server/codegen/javascript.js

@@ -71,7 +71,7 @@ class JavaScriptLanguageGenerator {
         {
           let method = 'click';
           if (action.clickCount === 2) method = 'dblclick';
-          const options = (0, _language.toClickOptions)(action);
+          const options = (0, _language.toClickOptionsForSourceCode)(action);
           const optionsString = formatOptions(options, false);
           return `await ${subject}.${this._asLocator(action.selector)}.${method}(${optionsString});`;
         }

package/lib/server/codegen/language.js

@@ -3,9 +3,10 @@
 Object.defineProperty(exports, "__esModule", {
   value: true
 });
+exports.fromKeyboardModifiers = fromKeyboardModifiers;
 exports.generateCode = generateCode;
 exports.sanitizeDeviceOptions = sanitizeDeviceOptions;
-exports.toClickOptions = toClickOptions;
+exports.toClickOptionsForSourceCode = toClickOptionsForSourceCode;
 exports.toKeyboardModifiers = toKeyboardModifiers;
 exports.toSignalMap = toSignalMap;
 /**
@@ -65,11 +66,22 @@ function toKeyboardModifiers(modifiers) {
   if (modifiers & 8) result.push('Shift');
   return result;
 }
-function toClickOptions(action) {
+function fromKeyboardModifiers(modifiers) {
+  let result = 0;
+  if (!modifiers) return result;
+  if (modifiers.includes('Alt')) result |= 1;
+  if (modifiers.includes('Control')) result |= 2;
+  if (modifiers.includes('ControlOrMeta')) result |= 2;
+  if (modifiers.includes('Meta')) result |= 4;
+  if (modifiers.includes('Shift')) result |= 8;
+  return result;
+}
+function toClickOptionsForSourceCode(action) {
   const modifiers = toKeyboardModifiers(action.modifiers);
   const options = {};
   if (action.button !== 'left') options.button = action.button;
   if (modifiers.length) options.modifiers = modifiers;
+  // Do not render clickCount === 2 for dblclick.
   if (action.clickCount > 2) options.clickCount = action.clickCount;
   if (action.position) options.position = action.position;
   return options;