@checkdigit/eslint-plugin 7.6.0-PR.75-c175 → 7.6.0-PR.75-8118
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/dist-mjs/agent/fetch-response-body-json.mjs +3 -3
- package/dist-mjs/agent/fetch-response-status.mjs +12 -2
- package/dist-mjs/agent/fetch.mjs +6 -1
- package/dist-mjs/agent/no-status-code.mjs +3 -3
- package/dist-types/agent/fetch.d.ts +2 -0
- package/package.json +1 -1
- package/src/agent/fetch-response-body-json.ts +2 -5
- package/src/agent/fetch-response-status.ts +16 -3
- package/src/agent/fetch.ts +8 -0
- package/src/agent/no-status-code.ts +2 -5
|
@@ -3,6 +3,7 @@ import { strict as assert } from "node:assert";
|
|
|
3
3
|
import { AST_NODE_TYPES, ESLintUtils } from "@typescript-eslint/utils";
|
|
4
4
|
import getDocumentationUrl from "../get-documentation-url.mjs";
|
|
5
5
|
import { getAncestor } from "../library/ts-tree.mjs";
|
|
6
|
+
import { isFetchResponse } from "./fetch.mjs";
|
|
6
7
|
var ruleId = "fetch-response-body-json";
|
|
7
8
|
var createRule = ESLintUtils.RuleCreator((name) => getDocumentationUrl(name));
|
|
8
9
|
var rule = createRule({
|
|
@@ -30,8 +31,7 @@ var rule = createRule({
|
|
|
30
31
|
try {
|
|
31
32
|
const responseNode = parserServices.esTreeNodeToTSNodeMap.get(responseBodyNode.object);
|
|
32
33
|
const responseType = typeChecker.getTypeAtLocation(responseNode);
|
|
33
|
-
|
|
34
|
-
if (shouldReplace) {
|
|
34
|
+
if (isFetchResponse(responseType)) {
|
|
35
35
|
if (responseBodyNode.object.type !== AST_NODE_TYPES.Identifier) {
|
|
36
36
|
context.report({
|
|
37
37
|
node: responseBodyNode,
|
|
@@ -143,4 +143,4 @@ export {
|
|
|
143
143
|
fetch_response_body_json_default as default,
|
|
144
144
|
ruleId
|
|
145
145
|
};
|
|
146
|
-
//# sourceMappingURL=data:application/json;base64,
|
|
146
|
+
//# sourceMappingURL=data:application/json;base64,ewogICJ2ZXJzaW9uIjogMywKICAic291cmNlcyI6IFsiLi4vLi4vc3JjL2FnZW50L2ZldGNoLXJlc3BvbnNlLWJvZHktanNvbi50cyJdLAogICJtYXBwaW5ncyI6ICI7QUFRQSxTQUFTLFVBQVUsY0FBYztBQUVqQyxTQUFTLGdCQUFnQixtQkFBNkI7QUFFdEQsT0FBTyx5QkFBeUI7QUFDaEMsU0FBUyxtQkFBbUI7QUFDNUIsU0FBUyx1QkFBdUI7QUFFekIsSUFBTSxTQUFTO0FBRXRCLElBQU0sYUFBYSxZQUFZLFlBQVksQ0FBQyxTQUFTLG9CQUFvQixJQUFJLENBQUM7QUFhOUUsSUFBTSxPQUEwRixXQUFXO0FBQUEsRUFDekcsTUFBTTtBQUFBLEVBQ04sTUFBTTtBQUFBLElBQ0osTUFBTTtBQUFBLElBQ04sTUFBTTtBQUFBLE1BQ0osYUFBYTtBQUFBLElBQ2Y7QUFBQSxJQUNBLFVBQVU7QUFBQSxNQUNSLGdCQUNFO0FBQUEsTUFDRixxQkFBcUI7QUFBQSxNQUNyQixjQUFjO0FBQUEsSUFDaEI7QUFBQSxJQUNBLFNBQVM7QUFBQSxJQUNULFFBQVEsQ0FBQztBQUFBLEVBQ1g7QUFBQSxFQUNBLGdCQUFnQixDQUFDO0FBQUEsRUFDakIsT0FBTyxTQUFTO0FBQ2QsVUFBTSxpQkFBaUIsWUFBWSxrQkFBa0IsT0FBTztBQUM1RCxVQUFNLGNBQWMsZUFBZSxRQUFRLGVBQWU7QUFDMUQsVUFBTSxhQUFhLG9CQUFJLElBQTBDO0FBRWpFLFdBQU87QUFBQSxNQUNMLDBDQUEwQyxDQUFDLHFCQUFnRDtBQUN6RixZQUFJO0FBQ0YsZ0JBQU0sZUFBZSxlQUFlLHNCQUFzQixJQUFJLGlCQUFpQixNQUFNO0FBQ3JGLGdCQUFNLGVBQWUsWUFBWSxrQkFBa0IsWUFBWTtBQUUvRCxjQUFJLGdCQUFnQixZQUFZLEdBQUc7QUFDakMsZ0JBQUksaUJBQWlCLE9BQU8sU0FBUyxlQUFlLFlBQVk7QUFDOUQsc0JBQVEsT0FBTztBQUFBLGdCQUNiLE1BQU07QUFBQSxnQkFDTixXQUFXO0FBQUEsY0FDYixDQUFDO0FBQ0Q7QUFBQSxZQUNGO0FBRUEsa0JBQU0sb0JBQW9CO0FBQUEsY0FDeEI7QUFBQSxjQUNBLENBQUMsU0FDQyxLQUFLLFNBQVMsZUFBZSwyQkFDN0IsS0FBSyxTQUFTLGVBQWUsc0JBQzdCLEtBQUssU0FBUyxlQUFlO0FBQUEsWUFDakM7QUFDQSxrQkFBTSxxQkFBcUI7QUFBQSxjQUN6QjtBQUFBLGNBQ0EsQ0FBQyxVQUNFLEtBQUssU0FBUyxlQUFlLHVCQUM1QixLQUFLLFNBQVMsZUFBZSx1QkFDN0IsS0FBSyxTQUFTLGVBQWUsb0JBQy9CLEtBQUssT0FBTyxTQUFTLGVBQWU7QUFBQSxZQUN4QztBQUNBLGtCQUFNLDBCQUEyQixrQkFBa0IsS0FBaUMsS0FBSztBQUFBLGNBQ3ZGO0FBQUEsWUFDRjtBQUNBLGtCQUFNLHVCQUF1QixpQkFBaUIsT0FBTztBQUNyRCxrQkFBTSxpQ0FDSixtQkFBbUIsU0FBUyxlQUFlLHVCQUMzQyxtQkFBbUIsYUFBYTtBQUFBLGNBQzlCLENBQUMsZ0JBQ0MsWUFBWSxTQUFTLG9CQUNwQixZQUFZLE1BQU0sU0FBUyxlQUFlLGtCQUN6QyxZQUFZLEtBQUssZUFBZTtBQUFBLFlBQ3RDO0FBQ0Ysa0JBQU0sMkJBQTJCLGlDQUM1QixtQkFBbUIsYUFBYTtBQUFBLGNBQy9CLENBQUMsZ0JBQ0MsWUFBWSxTQUFTLG9CQUNwQixZQUFZLE1BQU0sU0FBUyxlQUFlLGtCQUN6QyxZQUFZLEtBQUssZUFBZTtBQUFBLFlBQ3RDLEdBQUcsS0FDSCxHQUFHLGlCQUFpQixPQUFPLElBQUk7QUFFbkMsa0JBQU0sU0FBaUI7QUFBQSxjQUNyQjtBQUFBLGNBQ0E7QUFBQSxjQUNBO0FBQUEsY0FDQTtBQUFBLGNBQ0E7QUFBQSxjQUNBO0FBQUEsY0FDQTtBQUFBLFlBQ0Y7QUFFQSxrQkFBTSxvQkFBb0IsV0FBVyxJQUFJLGlCQUFpQixLQUFLLG9CQUFJLElBQXNCO0FBQ3pGLGtCQUFNLG9CQUFvQixrQkFBa0IsSUFBSSxvQkFBb0IsS0FBSyxDQUFDO0FBQzFFLDhCQUFrQixLQUFLLE1BQU07QUFDN0IsOEJBQWtCLElBQUksc0JBQXNCLGlCQUFpQjtBQUM3RCx1QkFBVyxJQUFJLG1CQUFtQixpQkFBaUI7QUFBQSxVQUNyRDtBQUFBLFFBQ0YsU0FBUyxPQUFPO0FBRWQsa0JBQVEsTUFBTSxtQkFBbUIsTUFBTSxtQkFBbUIsUUFBUSxRQUFRLE1BQU0sS0FBSztBQUNyRixrQkFBUSxPQUFPO0FBQUEsWUFDYixNQUFNO0FBQUEsWUFDTixXQUFXO0FBQUEsWUFDWCxNQUFNO0FBQUEsY0FDSixVQUFVLFFBQVE7QUFBQSxjQUNsQixPQUFPLGlCQUFpQixRQUFRLE1BQU0sU0FBUyxJQUFJLEtBQUssVUFBVSxLQUFLO0FBQUEsWUFDekU7QUFBQSxVQUNGLENBQUM7QUFBQSxRQUNIO0FBQUEsTUFDRjtBQUFBLE1BRUEsZ0JBQWdCLE1BQU07QUFDcEIsWUFBSSxXQUFXLFNBQVMsR0FBRztBQUN6QjtBQUFBLFFBQ0Y7QUFFQSxjQUFNLFFBQW1GLENBQUM7QUFDMUYsbUJBQVcscUJBQXFCLFdBQVcsT0FBTyxHQUFHO0FBQ25ELHFCQUFXLHFCQUFxQixrQkFBa0IsT0FBTyxHQUFHO0FBQzFELGtCQUFNLGlCQUFpQixrQkFBa0I7QUFBQSxjQUN2QyxDQUFDLFNBQVMsWUFBWSxRQUFRLDBCQUEwQixRQUFRO0FBQUEsWUFDbEU7QUFDQSxrQkFBTSxjQUFjLGVBQWUsQ0FBQztBQUNwQyxtQkFBTyxXQUFXO0FBRWxCLGtCQUFNO0FBQUEsY0FDSjtBQUFBLGNBQ0E7QUFBQSxjQUNBO0FBQUEsY0FDQTtBQUFBLGNBQ0E7QUFBQSxZQUNGLElBQUk7QUFFSixnQkFBSTtBQUNKLGdCQUFJLENBQUMsZ0NBQWdDO0FBQ25DLG9CQUFNLEtBQUs7QUFBQSxnQkFDVCxNQUFNLFFBQVEsV0FBVyxlQUFlLGtCQUFrQjtBQUFBLGdCQUMxRCxNQUFNO0FBQUEsUUFBVyx3QkFBd0IsWUFBWSxvQkFBb0I7QUFBQSxnQkFDekUsUUFBUTtBQUFBLGNBQ1YsQ0FBQztBQUNELGlDQUFtQjtBQUFBLFlBQ3JCLE9BQU87QUFDTCxvQkFBTSxLQUFLO0FBQUEsZ0JBQ1QsTUFBTTtBQUFBLGdCQUNOLE1BQU0sU0FBUyxvQkFBb0I7QUFBQSxnQkFDbkMsUUFBUTtBQUFBLGNBQ1YsQ0FBQztBQUNELGlDQUFtQixlQUFlLE1BQU0sQ0FBQztBQUFBLFlBQzNDO0FBRUEsdUJBQVcsVUFBVSxrQkFBa0I7QUFDckMsb0JBQU0sS0FBSyxFQUFFLE1BQU0sT0FBTyxrQkFBa0IsTUFBTSwwQkFBMEIsUUFBUSxNQUFNLENBQUM7QUFBQSxZQUM3RjtBQUFBLFVBQ0Y7QUFBQSxRQUNGO0FBRUEsbUJBQVcsT0FBTyxNQUFNLFFBQVEsR0FBRztBQUNqQyxrQkFBUSxPQUFPO0FBQUEsWUFDYixNQUFNLElBQUk7QUFBQSxZQUNWLFdBQVc7QUFBQSxZQUNYLElBQUksT0FBTztBQUNULHFCQUFPLElBQUksU0FBUyxNQUFNLGdCQUFnQixJQUFJLE1BQU0sSUFBSSxJQUFJLElBQUksTUFBTSxZQUFZLElBQUksTUFBTSxJQUFJLElBQUk7QUFBQSxZQUN0RztBQUFBLFVBQ0YsQ0FBQztBQUFBLFFBQ0g7QUFBQSxNQUNGO0FBQUEsSUFDRjtBQUFBLEVBQ0Y7QUFDRixDQUFDO0FBRUQsSUFBTyxtQ0FBUTsiLAogICJuYW1lcyI6IFtdCn0K
|
|
@@ -1,6 +1,7 @@
|
|
|
1
1
|
// src/agent/fetch-response-status.ts
|
|
2
2
|
import { AST_NODE_TYPES, ESLintUtils } from "@typescript-eslint/utils";
|
|
3
3
|
import getDocumentationUrl from "../get-documentation-url.mjs";
|
|
4
|
+
import { isFetchResponse } from "./fetch.mjs";
|
|
4
5
|
var ruleId = "fetch-response-status";
|
|
5
6
|
var createRule = ESLintUtils.RuleCreator((name) => getDocumentationUrl(name));
|
|
6
7
|
var rule = createRule({
|
|
@@ -19,10 +20,12 @@ var rule = createRule({
|
|
|
19
20
|
},
|
|
20
21
|
defaultOptions: [],
|
|
21
22
|
create(context) {
|
|
23
|
+
const parserServices = ESLintUtils.getParserServices(context);
|
|
24
|
+
const typeChecker = parserServices.program.getTypeChecker();
|
|
22
25
|
return {
|
|
23
26
|
VariableDeclaration: (variableDeclaration) => {
|
|
24
27
|
const variableInit = variableDeclaration.declarations[0]?.init;
|
|
25
|
-
if (!variableInit || variableInit.type !== AST_NODE_TYPES.AwaitExpression || variableInit.argument.type !== AST_NODE_TYPES.CallExpression
|
|
28
|
+
if (!variableInit || variableInit.type !== AST_NODE_TYPES.AwaitExpression || variableInit.argument.type !== AST_NODE_TYPES.CallExpression) {
|
|
26
29
|
return;
|
|
27
30
|
}
|
|
28
31
|
const variableId = variableDeclaration.declarations[0]?.id;
|
|
@@ -35,6 +38,13 @@ var rule = createRule({
|
|
|
35
38
|
if (!statusCodeProperty) {
|
|
36
39
|
return;
|
|
37
40
|
}
|
|
41
|
+
if (variableInit.argument.callee.type !== AST_NODE_TYPES.Identifier || variableInit.argument.callee.name !== "fetch") {
|
|
42
|
+
const variableNode = parserServices.esTreeNodeToTSNodeMap.get(variableId);
|
|
43
|
+
const variableType = typeChecker.getTypeAtLocation(variableNode);
|
|
44
|
+
if (!isFetchResponse(variableType)) {
|
|
45
|
+
return;
|
|
46
|
+
}
|
|
47
|
+
}
|
|
38
48
|
try {
|
|
39
49
|
context.report({
|
|
40
50
|
node: statusCodeProperty,
|
|
@@ -63,4 +73,4 @@ export {
|
|
|
63
73
|
fetch_response_status_default as default,
|
|
64
74
|
ruleId
|
|
65
75
|
};
|
|
66
|
-
//# sourceMappingURL=data:application/json;base64,
|
|
76
|
+
//# sourceMappingURL=data:application/json;base64,ewogICJ2ZXJzaW9uIjogMywKICAic291cmNlcyI6IFsiLi4vLi4vc3JjL2FnZW50L2ZldGNoLXJlc3BvbnNlLXN0YXR1cy50cyJdLAogICJtYXBwaW5ncyI6ICI7QUFRQSxTQUFTLGdCQUFnQixtQkFBNkI7QUFFdEQsT0FBTyx5QkFBeUI7QUFDaEMsU0FBUyx1QkFBdUI7QUFFekIsSUFBTSxTQUFTO0FBRXRCLElBQU0sYUFBYSxZQUFZLFlBQVksQ0FBQyxTQUFTLG9CQUFvQixJQUFJLENBQUM7QUFFOUUsSUFBTSxPQUE0RSxXQUFXO0FBQUEsRUFDM0YsTUFBTTtBQUFBLEVBQ04sTUFBTTtBQUFBLElBQ0osTUFBTTtBQUFBLElBQ04sTUFBTTtBQUFBLE1BQ0osYUFBYTtBQUFBLElBQ2Y7QUFBQSxJQUNBLFVBQVU7QUFBQSxNQUNSLDBCQUEwQjtBQUFBLE1BQzFCLGNBQWM7QUFBQSxJQUNoQjtBQUFBLElBQ0EsU0FBUztBQUFBLElBQ1QsUUFBUSxDQUFDO0FBQUEsRUFDWDtBQUFBLEVBQ0EsZ0JBQWdCLENBQUM7QUFBQSxFQUNqQixPQUFPLFNBQVM7QUFDZCxVQUFNLGlCQUFpQixZQUFZLGtCQUFrQixPQUFPO0FBQzVELFVBQU0sY0FBYyxlQUFlLFFBQVEsZUFBZTtBQUUxRCxXQUFPO0FBQUEsTUFDTCxxQkFBcUIsQ0FBQyx3QkFBc0Q7QUFDMUUsY0FBTSxlQUFlLG9CQUFvQixhQUFhLENBQUMsR0FBRztBQUMxRCxZQUNFLENBQUMsZ0JBQ0QsYUFBYSxTQUFTLGVBQWUsbUJBQ3JDLGFBQWEsU0FBUyxTQUFTLGVBQWUsZ0JBQzlDO0FBQ0E7QUFBQSxRQUNGO0FBRUEsY0FBTSxhQUFhLG9CQUFvQixhQUFhLENBQUMsR0FBRztBQUN4RCxZQUFJLFdBQVcsU0FBUyxlQUFlLGVBQWU7QUFDcEQ7QUFBQSxRQUNGO0FBQ0EsY0FBTSxxQkFBcUIsV0FBVyxXQUFXO0FBQUEsVUFDL0MsQ0FBQyxhQUNDLFNBQVMsU0FBUyxlQUFlLFlBQ2pDLFNBQVMsSUFBSSxTQUFTLGVBQWUsY0FDckMsU0FBUyxJQUFJLFNBQVM7QUFBQSxRQUMxQjtBQUNBLFlBQUksQ0FBQyxvQkFBb0I7QUFDdkI7QUFBQSxRQUNGO0FBRUEsWUFDRSxhQUFhLFNBQVMsT0FBTyxTQUFTLGVBQWUsY0FDckQsYUFBYSxTQUFTLE9BQU8sU0FBUyxTQUN0QztBQUNBLGdCQUFNLGVBQWUsZUFBZSxzQkFBc0IsSUFBSSxVQUFVO0FBQ3hFLGdCQUFNLGVBQWUsWUFBWSxrQkFBa0IsWUFBWTtBQUMvRCxjQUFJLENBQUMsZ0JBQWdCLFlBQVksR0FBRztBQUNsQztBQUFBLFVBQ0Y7QUFBQSxRQUNGO0FBRUEsWUFBSTtBQUNGLGtCQUFRLE9BQU87QUFBQSxZQUNiLE1BQU07QUFBQSxZQUNOLFdBQVc7QUFBQSxZQUNYLElBQUksT0FBTztBQUNULHFCQUFPLG1CQUFtQixZQUN0QixNQUFNLFlBQVksb0JBQW9CLG9CQUFvQixJQUMxRCxNQUFNLFlBQVksbUJBQW1CLEtBQUssUUFBUTtBQUFBLFlBQ3hEO0FBQUEsVUFDRixDQUFDO0FBQUEsUUFDSCxTQUFTLE9BQU87QUFFZCxrQkFBUSxNQUFNLG1CQUFtQixNQUFNLG1CQUFtQixRQUFRLFFBQVEsTUFBTSxLQUFLO0FBQ3JGLGtCQUFRLE9BQU87QUFBQSxZQUNiLE1BQU07QUFBQSxZQUNOLFdBQVc7QUFBQSxZQUNYLE1BQU07QUFBQSxjQUNKLFVBQVUsUUFBUTtBQUFBLGNBQ2xCLE9BQU8saUJBQWlCLFFBQVEsTUFBTSxTQUFTLElBQUksS0FBSyxVQUFVLEtBQUs7QUFBQSxZQUN6RTtBQUFBLFVBQ0YsQ0FBQztBQUFBLFFBQ0g7QUFBQSxNQUNGO0FBQUEsSUFDRjtBQUFBLEVBQ0Y7QUFDRixDQUFDO0FBRUQsSUFBTyxnQ0FBUTsiLAogICJuYW1lcyI6IFtdCn0K
|
package/dist-mjs/agent/fetch.mjs
CHANGED
|
@@ -1,5 +1,6 @@
|
|
|
1
1
|
// src/agent/fetch.ts
|
|
2
2
|
import { AST_NODE_TYPES } from "@typescript-eslint/utils";
|
|
3
|
+
import "typescript";
|
|
3
4
|
import { getParent, isBlockStatement } from "../library/ts-tree.mjs";
|
|
4
5
|
function getResponseBodyRetrievalText(responseVariableName) {
|
|
5
6
|
return `await ${responseVariableName}.json()`;
|
|
@@ -33,11 +34,15 @@ function hasAssertions(fixtureCall) {
|
|
|
33
34
|
}
|
|
34
35
|
return hasAssertions(parent);
|
|
35
36
|
}
|
|
37
|
+
function isFetchResponse(type) {
|
|
38
|
+
return type.getProperties().some((symbol) => symbol.name === "body") && type.getProperties().some((symbol) => symbol.name === "json");
|
|
39
|
+
}
|
|
36
40
|
export {
|
|
37
41
|
getResponseBodyRetrievalText,
|
|
38
42
|
getResponseHeadersRetrievalText,
|
|
39
43
|
getResponseStatusRetrievalText,
|
|
40
44
|
hasAssertions,
|
|
45
|
+
isFetchResponse,
|
|
41
46
|
isInvalidResponseHeadersAccess
|
|
42
47
|
};
|
|
43
|
-
//# sourceMappingURL=data:application/json;base64,
|
|
48
|
+
//# sourceMappingURL=data:application/json;base64,ewogICJ2ZXJzaW9uIjogMywKICAic291cmNlcyI6IFsiLi4vLi4vc3JjL2FnZW50L2ZldGNoLnRzIl0sCiAgIm1hcHBpbmdzIjogIjtBQUVBLFNBQVMsc0JBQWdDO0FBQ3pDLE9BQWU7QUFFZixTQUFTLFdBQVcsd0JBQXdCO0FBRXJDLFNBQVMsNkJBQTZCLHNCQUE4QjtBQUN6RSxTQUFPLFNBQVMsb0JBQW9CO0FBQ3RDO0FBRU8sU0FBUywrQkFBK0Isc0JBQThCO0FBQzNFLFNBQU8sR0FBRyxvQkFBb0I7QUFDaEM7QUFFTyxTQUFTLGdDQUFnQyxzQkFBOEI7QUFDNUUsU0FBTyxHQUFHLG9CQUFvQjtBQUNoQztBQUVPLFNBQVMsK0JBQStCLHVCQUErQztBQUM1RixRQUFNLDZCQUE2QixVQUFVLHFCQUFxQjtBQUNsRSxNQUFJLDRCQUE0QixTQUFTLGVBQWUsb0JBQW9CO0FBQzFFLFdBQU87QUFBQSxFQUNUO0FBRUEsTUFDRSw0QkFBNEIsU0FBUyxlQUFlLGtCQUNwRCwyQkFBMkIsT0FBTyxTQUFTLGVBQWUsb0JBQzFELDJCQUEyQixPQUFPLFNBQVMsU0FBUyxlQUFlLGNBQ25FLDJCQUEyQixPQUFPLFNBQVMsU0FBUyxPQUNwRDtBQUNBLFdBQU87QUFBQSxFQUNUO0FBRUEsU0FBTyxFQUNMLDRCQUE0QixTQUFTLGVBQWUsb0JBQ3BELDJCQUEyQixTQUFTLFNBQVMsZUFBZSxjQUM1RCwyQkFBMkIsU0FBUyxTQUFTO0FBRWpEO0FBRU8sU0FBUyxjQUFjLGFBQXFDO0FBQ2pFLE1BQUksaUJBQWlCLFdBQVcsR0FBRztBQUNqQyxXQUFPO0FBQUEsRUFDVDtBQUVBLFFBQU0sU0FBUyxVQUFVLFdBQVc7QUFDcEMsTUFBSSxDQUFDLFFBQVE7QUFDWCxXQUFPO0FBQUEsRUFDVDtBQUVBLE1BQ0UsT0FBTyxTQUFTLGVBQWUsb0JBQy9CLE9BQU8sU0FBUyxTQUFTLGVBQWUsY0FDeEMsT0FBTyxTQUFTLFNBQVMsWUFDekIsVUFBVSxNQUFNLEdBQUcsU0FBUyxlQUFlLGdCQUMzQztBQUNBLFdBQU87QUFBQSxFQUNUO0FBRUEsU0FBTyxjQUFjLE1BQU07QUFDN0I7QUFFTyxTQUFTLGdCQUFnQixNQUF3QjtBQUN0RCxTQUNFLEtBQUssY0FBYyxFQUFFLEtBQUssQ0FBQyxXQUFXLE9BQU8sU0FBUyxNQUFNLEtBQzVELEtBQUssY0FBYyxFQUFFLEtBQUssQ0FBQyxXQUFXLE9BQU8sU0FBUyxNQUFNO0FBRWhFOyIsCiAgIm5hbWVzIjogW10KfQo=
|
|
@@ -1,6 +1,7 @@
|
|
|
1
1
|
// src/agent/no-status-code.ts
|
|
2
2
|
import { ESLintUtils } from "@typescript-eslint/utils";
|
|
3
3
|
import getDocumentationUrl from "../get-documentation-url.mjs";
|
|
4
|
+
import { isFetchResponse } from "./fetch.mjs";
|
|
4
5
|
var ruleId = "no-status-code";
|
|
5
6
|
var createRule = ESLintUtils.RuleCreator((name) => getDocumentationUrl(name));
|
|
6
7
|
var rule = createRule({
|
|
@@ -26,8 +27,7 @@ var rule = createRule({
|
|
|
26
27
|
try {
|
|
27
28
|
const responseNode = parserServices.esTreeNodeToTSNodeMap.get(responseStatusCode.object);
|
|
28
29
|
const responseType = typeChecker.getTypeAtLocation(responseNode);
|
|
29
|
-
|
|
30
|
-
if (shouldReplace) {
|
|
30
|
+
if (isFetchResponse(responseType)) {
|
|
31
31
|
context.report({
|
|
32
32
|
messageId: "replaceStatusCode",
|
|
33
33
|
node: responseStatusCode.property,
|
|
@@ -56,4 +56,4 @@ export {
|
|
|
56
56
|
no_status_code_default as default,
|
|
57
57
|
ruleId
|
|
58
58
|
};
|
|
59
|
-
//# sourceMappingURL=data:application/json;base64,
|
|
59
|
+
//# sourceMappingURL=data:application/json;base64,ewogICJ2ZXJzaW9uIjogMywKICAic291cmNlcyI6IFsiLi4vLi4vc3JjL2FnZW50L25vLXN0YXR1cy1jb2RlLnRzIl0sCiAgIm1hcHBpbmdzIjogIjtBQVFBLFNBQVMsbUJBQTZCO0FBRXRDLE9BQU8seUJBQXlCO0FBQ2hDLFNBQVMsdUJBQXVCO0FBRXpCLElBQU0sU0FBUztBQUV0QixJQUFNLGFBQWEsWUFBWSxZQUFZLENBQUMsU0FBUyxvQkFBb0IsSUFBSSxDQUFDO0FBRTlFLElBQU0sT0FBcUUsV0FBVztBQUFBLEVBQ3BGLE1BQU07QUFBQSxFQUNOLE1BQU07QUFBQSxJQUNKLE1BQU07QUFBQSxJQUNOLE1BQU07QUFBQSxNQUNKLGFBQWE7QUFBQSxJQUNmO0FBQUEsSUFDQSxVQUFVO0FBQUEsTUFDUixtQkFBbUI7QUFBQSxNQUNuQixjQUFjO0FBQUEsSUFDaEI7QUFBQSxJQUNBLFNBQVM7QUFBQSxJQUNULFFBQVEsQ0FBQztBQUFBLEVBQ1g7QUFBQSxFQUNBLGdCQUFnQixDQUFDO0FBQUEsRUFDakIsT0FBTyxTQUFTO0FBQ2QsVUFBTSxpQkFBaUIsWUFBWSxrQkFBa0IsT0FBTztBQUM1RCxVQUFNLGNBQWMsZUFBZSxRQUFRLGVBQWU7QUFFMUQsV0FBTztBQUFBLE1BQ0wsZ0RBQWdELENBQUMsdUJBQWtEO0FBQ2pHLFlBQUk7QUFDRixnQkFBTSxlQUFlLGVBQWUsc0JBQXNCLElBQUksbUJBQW1CLE1BQU07QUFDdkYsZ0JBQU0sZUFBZSxZQUFZLGtCQUFrQixZQUFZO0FBRS9ELGNBQUksZ0JBQWdCLFlBQVksR0FBRztBQUNqQyxvQkFBUSxPQUFPO0FBQUEsY0FDYixXQUFXO0FBQUEsY0FDWCxNQUFNLG1CQUFtQjtBQUFBLGNBQ3pCLElBQUksT0FBTztBQUNULHVCQUFPLE1BQU0sWUFBWSxtQkFBbUIsVUFBVSxRQUFRO0FBQUEsY0FDaEU7QUFBQSxZQUNGLENBQUM7QUFBQSxVQUNIO0FBQUEsUUFDRixTQUFTLE9BQU87QUFFZCxrQkFBUSxNQUFNLG1CQUFtQixNQUFNLG1CQUFtQixRQUFRLFFBQVEsTUFBTSxLQUFLO0FBQ3JGLGtCQUFRLE9BQU87QUFBQSxZQUNiLE1BQU07QUFBQSxZQUNOLFdBQVc7QUFBQSxZQUNYLE1BQU07QUFBQSxjQUNKLFVBQVUsUUFBUTtBQUFBLGNBQ2xCLE9BQU8saUJBQWlCLFFBQVEsTUFBTSxTQUFTLElBQUksS0FBSyxVQUFVLEtBQUs7QUFBQSxZQUN6RTtBQUFBLFVBQ0YsQ0FBQztBQUFBLFFBQ0g7QUFBQSxNQUNGO0FBQUEsSUFDRjtBQUFBLEVBQ0Y7QUFDRixDQUFDO0FBRUQsSUFBTyx5QkFBUTsiLAogICJuYW1lcyI6IFtdCn0K
|
|
@@ -1,6 +1,8 @@
|
|
|
1
1
|
import { TSESTree } from '@typescript-eslint/utils';
|
|
2
|
+
import ts from 'typescript';
|
|
2
3
|
export declare function getResponseBodyRetrievalText(responseVariableName: string): string;
|
|
3
4
|
export declare function getResponseStatusRetrievalText(responseVariableName: string): string;
|
|
4
5
|
export declare function getResponseHeadersRetrievalText(responseVariableName: string): string;
|
|
5
6
|
export declare function isInvalidResponseHeadersAccess(responseHeadersAccess: TSESTree.Node): boolean;
|
|
6
7
|
export declare function hasAssertions(fixtureCall: TSESTree.Node): boolean;
|
|
8
|
+
export declare function isFetchResponse(type: ts.Type): boolean;
|
package/package.json
CHANGED
|
@@ -1 +1 @@
|
|
|
1
|
-
{"name":"@checkdigit/eslint-plugin","version":"7.6.0-PR.75-
|
|
1
|
+
{"name":"@checkdigit/eslint-plugin","version":"7.6.0-PR.75-8118","description":"Check Digit eslint plugins","keywords":["eslint","eslintplugin"],"homepage":"https://github.com/checkdigit/eslint-plugin#readme","bugs":{"url":"https://github.com/checkdigit/eslint-plugin/issues"},"repository":{"type":"git","url":"https://github.com/checkdigit/eslint-plugin"},"license":"MIT","author":"Check Digit, LLC","sideEffects":false,"type":"module","exports":{".":{"types":"./dist-types/index.d.ts","import":"./dist-mjs/index.mjs","default":"./dist-mjs/index.mjs"}},"files":["src","dist-types","dist-mjs","!src/**/test/**","!src/**/*.test.ts","!src/**/*.spec.ts","!dist-types/**/test/**","!dist-types/**/*.test.d.ts","!dist-types/**/*.spec.d.ts","!dist-mjs/**/test/**","!dist-mjs/**/*.test.mjs","!dist-mjs/**/*.spec.mjs","SECURITY.md"],"scripts":{"build:dist-mjs":"rimraf dist-mjs && npx builder --type=module --sourceMap --outDir=dist-mjs && node dist-mjs/index.mjs","build:dist-types":"rimraf dist-types && npx builder --type=types --outDir=dist-types","ci:compile":"tsc --noEmit","ci:coverage":"NODE_OPTIONS=\"--disable-warning ExperimentalWarning --experimental-vm-modules\" jest --coverage=true","ci:lint":"npm run lint","ci:style":"npm run prettier","ci:test":"NODE_OPTIONS=\"--disable-warning ExperimentalWarning --experimental-vm-modules\" jest --coverage=false","lint":"eslint --max-warnings 0 .","lint:fix":"eslint --max-warnings 0 --fix .","prepare":"","prepublishOnly":"npm run build:dist-types && npm run build:dist-mjs","prettier":"prettier --ignore-path .gitignore --list-different .","prettier:fix":"prettier --ignore-path .gitignore --write .","test":"npm run ci:compile && npm run ci:test && npm run ci:lint && npm run ci:style"},"prettier":"@checkdigit/prettier-config","jest":{"preset":"@checkdigit/jest-config"},"dependencies":{"@typescript-eslint/type-utils":"^8.15.0","@typescript-eslint/utils":"^8.15.0","debug":"^4.3.7","ts-api-utils":"^1.4.0"},"devDependencies":{"@checkdigit/jest-config":"^6.0.2","@checkdigit/prettier-config":"^5.5.1","@checkdigit/typescript-config":"^8.0.0","@eslint/js":"^9.15.0","@types/debug":"^4.1.12","@types/eslint":"^9.6.1","@types/eslint-config-prettier":"^6.11.3","@typescript-eslint/parser":"^8.15.0","@typescript-eslint/rule-tester":"^8.15.0","eslint":"^9.15.0","eslint-config-prettier":"^9.1.0","eslint-import-resolver-typescript":"^3.6.3","eslint-plugin-eslint-plugin":"^6.3.2","eslint-plugin-import":"^2.31.0","eslint-plugin-no-only-tests":"^3.3.0","eslint-plugin-no-secrets":"^1.1.2","eslint-plugin-node":"^11.1.0","eslint-plugin-sonarjs":"1.0.4","http-status-codes":"^2.3.0","rimraf":"^6.0.1","typescript-eslint":"^8.15.0"},"peerDependencies":{"eslint":">=9 <10"},"engines":{"node":">=20.17"}}
|
|
@@ -12,6 +12,7 @@ import { AST_NODE_TYPES, ESLintUtils, TSESTree } from '@typescript-eslint/utils'
|
|
|
12
12
|
|
|
13
13
|
import getDocumentationUrl from '../get-documentation-url';
|
|
14
14
|
import { getAncestor } from '../library/ts-tree';
|
|
15
|
+
import { isFetchResponse } from './fetch';
|
|
15
16
|
|
|
16
17
|
export const ruleId = 'fetch-response-body-json';
|
|
17
18
|
|
|
@@ -56,11 +57,7 @@ const rule: ESLintUtils.RuleModule<'unknownError' | 'replaceBodyWithJson' | 'ref
|
|
|
56
57
|
const responseNode = parserServices.esTreeNodeToTSNodeMap.get(responseBodyNode.object);
|
|
57
58
|
const responseType = typeChecker.getTypeAtLocation(responseNode);
|
|
58
59
|
|
|
59
|
-
|
|
60
|
-
responseType.getProperties().some((symbol) => symbol.name === 'body') &&
|
|
61
|
-
responseType.getProperties().some((symbol) => symbol.name === 'json');
|
|
62
|
-
|
|
63
|
-
if (shouldReplace) {
|
|
60
|
+
if (isFetchResponse(responseType)) {
|
|
64
61
|
if (responseBodyNode.object.type !== AST_NODE_TYPES.Identifier) {
|
|
65
62
|
context.report({
|
|
66
63
|
node: responseBodyNode,
|
|
@@ -9,6 +9,7 @@
|
|
|
9
9
|
import { AST_NODE_TYPES, ESLintUtils, TSESTree } from '@typescript-eslint/utils';
|
|
10
10
|
|
|
11
11
|
import getDocumentationUrl from '../get-documentation-url';
|
|
12
|
+
import { isFetchResponse } from './fetch';
|
|
12
13
|
|
|
13
14
|
export const ruleId = 'fetch-response-status';
|
|
14
15
|
|
|
@@ -30,15 +31,16 @@ const rule: ESLintUtils.RuleModule<'unknownError' | 'renameStatusCodeProperty'>
|
|
|
30
31
|
},
|
|
31
32
|
defaultOptions: [],
|
|
32
33
|
create(context) {
|
|
34
|
+
const parserServices = ESLintUtils.getParserServices(context);
|
|
35
|
+
const typeChecker = parserServices.program.getTypeChecker();
|
|
36
|
+
|
|
33
37
|
return {
|
|
34
38
|
VariableDeclaration: (variableDeclaration: TSESTree.VariableDeclaration) => {
|
|
35
39
|
const variableInit = variableDeclaration.declarations[0]?.init;
|
|
36
40
|
if (
|
|
37
41
|
!variableInit ||
|
|
38
42
|
variableInit.type !== AST_NODE_TYPES.AwaitExpression ||
|
|
39
|
-
variableInit.argument.type !== AST_NODE_TYPES.CallExpression
|
|
40
|
-
variableInit.argument.callee.type !== AST_NODE_TYPES.Identifier ||
|
|
41
|
-
variableInit.argument.callee.name !== 'fetch'
|
|
43
|
+
variableInit.argument.type !== AST_NODE_TYPES.CallExpression
|
|
42
44
|
) {
|
|
43
45
|
return;
|
|
44
46
|
}
|
|
@@ -57,6 +59,17 @@ const rule: ESLintUtils.RuleModule<'unknownError' | 'renameStatusCodeProperty'>
|
|
|
57
59
|
return;
|
|
58
60
|
}
|
|
59
61
|
|
|
62
|
+
if (
|
|
63
|
+
variableInit.argument.callee.type !== AST_NODE_TYPES.Identifier ||
|
|
64
|
+
variableInit.argument.callee.name !== 'fetch'
|
|
65
|
+
) {
|
|
66
|
+
const variableNode = parserServices.esTreeNodeToTSNodeMap.get(variableId);
|
|
67
|
+
const variableType = typeChecker.getTypeAtLocation(variableNode);
|
|
68
|
+
if (!isFetchResponse(variableType)) {
|
|
69
|
+
return;
|
|
70
|
+
}
|
|
71
|
+
}
|
|
72
|
+
|
|
60
73
|
try {
|
|
61
74
|
context.report({
|
|
62
75
|
node: statusCodeProperty,
|
package/src/agent/fetch.ts
CHANGED
|
@@ -1,6 +1,7 @@
|
|
|
1
1
|
// agent/fetch.ts
|
|
2
2
|
|
|
3
3
|
import { AST_NODE_TYPES, TSESTree } from '@typescript-eslint/utils';
|
|
4
|
+
import ts from 'typescript';
|
|
4
5
|
|
|
5
6
|
import { getParent, isBlockStatement } from '../library/ts-tree';
|
|
6
7
|
|
|
@@ -59,3 +60,10 @@ export function hasAssertions(fixtureCall: TSESTree.Node): boolean {
|
|
|
59
60
|
|
|
60
61
|
return hasAssertions(parent);
|
|
61
62
|
}
|
|
63
|
+
|
|
64
|
+
export function isFetchResponse(type: ts.Type): boolean {
|
|
65
|
+
return (
|
|
66
|
+
type.getProperties().some((symbol) => symbol.name === 'body') &&
|
|
67
|
+
type.getProperties().some((symbol) => symbol.name === 'json')
|
|
68
|
+
);
|
|
69
|
+
}
|
|
@@ -9,6 +9,7 @@
|
|
|
9
9
|
import { ESLintUtils, TSESTree } from '@typescript-eslint/utils';
|
|
10
10
|
|
|
11
11
|
import getDocumentationUrl from '../get-documentation-url';
|
|
12
|
+
import { isFetchResponse } from './fetch';
|
|
12
13
|
|
|
13
14
|
export const ruleId = 'no-status-code';
|
|
14
15
|
|
|
@@ -39,11 +40,7 @@ const rule: ESLintUtils.RuleModule<'unknownError' | 'replaceStatusCode'> = creat
|
|
|
39
40
|
const responseNode = parserServices.esTreeNodeToTSNodeMap.get(responseStatusCode.object);
|
|
40
41
|
const responseType = typeChecker.getTypeAtLocation(responseNode);
|
|
41
42
|
|
|
42
|
-
|
|
43
|
-
responseType.getProperties().some((symbol) => symbol.name === 'status') &&
|
|
44
|
-
!responseType.getProperties().some((symbol) => symbol.name === 'statusCode');
|
|
45
|
-
|
|
46
|
-
if (shouldReplace) {
|
|
43
|
+
if (isFetchResponse(responseType)) {
|
|
47
44
|
context.report({
|
|
48
45
|
messageId: 'replaceStatusCode',
|
|
49
46
|
node: responseStatusCode.property,
|