@checkdigit/eslint-plugin 7.14.0-PR.117-1980 → 7.14.0-PR.117-a113
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/dist-mjs/index.mjs +4 -7
- package/dist-mjs/no-random-v4-uuid.mjs +4 -4
- package/dist-mjs/no-side-effects.mjs +88 -32
- package/dist-mjs/no-type-assertion-as.mjs +2 -10
- package/package.json +1 -1
- package/src/index.ts +1 -4
- package/src/no-random-v4-uuid.ts +3 -4
- package/src/no-side-effects.ts +162 -71
- package/src/no-type-assertion-as.ts +1 -18
package/dist-mjs/index.mjs
CHANGED
|
@@ -80,10 +80,7 @@ var configs = {
|
|
|
80
80
|
"@checkdigit/require-strict-assert": "error",
|
|
81
81
|
"@checkdigit/require-ts-extension-imports-exports": "error",
|
|
82
82
|
"@checkdigit/no-wallaby-comment": "error",
|
|
83
|
-
"@checkdigit/no-side-effects":
|
|
84
|
-
"error",
|
|
85
|
-
{ excludedIdentifiers: ["assert", "debug", "log", "promisify", "Symbol.for"] }
|
|
86
|
-
],
|
|
83
|
+
"@checkdigit/no-side-effects": "error",
|
|
87
84
|
"@checkdigit/no-type-assertion-as": "error",
|
|
88
85
|
"@checkdigit/regular-expression-comment": "error",
|
|
89
86
|
"@checkdigit/require-assert-predicate-rejects-throws": "error",
|
|
@@ -141,8 +138,8 @@ var defaultToExport = {
|
|
|
141
138
|
...plugin,
|
|
142
139
|
configs
|
|
143
140
|
};
|
|
144
|
-
var
|
|
141
|
+
var index_default = defaultToExport;
|
|
145
142
|
export {
|
|
146
|
-
|
|
143
|
+
index_default as default
|
|
147
144
|
};
|
|
148
|
-
//# sourceMappingURL=data:application/json;base64,
|
|
145
|
+
//# sourceMappingURL=data:application/json;base64,ewogICJ2ZXJzaW9uIjogMywKICAic291cmNlcyI6IFsiLi4vc3JjL2luZGV4LnRzIl0sCiAgIm1hcHBpbmdzIjogIjtBQVVBLE9BQU8sd0JBQXdCLFVBQVUsa0NBQWtDO0FBQzNFLE9BQU8sdUJBQXVCLFVBQVUsaUNBQWlDO0FBQ3pFLE9BQU8seUJBQXlCLFVBQVUsbUNBQW1DO0FBQzdFLE9BQU8sMkJBQTJCLFVBQVUscUNBQXFDO0FBQ2pGLE9BQU8sd0JBQXdCO0FBQy9CLE9BQU87QUFBQSxFQUNMLFVBQVU7QUFBQSxPQUNMO0FBQ1AsT0FBTztBQUFBLEVBQ0wsVUFBVTtBQUFBLE9BQ0w7QUFDUCxPQUFPO0FBQUEsRUFDTCxVQUFVO0FBQUEsT0FDTDtBQUNQLE9BQU8sa0JBQWtCLFVBQVUsNEJBQTRCO0FBQy9ELE9BQU87QUFBQSxFQUNMLFVBQVU7QUFBQSxPQUNMO0FBQ1AsT0FBTyxxQkFBcUI7QUFDNUIsT0FBTyxtQkFBbUI7QUFDMUIsT0FBTyxZQUFZO0FBQ25CLE9BQU8sbUJBQW1CO0FBQzFCLE9BQU8sb0JBQW9CO0FBQzNCLE9BQU8sa0JBQWtCO0FBQ3pCLE9BQU8sdUJBQXVCO0FBQzlCLE9BQU8sWUFBWTtBQUNuQixPQUFPLHNCQUFzQjtBQUM3QixPQUFPLDJCQUEyQjtBQUNsQyxPQUFPLGtCQUFrQjtBQUN6QixPQUFPLHlDQUF5QztBQUNoRCxPQUFPLHlCQUF5QjtBQUNoQyxPQUFPLDBCQUEwQjtBQUNqQyxPQUFPLHNDQUFzQztBQUU3QyxJQUFNLFFBQXNEO0FBQUEsRUFDMUQscUJBQXFCO0FBQUEsRUFDckIsbUJBQW1CO0FBQUEsRUFDbkIsV0FBVztBQUFBLEVBQ1gscUJBQXFCO0FBQUEsRUFDckIseUJBQXlCO0FBQUEsRUFDekIsV0FBVztBQUFBLEVBQ1gsMEJBQTBCO0FBQUEsRUFDMUIseUJBQXlCO0FBQUEsRUFDekIsd0NBQXdDO0FBQUEsRUFDeEMsa0JBQWtCO0FBQUEsRUFDbEIsc0JBQXNCO0FBQUEsRUFDdEIsbUJBQW1CO0FBQUEsRUFDbkIsd0JBQXdCO0FBQUEsRUFDeEIsOEJBQThCO0FBQUEsRUFDOUIsMkNBQTJDO0FBQUEsRUFDM0MsMkJBQTJCO0FBQUEsRUFDM0IsQ0FBQywwQkFBMEIsR0FBRztBQUFBLEVBQzlCLENBQUMsNkJBQTZCLEdBQUc7QUFBQSxFQUNqQyxDQUFDLDJCQUEyQixHQUFHO0FBQUEsRUFDL0IsQ0FBQyxnQ0FBZ0MsR0FBRztBQUFBLEVBQ3BDLENBQUMseUJBQXlCLEdBQUc7QUFBQSxFQUM3QixDQUFDLG9CQUFvQixHQUFHO0FBQUEsRUFDeEIsQ0FBQywyQ0FBMkMsR0FBRztBQUFBLEVBQy9DLENBQUMsZ0NBQWdDLEdBQUc7QUFBQSxFQUNwQyxDQUFDLHFDQUFxQyxHQUFHO0FBQzNDO0FBRUEsSUFBTSxTQUFxQztBQUFBLEVBQ3pDO0FBQ0Y7QUFFQSxJQUFNLFVBQXdEO0FBQUEsRUFDNUQsS0FBSztBQUFBLElBQ0g7QUFBQSxNQUNFLE9BQU8sQ0FBQyxTQUFTO0FBQUEsTUFDakIsU0FBUztBQUFBLFFBQ1AsZUFBZTtBQUFBLE1BQ2pCO0FBQUEsTUFDQSxPQUFPO0FBQUEsUUFDTCwrQkFBK0I7QUFBQSxRQUMvQix1QkFBdUI7QUFBQSxRQUN2QixpQ0FBaUM7QUFBQSxRQUNqQyxpQ0FBaUM7QUFBQSxRQUNqQyxxQ0FBcUM7QUFBQSxRQUNyQyx1QkFBdUI7QUFBQSxRQUN2QixzQ0FBc0M7QUFBQSxRQUN0QyxxQ0FBcUM7QUFBQSxRQUNyQyxvREFBb0Q7QUFBQSxRQUNwRCxrQ0FBa0M7QUFBQSxRQUNsQywrQkFBK0I7QUFBQSxRQUMvQixvQ0FBb0M7QUFBQSxRQUNwQywwQ0FBMEM7QUFBQSxRQUMxQyx1REFBdUQ7QUFBQSxRQUN2RCx1Q0FBdUM7QUFBQSxRQUN2Qyw4QkFBOEI7QUFBQSxRQUM5QixDQUFDLGVBQWUsMEJBQTBCLEVBQUUsR0FBRztBQUFBLFFBQy9DLENBQUMsZUFBZSw2QkFBNkIsRUFBRSxHQUFHO0FBQUEsUUFDbEQsQ0FBQyxlQUFlLDJCQUEyQixFQUFFLEdBQUc7QUFBQSxRQUNoRCxDQUFDLGVBQWUsZ0NBQWdDLEVBQUUsR0FBRztBQUFBLFFBQ3JELENBQUMsZUFBZSx5QkFBeUIsRUFBRSxHQUFHO0FBQUEsUUFDOUMsQ0FBQyxlQUFlLGdDQUFnQyxFQUFFLEdBQUc7QUFBQSxRQUNyRCxDQUFDLGVBQWUscUNBQXFDLEVBQUUsR0FBRztBQUFBLFFBQzFELENBQUMsZUFBZSxvQkFBb0IsRUFBRSxHQUFHO0FBQUEsUUFDekMsQ0FBQyxlQUFlLDJDQUEyQyxFQUFFLEdBQUc7QUFBQSxNQUNsRTtBQUFBLElBQ0Y7QUFBQSxFQUNGO0FBQUEsRUFDQSxhQUFhO0FBQUEsSUFDWDtBQUFBLE1BQ0UsT0FBTyxDQUFDLFNBQVM7QUFBQSxNQUNqQixTQUFTO0FBQUEsUUFDUCxlQUFlO0FBQUEsTUFDakI7QUFBQSxNQUNBLE9BQU87QUFBQSxRQUNMLCtCQUErQjtBQUFBLFFBQy9CLHVCQUF1QjtBQUFBLFFBQ3ZCLGlDQUFpQztBQUFBLFFBQ2pDLGlDQUFpQztBQUFBLFFBQ2pDLHFDQUFxQztBQUFBLFFBQ3JDLHVCQUF1QjtBQUFBLFFBQ3ZCLHNDQUFzQztBQUFBLFFBQ3RDLHFDQUFxQztBQUFBLFFBQ3JDLG9EQUFvRDtBQUFBLFFBQ3BELGtDQUFrQztBQUFBLFFBQ2xDLCtCQUErQjtBQUFBLFFBQy9CLG9DQUFvQztBQUFBLFFBQ3BDLDBDQUEwQztBQUFBLFFBQzFDLHVEQUF1RDtBQUFBLFFBQ3ZELHVDQUF1QztBQUFBLFFBQ3ZDLDhCQUE4QjtBQUFBLFFBQzlCLENBQUMsZUFBZSwwQkFBMEIsRUFBRSxHQUFHO0FBQUEsUUFDL0MsQ0FBQyxlQUFlLDZCQUE2QixFQUFFLEdBQUc7QUFBQSxRQUNsRCxDQUFDLGVBQWUsMkJBQTJCLEVBQUUsR0FBRztBQUFBLFFBQ2hELENBQUMsZUFBZSxnQ0FBZ0MsRUFBRSxHQUFHO0FBQUEsUUFDckQsQ0FBQyxlQUFlLHlCQUF5QixFQUFFLEdBQUc7QUFBQSxRQUM5QyxDQUFDLGVBQWUsZ0NBQWdDLEVBQUUsR0FBRztBQUFBLFFBQ3JELENBQUMsZUFBZSxxQ0FBcUMsRUFBRSxHQUFHO0FBQUEsUUFDMUQsQ0FBQyxlQUFlLG9CQUFvQixFQUFFLEdBQUc7QUFBQSxRQUN6QyxDQUFDLGVBQWUsMkNBQTJDLEVBQUUsR0FBRztBQUFBLE1BQ2xFO0FBQUEsSUFDRjtBQUFBLEVBQ0Y7QUFDRjtBQUVBLElBQU0sa0JBRUY7QUFBQSxFQUNGLEdBQUc7QUFBQSxFQUNIO0FBQ0Y7QUFDQSxJQUFPLGdCQUFROyIsCiAgIm5hbWVzIjogW10KfQo=
|
|
@@ -25,12 +25,12 @@ var rule = createRule({
|
|
|
25
25
|
meta: {
|
|
26
26
|
type: "problem",
|
|
27
27
|
docs: {
|
|
28
|
-
description: "Disallow the use of `uuid.v4` and `crypto.randomUUID` for generating random v4 UUIDs
|
|
28
|
+
description: "Disallow the use of `uuid.v4` and `crypto.randomUUID` for generating random v4 UUIDs."
|
|
29
29
|
},
|
|
30
30
|
schema: [],
|
|
31
31
|
messages: {
|
|
32
|
-
[NO_RANDOM_V4_UUID]: "Avoid
|
|
33
|
-
[NO_UUID_MODULE_FOR_V4]: "Avoid using the `uuid` module for v4 UUID generation
|
|
32
|
+
[NO_RANDOM_V4_UUID]: "Avoid generating v4 UUIDs",
|
|
33
|
+
[NO_UUID_MODULE_FOR_V4]: "Avoid using the `uuid` module for v4 UUID generation"
|
|
34
34
|
}
|
|
35
35
|
},
|
|
36
36
|
defaultOptions: [],
|
|
@@ -61,4 +61,4 @@ export {
|
|
|
61
61
|
no_random_v4_uuid_default as default,
|
|
62
62
|
ruleId
|
|
63
63
|
};
|
|
64
|
-
//# sourceMappingURL=data:application/json;base64,
|
|
64
|
+
//# sourceMappingURL=data:application/json;base64,ewogICJ2ZXJzaW9uIjogMywKICAic291cmNlcyI6IFsiLi4vc3JjL25vLXJhbmRvbS12NC11dWlkLnRzIl0sCiAgIm1hcHBpbmdzIjogIjtBQVFBLFNBQVMsZ0JBQWdCLG1CQUF1QztBQUNoRSxPQUFPLHlCQUF5QjtBQUV6QixJQUFNLFNBQVM7QUFDdEIsSUFBTSxvQkFBb0I7QUFDMUIsSUFBTSx3QkFBd0I7QUFFOUIsSUFBTSxhQUFhLFlBQVksWUFBWSxDQUFDLFNBQVMsb0JBQW9CLElBQUksQ0FBQztBQVE5RSxJQUFNLDJCQUEyQixDQUFDLE1BQWtDLFlBQXFCO0FBQ3ZGLE9BQUssV0FBVyxRQUFRLENBQUMsY0FBYztBQUNyQyxRQUFJLFVBQVUsU0FBUyxlQUFlLGlCQUFpQjtBQUNyRCxVQUNFLEtBQUssT0FBTyxVQUFVLFVBQ3RCLFVBQVUsU0FBUyxTQUFTLGVBQWUsY0FDM0MsVUFBVSxTQUFTLFNBQVMsTUFDNUI7QUFDQSxnQkFBUSxhQUFhLFVBQVUsTUFBTTtBQUFBLE1BQ3ZDLFdBQ0UsS0FBSyxPQUFPLFVBQVUsaUJBQ3RCLFVBQVUsU0FBUyxTQUFTLGVBQWUsY0FDM0MsVUFBVSxTQUFTLFNBQVMsY0FDNUI7QUFDQSxnQkFBUSw0QkFBNEIsVUFBVSxNQUFNO0FBQUEsTUFDdEQ7QUFBQSxJQUNGLFdBQVcsVUFBVSxTQUFTLGVBQWUsMEJBQTBCLEtBQUssT0FBTyxVQUFVLFFBQVE7QUFDbkcsY0FBUSxtQkFBbUIsVUFBVSxNQUFNO0FBQUEsSUFDN0M7QUFBQSxFQUNGLENBQUM7QUFDSDtBQUVBLElBQU0sY0FBYyxDQUFDLE1BQStCLFlBQ2pELEtBQUssT0FBTyxTQUFTLGVBQWUsY0FBYyxLQUFLLE9BQU8sU0FBUyxRQUFRLGNBQy9FLEtBQUssT0FBTyxTQUFTLGVBQWUsb0JBQ25DLEtBQUssT0FBTyxPQUFPLFNBQVMsZUFBZSxjQUMzQyxLQUFLLE9BQU8sT0FBTyxTQUFTLFFBQVEsb0JBQ3BDLEtBQUssT0FBTyxTQUFTLFNBQVMsZUFBZSxjQUM3QyxLQUFLLE9BQU8sU0FBUyxTQUFTO0FBRWxDLElBQU0seUJBQXlCLENBQUMsTUFBK0IsVUFDNUQsS0FBSyxPQUFPLFNBQVMsZUFBZSxjQUFjLEtBQUssT0FBTyxTQUFTLFNBQ3ZFLEtBQUssT0FBTyxTQUFTLGVBQWUsb0JBQ25DLEtBQUssT0FBTyxPQUFPLFNBQVMsZUFBZSxjQUMzQyxLQUFLLE9BQU8sT0FBTyxTQUFTLFlBQzVCLEtBQUssT0FBTyxTQUFTLFNBQVMsZUFBZSxjQUM3QyxLQUFLLE9BQU8sU0FBUyxTQUFTO0FBRWxDLElBQU0sT0FBcUYsV0FBVztBQUFBLEVBQ3BHLE1BQU07QUFBQSxFQUNOLE1BQU07QUFBQSxJQUNKLE1BQU07QUFBQSxJQUNOLE1BQU07QUFBQSxNQUNKLGFBQWE7QUFBQSxJQUNmO0FBQUEsSUFDQSxRQUFRLENBQUM7QUFBQSxJQUNULFVBQVU7QUFBQSxNQUNSLENBQUMsaUJBQWlCLEdBQUc7QUFBQSxNQUNyQixDQUFDLHFCQUFxQixHQUFHO0FBQUEsSUFDM0I7QUFBQSxFQUNGO0FBQUEsRUFDQSxnQkFBZ0IsQ0FBQztBQUFBLEVBQ2pCLE9BQU8sU0FBUztBQUNkLFVBQU0sVUFBbUIsQ0FBQztBQUUxQixXQUFPO0FBQUEsTUFDTCxrQkFBa0IsTUFBa0M7QUFDbEQsaUNBQXlCLE1BQU0sT0FBTztBQUFBLE1BQ3hDO0FBQUEsTUFDQSxlQUFlLE1BQStCO0FBQzVDLFlBQUksWUFBWSxNQUFNLE9BQU8sR0FBRztBQUM5QixrQkFBUSxPQUFPO0FBQUEsWUFDYjtBQUFBLFlBQ0EsV0FBVztBQUFBLFVBQ2IsQ0FBQztBQUFBLFFBQ0gsV0FBVyx1QkFBdUIsTUFBTSxRQUFRLHlCQUF5QixHQUFHO0FBQzFFLGtCQUFRLE9BQU87QUFBQSxZQUNiO0FBQUEsWUFDQSxXQUFXO0FBQUEsVUFDYixDQUFDO0FBQUEsUUFDSDtBQUFBLE1BQ0Y7QUFBQSxJQUNGO0FBQUEsRUFDRjtBQUNGLENBQUM7QUFFRCxJQUFPLDRCQUFROyIsCiAgIm5hbWVzIjogW10KfQo=
|
|
@@ -1,49 +1,101 @@
|
|
|
1
1
|
// src/no-side-effects.ts
|
|
2
2
|
import { ESLintUtils } from "@typescript-eslint/utils";
|
|
3
3
|
import { TSESTree } from "@typescript-eslint/typescript-estree";
|
|
4
|
+
import getDocumentationUrl from "./get-documentation-url.mjs";
|
|
4
5
|
var ruleId = "no-side-effects";
|
|
5
6
|
var NO_SIDE_EFFECTS = "NO_SIDE_EFFECTS";
|
|
6
|
-
|
|
7
|
-
|
|
8
|
-
|
|
9
|
-
|
|
10
|
-
|
|
11
|
-
|
|
12
|
-
|
|
13
|
-
|
|
14
|
-
|
|
15
|
-
|
|
16
|
-
|
|
17
|
-
|
|
18
|
-
|
|
19
|
-
|
|
20
|
-
}
|
|
21
|
-
|
|
22
|
-
|
|
23
|
-
}
|
|
24
|
-
|
|
25
|
-
|
|
26
|
-
}
|
|
27
|
-
function isVariableDeclarationCallExpression(node, excludedIdentifiers) {
|
|
7
|
+
var isExpressionStatement = (node) => node.type === TSESTree.AST_NODE_TYPES.ExpressionStatement;
|
|
8
|
+
var isAwaitExpression = (statement) => isExpressionStatement(statement) && statement.expression.type === TSESTree.AST_NODE_TYPES.AwaitExpression;
|
|
9
|
+
var isVariableDeclarationAwaitExpression = (node) => node.type === TSESTree.AST_NODE_TYPES.VariableDeclaration && node.declarations.length > 0 && node.declarations[0].init?.type === TSESTree.AST_NODE_TYPES.AwaitExpression;
|
|
10
|
+
var isNotValidVariableDeclaration = (node) => node.type === TSESTree.AST_NODE_TYPES.VariableDeclaration && node.kind !== "const" && node.kind !== "using";
|
|
11
|
+
var isControlFlowStatement = (node) => [
|
|
12
|
+
TSESTree.AST_NODE_TYPES.TryStatement,
|
|
13
|
+
TSESTree.AST_NODE_TYPES.IfStatement,
|
|
14
|
+
TSESTree.AST_NODE_TYPES.SwitchStatement,
|
|
15
|
+
TSESTree.AST_NODE_TYPES.ForStatement,
|
|
16
|
+
TSESTree.AST_NODE_TYPES.WhileStatement,
|
|
17
|
+
TSESTree.AST_NODE_TYPES.DoWhileStatement
|
|
18
|
+
].includes(node.type);
|
|
19
|
+
var isAssignmentExpression = (node) => node.type === TSESTree.AST_NODE_TYPES.ExpressionStatement && node.expression.type === TSESTree.AST_NODE_TYPES.AssignmentExpression;
|
|
20
|
+
var isIdentifierCallee = (node, excludedIdentifiers) => node.callee.type === TSESTree.AST_NODE_TYPES.Identifier && !excludedIdentifiers.includes(node.callee.name);
|
|
21
|
+
var isMemberExpressionCallee = (node, excludedIdentifiers) => node.callee.type === TSESTree.AST_NODE_TYPES.MemberExpression && node.callee.object.type === TSESTree.AST_NODE_TYPES.Identifier && node.callee.property.type === TSESTree.AST_NODE_TYPES.Identifier && !excludedIdentifiers.includes(`${node.callee.object.name}.${node.callee.property.name}`);
|
|
22
|
+
var isNonIdentifierObjectMemberExpressionCallee = (node) => node.callee.type === TSESTree.AST_NODE_TYPES.MemberExpression && node.callee.object.type !== TSESTree.AST_NODE_TYPES.Identifier;
|
|
23
|
+
var isCallExpressionCalleeMemberExpression = (statement, excludedIdentifiers) => isExpressionStatement(statement) && statement.expression.type === TSESTree.AST_NODE_TYPES.CallExpression && statement.expression.callee.type === TSESTree.AST_NODE_TYPES.MemberExpression && statement.expression.callee.object.type === TSESTree.AST_NODE_TYPES.Identifier && statement.expression.callee.property.type === TSESTree.AST_NODE_TYPES.Identifier && !excludedIdentifiers.includes(statement.expression.callee.object.name) && !excludedIdentifiers.includes(
|
|
24
|
+
`${statement.expression.callee.object.name}.${statement.expression.callee.property.name}`
|
|
25
|
+
);
|
|
26
|
+
var isVariableDeclarationCallExpression = (node, excludedIdentifiers) => {
|
|
28
27
|
if (node.type !== TSESTree.AST_NODE_TYPES.VariableDeclaration || node.declarations.length === 0) {
|
|
29
28
|
return false;
|
|
30
29
|
}
|
|
31
|
-
const init = node.declarations[0]
|
|
30
|
+
const init = node.declarations[0].init;
|
|
32
31
|
if (init?.type !== TSESTree.AST_NODE_TYPES.CallExpression) {
|
|
33
32
|
return false;
|
|
34
33
|
}
|
|
34
|
+
const callee = init.callee;
|
|
35
|
+
if (callee.type === TSESTree.AST_NODE_TYPES.ArrowFunctionExpression || callee.type === TSESTree.AST_NODE_TYPES.FunctionExpression) {
|
|
36
|
+
return true;
|
|
37
|
+
}
|
|
35
38
|
return isIdentifierCallee(init, excludedIdentifiers) || isMemberExpressionCallee(init, excludedIdentifiers) || isNonIdentifierObjectMemberExpressionCallee(init);
|
|
36
|
-
}
|
|
37
|
-
|
|
38
|
-
|
|
39
|
-
}
|
|
40
|
-
|
|
39
|
+
};
|
|
40
|
+
var isExportNamedDeclarationWithSideEffects = (statement, excludedIdentifiers) => statement.type === TSESTree.AST_NODE_TYPES.ExportNamedDeclaration && statement.declaration !== null && (isVariableDeclarationAwaitExpression(statement.declaration) || isVariableDeclarationCallExpression(statement.declaration, excludedIdentifiers));
|
|
41
|
+
var isExpressionStatementWithSideEffects = (statement, excludedIdentifiers) => statement.type === TSESTree.AST_NODE_TYPES.ExpressionStatement && statement.expression.type === TSESTree.AST_NODE_TYPES.CallExpression && (statement.expression.callee.type === TSESTree.AST_NODE_TYPES.Identifier && !excludedIdentifiers.includes(statement.expression.callee.name) || statement.expression.callee.type === TSESTree.AST_NODE_TYPES.MemberExpression && statement.expression.callee.object.type === TSESTree.AST_NODE_TYPES.Identifier && statement.expression.callee.property.type === TSESTree.AST_NODE_TYPES.Identifier && !excludedIdentifiers.includes(
|
|
42
|
+
`${statement.expression.callee.object.name}.${statement.expression.callee.property.name}`
|
|
43
|
+
));
|
|
44
|
+
var isVariableDeclarationNewExpression = (node) => {
|
|
45
|
+
if (node.type !== TSESTree.AST_NODE_TYPES.VariableDeclaration || node.declarations.length === 0) {
|
|
46
|
+
return false;
|
|
47
|
+
}
|
|
48
|
+
const init = node.declarations[0].init;
|
|
49
|
+
return init?.type === TSESTree.AST_NODE_TYPES.NewExpression;
|
|
50
|
+
};
|
|
51
|
+
var isFunctionDeclarationAwaitExpression = (node) => node.type === TSESTree.AST_NODE_TYPES.FunctionDeclaration && node.body.body.some(
|
|
52
|
+
(statement) => statement.type === TSESTree.AST_NODE_TYPES.ExpressionStatement && statement.expression.type === TSESTree.AST_NODE_TYPES.AwaitExpression
|
|
53
|
+
);
|
|
54
|
+
var hasSideEffects = (statement, excludedIdentifiers) => {
|
|
55
|
+
if (isAwaitExpression(statement)) {
|
|
56
|
+
return TSESTree.AST_NODE_TYPES.AwaitExpression;
|
|
57
|
+
}
|
|
58
|
+
if (isCallExpressionCalleeMemberExpression(statement, excludedIdentifiers)) {
|
|
59
|
+
return "CallExpressionCalleeMemberExpression";
|
|
60
|
+
}
|
|
61
|
+
if (isVariableDeclarationAwaitExpression(statement)) {
|
|
62
|
+
return "VariableDeclarationAwaitExpression";
|
|
63
|
+
}
|
|
64
|
+
if (isVariableDeclarationCallExpression(statement, excludedIdentifiers)) {
|
|
65
|
+
return "VariableDeclarationCallExpression";
|
|
66
|
+
}
|
|
67
|
+
if (isVariableDeclarationNewExpression(statement)) {
|
|
68
|
+
return "VariableDeclarationNewExpression";
|
|
69
|
+
}
|
|
70
|
+
if (isExportNamedDeclarationWithSideEffects(statement, excludedIdentifiers)) {
|
|
71
|
+
return "ExportNamedDeclarationWithSideEffects";
|
|
72
|
+
}
|
|
73
|
+
if (isExpressionStatementWithSideEffects(statement, excludedIdentifiers)) {
|
|
74
|
+
return "ExpressionStatementWithSideEffects";
|
|
75
|
+
}
|
|
76
|
+
if (isControlFlowStatement(statement)) {
|
|
77
|
+
return "ControlFlowStatement";
|
|
78
|
+
}
|
|
79
|
+
if (isNotValidVariableDeclaration(statement)) {
|
|
80
|
+
return "NotValidVariableDeclaration";
|
|
81
|
+
}
|
|
82
|
+
if (isAssignmentExpression(statement)) {
|
|
83
|
+
return TSESTree.AST_NODE_TYPES.AssignmentExpression;
|
|
84
|
+
}
|
|
85
|
+
if (isFunctionDeclarationAwaitExpression(statement)) {
|
|
86
|
+
return "FunctionDeclarationAwaitExpression";
|
|
87
|
+
}
|
|
88
|
+
return null;
|
|
89
|
+
};
|
|
90
|
+
var createRule = ESLintUtils.RuleCreator(
|
|
91
|
+
(name) => getDocumentationUrl(name)
|
|
92
|
+
);
|
|
41
93
|
var rule = createRule({
|
|
42
94
|
name: ruleId,
|
|
43
95
|
meta: {
|
|
44
96
|
type: "problem",
|
|
45
97
|
docs: {
|
|
46
|
-
description: "Ensure no side effects can occur at the module-level"
|
|
98
|
+
description: "Ensure no side effects can occur at the module-level only if exporting module"
|
|
47
99
|
},
|
|
48
100
|
schema: [
|
|
49
101
|
{
|
|
@@ -74,10 +126,14 @@ var rule = createRule({
|
|
|
74
126
|
return;
|
|
75
127
|
}
|
|
76
128
|
node.body.forEach((statement) => {
|
|
77
|
-
|
|
129
|
+
const sideEffectType = hasSideEffects(statement, excludedIdentifiers);
|
|
130
|
+
if (sideEffectType !== null) {
|
|
78
131
|
context.report({
|
|
79
132
|
node: statement,
|
|
80
|
-
messageId: NO_SIDE_EFFECTS
|
|
133
|
+
messageId: NO_SIDE_EFFECTS,
|
|
134
|
+
data: {
|
|
135
|
+
sideEffectType
|
|
136
|
+
}
|
|
81
137
|
});
|
|
82
138
|
}
|
|
83
139
|
});
|
|
@@ -90,4 +146,4 @@ export {
|
|
|
90
146
|
no_side_effects_default as default,
|
|
91
147
|
ruleId
|
|
92
148
|
};
|
|
93
|
-
//# sourceMappingURL=data:application/json;base64,
|
|
149
|
+
//# sourceMappingURL=data:application/json;base64,ewogICJ2ZXJzaW9uIjogMywKICAic291cmNlcyI6IFsiLi4vc3JjL25vLXNpZGUtZWZmZWN0cy50cyJdLAogICJtYXBwaW5ncyI6ICI7QUFRQSxTQUFTLG1CQUFtQjtBQUM1QixTQUFTLGdCQUFnQjtBQUN6QixPQUFPLHlCQUF5QjtBQU16QixJQUFNLFNBQVM7QUFDdEIsSUFBTSxrQkFBa0I7QUFLeEIsSUFBTSx3QkFBd0IsQ0FBQyxTQUM3QixLQUFLLFNBQVMsU0FBUyxlQUFlO0FBR3hDLElBQU0sb0JBQW9CLENBQUMsY0FDekIsc0JBQXNCLFNBQVMsS0FBSyxVQUFVLFdBQVcsU0FBUyxTQUFTLGVBQWU7QUFHNUYsSUFBTSx1Q0FBdUMsQ0FBQyxTQUM1QyxLQUFLLFNBQVMsU0FBUyxlQUFlLHVCQUN0QyxLQUFLLGFBQWEsU0FBUyxLQUMzQixLQUFLLGFBQWEsQ0FBQyxFQUFFLE1BQU0sU0FBUyxTQUFTLGVBQWU7QUFHOUQsSUFBTSxnQ0FBZ0MsQ0FBQyxTQUNyQyxLQUFLLFNBQVMsU0FBUyxlQUFlLHVCQUF1QixLQUFLLFNBQVMsV0FBVyxLQUFLLFNBQVM7QUFHdEcsSUFBTSx5QkFBeUIsQ0FBQyxTQUM5QjtBQUFBLEVBQ0UsU0FBUyxlQUFlO0FBQUEsRUFDeEIsU0FBUyxlQUFlO0FBQUEsRUFDeEIsU0FBUyxlQUFlO0FBQUEsRUFDeEIsU0FBUyxlQUFlO0FBQUEsRUFDeEIsU0FBUyxlQUFlO0FBQUEsRUFDeEIsU0FBUyxlQUFlO0FBQzFCLEVBQUUsU0FBUyxLQUFLLElBQUk7QUFHdEIsSUFBTSx5QkFBeUIsQ0FBQyxTQUM5QixLQUFLLFNBQVMsU0FBUyxlQUFlLHVCQUN0QyxLQUFLLFdBQVcsU0FBUyxTQUFTLGVBQWU7QUFLbkQsSUFBTSxxQkFBcUIsQ0FBQyxNQUErQix3QkFDekQsS0FBSyxPQUFPLFNBQVMsU0FBUyxlQUFlLGNBQWMsQ0FBQyxvQkFBb0IsU0FBUyxLQUFLLE9BQU8sSUFBSTtBQUczRyxJQUFNLDJCQUEyQixDQUFDLE1BQStCLHdCQUMvRCxLQUFLLE9BQU8sU0FBUyxTQUFTLGVBQWUsb0JBQzdDLEtBQUssT0FBTyxPQUFPLFNBQVMsU0FBUyxlQUFlLGNBQ3BELEtBQUssT0FBTyxTQUFTLFNBQVMsU0FBUyxlQUFlLGNBQ3RELENBQUMsb0JBQW9CLFNBQVMsR0FBRyxLQUFLLE9BQU8sT0FBTyxJQUFJLElBQUksS0FBSyxPQUFPLFNBQVMsSUFBSSxFQUFFO0FBR3pGLElBQU0sOENBQThDLENBQUMsU0FDbkQsS0FBSyxPQUFPLFNBQVMsU0FBUyxlQUFlLG9CQUM3QyxLQUFLLE9BQU8sT0FBTyxTQUFTLFNBQVMsZUFBZTtBQUd0RCxJQUFNLHlDQUF5QyxDQUFDLFdBQTBCLHdCQUN4RSxzQkFBc0IsU0FBUyxLQUMvQixVQUFVLFdBQVcsU0FBUyxTQUFTLGVBQWUsa0JBQ3RELFVBQVUsV0FBVyxPQUFPLFNBQVMsU0FBUyxlQUFlLG9CQUM3RCxVQUFVLFdBQVcsT0FBTyxPQUFPLFNBQVMsU0FBUyxlQUFlLGNBQ3BFLFVBQVUsV0FBVyxPQUFPLFNBQVMsU0FBUyxTQUFTLGVBQWUsY0FDdEUsQ0FBQyxvQkFBb0IsU0FBUyxVQUFVLFdBQVcsT0FBTyxPQUFPLElBQUksS0FDckUsQ0FBQyxvQkFBb0I7QUFBQSxFQUNuQixHQUFHLFVBQVUsV0FBVyxPQUFPLE9BQU8sSUFBSSxJQUFJLFVBQVUsV0FBVyxPQUFPLFNBQVMsSUFBSTtBQUN6RjtBQUdGLElBQU0sc0NBQXNDLENBQUMsTUFBcUIsd0JBQTJDO0FBQzNHLE1BQUksS0FBSyxTQUFTLFNBQVMsZUFBZSx1QkFBdUIsS0FBSyxhQUFhLFdBQVcsR0FBRztBQUMvRixXQUFPO0FBQUEsRUFDVDtBQUVBLFFBQU0sT0FBTyxLQUFLLGFBQWEsQ0FBQyxFQUFFO0FBQ2xDLE1BQUksTUFBTSxTQUFTLFNBQVMsZUFBZSxnQkFBZ0I7QUFDekQsV0FBTztBQUFBLEVBQ1Q7QUFFQSxRQUFNLFNBQVMsS0FBSztBQUNwQixNQUNFLE9BQU8sU0FBUyxTQUFTLGVBQWUsMkJBQ3hDLE9BQU8sU0FBUyxTQUFTLGVBQWUsb0JBQ3hDO0FBQ0EsV0FBTztBQUFBLEVBQ1Q7QUFFQSxTQUNFLG1CQUFtQixNQUFNLG1CQUFtQixLQUM1Qyx5QkFBeUIsTUFBTSxtQkFBbUIsS0FDbEQsNENBQTRDLElBQUk7QUFFcEQ7QUFHQSxJQUFNLDBDQUEwQyxDQUFDLFdBQTBCLHdCQUN6RSxVQUFVLFNBQVMsU0FBUyxlQUFlLDBCQUMzQyxVQUFVLGdCQUFnQixTQUN6QixxQ0FBcUMsVUFBVSxXQUFXLEtBQ3pELG9DQUFvQyxVQUFVLGFBQWEsbUJBQW1CO0FBR2xGLElBQU0sdUNBQXVDLENBQUMsV0FBMEIsd0JBQ3RFLFVBQVUsU0FBUyxTQUFTLGVBQWUsdUJBQzNDLFVBQVUsV0FBVyxTQUFTLFNBQVMsZUFBZSxtQkFDcEQsVUFBVSxXQUFXLE9BQU8sU0FBUyxTQUFTLGVBQWUsY0FDN0QsQ0FBQyxvQkFBb0IsU0FBUyxVQUFVLFdBQVcsT0FBTyxJQUFJLEtBQzdELFVBQVUsV0FBVyxPQUFPLFNBQVMsU0FBUyxlQUFlLG9CQUM1RCxVQUFVLFdBQVcsT0FBTyxPQUFPLFNBQVMsU0FBUyxlQUFlLGNBQ3BFLFVBQVUsV0FBVyxPQUFPLFNBQVMsU0FBUyxTQUFTLGVBQWUsY0FDdEUsQ0FBQyxvQkFBb0I7QUFBQSxFQUNuQixHQUFHLFVBQVUsV0FBVyxPQUFPLE9BQU8sSUFBSSxJQUFJLFVBQVUsV0FBVyxPQUFPLFNBQVMsSUFBSTtBQUN6RjtBQUdOLElBQU0scUNBQXFDLENBQUMsU0FBaUM7QUFDM0UsTUFBSSxLQUFLLFNBQVMsU0FBUyxlQUFlLHVCQUF1QixLQUFLLGFBQWEsV0FBVyxHQUFHO0FBQy9GLFdBQU87QUFBQSxFQUNUO0FBRUEsUUFBTSxPQUFPLEtBQUssYUFBYSxDQUFDLEVBQUU7QUFDbEMsU0FBTyxNQUFNLFNBQVMsU0FBUyxlQUFlO0FBQ2hEO0FBR0EsSUFBTSx1Q0FBdUMsQ0FBQyxTQUM1QyxLQUFLLFNBQVMsU0FBUyxlQUFlLHVCQUN0QyxLQUFLLEtBQUssS0FBSztBQUFBLEVBQ2IsQ0FBQyxjQUNDLFVBQVUsU0FBUyxTQUFTLGVBQWUsdUJBQzNDLFVBQVUsV0FBVyxTQUFTLFNBQVMsZUFBZTtBQUMxRDtBQUdGLElBQU0saUJBQWlCLENBQUMsV0FBMEIsd0JBQWlEO0FBQ2pHLE1BQUksa0JBQWtCLFNBQVMsR0FBRztBQUNoQyxXQUFPLFNBQVMsZUFBZTtBQUFBLEVBQ2pDO0FBQ0EsTUFBSSx1Q0FBdUMsV0FBVyxtQkFBbUIsR0FBRztBQUMxRSxXQUFPO0FBQUEsRUFDVDtBQUNBLE1BQUkscUNBQXFDLFNBQVMsR0FBRztBQUNuRCxXQUFPO0FBQUEsRUFDVDtBQUNBLE1BQUksb0NBQW9DLFdBQVcsbUJBQW1CLEdBQUc7QUFDdkUsV0FBTztBQUFBLEVBQ1Q7QUFDQSxNQUFJLG1DQUFtQyxTQUFTLEdBQUc7QUFDakQsV0FBTztBQUFBLEVBQ1Q7QUFDQSxNQUFJLHdDQUF3QyxXQUFXLG1CQUFtQixHQUFHO0FBQzNFLFdBQU87QUFBQSxFQUNUO0FBQ0EsTUFBSSxxQ0FBcUMsV0FBVyxtQkFBbUIsR0FBRztBQUN4RSxXQUFPO0FBQUEsRUFDVDtBQUNBLE1BQUksdUJBQXVCLFNBQVMsR0FBRztBQUNyQyxXQUFPO0FBQUEsRUFDVDtBQUNBLE1BQUksOEJBQThCLFNBQVMsR0FBRztBQUM1QyxXQUFPO0FBQUEsRUFDVDtBQUNBLE1BQUksdUJBQXVCLFNBQVMsR0FBRztBQUNyQyxXQUFPLFNBQVMsZUFBZTtBQUFBLEVBQ2pDO0FBQ0EsTUFBSSxxQ0FBcUMsU0FBUyxHQUFHO0FBQ25ELFdBQU87QUFBQSxFQUNUO0FBQ0EsU0FBTztBQUNUO0FBRUEsSUFBTSxhQUF5RCxZQUFZO0FBQUEsRUFBWSxDQUFDLFNBQ3RGLG9CQUFvQixJQUFJO0FBQzFCO0FBRUEsSUFBTSxPQUFzQyxXQUFXO0FBQUEsRUFDckQsTUFBTTtBQUFBLEVBQ04sTUFBTTtBQUFBLElBQ0osTUFBTTtBQUFBLElBQ04sTUFBTTtBQUFBLE1BQ0osYUFBYTtBQUFBLElBQ2Y7QUFBQSxJQUNBLFFBQVE7QUFBQSxNQUNOO0FBQUEsUUFDRSxNQUFNO0FBQUEsUUFDTixZQUFZO0FBQUEsVUFDVixxQkFBcUI7QUFBQSxZQUNuQixNQUFNO0FBQUEsWUFDTixPQUFPLEVBQUUsTUFBTSxTQUFTO0FBQUEsVUFDMUI7QUFBQSxRQUNGO0FBQUEsUUFDQSxzQkFBc0I7QUFBQSxNQUN4QjtBQUFBLElBQ0Y7QUFBQSxJQUNBLFVBQVU7QUFBQSxNQUNSLENBQUMsZUFBZSxHQUFHO0FBQUEsSUFDckI7QUFBQSxFQUNGO0FBQUEsRUFDQSxnQkFBZ0IsQ0FBQyxFQUFFLHFCQUFxQixDQUFDLEVBQUUsRUFBRSxDQUFDO0FBQUEsRUFDOUMsT0FBTyxTQUFTO0FBQ2QsVUFBTSxVQUF1QixRQUFRLFFBQVEsQ0FBQztBQUM5QyxVQUFNLHNCQUFzQixRQUFRLG9CQUFvQixTQUFTLElBQUksUUFBUSxzQkFBc0IsQ0FBQztBQUNwRyxXQUFPO0FBQUEsTUFDTCxRQUFRLE1BQXdCO0FBQzlCLGNBQU0sWUFBWSxLQUFLLEtBQUs7QUFBQSxVQUMxQixDQUFDLGNBQ0MsVUFBVSxTQUFTLFNBQVMsZUFBZSwwQkFDM0MsVUFBVSxTQUFTLFNBQVMsZUFBZSw0QkFDM0MsVUFBVSxTQUFTLFNBQVMsZUFBZTtBQUFBLFFBQy9DO0FBRUEsWUFBSSxDQUFDLFdBQVc7QUFDZDtBQUFBLFFBQ0Y7QUFFQSxhQUFLLEtBQUssUUFBUSxDQUFDLGNBQTZCO0FBQzlDLGdCQUFNLGlCQUFpQixlQUFlLFdBQVcsbUJBQW1CO0FBQ3BFLGNBQUksbUJBQW1CLE1BQU07QUFDM0Isb0JBQVEsT0FBTztBQUFBLGNBQ2IsTUFBTTtBQUFBLGNBQ04sV0FBVztBQUFBLGNBQ1gsTUFBTTtBQUFBLGdCQUNKO0FBQUEsY0FDRjtBQUFBLFlBQ0YsQ0FBQztBQUFBLFVBQ0g7QUFBQSxRQUNGLENBQUM7QUFBQSxNQUNIO0FBQUEsSUFDRjtBQUFBLEVBQ0Y7QUFDRixDQUFDO0FBRUQsSUFBTywwQkFBUTsiLAogICJuYW1lcyI6IFtdCn0K
|
|
@@ -19,15 +19,7 @@ var rule = createRule({
|
|
|
19
19
|
create(context) {
|
|
20
20
|
return {
|
|
21
21
|
TSAsExpression(node) {
|
|
22
|
-
|
|
23
|
-
if (node.typeAnnotation.type === AST_NODE_TYPES.TSUnknownKeyword || node.expression.type === AST_NODE_TYPES.TSAsExpression && node.expression.typeAnnotation.type === AST_NODE_TYPES.TSUnknownKeyword || isUnknownUnionOrIntersection) {
|
|
24
|
-
if (node.parent.type !== AST_NODE_TYPES.TSAsExpression) {
|
|
25
|
-
context.report({
|
|
26
|
-
node,
|
|
27
|
-
messageId: NO_AS_TYPE_ASSERTION
|
|
28
|
-
});
|
|
29
|
-
}
|
|
30
|
-
} else {
|
|
22
|
+
if (node.parent.type !== AST_NODE_TYPES.TSAsExpression) {
|
|
31
23
|
context.report({
|
|
32
24
|
node,
|
|
33
25
|
messageId: NO_AS_TYPE_ASSERTION
|
|
@@ -42,4 +34,4 @@ export {
|
|
|
42
34
|
no_type_assertion_as_default as default,
|
|
43
35
|
ruleId
|
|
44
36
|
};
|
|
45
|
-
//# sourceMappingURL=data:application/json;base64,
|
|
37
|
+
//# sourceMappingURL=data:application/json;base64,ewogICJ2ZXJzaW9uIjogMywKICAic291cmNlcyI6IFsiLi4vc3JjL25vLXR5cGUtYXNzZXJ0aW9uLWFzLnRzIl0sCiAgIm1hcHBpbmdzIjogIjtBQVFBLFNBQVMsZ0JBQWdCLG1CQUE2QjtBQUUvQyxJQUFNLFNBQVM7QUFDdEIsSUFBTSx1QkFBdUI7QUFFN0IsSUFBTSxhQUFhLFlBQVksWUFBWSxDQUFDLFNBQVMsSUFBSTtBQUV6RCxJQUFNLE9BQTRELFdBQVc7QUFBQSxFQUMzRSxNQUFNO0FBQUEsRUFDTixNQUFNO0FBQUEsSUFDSixNQUFNO0FBQUEsSUFDTixNQUFNO0FBQUEsTUFDSixhQUFhO0FBQUEsSUFDZjtBQUFBLElBQ0EsUUFBUSxDQUFDO0FBQUEsSUFDVCxVQUFVO0FBQUEsTUFDUixDQUFDLG9CQUFvQixHQUFHO0FBQUEsSUFDMUI7QUFBQSxFQUNGO0FBQUEsRUFDQSxnQkFBZ0IsQ0FBQztBQUFBLEVBQ2pCLE9BQU8sU0FBUztBQUNkLFdBQU87QUFBQSxNQUNMLGVBQWUsTUFBK0I7QUFDNUMsWUFBSSxLQUFLLE9BQU8sU0FBUyxlQUFlLGdCQUFnQjtBQUN0RCxrQkFBUSxPQUFPO0FBQUEsWUFDYjtBQUFBLFlBQ0EsV0FBVztBQUFBLFVBQ2IsQ0FBQztBQUFBLFFBQ0g7QUFBQSxNQUNGO0FBQUEsSUFDRjtBQUFBLEVBQ0Y7QUFDRixDQUFDO0FBRUQsSUFBTywrQkFBUTsiLAogICJuYW1lcyI6IFtdCn0K
|
package/package.json
CHANGED
|
@@ -1 +1 @@
|
|
|
1
|
-
{"name":"@checkdigit/eslint-plugin","version":"7.14.0-PR.117-
|
|
1
|
+
{"name":"@checkdigit/eslint-plugin","version":"7.14.0-PR.117-a113","description":"Check Digit eslint plugins","keywords":["eslint","eslintplugin"],"homepage":"https://github.com/checkdigit/eslint-plugin#readme","bugs":{"url":"https://github.com/checkdigit/eslint-plugin/issues"},"repository":{"type":"git","url":"https://github.com/checkdigit/eslint-plugin"},"license":"MIT","author":"Check Digit, LLC","sideEffects":false,"type":"module","exports":{".":{"types":"./dist-types/index.d.ts","import":"./dist-mjs/index.mjs","default":"./dist-mjs/index.mjs"}},"files":["src","dist-types","dist-mjs","!src/**/test/**","!src/**/*.test.ts","!src/**/*.spec.ts","!dist-types/**/test/**","!dist-types/**/*.test.d.ts","!dist-types/**/*.spec.d.ts","!dist-mjs/**/test/**","!dist-mjs/**/*.test.mjs","!dist-mjs/**/*.spec.mjs","SECURITY.md"],"scripts":{"build:dist-mjs":"rimraf dist-mjs && npx builder --type=module --sourceMap --outDir=dist-mjs && node dist-mjs/index.mjs","build:dist-types":"rimraf dist-types && npx builder --type=types --outDir=dist-types","ci:compile":"tsc --noEmit","ci:coverage":"NODE_OPTIONS=\"--disable-warning ExperimentalWarning --experimental-vm-modules\" jest --coverage=true","ci:lint":"npm run lint","ci:style":"npm run prettier","ci:test":"NODE_OPTIONS=\"--disable-warning ExperimentalWarning --experimental-vm-modules\" jest --coverage=false","lint":"eslint --max-warnings 0 .","lint:fix":"eslint --max-warnings 0 --fix .","prepare":"","prepublishOnly":"npm run build:dist-types && npm run build:dist-mjs","prettier":"prettier --ignore-path .gitignore --list-different .","prettier:fix":"prettier --ignore-path .gitignore --write .","test":"npm run ci:compile && npm run ci:test && npm run ci:lint && npm run ci:style"},"prettier":"@checkdigit/prettier-config","jest":{"preset":"@checkdigit/jest-config"},"dependencies":{"@typescript-eslint/type-utils":"^8.23.0","@typescript-eslint/utils":"^8.23.0","http-status-codes":"^2.3.0","ts-api-utils":"^2.0.1"},"devDependencies":{"@checkdigit/jest-config":"^6.0.2","@checkdigit/prettier-config":"^6.1.0","@checkdigit/typescript-config":"^9.0.0","@eslint/js":"^9.19.0","@types/eslint":"^9.6.1","@types/eslint-config-prettier":"^6.11.3","@typescript-eslint/parser":"^8.23.0","@typescript-eslint/rule-tester":"^8.23.0","eslint":"^9.19.0","eslint-config-prettier":"^10.0.1","eslint-import-resolver-typescript":"^3.7.0","eslint-plugin-eslint-plugin":"^6.4.0","eslint-plugin-import":"^2.31.0","eslint-plugin-no-only-tests":"^3.3.0","eslint-plugin-no-secrets":"^2.2.1","eslint-plugin-node":"^11.1.0","eslint-plugin-sonarjs":"1.0.4","rimraf":"^6.0.1","typescript-eslint":"^8.23.0"},"peerDependencies":{"eslint":">=9 <10"},"engines":{"node":">=22.14"}}
|
package/src/index.ts
CHANGED
|
@@ -92,10 +92,7 @@ const configs: Record<string, TSESLint.FlatConfig.Config[]> = {
|
|
|
92
92
|
'@checkdigit/require-strict-assert': 'error',
|
|
93
93
|
'@checkdigit/require-ts-extension-imports-exports': 'error',
|
|
94
94
|
'@checkdigit/no-wallaby-comment': 'error',
|
|
95
|
-
'@checkdigit/no-side-effects':
|
|
96
|
-
'error',
|
|
97
|
-
{ excludedIdentifiers: ['assert', 'debug', 'log', 'promisify', 'Symbol.for'] },
|
|
98
|
-
],
|
|
95
|
+
'@checkdigit/no-side-effects': 'error',
|
|
99
96
|
'@checkdigit/no-type-assertion-as': 'error',
|
|
100
97
|
'@checkdigit/regular-expression-comment': 'error',
|
|
101
98
|
'@checkdigit/require-assert-predicate-rejects-throws': 'error',
|
package/src/no-random-v4-uuid.ts
CHANGED
|
@@ -64,13 +64,12 @@ const rule: TSESLint.RuleModule<typeof NO_RANDOM_V4_UUID | typeof NO_UUID_MODULE
|
|
|
64
64
|
meta: {
|
|
65
65
|
type: 'problem',
|
|
66
66
|
docs: {
|
|
67
|
-
description:
|
|
68
|
-
'Disallow the use of `uuid.v4` and `crypto.randomUUID` for generating random v4 UUIDs, and suggest replacing `uuid` module usage with `crypto.randomUUID`.',
|
|
67
|
+
description: 'Disallow the use of `uuid.v4` and `crypto.randomUUID` for generating random v4 UUIDs.',
|
|
69
68
|
},
|
|
70
69
|
schema: [],
|
|
71
70
|
messages: {
|
|
72
|
-
[NO_RANDOM_V4_UUID]: 'Avoid
|
|
73
|
-
[NO_UUID_MODULE_FOR_V4]: 'Avoid using the `uuid` module for v4 UUID generation
|
|
71
|
+
[NO_RANDOM_V4_UUID]: 'Avoid generating v4 UUIDs',
|
|
72
|
+
[NO_UUID_MODULE_FOR_V4]: 'Avoid using the `uuid` module for v4 UUID generation',
|
|
74
73
|
},
|
|
75
74
|
},
|
|
76
75
|
defaultOptions: [],
|
package/src/no-side-effects.ts
CHANGED
|
@@ -1,13 +1,14 @@
|
|
|
1
1
|
// no-side-effects.ts
|
|
2
2
|
|
|
3
3
|
/*
|
|
4
|
-
* Copyright (c) 2022-
|
|
4
|
+
* Copyright (c) 2022-2025 Check Digit, LLC
|
|
5
5
|
*
|
|
6
6
|
* This code is licensed under the MIT license (see LICENSE.txt for details).
|
|
7
7
|
*/
|
|
8
8
|
|
|
9
9
|
import { ESLintUtils } from '@typescript-eslint/utils';
|
|
10
10
|
import { TSESTree } from '@typescript-eslint/typescript-estree';
|
|
11
|
+
import getDocumentationUrl from './get-documentation-url.ts';
|
|
11
12
|
|
|
12
13
|
interface RuleOptions {
|
|
13
14
|
excludedIdentifiers: string[];
|
|
@@ -16,99 +17,185 @@ interface RuleOptions {
|
|
|
16
17
|
export const ruleId = 'no-side-effects';
|
|
17
18
|
const NO_SIDE_EFFECTS = 'NO_SIDE_EFFECTS';
|
|
18
19
|
|
|
19
|
-
// Type
|
|
20
|
-
|
|
21
|
-
|
|
22
|
-
|
|
23
|
-
|
|
24
|
-
|
|
25
|
-
|
|
26
|
-
|
|
27
|
-
|
|
28
|
-
|
|
29
|
-
//
|
|
30
|
-
|
|
31
|
-
|
|
32
|
-
|
|
33
|
-
|
|
34
|
-
|
|
35
|
-
|
|
36
|
-
|
|
37
|
-
|
|
38
|
-
|
|
39
|
-
|
|
40
|
-
|
|
41
|
-
|
|
42
|
-
|
|
43
|
-
|
|
44
|
-
|
|
45
|
-
|
|
46
|
-
|
|
47
|
-
|
|
48
|
-
|
|
49
|
-
|
|
50
|
-
|
|
51
|
-
|
|
52
|
-
|
|
53
|
-
|
|
54
|
-
|
|
55
|
-
|
|
56
|
-
|
|
57
|
-
|
|
58
|
-
|
|
59
|
-
|
|
60
|
-
|
|
20
|
+
// Type guards
|
|
21
|
+
|
|
22
|
+
// Checks if a node is an ExpressionStatement
|
|
23
|
+
const isExpressionStatement = (node: TSESTree.Node): node is TSESTree.ExpressionStatement =>
|
|
24
|
+
node.type === TSESTree.AST_NODE_TYPES.ExpressionStatement;
|
|
25
|
+
|
|
26
|
+
// Checks if a statement is an AwaitExpression
|
|
27
|
+
const isAwaitExpression = (statement: TSESTree.Node): boolean =>
|
|
28
|
+
isExpressionStatement(statement) && statement.expression.type === TSESTree.AST_NODE_TYPES.AwaitExpression;
|
|
29
|
+
|
|
30
|
+
// Checks if a node is a VariableDeclaration with an AwaitExpression
|
|
31
|
+
const isVariableDeclarationAwaitExpression = (node: TSESTree.Node): boolean =>
|
|
32
|
+
node.type === TSESTree.AST_NODE_TYPES.VariableDeclaration &&
|
|
33
|
+
node.declarations.length > 0 &&
|
|
34
|
+
node.declarations[0].init?.type === TSESTree.AST_NODE_TYPES.AwaitExpression;
|
|
35
|
+
|
|
36
|
+
// Checks if a node is a VariableDeclaration that is not const or using
|
|
37
|
+
const isNotValidVariableDeclaration = (node: TSESTree.Node): boolean =>
|
|
38
|
+
node.type === TSESTree.AST_NODE_TYPES.VariableDeclaration && node.kind !== 'const' && node.kind !== 'using';
|
|
39
|
+
|
|
40
|
+
// Checks if a node is a control flow statement
|
|
41
|
+
const isControlFlowStatement = (node: TSESTree.Node): boolean =>
|
|
42
|
+
[
|
|
43
|
+
TSESTree.AST_NODE_TYPES.TryStatement,
|
|
44
|
+
TSESTree.AST_NODE_TYPES.IfStatement,
|
|
45
|
+
TSESTree.AST_NODE_TYPES.SwitchStatement,
|
|
46
|
+
TSESTree.AST_NODE_TYPES.ForStatement,
|
|
47
|
+
TSESTree.AST_NODE_TYPES.WhileStatement,
|
|
48
|
+
TSESTree.AST_NODE_TYPES.DoWhileStatement,
|
|
49
|
+
].includes(node.type);
|
|
50
|
+
|
|
51
|
+
// Checks if a node is an AssignmentExpression
|
|
52
|
+
const isAssignmentExpression = (node: TSESTree.Node): boolean =>
|
|
53
|
+
node.type === TSESTree.AST_NODE_TYPES.ExpressionStatement &&
|
|
54
|
+
node.expression.type === TSESTree.AST_NODE_TYPES.AssignmentExpression;
|
|
55
|
+
|
|
56
|
+
// Helper functions
|
|
57
|
+
|
|
58
|
+
// Checks if the callee is an identifier and not excluded
|
|
59
|
+
const isIdentifierCallee = (node: TSESTree.CallExpression, excludedIdentifiers: string[]): boolean =>
|
|
60
|
+
node.callee.type === TSESTree.AST_NODE_TYPES.Identifier && !excludedIdentifiers.includes(node.callee.name);
|
|
61
|
+
|
|
62
|
+
// Checks if the callee is a member expression and not excluded
|
|
63
|
+
const isMemberExpressionCallee = (node: TSESTree.CallExpression, excludedIdentifiers: string[]): boolean =>
|
|
64
|
+
node.callee.type === TSESTree.AST_NODE_TYPES.MemberExpression &&
|
|
65
|
+
node.callee.object.type === TSESTree.AST_NODE_TYPES.Identifier &&
|
|
66
|
+
node.callee.property.type === TSESTree.AST_NODE_TYPES.Identifier &&
|
|
67
|
+
!excludedIdentifiers.includes(`${node.callee.object.name}.${node.callee.property.name}`);
|
|
68
|
+
|
|
69
|
+
// Checks if the callee is a member expression with a non-identifier object
|
|
70
|
+
const isNonIdentifierObjectMemberExpressionCallee = (node: TSESTree.CallExpression): boolean =>
|
|
71
|
+
node.callee.type === TSESTree.AST_NODE_TYPES.MemberExpression &&
|
|
72
|
+
node.callee.object.type !== TSESTree.AST_NODE_TYPES.Identifier;
|
|
73
|
+
|
|
74
|
+
// Checks if a statement is a CallExpression with a member expression callee
|
|
75
|
+
const isCallExpressionCalleeMemberExpression = (statement: TSESTree.Node, excludedIdentifiers: string[]): boolean =>
|
|
76
|
+
isExpressionStatement(statement) &&
|
|
77
|
+
statement.expression.type === TSESTree.AST_NODE_TYPES.CallExpression &&
|
|
78
|
+
statement.expression.callee.type === TSESTree.AST_NODE_TYPES.MemberExpression &&
|
|
79
|
+
statement.expression.callee.object.type === TSESTree.AST_NODE_TYPES.Identifier &&
|
|
80
|
+
statement.expression.callee.property.type === TSESTree.AST_NODE_TYPES.Identifier &&
|
|
81
|
+
!excludedIdentifiers.includes(statement.expression.callee.object.name) &&
|
|
82
|
+
!excludedIdentifiers.includes(
|
|
83
|
+
`${statement.expression.callee.object.name}.${statement.expression.callee.property.name}`,
|
|
61
84
|
);
|
|
62
|
-
}
|
|
63
|
-
|
|
64
|
-
// Helper function to check if the callee is a member expression with a non-identifier object
|
|
65
|
-
function isNonIdentifierObjectMemberExpressionCallee(node: TSESTree.CallExpression): boolean {
|
|
66
|
-
return (
|
|
67
|
-
node.callee.type === TSESTree.AST_NODE_TYPES.MemberExpression &&
|
|
68
|
-
node.callee.object.type !== TSESTree.AST_NODE_TYPES.Identifier
|
|
69
|
-
);
|
|
70
|
-
}
|
|
71
85
|
|
|
72
|
-
//
|
|
73
|
-
|
|
86
|
+
// Checks if a node is a VariableDeclaration with a CallExpression
|
|
87
|
+
const isVariableDeclarationCallExpression = (node: TSESTree.Node, excludedIdentifiers: string[]): boolean => {
|
|
74
88
|
if (node.type !== TSESTree.AST_NODE_TYPES.VariableDeclaration || node.declarations.length === 0) {
|
|
75
89
|
return false;
|
|
76
90
|
}
|
|
77
91
|
|
|
78
|
-
const init = node.declarations[0]
|
|
92
|
+
const init = node.declarations[0].init;
|
|
79
93
|
if (init?.type !== TSESTree.AST_NODE_TYPES.CallExpression) {
|
|
80
94
|
return false;
|
|
81
95
|
}
|
|
82
96
|
|
|
97
|
+
const callee = init.callee;
|
|
98
|
+
if (
|
|
99
|
+
callee.type === TSESTree.AST_NODE_TYPES.ArrowFunctionExpression ||
|
|
100
|
+
callee.type === TSESTree.AST_NODE_TYPES.FunctionExpression
|
|
101
|
+
) {
|
|
102
|
+
return true;
|
|
103
|
+
}
|
|
104
|
+
|
|
83
105
|
return (
|
|
84
106
|
isIdentifierCallee(init, excludedIdentifiers) ||
|
|
85
107
|
isMemberExpressionCallee(init, excludedIdentifiers) ||
|
|
86
108
|
isNonIdentifierObjectMemberExpressionCallee(init)
|
|
87
109
|
);
|
|
88
|
-
}
|
|
110
|
+
};
|
|
111
|
+
|
|
112
|
+
// Checks if an ExportNamedDeclaration has side effects
|
|
113
|
+
const isExportNamedDeclarationWithSideEffects = (statement: TSESTree.Node, excludedIdentifiers: string[]): boolean =>
|
|
114
|
+
statement.type === TSESTree.AST_NODE_TYPES.ExportNamedDeclaration &&
|
|
115
|
+
statement.declaration !== null &&
|
|
116
|
+
(isVariableDeclarationAwaitExpression(statement.declaration) ||
|
|
117
|
+
isVariableDeclarationCallExpression(statement.declaration, excludedIdentifiers));
|
|
118
|
+
|
|
119
|
+
// Checks if an ExpressionStatement has side effects
|
|
120
|
+
const isExpressionStatementWithSideEffects = (statement: TSESTree.Node, excludedIdentifiers: string[]): boolean =>
|
|
121
|
+
statement.type === TSESTree.AST_NODE_TYPES.ExpressionStatement &&
|
|
122
|
+
statement.expression.type === TSESTree.AST_NODE_TYPES.CallExpression &&
|
|
123
|
+
((statement.expression.callee.type === TSESTree.AST_NODE_TYPES.Identifier &&
|
|
124
|
+
!excludedIdentifiers.includes(statement.expression.callee.name)) ||
|
|
125
|
+
(statement.expression.callee.type === TSESTree.AST_NODE_TYPES.MemberExpression &&
|
|
126
|
+
statement.expression.callee.object.type === TSESTree.AST_NODE_TYPES.Identifier &&
|
|
127
|
+
statement.expression.callee.property.type === TSESTree.AST_NODE_TYPES.Identifier &&
|
|
128
|
+
!excludedIdentifiers.includes(
|
|
129
|
+
`${statement.expression.callee.object.name}.${statement.expression.callee.property.name}`,
|
|
130
|
+
)));
|
|
131
|
+
|
|
132
|
+
// Checks if a node is a VariableDeclaration with a NewExpression
|
|
133
|
+
const isVariableDeclarationNewExpression = (node: TSESTree.Node): boolean => {
|
|
134
|
+
if (node.type !== TSESTree.AST_NODE_TYPES.VariableDeclaration || node.declarations.length === 0) {
|
|
135
|
+
return false;
|
|
136
|
+
}
|
|
89
137
|
|
|
90
|
-
|
|
91
|
-
|
|
92
|
-
|
|
93
|
-
|
|
94
|
-
|
|
95
|
-
|
|
96
|
-
|
|
97
|
-
|
|
98
|
-
|
|
99
|
-
|
|
100
|
-
|
|
138
|
+
const init = node.declarations[0].init;
|
|
139
|
+
return init?.type === TSESTree.AST_NODE_TYPES.NewExpression;
|
|
140
|
+
};
|
|
141
|
+
|
|
142
|
+
// Checks if a node is a FunctionDeclaration with an AwaitExpression
|
|
143
|
+
const isFunctionDeclarationAwaitExpression = (node: TSESTree.Node): boolean =>
|
|
144
|
+
node.type === TSESTree.AST_NODE_TYPES.FunctionDeclaration &&
|
|
145
|
+
node.body.body.some(
|
|
146
|
+
(statement) =>
|
|
147
|
+
statement.type === TSESTree.AST_NODE_TYPES.ExpressionStatement &&
|
|
148
|
+
statement.expression.type === TSESTree.AST_NODE_TYPES.AwaitExpression,
|
|
101
149
|
);
|
|
102
|
-
}
|
|
103
150
|
|
|
104
|
-
|
|
151
|
+
// Update the hasSideEffects function to return a string indicating the type of side effect
|
|
152
|
+
const hasSideEffects = (statement: TSESTree.Node, excludedIdentifiers: string[]): string | null => {
|
|
153
|
+
if (isAwaitExpression(statement)) {
|
|
154
|
+
return TSESTree.AST_NODE_TYPES.AwaitExpression;
|
|
155
|
+
}
|
|
156
|
+
if (isCallExpressionCalleeMemberExpression(statement, excludedIdentifiers)) {
|
|
157
|
+
return 'CallExpressionCalleeMemberExpression';
|
|
158
|
+
}
|
|
159
|
+
if (isVariableDeclarationAwaitExpression(statement)) {
|
|
160
|
+
return 'VariableDeclarationAwaitExpression';
|
|
161
|
+
}
|
|
162
|
+
if (isVariableDeclarationCallExpression(statement, excludedIdentifiers)) {
|
|
163
|
+
return 'VariableDeclarationCallExpression';
|
|
164
|
+
}
|
|
165
|
+
if (isVariableDeclarationNewExpression(statement)) {
|
|
166
|
+
return 'VariableDeclarationNewExpression';
|
|
167
|
+
}
|
|
168
|
+
if (isExportNamedDeclarationWithSideEffects(statement, excludedIdentifiers)) {
|
|
169
|
+
return 'ExportNamedDeclarationWithSideEffects';
|
|
170
|
+
}
|
|
171
|
+
if (isExpressionStatementWithSideEffects(statement, excludedIdentifiers)) {
|
|
172
|
+
return 'ExpressionStatementWithSideEffects';
|
|
173
|
+
}
|
|
174
|
+
if (isControlFlowStatement(statement)) {
|
|
175
|
+
return 'ControlFlowStatement';
|
|
176
|
+
}
|
|
177
|
+
if (isNotValidVariableDeclaration(statement)) {
|
|
178
|
+
return 'NotValidVariableDeclaration';
|
|
179
|
+
}
|
|
180
|
+
if (isAssignmentExpression(statement)) {
|
|
181
|
+
return TSESTree.AST_NODE_TYPES.AssignmentExpression;
|
|
182
|
+
}
|
|
183
|
+
if (isFunctionDeclarationAwaitExpression(statement)) {
|
|
184
|
+
return 'FunctionDeclarationAwaitExpression';
|
|
185
|
+
}
|
|
186
|
+
return null;
|
|
187
|
+
};
|
|
188
|
+
|
|
189
|
+
const createRule: ReturnType<typeof ESLintUtils.RuleCreator> = ESLintUtils.RuleCreator((name) =>
|
|
190
|
+
getDocumentationUrl(name),
|
|
191
|
+
);
|
|
105
192
|
|
|
106
193
|
const rule: ReturnType<typeof createRule> = createRule({
|
|
107
194
|
name: ruleId,
|
|
108
195
|
meta: {
|
|
109
196
|
type: 'problem',
|
|
110
197
|
docs: {
|
|
111
|
-
description: 'Ensure no side effects can occur at the module-level',
|
|
198
|
+
description: 'Ensure no side effects can occur at the module-level only if exporting module',
|
|
112
199
|
},
|
|
113
200
|
schema: [
|
|
114
201
|
{
|
|
@@ -144,10 +231,14 @@ const rule: ReturnType<typeof createRule> = createRule({
|
|
|
144
231
|
}
|
|
145
232
|
|
|
146
233
|
node.body.forEach((statement: TSESTree.Node) => {
|
|
147
|
-
|
|
234
|
+
const sideEffectType = hasSideEffects(statement, excludedIdentifiers);
|
|
235
|
+
if (sideEffectType !== null) {
|
|
148
236
|
context.report({
|
|
149
237
|
node: statement,
|
|
150
238
|
messageId: NO_SIDE_EFFECTS,
|
|
239
|
+
data: {
|
|
240
|
+
sideEffectType,
|
|
241
|
+
},
|
|
151
242
|
});
|
|
152
243
|
}
|
|
153
244
|
});
|
|
@@ -29,24 +29,7 @@ const rule: ESLintUtils.RuleModule<typeof NO_AS_TYPE_ASSERTION> = createRule({
|
|
|
29
29
|
create(context) {
|
|
30
30
|
return {
|
|
31
31
|
TSAsExpression(node: TSESTree.TSAsExpression) {
|
|
32
|
-
|
|
33
|
-
(node.typeAnnotation.type === AST_NODE_TYPES.TSUnionType ||
|
|
34
|
-
node.typeAnnotation.type === AST_NODE_TYPES.TSIntersectionType) &&
|
|
35
|
-
node.typeAnnotation.types.some((type) => type.type === AST_NODE_TYPES.TSUnknownKeyword);
|
|
36
|
-
|
|
37
|
-
if (
|
|
38
|
-
node.typeAnnotation.type === AST_NODE_TYPES.TSUnknownKeyword ||
|
|
39
|
-
(node.expression.type === AST_NODE_TYPES.TSAsExpression &&
|
|
40
|
-
node.expression.typeAnnotation.type === AST_NODE_TYPES.TSUnknownKeyword) ||
|
|
41
|
-
isUnknownUnionOrIntersection
|
|
42
|
-
) {
|
|
43
|
-
if (node.parent.type !== AST_NODE_TYPES.TSAsExpression) {
|
|
44
|
-
context.report({
|
|
45
|
-
node,
|
|
46
|
-
messageId: NO_AS_TYPE_ASSERTION,
|
|
47
|
-
});
|
|
48
|
-
}
|
|
49
|
-
} else {
|
|
32
|
+
if (node.parent.type !== AST_NODE_TYPES.TSAsExpression) {
|
|
50
33
|
context.report({
|
|
51
34
|
node,
|
|
52
35
|
messageId: NO_AS_TYPE_ASSERTION,
|