@checkdigit/eslint-plugin 6.6.0-PR.79-7a20 → 6.7.0-PR.79-33df

package/dist-mjs/require-resolve-full-response.mjs

@@ -0,0 +1,159 @@
+// src/require-resolve-full-response.ts
+import { AST_NODE_TYPES, ESLintUtils } from "@typescript-eslint/utils";
+import { DefinitionType } from "@typescript-eslint/scope-manager";
+import { strict as assert } from "node:assert";
+import getDocumentationUrl from "./get-documentation-url.mjs";
+import { getEnclosingScopeNode } from "./library/ts-tree.mjs";
+var ruleId = "require-resolve-full-response";
+var PLAIN_URL_REGEXP = /^[`']\/\w+(?<serviceNamePart>-\w+)*\/v\d+\/(?<any>.|\r|\n)+[`']$/u;
+var TOKENIZED_URL_REGEXP = /^`\$\{(?<serviceNamePart>[A-Z]+_)*BASE_PATH\}\/(?<any>.|\r|\n)+`$/u;
+var createRule = ESLintUtils.RuleCreator((name) => getDocumentationUrl(name));
+var rule = createRule({
+  name: ruleId,
+  meta: {
+    type: "suggestion",
+    docs: {
+      description: "Prefer native fetch over customized service wrapper."
+    },
+    messages: {
+      invalidOptions: '"options" argument should be provided with "resolveWithFullResponse" property set as "true". Otherwise, it indicates that the response body will be obtained without status code assertion which could result in unexpected issue.',
+      unknownError: 'Unknown error occurred in file "{{fileName}}": {{ error }}.'
+    },
+    schema: []
+  },
+  defaultOptions: [],
+  create(context) {
+    const sourceCode = context.sourceCode;
+    const scopeManager = sourceCode.scopeManager;
+    const parserService = ESLintUtils.getParserServices(context);
+    const typeChecker = parserService.program.getTypeChecker();
+    function isUrlArgumentValid(urlArgument, scope) {
+      if (urlArgument?.type === AST_NODE_TYPES.Literal && typeof urlArgument.value === "string" || urlArgument?.type === AST_NODE_TYPES.TemplateLiteral) {
+        const urlText = sourceCode.getText(urlArgument);
+        return PLAIN_URL_REGEXP.test(urlText) || TOKENIZED_URL_REGEXP.test(urlText);
+      }
+      if (urlArgument?.type === AST_NODE_TYPES.Identifier) {
+        const foundVariable = scope.variables.find((variable) => variable.name === urlArgument.name);
+        if (foundVariable) {
+          const variableDefinition = foundVariable.defs.find((def) => def.type === DefinitionType.Variable);
+          assert.ok(variableDefinition, `Variable "${urlArgument.name}" not defined in scope`);
+          const variableDefinitionNode = variableDefinition.node;
+          assert.ok(variableDefinitionNode.type === AST_NODE_TYPES.VariableDeclarator);
+          assert.ok(variableDefinitionNode.init, "Variable definition node has no init property");
+          return isUrlArgumentValid(variableDefinitionNode.init, scope);
+        }
+      }
+      return false;
+    }
+    function getType(identifier) {
+      const variable = parserService.esTreeNodeToTSNodeMap.get(identifier);
+      const variableType = typeChecker.getTypeAtLocation(variable);
+      return typeChecker.typeToString(variableType);
+    }
+    function isServiceLikeName(name) {
+      return /.*[Ss]ervice$/u.test(name);
+    }
+    function isCalleeServiceWrapper(serviceCall) {
+      const callee = serviceCall.callee;
+      if (callee.type !== AST_NODE_TYPES.MemberExpression) {
+        return false;
+      }
+      const endpoint = callee.object;
+      if (endpoint.type === AST_NODE_TYPES.Identifier) {
+        return getType(endpoint) === "Endpoint" || isServiceLikeName(endpoint.name);
+      }
+      if (endpoint.type !== AST_NODE_TYPES.CallExpression) {
+        return false;
+      }
+      const [contextArgument] = endpoint.arguments;
+      if (contextArgument?.type !== AST_NODE_TYPES.Identifier) {
+        return false;
+      }
+      if (contextArgument.name !== "EMPTY_CONTEXT" && getType(contextArgument) !== "InboundContext") {
+        return false;
+      }
+      const service = endpoint.callee;
+      if (service.type === AST_NODE_TYPES.Identifier) {
+        return getType(service) === "ResolvedService";
+      }
+      if (service.type !== AST_NODE_TYPES.MemberExpression) {
+        return false;
+      }
+      const services = service.object;
+      if (services.type === AST_NODE_TYPES.Identifier) {
+        return getType(services) === "ResolvedServices";
+      }
+      if (services.type !== AST_NODE_TYPES.MemberExpression) {
+        return false;
+      }
+      const configuration = services.object;
+      if (configuration.type === AST_NODE_TYPES.Identifier) {
+        return ["Configuration", "Configuration<ResolvedServices>"].includes(getType(configuration));
+      }
+      if (configuration.type !== AST_NODE_TYPES.MemberExpression) {
+        return false;
+      }
+      const fixture = configuration.object;
+      if (fixture.type === AST_NODE_TYPES.Identifier) {
+        return fixture.name === "fixture" || getType(fixture) === "Fixture";
+      }
+      return false;
+    }
+    return {
+      "CallExpression[callee.property.name=/^(head|get|put|post|del|patch)$/]": (serviceCall) => {
+        try {
+          if (!isCalleeServiceWrapper(serviceCall)) {
+            return;
+          }
+          const enclosingScopeNode = getEnclosingScopeNode(serviceCall);
+          assert.ok(enclosingScopeNode, "enclosingScopeNode is undefined");
+          const scope = scopeManager?.acquire(enclosingScopeNode);
+          assert.ok(scope, "scope is undefined");
+          const urlArgument = serviceCall.arguments[0];
+          if (!isUrlArgumentValid(urlArgument, scope)) {
+            return;
+          }
+          assert.ok(serviceCall.callee.type === AST_NODE_TYPES.MemberExpression);
+          assert.ok(serviceCall.callee.property.type === AST_NODE_TYPES.Identifier);
+          const method = serviceCall.callee.property.name;
+          const optionsArgument = ["get", "head", "del"].includes(method) ? serviceCall.arguments[1] : serviceCall.arguments[2];
+          if (optionsArgument === void 0 || optionsArgument.type !== AST_NODE_TYPES.ObjectExpression) {
+            context.report({
+              node: serviceCall,
+              messageId: "invalidOptions"
+            });
+            return;
+          }
+          const resolveWithFullResponseProperty = optionsArgument.properties.find(
+            (property) => property.type === AST_NODE_TYPES.Property && property.key.type === AST_NODE_TYPES.Identifier && property.key.name === "resolveWithFullResponse"
+          );
+          if (resolveWithFullResponseProperty?.type !== AST_NODE_TYPES.Property || resolveWithFullResponseProperty.value.type !== AST_NODE_TYPES.Literal || resolveWithFullResponseProperty.value.value !== true) {
+            context.report({
+              node: optionsArgument,
+              messageId: "invalidOptions"
+            });
+            return;
+          }
+        } catch (error) {
+          console.error(`Failed to apply ${ruleId} rule for file "${context.filename}":`, error);
+          context.report({
+            node: serviceCall,
+            messageId: "unknownError",
+            data: {
+              fileName: context.filename,
+              error: error instanceof Error ? error.toString() : JSON.stringify(error)
+            }
+          });
+        }
+      }
+    };
+  }
+});
+var require_resolve_full_response_default = rule;
+export {
+  PLAIN_URL_REGEXP,
+  TOKENIZED_URL_REGEXP,
+  require_resolve_full_response_default as default,
+  ruleId
+};
+//# sourceMappingURL=data:application/json;base64,ewogICJ2ZXJzaW9uIjogMywKICAic291cmNlcyI6IFsiLi4vc3JjL3JlcXVpcmUtcmVzb2x2ZS1mdWxsLXJlc3BvbnNlLnRzIl0sCiAgIm1hcHBpbmdzIjogIjtBQVFBLFNBQVMsZ0JBQWdCLG1CQUE2QjtBQUN0RCxTQUFTLHNCQUFrQztBQUMzQyxTQUFTLFVBQVUsY0FBYztBQUNqQyxPQUFPLHlCQUF5QjtBQUNoQyxTQUFTLDZCQUE2QjtBQUUvQixJQUFNLFNBQVM7QUFDZixJQUFNLG1CQUFtQjtBQUN6QixJQUFNLHVCQUF1QjtBQUVwQyxJQUFNLGFBQWEsWUFBWSxZQUFZLENBQUMsU0FBUyxvQkFBb0IsSUFBSSxDQUFDO0FBRTlFLElBQU0sT0FBTyxXQUFXO0FBQUEsRUFDdEIsTUFBTTtBQUFBLEVBQ04sTUFBTTtBQUFBLElBQ0osTUFBTTtBQUFBLElBQ04sTUFBTTtBQUFBLE1BQ0osYUFBYTtBQUFBLElBQ2Y7QUFBQSxJQUNBLFVBQVU7QUFBQSxNQUNSLGdCQUNFO0FBQUEsTUFDRixjQUFjO0FBQUEsSUFDaEI7QUFBQSxJQUNBLFFBQVEsQ0FBQztBQUFBLEVBQ1g7QUFBQSxFQUNBLGdCQUFnQixDQUFDO0FBQUEsRUFDakIsT0FBTyxTQUFTO0FBQ2QsVUFBTSxhQUFhLFFBQVE7QUFDM0IsVUFBTSxlQUFlLFdBQVc7QUFDaEMsVUFBTSxnQkFBZ0IsWUFBWSxrQkFBa0IsT0FBTztBQUMzRCxVQUFNLGNBQWMsY0FBYyxRQUFRLGVBQWU7QUFFekQsYUFBUyxtQkFBbUIsYUFBd0MsT0FBYztBQUNoRixVQUNHLGFBQWEsU0FBUyxlQUFlLFdBQVcsT0FBTyxZQUFZLFVBQVUsWUFDOUUsYUFBYSxTQUFTLGVBQWUsaUJBQ3JDO0FBQ0EsY0FBTSxVQUFVLFdBQVcsUUFBUSxXQUFXO0FBQzlDLGVBQU8saUJBQWlCLEtBQUssT0FBTyxLQUFLLHFCQUFxQixLQUFLLE9BQU87QUFBQSxNQUM1RTtBQUVBLFVBQUksYUFBYSxTQUFTLGVBQWUsWUFBWTtBQUNuRCxjQUFNLGdCQUFnQixNQUFNLFVBQVUsS0FBSyxDQUFDLGFBQWEsU0FBUyxTQUFTLFlBQVksSUFBSTtBQUMzRixZQUFJLGVBQWU7QUFDakIsZ0JBQU0scUJBQXFCLGNBQWMsS0FBSyxLQUFLLENBQUMsUUFBUSxJQUFJLFNBQVMsZUFBZSxRQUFRO0FBQ2hHLGlCQUFPLEdBQUcsb0JBQW9CLGFBQWEsWUFBWSxJQUFJLHdCQUF3QjtBQUNuRixnQkFBTSx5QkFBeUIsbUJBQW1CO0FBQ2xELGlCQUFPLEdBQUcsdUJBQXVCLFNBQVMsZUFBZSxrQkFBa0I7QUFDM0UsaUJBQU8sR0FBRyx1QkFBdUIsTUFBTSwrQ0FBK0M7QUFDdEYsaUJBQU8sbUJBQW1CLHVCQUF1QixNQUFNLEtBQUs7QUFBQSxRQUM5RDtBQUFBLE1BQ0Y7QUFFQSxhQUFPO0FBQUEsSUFDVDtBQUVBLGFBQVMsUUFBUSxZQUFpQztBQUNoRCxZQUFNLFdBQVcsY0FBYyxzQkFBc0IsSUFBSSxVQUFVO0FBQ25FLFlBQU0sZUFBZSxZQUFZLGtCQUFrQixRQUFRO0FBQzNELGFBQU8sWUFBWSxhQUFhLFlBQVk7QUFBQSxJQUM5QztBQUVBLGFBQVMsa0JBQWtCLE1BQWM7QUFDdkMsYUFBTyxpQkFBaUIsS0FBSyxJQUFJO0FBQUEsSUFDbkM7QUFFQSxhQUFTLHVCQUF1QixhQUFzQztBQUNwRSxZQUFNLFNBQVMsWUFBWTtBQUMzQixVQUFJLE9BQU8sU0FBUyxlQUFlLGtCQUFrQjtBQUNuRCxlQUFPO0FBQUEsTUFDVDtBQUVBLFlBQU0sV0FBVyxPQUFPO0FBQ3hCLFVBQUksU0FBUyxTQUFTLGVBQWUsWUFBWTtBQUMvQyxlQUFPLFFBQVEsUUFBUSxNQUFNLGNBQWMsa0JBQWtCLFNBQVMsSUFBSTtBQUFBLE1BQzVFO0FBQ0EsVUFBSSxTQUFTLFNBQVMsZUFBZSxnQkFBZ0I7QUFDbkQsZUFBTztBQUFBLE1BQ1Q7QUFFQSxZQUFNLENBQUMsZUFBZSxJQUFJLFNBQVM7QUFDbkMsVUFBSSxpQkFBaUIsU0FBUyxlQUFlLFlBQVk7QUFDdkQsZUFBTztBQUFBLE1BQ1Q7QUFDQSxVQUFJLGdCQUFnQixTQUFTLG1CQUFtQixRQUFRLGVBQWUsTUFBTSxrQkFBa0I7QUFDN0YsZUFBTztBQUFBLE1BQ1Q7QUFDQSxZQUFNLFVBQVUsU0FBUztBQUN6QixVQUFJLFFBQVEsU0FBUyxlQUFlLFlBQVk7QUFDOUMsZUFBTyxRQUFRLE9BQU8sTUFBTTtBQUFBLE1BQzlCO0FBRUEsVUFBSSxRQUFRLFNBQVMsZUFBZSxrQkFBa0I7QUFDcEQsZUFBTztBQUFBLE1BQ1Q7QUFDQSxZQUFNLFdBQVcsUUFBUTtBQUN6QixVQUFJLFNBQVMsU0FBUyxlQUFlLFlBQVk7QUFDL0MsZUFBTyxRQUFRLFFBQVEsTUFBTTtBQUFBLE1BQy9CO0FBRUEsVUFBSSxTQUFTLFNBQVMsZUFBZSxrQkFBa0I7QUFDckQsZUFBTztBQUFBLE1BQ1Q7QUFDQSxZQUFNLGdCQUFnQixTQUFTO0FBQy9CLFVBQUksY0FBYyxTQUFTLGVBQWUsWUFBWTtBQUNwRCxlQUFPLENBQUMsaUJBQWlCLGlDQUFpQyxFQUFFLFNBQVMsUUFBUSxhQUFhLENBQUM7QUFBQSxNQUM3RjtBQUdBLFVBQUksY0FBYyxTQUFTLGVBQWUsa0JBQWtCO0FBQzFELGVBQU87QUFBQSxNQUNUO0FBQ0EsWUFBTSxVQUFVLGNBQWM7QUFDOUIsVUFBSSxRQUFRLFNBQVMsZUFBZSxZQUFZO0FBQzlDLGVBQU8sUUFBUSxTQUFTLGFBQWEsUUFBUSxPQUFPLE1BQU07QUFBQSxNQUM1RDtBQUVBLGFBQU87QUFBQSxJQUNUO0FBRUEsV0FBTztBQUFBLE1BQ0wsMEVBQTBFLENBQ3hFLGdCQUNHO0FBQ0gsWUFBSTtBQUNGLGNBQUksQ0FBQyx1QkFBdUIsV0FBVyxHQUFHO0FBQ3hDO0FBQUEsVUFDRjtBQUVBLGdCQUFNLHFCQUFxQixzQkFBc0IsV0FBVztBQUM1RCxpQkFBTyxHQUFHLG9CQUFvQixpQ0FBaUM7QUFDL0QsZ0JBQU0sUUFBUSxjQUFjLFFBQVEsa0JBQWtCO0FBQ3RELGlCQUFPLEdBQUcsT0FBTyxvQkFBb0I7QUFDckMsZ0JBQU0sY0FBYyxZQUFZLFVBQVUsQ0FBQztBQUMzQyxjQUFJLENBQUMsbUJBQW1CLGFBQWEsS0FBSyxHQUFHO0FBQzNDO0FBQUEsVUFDRjtBQUVBLGlCQUFPLEdBQUcsWUFBWSxPQUFPLFNBQVMsZUFBZSxnQkFBZ0I7QUFDckUsaUJBQU8sR0FBRyxZQUFZLE9BQU8sU0FBUyxTQUFTLGVBQWUsVUFBVTtBQUd4RSxnQkFBTSxTQUFTLFlBQVksT0FBTyxTQUFTO0FBRzNDLGdCQUFNLGtCQUFrQixDQUFDLE9BQU8sUUFBUSxLQUFLLEVBQUUsU0FBUyxNQUFNLElBQzFELFlBQVksVUFBVSxDQUFDLElBQ3ZCLFlBQVksVUFBVSxDQUFDO0FBQzNCLGNBQUksb0JBQW9CLFVBQWEsZ0JBQWdCLFNBQVMsZUFBZSxrQkFBa0I7QUFDN0Ysb0JBQVEsT0FBTztBQUFBLGNBQ2IsTUFBTTtBQUFBLGNBQ04sV0FBVztBQUFBLFlBQ2IsQ0FBQztBQUNEO0FBQUEsVUFDRjtBQUVBLGdCQUFNLGtDQUFrQyxnQkFBZ0IsV0FBVztBQUFBLFlBQ2pFLENBQUMsYUFDQyxTQUFTLFNBQVMsZUFBZSxZQUNqQyxTQUFTLElBQUksU0FBUyxlQUFlLGNBQ3JDLFNBQVMsSUFBSSxTQUFTO0FBQUEsVUFDMUI7QUFDQSxjQUNFLGlDQUFpQyxTQUFTLGVBQWUsWUFDekQsZ0NBQWdDLE1BQU0sU0FBUyxlQUFlLFdBQzlELGdDQUFnQyxNQUFNLFVBQVUsTUFDaEQ7QUFDQSxvQkFBUSxPQUFPO0FBQUEsY0FDYixNQUFNO0FBQUEsY0FDTixXQUFXO0FBQUEsWUFDYixDQUFDO0FBQ0Q7QUFBQSxVQUNGO0FBQUEsUUFDRixTQUFTLE9BQU87QUFFZCxrQkFBUSxNQUFNLG1CQUFtQixNQUFNLG1CQUFtQixRQUFRLFFBQVEsTUFBTSxLQUFLO0FBQ3JGLGtCQUFRLE9BQU87QUFBQSxZQUNiLE1BQU07QUFBQSxZQUNOLFdBQVc7QUFBQSxZQUNYLE1BQU07QUFBQSxjQUNKLFVBQVUsUUFBUTtBQUFBLGNBQ2xCLE9BQU8saUJBQWlCLFFBQVEsTUFBTSxTQUFTLElBQUksS0FBSyxVQUFVLEtBQUs7QUFBQSxZQUN6RTtBQUFBLFVBQ0YsQ0FBQztBQUFBLFFBQ0g7QUFBQSxNQUNGO0FBQUEsSUFDRjtBQUFBLEVBQ0Y7QUFDRixDQUFDO0FBRUQsSUFBTyx3Q0FBUTsiLAogICJuYW1lcyI6IFtdCn0K

package/dist-types/index.d.ts

@@ -12,6 +12,7 @@ declare const _default: {
         'object-literal-response': import("eslint").Rule.RuleModule;
         "invalid-json-stringify": import("eslint").Rule.RuleModule;
         "no-promise-instance-method": import("eslint").Rule.RuleModule;
+        "require-resolve-full-response": import("@typescript-eslint/utils/ts-eslint").RuleModule<"invalidOptions" | "unknownError", never[], import("@typescript-eslint/utils/ts-eslint").RuleListener>;
     };
     configs: {
         all: {
@@ -28,6 +29,7 @@ declare const _default: {
                 '@checkdigit/no-test-import': string;
                 "@checkdigit/invalid-json-stringify": string;
                 "@checkdigit/no-promise-instance-method": string;
+                "@checkdigit/require-resolve-full-response": string;
             };
         };
         recommended: {

package/dist-types/library/format.d.ts

@@ -0,0 +1,4 @@
+import { TSESLint, TSESTree } from '@typescript-eslint/utils';
+import type { Node } from 'estree';
+import type { SourceCode } from 'eslint';
+export declare function getIndentation(node: Node | TSESTree.Node, sourceCode: SourceCode | TSESLint.SourceCode): string;

package/dist-types/library/tree.d.ts

@@ -0,0 +1,8 @@
+import type { Node } from 'estree';
+export declare function getParent(node: Node): Node | undefined | null;
+export declare function getAncestor(node: Node, matcher: string | ((testNode: Node) => boolean), exitMatcher?: string | ((testNode: Node) => boolean)): Node | undefined;
+export declare function isBlockStatement(node: Node): boolean;
+export declare function getEnclosingStatement(node: Node): Node | undefined;
+export declare function getEnclosingScopeNode(node: Node): Node | undefined;
+export declare function isUsedInArrayOrAsArgument(node: Node): boolean;
+export declare function getEnclosingFunction(node: Node): import("estree").ArrowFunctionExpression | import("estree").FunctionExpression | import("estree").FunctionDeclaration | undefined;

package/dist-types/library/ts-tree.d.ts

@@ -0,0 +1,9 @@
+import { AST_NODE_TYPES, TSESTree } from '@typescript-eslint/utils';
+export declare function getParent(node: TSESTree.Node): TSESTree.Node | undefined | null;
+export declare function getAncestor(node: TSESTree.Node, matcher: AST_NODE_TYPES | ((testNode: TSESTree.Node) => boolean), exitMatcher?: AST_NODE_TYPES | ((testNode: TSESTree.Node) => boolean)): TSESTree.Node | undefined;
+export declare function isBlockStatement(node: TSESTree.Node): boolean;
+export declare function getEnclosingStatement(node: TSESTree.Node): TSESTree.Node | undefined;
+export declare function getEnclosingScopeNode(node: TSESTree.Node): TSESTree.Node | undefined;
+export declare function isUsedInArrayOrAsArgument(node: TSESTree.Node): boolean;
+export declare function getEnclosingFunction(node: TSESTree.Node): TSESTree.ArrowFunctionExpression | TSESTree.FunctionDeclarationWithOptionalName | TSESTree.FunctionExpression | undefined;
+export declare function getTypeParentNode(node: TSESTree.Node | undefined): TSESTree.TSTypeAnnotation | TSESTree.TSAsExpression | undefined;

package/dist-types/library/variable.d.ts

@@ -0,0 +1 @@
+export declare function isValidPropertyName(name: unknown): boolean;

package/dist-types/require-resolve-full-response.d.ts

@@ -0,0 +1,6 @@
+import { ESLintUtils } from '@typescript-eslint/utils';
+export declare const ruleId = "require-resolve-full-response";
+export declare const PLAIN_URL_REGEXP: RegExp;
+export declare const TOKENIZED_URL_REGEXP: RegExp;
+declare const rule: ESLintUtils.RuleModule<"invalidOptions" | "unknownError", never[], ESLintUtils.RuleListener>;
+export default rule;

package/package.json

@@ -1 +1 @@
-{"name":"@checkdigit/eslint-plugin","version":"6.6.0-PR.79-7a20","description":"Check Digit eslint plugins","keywords":["eslint","eslintplugin"],"homepage":"https://github.com/checkdigit/eslint-plugin#readme","bugs":{"url":"https://github.com/checkdigit/eslint-plugin/issues"},"repository":{"type":"git","url":"https://github.com/checkdigit/eslint-plugin"},"license":"MIT","author":"Check Digit, LLC","sideEffects":false,"type":"module","exports":{".":{"types":"./dist-types/index.d.ts","require":"./dist-cjs/index.cjs","import":"./dist-mjs/index.mjs","default":"./dist-mjs/index.mjs"}},"files":["src","dist-types","dist-cjs","dist-mjs","!src/**/*.test.ts","!src/**/*.spec.ts","!dist-types/**/*.test.d.ts","!dist-types/**/*.spec.d.ts","!dist-cjs/**/*.test.cjs","!dist-cjs/**/*.spec.cjs","!dist-mjs/**/*.test.mjs","!dist-mjs/**/*.spec.mjs","SECURITY.md"],"scripts":{"build:dist-cjs":"rimraf dist-cjs && npx builder --type=commonjs --sourceMap --entryPoint=index.ts --outDir=dist-cjs --outFile=index.cjs --external=espree && echo \"module.exports = module.exports.default;\" >> dist-cjs/index.cjs && node dist-cjs/index.cjs","build:dist-mjs":"rimraf dist-mjs && npx builder --type=module --sourceMap --outDir=dist-mjs && node dist-mjs/index.mjs","build:dist-types":"rimraf dist-types && npx builder --type=types --outDir=dist-types","ci:compile":"tsc --noEmit","ci:coverage":"NODE_OPTIONS=\"--disable-warning ExperimentalWarning --experimental-vm-modules\" jest --coverage=true","ci:lint":"npm run lint","ci:style":"npm run prettier","ci:test":"NODE_OPTIONS=\"--disable-warning ExperimentalWarning --experimental-vm-modules\" jest --coverage=false","lint":"eslint --max-warnings 0 --ignore-path .gitignore .","lint:fix":"eslint --ignore-path .gitignore . --fix","prepublishOnly":"npm run build:dist-types && npm run build:dist-cjs && npm run build:dist-mjs","prettier":"prettier --ignore-path .gitignore --list-different .","prettier:fix":"prettier --ignore-path .gitignore --write .","test":"npm run ci:compile && npm run ci:test && npm run ci:lint && npm run ci:style"},"prettier":"@checkdigit/prettier-config","jest":{"preset":"@checkdigit/jest-config"},"devDependencies":{"@checkdigit/jest-config":"^6.0.2","@checkdigit/prettier-config":"^5.5.0","@checkdigit/typescript-config":"6.0.0","@types/eslint":"8.56.10","@typescript-eslint/eslint-plugin":"7.18.0","@typescript-eslint/parser":"7.18.0","@typescript-eslint/rule-tester":"7.18.0","@typescript-eslint/utils":"7.18.0","eslint-config-prettier":"^9.1.0","eslint-plugin-eslint-plugin":"^6.2.0","eslint-plugin-import":"^2.29.1","eslint-plugin-no-only-tests":"^3.1.0","eslint-plugin-no-secrets":"^1.0.2","eslint-plugin-node":"^11.1.0","eslint-plugin-sonarjs":"0.24.0","http-status-codes":"^2.3.0"},"peerDependencies":{"eslint":">=8 <9"},"engines":{"node":">=20.14"}}
+{"name":"@checkdigit/eslint-plugin","version":"6.7.0-PR.79-33df","description":"Check Digit eslint plugins","keywords":["eslint","eslintplugin"],"homepage":"https://github.com/checkdigit/eslint-plugin#readme","bugs":{"url":"https://github.com/checkdigit/eslint-plugin/issues"},"repository":{"type":"git","url":"https://github.com/checkdigit/eslint-plugin"},"license":"MIT","author":"Check Digit, LLC","sideEffects":false,"type":"module","exports":{".":{"types":"./dist-types/index.d.ts","require":"./dist-cjs/index.cjs","import":"./dist-mjs/index.mjs","default":"./dist-mjs/index.mjs"}},"files":["src","dist-types","dist-cjs","dist-mjs","!src/**/*.test.ts","!src/**/*.spec.ts","!dist-types/**/*.test.d.ts","!dist-types/**/*.spec.d.ts","!dist-cjs/**/*.test.cjs","!dist-cjs/**/*.spec.cjs","!dist-mjs/**/*.test.mjs","!dist-mjs/**/*.spec.mjs","SECURITY.md"],"scripts":{"build:dist-cjs":"rimraf dist-cjs && npx builder --type=commonjs --sourceMap --entryPoint=index.ts --outDir=dist-cjs --outFile=index.cjs --external=espree && echo \"module.exports = module.exports.default;\" >> dist-cjs/index.cjs && node dist-cjs/index.cjs","build:dist-mjs":"rimraf dist-mjs && npx builder --type=module --sourceMap --outDir=dist-mjs && node dist-mjs/index.mjs","build:dist-types":"rimraf dist-types && npx builder --type=types --outDir=dist-types","ci:compile":"tsc --noEmit","ci:coverage":"NODE_OPTIONS=\"--disable-warning ExperimentalWarning --experimental-vm-modules\" jest --coverage=true","ci:lint":"npm run lint","ci:style":"npm run prettier","ci:test":"NODE_OPTIONS=\"--disable-warning ExperimentalWarning --experimental-vm-modules\" jest --coverage=false","lint":"eslint --max-warnings 0 --ignore-path .gitignore .","lint:fix":"eslint --ignore-path .gitignore . --fix","prepublishOnly":"npm run build:dist-types && npm run build:dist-cjs && npm run build:dist-mjs","prettier":"prettier --ignore-path .gitignore --list-different .","prettier:fix":"prettier --ignore-path .gitignore --write .","test":"npm run ci:compile && npm run ci:test && npm run ci:lint && npm run ci:style"},"prettier":"@checkdigit/prettier-config","jest":{"preset":"@checkdigit/jest-config"},"dependencies":{"@typescript-eslint/type-utils":"7.18.0","@typescript-eslint/utils":"7.18.0","ts-api-utils":"^1.3.0"},"devDependencies":{"@checkdigit/jest-config":"^6.0.2","@checkdigit/prettier-config":"^5.5.0","@checkdigit/typescript-config":"6.0.0","@types/eslint":"8.56.10","@typescript-eslint/eslint-plugin":"7.18.0","@typescript-eslint/parser":"7.18.0","@typescript-eslint/rule-tester":"7.18.0","eslint-config-prettier":"^9.1.0","eslint-plugin-eslint-plugin":"^6.2.0","eslint-plugin-import":"^2.29.1","eslint-plugin-no-only-tests":"^3.1.0","eslint-plugin-no-secrets":"^1.0.2","eslint-plugin-node":"^11.1.0","eslint-plugin-sonarjs":"0.24.0","http-status-codes":"^2.3.0"},"peerDependencies":{"eslint":">=8 <9"},"engines":{"node":">=20.14"}}

package/src/index.ts

@@ -8,6 +8,9 @@
 
 import invalidJsonStringify, { ruleId as invalidJsonStringifyRuleId } from './invalid-json-stringify';
 import noPromiseInstanceMethod, { ruleId as noPromiseInstanceMethodRuleId } from './no-promise-instance-method';
+import requireResolveFullResponse, {
+  ruleId as requireResolveFullResponseRuleId,
+} from './require-resolve-full-response';
 import filePathComment from './file-path-comment';
 import noCardNumbers from './no-card-numbers';
 import noEnum from './no-enum';
@@ -33,6 +36,7 @@ export default {
     'object-literal-response': objectLiteralResponse,
     [invalidJsonStringifyRuleId]: invalidJsonStringify,
     [noPromiseInstanceMethodRuleId]: noPromiseInstanceMethod,
+    [requireResolveFullResponseRuleId]: requireResolveFullResponse,
   },
   configs: {
     all: {
@@ -49,6 +53,7 @@ export default {
         '@checkdigit/no-test-import': 'error',
         [`@checkdigit/${invalidJsonStringifyRuleId}`]: 'error',
         [`@checkdigit/${noPromiseInstanceMethodRuleId}`]: 'error',
+        [`@checkdigit/${requireResolveFullResponseRuleId}`]: 'error',
       },
     },
     recommended: {

package/src/library/format.ts

@@ -0,0 +1,20 @@
+// format.ts
+
+/*
+ * Copyright (c) 2021-2024 Check Digit, LLC
+ *
+ * This code is licensed under the MIT license (see LICENSE.txt for details).
+ */
+
+import { TSESLint, TSESTree } from '@typescript-eslint/utils';
+import type { Node } from 'estree';
+import type { SourceCode } from 'eslint';
+import { strict as assert } from 'node:assert';
+
+export function getIndentation(node: Node | TSESTree.Node, sourceCode: SourceCode | TSESLint.SourceCode) {
+  assert.ok(node.loc);
+  const line = sourceCode.lines[node.loc.start.line - 1];
+  assert.ok(line !== undefined);
+  const indentMatch = line.match(/^\s*/u);
+  return indentMatch ? indentMatch[0] : '';
+}

package/src/library/tree.ts

@@ -0,0 +1,90 @@
+// tree.ts
+
+/*
+ * Copyright (c) 2021-2024 Check Digit, LLC
+ *
+ * This code is licensed under the MIT license (see LICENSE.txt for details).
+ */
+
+import type { Expression, Node } from 'estree';
+
+type NodeParent = Node | undefined | null;
+
+interface NodeParentExtension {
+  parent: NodeParent;
+}
+
+export function getParent(node: Node): Node | undefined | null {
+  return (node as unknown as NodeParentExtension).parent;
+}
+
+export function getAncestor(
+  node: Node,
+  matcher: string | ((testNode: Node) => boolean),
+  exitMatcher?: string | ((testNode: Node) => boolean),
+): Node | undefined {
+  const parent = getParent(node);
+  if (!parent) {
+    return undefined;
+  } else if (typeof matcher === 'string' && parent.type === matcher) {
+    return parent;
+  } else if (typeof matcher === 'function' && matcher(parent)) {
+    return parent;
+  } else if (typeof exitMatcher === 'string' && parent.type === exitMatcher) {
+    return undefined;
+  } else if (typeof exitMatcher === 'function' && exitMatcher(parent)) {
+    return undefined;
+  }
+  return getAncestor(parent, matcher, exitMatcher);
+}
+
+export function isBlockStatement(node: Node) {
+  return node.type.endsWith('Statement') || node.type.endsWith('Declaration');
+}
+
+export function getEnclosingStatement(node: Node) {
+  return getAncestor(node, isBlockStatement);
+}
+
+export function getEnclosingScopeNode(node: Node) {
+  return getAncestor(node, (parentNode) =>
+    ['FunctionExpression', 'FunctionDeclaration', 'ArrowFunctionExpression', 'Program'].includes(parentNode.type),
+  );
+}
+
+export function isUsedInArrayOrAsArgument(node: Node) {
+  if (isBlockStatement(node)) {
+    return false;
+  }
+
+  const parent = getParent(node);
+  if (!parent) {
+    return false;
+  }
+
+  if (
+    parent.type === 'ArrayExpression' ||
+    (parent.type === 'CallExpression' && parent.arguments.includes(node as Expression))
+  ) {
+    return true;
+  }
+
+  // recurse up the tree until hitting a block statement
+  return isUsedInArrayOrAsArgument(parent);
+}
+
+export function getEnclosingFunction(node: Node) {
+  if (
+    node.type === 'FunctionDeclaration' ||
+    node.type === 'FunctionExpression' ||
+    node.type === 'ArrowFunctionExpression'
+  ) {
+    return node;
+  }
+
+  const parent = getParent(node);
+  if (!parent) {
+    return;
+  }
+  return getEnclosingFunction(parent);
+}

package/src/library/ts-tree.ts

@@ -0,0 +1,101 @@
+// tree.ts
+
+/*
+ * Copyright (c) 2021-2024 Check Digit, LLC
+ *
+ * This code is licensed under the MIT license (see LICENSE.txt for details).
+ */
+
+import { AST_NODE_TYPES, TSESTree } from '@typescript-eslint/utils';
+
+type NodeParent = TSESTree.Node | undefined | null;
+
+interface NodeParentExtension {
+  parent: NodeParent;
+}
+
+export function getParent(node: TSESTree.Node): TSESTree.Node | undefined | null {
+  return (node as unknown as NodeParentExtension).parent;
+}
+
+export function getAncestor(
+  node: TSESTree.Node,
+  matcher: AST_NODE_TYPES | ((testNode: TSESTree.Node) => boolean),
+  exitMatcher?: AST_NODE_TYPES | ((testNode: TSESTree.Node) => boolean),
+): TSESTree.Node | undefined {
+  const parent = getParent(node);
+  if (!parent) {
+    return undefined;
+  } else if (typeof matcher === 'string' && parent.type === matcher) {
+    return parent;
+  } else if (typeof matcher === 'function' && matcher(parent)) {
+    return parent;
+  } else if (typeof exitMatcher === 'string' && parent.type === exitMatcher) {
+    return undefined;
+  } else if (typeof exitMatcher === 'function' && exitMatcher(parent)) {
+    return undefined;
+  }
+  return getAncestor(parent, matcher, exitMatcher);
+}
+
+export function isBlockStatement(node: TSESTree.Node) {
+  return node.type.endsWith('Statement') || node.type.endsWith('Declaration');
+}
+
+export function getEnclosingStatement(node: TSESTree.Node) {
+  return getAncestor(node, isBlockStatement);
+}
+
+export function getEnclosingScopeNode(node: TSESTree.Node) {
+  return getAncestor(node, (parentNode) =>
+    ['FunctionExpression', 'FunctionDeclaration', 'ArrowFunctionExpression', 'Program'].includes(parentNode.type),
+  );
+}
+
+export function isUsedInArrayOrAsArgument(node: TSESTree.Node) {
+  if (isBlockStatement(node)) {
+    return false;
+  }
+
+  const parent = getParent(node);
+  if (!parent) {
+    return false;
+  }
+
+  if (
+    parent.type === AST_NODE_TYPES.ArrayExpression ||
+    (parent.type === AST_NODE_TYPES.CallExpression && parent.arguments.includes(node as TSESTree.Expression))
+  ) {
+    return true;
+  }
+
+  // recurse up the tree until hitting a block statement
+  return isUsedInArrayOrAsArgument(parent);
+}
+
+export function getEnclosingFunction(node: TSESTree.Node) {
+  if (
+    node.type === AST_NODE_TYPES.FunctionDeclaration ||
+    node.type === AST_NODE_TYPES.FunctionExpression ||
+    node.type === AST_NODE_TYPES.ArrowFunctionExpression
+  ) {
+    return node;
+  }
+
+  const parent = getParent(node);
+  if (!parent) {
+    return;
+  }
+  return getEnclosingFunction(parent);
+}
+
+export function getTypeParentNode(
+  node: TSESTree.Node | undefined,
+): TSESTree.TSTypeAnnotation | TSESTree.TSAsExpression | undefined {
+  if (!node) {
+    return undefined;
+  }
+  return node.type === AST_NODE_TYPES.TSTypeAnnotation || node.type === AST_NODE_TYPES.TSAsExpression
+    ? node
+    : getTypeParentNode(node.parent);
+}

package/src/library/variable.ts

@@ -0,0 +1,5 @@
+// fixture/variable.ts
+
+export function isValidPropertyName(name: unknown) {
+  return typeof name === 'string' && /^[a-zA-Z_$][a-zA-Z_$0-9]*$/u.test(name);
+}

package/src/no-enum.ts

@@ -1,18 +1,32 @@
 // no-enum.ts
 
-import { ESLintUtils, TSESTree } from '@typescript-eslint/utils';
-
 /*
  * Copyright (c) 2021-2024 Check Digit, LLC
  *
  * This code is licensed under the MIT license (see LICENSE.txt for details).
  */
 
+import { ESLintUtils, TSESTree } from '@typescript-eslint/utils';
+
 export const ruleId = 'no-enum';
 const NO_ENUM = 'NO_ENUM';
 
 const createRule = ESLintUtils.RuleCreator((name) => name);
 
+function isJsonSchemaProperty(node?: TSESTree.Node): boolean {
+  if (!node) {
+    return false;
+  }
+  if (
+    node.type === TSESTree.AST_NODE_TYPES.Property &&
+    node.key.type === TSESTree.AST_NODE_TYPES.Identifier &&
+    node.key.name === 'properties'
+  ) {
+    return true;
+  }
+  return isJsonSchemaProperty(node.parent);
+}
+
 const rule = createRule({
   name: ruleId,
   meta: {
@@ -38,7 +52,8 @@ const rule = createRule({
         if (
           node.key.type === TSESTree.AST_NODE_TYPES.Identifier &&
           node.key.name === 'enum' &&
-          node.value.type === TSESTree.AST_NODE_TYPES.ArrayExpression
+          node.value.type === TSESTree.AST_NODE_TYPES.ArrayExpression &&
+          !isJsonSchemaProperty(node.parent)
         ) {
           context.report({
             node,