@checkdigit/eslint-plugin 6.6.0-PR.75-66d8 → 6.6.0-PR.75-0dbb

package/dist-types/fixture/{concurrent-promises.d.ts → fetch-then.d.ts}

@@ -1,4 +1,4 @@
 import { type Rule } from 'eslint';
-export declare const ruleId = "concurrent-promises";
+export declare const ruleId = "fetch-then";
 declare const rule: Rule.RuleModule;
 export default rule;

package/dist-types/fixture/fetch.d.ts

@@ -1,3 +1,4 @@
 import type { Node } from 'estree';
 export declare function getResponseBodyRetrievalText(responseVariableName: string): string;
 export declare function isInvalidResponseHeadersAccess(responseHeadersAccess: Node): boolean;
+export declare function hasAssertions(fixtureCall: Node): boolean;

package/dist-types/index.d.ts

@@ -13,7 +13,7 @@ declare const _default: {
         "no-promise-instance-method": import("eslint").Rule.RuleModule;
         "no-fixture": import("eslint").Rule.RuleModule;
         "fetch-header-getter": import("eslint").Rule.RuleModule;
-        "concurrent-promises": import("eslint").Rule.RuleModule;
+        "fetch-then": import("eslint").Rule.RuleModule;
     };
     configs: {
         all: {
@@ -31,7 +31,7 @@ declare const _default: {
                 "@checkdigit/no-promise-instance-method": string;
                 "@checkdigit/no-fixture": string;
                 "@checkdigit/fetch-header-getter": string;
-                "@checkdigit/concurrent-promises": string;
+                "@checkdigit/fetch-then": string;
             };
         };
         recommended: {

package/package.json

@@ -1 +1 @@
-{"name":"@checkdigit/eslint-plugin","version":"6.6.0-PR.75-66d8","description":"Check Digit eslint plugins","keywords":["eslint","eslintplugin"],"homepage":"https://github.com/checkdigit/eslint-plugin#readme","bugs":{"url":"https://github.com/checkdigit/eslint-plugin/issues"},"repository":{"type":"git","url":"https://github.com/checkdigit/eslint-plugin"},"license":"MIT","author":"Check Digit, LLC","sideEffects":false,"type":"module","exports":{".":{"types":"./dist-types/index.d.ts","require":"./dist-cjs/index.cjs","import":"./dist-mjs/index.mjs","default":"./dist-mjs/index.mjs"}},"files":["src","dist-types","dist-cjs","dist-mjs","!src/**/*.test.ts","!src/**/*.spec.ts","!dist-types/**/*.test.d.ts","!dist-types/**/*.spec.d.ts","!dist-cjs/**/*.test.cjs","!dist-cjs/**/*.spec.cjs","!dist-mjs/**/*.test.mjs","!dist-mjs/**/*.spec.mjs","SECURITY.md"],"scripts":{"build:dist-cjs":"rimraf dist-cjs && npx builder --type=commonjs --sourceMap --entryPoint=index.ts --outDir=dist-cjs --outFile=index.cjs --external=espree && echo \"module.exports = module.exports.default;\" >> dist-cjs/index.cjs","build:dist-mjs":"rimraf dist-mjs && npx builder --type=module --sourceMap --outDir=dist-mjs && node dist-mjs/index.mjs","build:dist-types":"rimraf dist-types && npx builder --type=types --outDir=dist-types","ci:compile":"tsc --noEmit","ci:coverage":"NODE_OPTIONS=\"--disable-warning ExperimentalWarning --experimental-vm-modules\" jest --coverage=true","ci:lint":"npm run lint","ci:style":"npm run prettier","ci:test":"NODE_OPTIONS=\"--disable-warning ExperimentalWarning --experimental-vm-modules\" jest --coverage=false","lint":"eslint --max-warnings 0 --ignore-path .gitignore .","lint:fix":"eslint --ignore-path .gitignore . --fix","prepublishOnly":"npm run build:dist-types && npm run build:dist-cjs && npm run build:dist-mjs","prettier":"prettier --ignore-path .gitignore --list-different .","prettier:fix":"prettier --ignore-path .gitignore --write .","test":"npm run ci:compile && npm run ci:test && npm run ci:lint && npm run ci:style"},"prettier":"@checkdigit/prettier-config","jest":{"preset":"@checkdigit/jest-config"},"devDependencies":{"@checkdigit/jest-config":"^6.0.2","@checkdigit/prettier-config":"^5.5.0","@checkdigit/typescript-config":"6.0.0","@types/eslint":"^8.56.10","@typescript-eslint/eslint-plugin":"^7.16.1","@typescript-eslint/parser":"^7.16.1","eslint-config-prettier":"^9.1.0","eslint-plugin-eslint-plugin":"^6.2.0","eslint-plugin-import":"^2.29.1","eslint-plugin-no-only-tests":"^3.1.0","eslint-plugin-no-secrets":"^1.0.2","eslint-plugin-node":"^11.1.0","eslint-plugin-sonarjs":"0.24.0"},"peerDependencies":{"eslint":">=8 <9"},"engines":{"node":">=20.14"}}
+{"name":"@checkdigit/eslint-plugin","version":"6.6.0-PR.75-0dbb","description":"Check Digit eslint plugins","keywords":["eslint","eslintplugin"],"homepage":"https://github.com/checkdigit/eslint-plugin#readme","bugs":{"url":"https://github.com/checkdigit/eslint-plugin/issues"},"repository":{"type":"git","url":"https://github.com/checkdigit/eslint-plugin"},"license":"MIT","author":"Check Digit, LLC","sideEffects":false,"type":"module","exports":{".":{"types":"./dist-types/index.d.ts","require":"./dist-cjs/index.cjs","import":"./dist-mjs/index.mjs","default":"./dist-mjs/index.mjs"}},"files":["src","dist-types","dist-cjs","dist-mjs","!src/**/*.test.ts","!src/**/*.spec.ts","!dist-types/**/*.test.d.ts","!dist-types/**/*.spec.d.ts","!dist-cjs/**/*.test.cjs","!dist-cjs/**/*.spec.cjs","!dist-mjs/**/*.test.mjs","!dist-mjs/**/*.spec.mjs","SECURITY.md"],"scripts":{"build:dist-cjs":"rimraf dist-cjs && npx builder --type=commonjs --sourceMap --entryPoint=index.ts --outDir=dist-cjs --outFile=index.cjs --external=espree && echo \"module.exports = module.exports.default;\" >> dist-cjs/index.cjs","build:dist-mjs":"rimraf dist-mjs && npx builder --type=module --sourceMap --outDir=dist-mjs && node dist-mjs/index.mjs","build:dist-types":"rimraf dist-types && npx builder --type=types --outDir=dist-types","ci:compile":"tsc --noEmit","ci:coverage":"NODE_OPTIONS=\"--disable-warning ExperimentalWarning --experimental-vm-modules\" jest --coverage=true","ci:lint":"npm run lint","ci:style":"npm run prettier","ci:test":"NODE_OPTIONS=\"--disable-warning ExperimentalWarning --experimental-vm-modules\" jest --coverage=false","lint":"eslint --max-warnings 0 --ignore-path .gitignore .","lint:fix":"eslint --ignore-path .gitignore . --fix","prepublishOnly":"npm run build:dist-types && npm run build:dist-cjs && npm run build:dist-mjs","prettier":"prettier --ignore-path .gitignore --list-different .","prettier:fix":"prettier --ignore-path .gitignore --write .","test":"npm run ci:compile && npm run ci:test && npm run ci:lint && npm run ci:style"},"prettier":"@checkdigit/prettier-config","jest":{"preset":"@checkdigit/jest-config"},"devDependencies":{"@checkdigit/jest-config":"^6.0.2","@checkdigit/prettier-config":"^5.5.0","@checkdigit/typescript-config":"6.0.0","@types/eslint":"^8.56.10","@typescript-eslint/eslint-plugin":"^7.16.1","@typescript-eslint/parser":"^7.16.1","eslint-config-prettier":"^9.1.0","eslint-plugin-eslint-plugin":"^6.2.0","eslint-plugin-import":"^2.29.1","eslint-plugin-no-only-tests":"^3.1.0","eslint-plugin-no-secrets":"^1.0.2","eslint-plugin-node":"^11.1.0","eslint-plugin-sonarjs":"0.24.0"},"peerDependencies":{"eslint":">=8 <9"},"engines":{"node":">=20.14"}}

package/src/ast/tree.ts

@@ -6,7 +6,7 @@
  * This code is licensed under the MIT license (see LICENSE.txt for details).
  */
 
-import type { Node } from 'estree';
+import type { Expression, Node } from 'estree';
 
 type NodeParent = Node | undefined | null;
 
@@ -38,11 +38,12 @@ export function getAncestor(
   return getAncestor(parent, matcher, exitMatcher);
 }
 
+export function isBlockStatement(node: Node) {
+  return node.type.endsWith('Statement') || node.type.endsWith('Declaration');
+}
+
 export function getEnclosingStatement(node: Node) {
-  return getAncestor(
-    node,
-    (parentNode) => parentNode.type.endsWith('Statement') || parentNode.type.endsWith('Declaration'),
-  );
+  return getAncestor(node, isBlockStatement);
 }
 
 export function getEnclosingScopeNode(node: Node) {
@@ -50,3 +51,40 @@ export function getEnclosingScopeNode(node: Node) {
     ['FunctionExpression', 'FunctionDeclaration', 'ArrowFunctionExpression', 'Program'].includes(parentNode.type),
   );
 }
+
+export function isUsedInArrayOrAsArgument(node: Node) {
+  if (isBlockStatement(node)) {
+    return false;
+  }
+
+  const parent = getParent(node);
+  if (!parent) {
+    return false;
+  }
+
+  if (
+    parent.type === 'ArrayExpression' ||
+    (parent.type === 'CallExpression' && parent.arguments.includes(node as Expression))
+  ) {
+    return true;
+  }
+
+  // recurse up the tree until hitting a block statement
+  return isUsedInArrayOrAsArgument(parent);
+}
+
+export function getEnclosingFunction(node: Node) {
+  if (
+    node.type === 'FunctionDeclaration' ||
+    node.type === 'FunctionExpression' ||
+    node.type === 'ArrowFunctionExpression'
+  ) {
+    return node;
+  }
+
+  const parent = getParent(node);
+  if (!parent) {
+    return;
+  }
+  return getEnclosingFunction(parent);
+}

package/src/fixture/{concurrent-promises.ts → fetch-then.ts}

@@ -1,4 +1,4 @@
-// fixture/concurrent-promises.ts
+// fixture/fetch-then.ts
 
 /*
  * Copyright (c) 2021-2024 Check Digit, LLC
@@ -8,15 +8,15 @@
 
 import type { CallExpression, Expression, MemberExpression, SimpleCallExpression } from 'estree';
 import { type Rule, type Scope, SourceCode } from 'eslint';
-import { getEnclosingStatement, getParent } from '../ast/tree';
+import { getEnclosingFunction, getEnclosingStatement, getParent, isUsedInArrayOrAsArgument } from '../ast/tree';
+import { hasAssertions, isInvalidResponseHeadersAccess } from './fetch';
 import { strict as assert } from 'node:assert';
 import getDocumentationUrl from '../get-documentation-url';
 import { getIndentation } from '../ast/format';
-import { isInvalidResponseHeadersAccess } from './fetch';
 import { isValidPropertyName } from './variable';
 import { replaceEndpointUrlPrefixWithBasePath } from './url';
 
-export const ruleId = 'concurrent-promises';
+export const ruleId = 'fetch-then';
 
 interface FixtureCallInformation {
   fixtureNode: SimpleCallExpression;
@@ -33,9 +33,12 @@ function analyzeFixtureCall(call: SimpleCallExpression, results: FixtureCallInfo
   }
 
   let nextCall;
-  if (parent.type === 'ArrayExpression') {
+  if (parent.type !== 'MemberExpression') {
     results.fixtureNode = call;
-  } else if (parent.type === 'MemberExpression' && parent.property.type === 'Identifier') {
+    return;
+  }
+
+  if (parent.property.type === 'Identifier') {
     if (parent.property.name === 'expect') {
       // supertest assertions
       const assertionCall = getParent(parent);
@@ -203,137 +206,148 @@ const rule: Rule.RuleModule = {
 
     return {
       // eslint-disable-next-line max-lines-per-function
-      'CallExpression[callee.object.name="Promise"] > ArrayExpression CallExpression[callee.object.object.name="fixture"][callee.object.property.name="api"]':
-        (fixtureCall: CallExpression) => {
-          try {
-            assert.ok(fixtureCall.type === 'CallExpression');
-            const fixtureFunction = fixtureCall.callee; // e.g. fixture.api.get
-            assert.ok(fixtureFunction.type === 'MemberExpression');
-            const indentation = getIndentation(fixtureCall, sourceCode);
+      'CallExpression[callee.object.object.name="fixture"][callee.object.property.name="api"]': (
+        fixtureCall: CallExpression,
+        // eslint-disable-next-line sonarjs/cognitive-complexity
+      ) => {
+        try {
+          if (!hasAssertions(fixtureCall)) {
+            // skip if there are no assertions, let "no-fixture" rule to handle the conversion
+            return;
+          }
 
-            const [urlArgumentNode] = fixtureCall.arguments; // e.g. `/sample-service/v1/ping`
-            assert.ok(urlArgumentNode !== undefined);
+          if (!(isUsedInArrayOrAsArgument(fixtureCall) || getEnclosingFunction(fixtureCall)?.async === false)) {
+            return;
+          }
 
-            const fixtureCallInformation = {} as FixtureCallInformation;
-            analyzeFixtureCall(fixtureCall, fixtureCallInformation, sourceCode);
+          assert.ok(fixtureCall.type === 'CallExpression');
+          const fixtureFunction = fixtureCall.callee; // e.g. fixture.api.get
+          assert.ok(fixtureFunction.type === 'MemberExpression');
+          const indentation = getIndentation(fixtureCall, sourceCode);
 
-            // convert url from `/sample-service/v1/ping` to `${BASE_PATH}/ping`
-            const originalUrlArgumentText = sourceCode.getText(urlArgumentNode);
-            const fetchUrlArgumentText = replaceEndpointUrlPrefixWithBasePath(originalUrlArgumentText);
+          const [urlArgumentNode] = fixtureCall.arguments; // e.g. `/sample-service/v1/ping`
+          assert.ok(urlArgumentNode !== undefined);
 
-            // fetch request argument
-            const methodNode = fixtureFunction.property; // get/put/etc.
-            assert.ok(methodNode.type === 'Identifier');
-            const fetchRequestArgumentLines = [
-              '{',
-              `  method: '${methodNode.name.toUpperCase()}',`,
-              ...(fixtureCallInformation.requestBody
-                ? [`  body: JSON.stringify(${sourceCode.getText(fixtureCallInformation.requestBody)}),`]
-                : []),
-              ...(fixtureCallInformation.requestHeaders
-                ? [
-                    `  headers: {`,
-                    ...fixtureCallInformation.requestHeaders.map(
-                      ({ name, value }) =>
-                        // eslint-disable-next-line @typescript-eslint/restrict-template-expressions, no-nested-ternary, sonarjs/no-nested-template-literals
-                        `    ${name.type === 'Literal' ? (isValidPropertyName(name.value) ? name.value : `'${name.value}'`) : `[${sourceCode.getText(name)}]`}: ${sourceCode.getText(value)},`,
-                    ),
-                    `  },`,
-                  ]
-                : []),
-              '}',
-            ].join(`\n${indentation}`);
+          const fixtureCallInformation = {} as FixtureCallInformation;
+          analyzeFixtureCall(fixtureCall, fixtureCallInformation, sourceCode);
 
-            const responseVariableNameToUse = 'res';
-            const { statusAssertion, nonStatusAssertions } = createResponseAssertions(
-              fixtureCallInformation,
-              sourceCode,
-              responseVariableNameToUse,
-            );
+          // convert url from `/sample-service/v1/ping` to `${BASE_PATH}/ping`
+          const originalUrlArgumentText = sourceCode.getText(urlArgumentNode);
+          const fetchUrlArgumentText = replaceEndpointUrlPrefixWithBasePath(originalUrlArgumentText);
 
-            // add variable declaration if needed
-            const disableLintComment = '// eslint-disable-next-line @checkdigit/no-promise-instance-method';
-            const fetchCallText = `fetch(${fetchUrlArgumentText}, ${fetchRequestArgumentLines})`;
-            const appendingAssignmentAndAssertionText = [
-              ...(statusAssertion !== undefined ? [statusAssertion] : []),
-              ...nonStatusAssertions,
-            ].join(`;\n${indentation}`);
-            const replacementText = fixtureCallInformation.assertions
+          // fetch request argument
+          const methodNode = fixtureFunction.property; // get/put/etc.
+          assert.ok(methodNode.type === 'Identifier');
+          const fetchRequestArgumentLines = [
+            '{',
+            `  method: '${methodNode.name.toUpperCase()}',`,
+            ...(fixtureCallInformation.requestBody
+              ? [`  body: JSON.stringify(${sourceCode.getText(fixtureCallInformation.requestBody)}),`]
+              : []),
+            ...(fixtureCallInformation.requestHeaders
               ? [
-                  disableLintComment,
-                  `${fetchCallText}.then((${responseVariableNameToUse}) => {`,
-                  appendingAssignmentAndAssertionText === '' ? '' : `  ${appendingAssignmentAndAssertionText};`,
-                  `  return ${responseVariableNameToUse};`,
-                  `})`,
-                ].join(`\n${indentation}`)
-              : fetchCallText;
+                  `  headers: {`,
+                  ...fixtureCallInformation.requestHeaders.map(
+                    ({ name, value }) =>
+                      // eslint-disable-next-line @typescript-eslint/restrict-template-expressions, no-nested-ternary, sonarjs/no-nested-template-literals
+                      `    ${name.type === 'Literal' ? (isValidPropertyName(name.value) ? name.value : `'${name.value}'`) : `[${sourceCode.getText(name)}]`}: ${sourceCode.getText(value)},`,
+                  ),
+                  `  },`,
+                ]
+              : []),
+            '}',
+          ].join(`\n${indentation}`);
 
-            context.report({
-              node: fixtureCall,
-              messageId: 'preferNativeFetch',
-              fix(fixer) {
-                return fixer.replaceText(fixtureCallInformation.fixtureNode, replacementText);
-              },
-            });
+          const responseVariableNameToUse = 'res';
+          const { statusAssertion, nonStatusAssertions } = createResponseAssertions(
+            fixtureCallInformation,
+            sourceCode,
+            responseVariableNameToUse,
+          );
 
-            const responsesVariable = getEnclosingStatement(fixtureCallInformation.fixtureNode);
-            if (!responsesVariable) {
-              return;
-            }
+          // add variable declaration if needed
+          const disableLintComment = '// eslint-disable-next-line @checkdigit/no-promise-instance-method';
+          const fetchCallText = `fetch(${fetchUrlArgumentText}, ${fetchRequestArgumentLines})`;
+          const appendingAssignmentAndAssertionText = [
+            ...(statusAssertion !== undefined ? [statusAssertion] : []),
+            ...nonStatusAssertions,
+          ].join(`;\n${indentation}`);
+          const replacementText = fixtureCallInformation.assertions
+            ? [
+                disableLintComment,
+                `${fetchCallText}.then((${responseVariableNameToUse}) => {`,
+                appendingAssignmentAndAssertionText === '' ? '' : `  ${appendingAssignmentAndAssertionText};`,
+                `  return ${responseVariableNameToUse};`,
+                `})`,
+              ].join(`\n${indentation}`)
+            : fetchCallText;
 
-            const responseVariableReferences = scopeManager.getDeclaredVariables(responsesVariable);
-            const responseHeadersAccesses = getResponseHeadersAccesses(
-              responseVariableReferences,
-              scopeManager,
-              sourceCode,
-            );
-            for (const responseHeadersAccess of responseHeadersAccesses) {
-              if (isInvalidResponseHeadersAccess(responseHeadersAccess)) {
-                const headerAccess = getParent(responseHeadersAccess);
-                if (headerAccess?.type === 'MemberExpression') {
-                  const headerNameNode = headerAccess.property;
-                  const headerName = headerAccess.computed
-                    ? sourceCode.getText(headerNameNode)
-                    : `'${sourceCode.getText(headerNameNode)}'`;
-                  const headerAccessReplacementText = `${sourceCode.getText(headerAccess.object)}.get(${headerName})`;
+          context.report({
+            node: fixtureCall,
+            messageId: 'preferNativeFetch',
+            fix(fixer) {
+              return fixer.replaceText(fixtureCallInformation.fixtureNode, replacementText);
+            },
+          });
 
-                  context.report({
-                    node: headerAccess,
-                    messageId: 'shouldUseHeaderGetter',
-                    fix(fixer) {
-                      return fixer.replaceText(headerAccess, headerAccessReplacementText);
-                    },
-                  });
-                } else if (
-                  headerAccess?.type === 'CallExpression' &&
-                  responseHeadersAccess.property.type === 'Identifier' &&
-                  responseHeadersAccess.property.name === 'get'
-                ) {
-                  const headerAccessReplacementText = `${sourceCode.getText(responseHeadersAccess.object)}.headers.get(${sourceCode.getText(headerAccess.arguments[0])})`;
+          const responsesVariable = getEnclosingStatement(fixtureCallInformation.fixtureNode);
+          if (!responsesVariable) {
+            return;
+          }
 
-                  context.report({
-                    node: headerAccess,
-                    messageId: 'shouldUseHeaderGetter',
-                    fix(fixer) {
-                      return fixer.replaceText(headerAccess, headerAccessReplacementText);
-                    },
-                  });
-                }
+          const responseVariableReferences = scopeManager.getDeclaredVariables(responsesVariable);
+          const responseHeadersAccesses = getResponseHeadersAccesses(
+            responseVariableReferences,
+            scopeManager,
+            sourceCode,
+          );
+          for (const responseHeadersAccess of responseHeadersAccesses) {
+            if (isInvalidResponseHeadersAccess(responseHeadersAccess)) {
+              const headerAccess = getParent(responseHeadersAccess);
+              if (headerAccess?.type === 'MemberExpression') {
+                const headerNameNode = headerAccess.property;
+                const headerName = headerAccess.computed
+                  ? sourceCode.getText(headerNameNode)
+                  : `'${sourceCode.getText(headerNameNode)}'`;
+                const headerAccessReplacementText = `${sourceCode.getText(headerAccess.object)}.get(${headerName})`;
+
+                context.report({
+                  node: headerAccess,
+                  messageId: 'shouldUseHeaderGetter',
+                  fix(fixer) {
+                    return fixer.replaceText(headerAccess, headerAccessReplacementText);
+                  },
+                });
+              } else if (
+                headerAccess?.type === 'CallExpression' &&
+                responseHeadersAccess.property.type === 'Identifier' &&
+                responseHeadersAccess.property.name === 'get'
+              ) {
+                const headerAccessReplacementText = `${sourceCode.getText(responseHeadersAccess.object)}.headers.get(${sourceCode.getText(headerAccess.arguments[0])})`;
+
+                context.report({
+                  node: headerAccess,
+                  messageId: 'shouldUseHeaderGetter',
+                  fix(fixer) {
+                    return fixer.replaceText(headerAccess, headerAccessReplacementText);
+                  },
+                });
               }
             }
-          } catch (error) {
-            // eslint-disable-next-line no-console
-            console.error(`Failed to apply ${ruleId} rule for file "${context.filename}":`, error);
-            context.report({
-              node: fixtureCall,
-              messageId: 'unknownError',
-              data: {
-                fileName: context.filename,
-                error: error instanceof Error ? error.toString() : JSON.stringify(error),
-              },
-            });
           }
-        },
+        } catch (error) {
+          // eslint-disable-next-line no-console
+          console.error(`Failed to apply ${ruleId} rule for file "${context.filename}":`, error);
+          context.report({
+            node: fixtureCall,
+            messageId: 'unknownError',
+            data: {
+              fileName: context.filename,
+              error: error instanceof Error ? error.toString() : JSON.stringify(error),
+            },
+          });
+        }
+      },
     };
   },
 };

package/src/fixture/fetch.ts

@@ -1,7 +1,7 @@
 // fixture/fetch.ts
 
+import { getParent, isBlockStatement } from '../ast/tree';
 import type { Node } from 'estree';
-import { getParent } from '../ast/tree';
 
 export function getResponseBodyRetrievalText(responseVariableName: string) {
   return `await ${responseVariableName}.json()`;
@@ -28,3 +28,25 @@ export function isInvalidResponseHeadersAccess(responseHeadersAccess: Node) {
     responseHeaderAccessParent.property.name === 'get'
   );
 }
+
+export function hasAssertions(fixtureCall: Node) {
+  if (isBlockStatement(fixtureCall)) {
+    return false;
+  }
+
+  const parent = getParent(fixtureCall);
+  if (!parent) {
+    return false;
+  }
+
+  if (
+    parent.type === 'MemberExpression' &&
+    parent.property.type === 'Identifier' &&
+    parent.property.name === 'expect' &&
+    getParent(parent)?.type === 'CallExpression'
+  ) {
+    return true;
+  }
+
+  return hasAssertions(parent);
+}

package/src/fixture/no-fixture.ts

@@ -17,19 +17,25 @@ import type {
   VariableDeclaration,
 } from 'estree';
 import { type Rule, type Scope, SourceCode } from 'eslint';
-import { getEnclosingScopeNode, getEnclosingStatement, getParent } from '../ast/tree';
+import {
+  getEnclosingFunction,
+  getEnclosingScopeNode,
+  getEnclosingStatement,
+  getParent,
+  isUsedInArrayOrAsArgument,
+} from '../ast/tree';
+import { getResponseBodyRetrievalText, hasAssertions } from './fetch';
 import { analyzeResponseReferences } from './response-reference';
 import { strict as assert } from 'node:assert';
 import getDocumentationUrl from '../get-documentation-url';
 import { getIndentation } from '../ast/format';
-import { getResponseBodyRetrievalText } from './fetch';
 import { isValidPropertyName } from './variable';
 import { replaceEndpointUrlPrefixWithBasePath } from './url';
 
 export const ruleId = 'no-fixture';
 
 interface FixtureCallInformation {
-  rootNode: AwaitExpression | ReturnStatement | VariableDeclaration;
+  rootNode: AwaitExpression | ReturnStatement | VariableDeclaration | SimpleCallExpression;
   fixtureNode: AwaitExpression | SimpleCallExpression;
   variableDeclaration?: VariableDeclaration;
   requestBody?: Expression;
@@ -37,10 +43,10 @@ interface FixtureCallInformation {
   assertions?: Expression[][];
   inlineStatementNode?: Node;
   inlineBodyReference?: MemberExpression;
-  isConcurrent?: boolean;
 }
 
 // recursively analyze the fixture/supertest call chain to collect information of request/response
+// eslint-disable-next-line sonarjs/cognitive-complexity
 function analyzeFixtureCall(call: SimpleCallExpression, results: FixtureCallInformation, sourceCode: SourceCode) {
   const parent = getParent(call);
   assert.ok(parent, 'parent should exist for fixture/supertest call node');
@@ -50,8 +56,10 @@ function analyzeFixtureCall(call: SimpleCallExpression, results: FixtureCallInfo
     // direct return, no variable declaration or await
     results.fixtureNode = call;
     results.rootNode = parent;
-  } else if (parent.type === 'ArrayExpression') {
-    results.isConcurrent = true;
+  } else if (parent.type === 'ArrayExpression' || parent.type === 'CallExpression') {
+    // direct return, no variable declaration or await
+    results.fixtureNode = call;
+    results.rootNode = call;
   } else if (parent.type === 'AwaitExpression') {
     results.fixtureNode = call;
     const enclosingStatement = getEnclosingStatement(parent);
@@ -238,6 +246,14 @@ const rule: Rule.RuleModule = {
         fixtureCall: CallExpression,
       ) => {
         try {
+          if (
+            hasAssertions(fixtureCall) &&
+            (isUsedInArrayOrAsArgument(fixtureCall) || getEnclosingFunction(fixtureCall)?.async === false)
+          ) {
+            // skip and leave it to "fetch-then" rule to handle it because no "await" can be used here
+            return;
+          }
+
           assert.ok(fixtureCall.type === 'CallExpression');
           const fixtureFunction = fixtureCall.callee; // e.g. fixture.api.get
           assert.ok(fixtureFunction.type === 'MemberExpression');
@@ -248,9 +264,6 @@ const rule: Rule.RuleModule = {
 
           const fixtureCallInformation = {} as FixtureCallInformation;
           analyzeFixtureCall(fixtureCall, fixtureCallInformation, sourceCode);
-          if (fixtureCallInformation.isConcurrent === true) {
-            return;
-          }
 
           const {
             variable: responseVariable,

package/src/index.ts

@@ -6,8 +6,8 @@
  * This code is licensed under the MIT license (see LICENSE.txt for details).
  */
 
-import concurrentPromises, { ruleId as concurrentPromisesRuleId } from './fixture/concurrent-promises';
 import fetchHeaderGetter, { ruleId as fetchHeaderGetterRuleId } from './fixture/fetch-header-getter';
+import fetchThen, { ruleId as fetchThenRuleId } from './fixture/fetch-then';
 import invalidJsonStringify, { ruleId as invalidJsonStringifyRuleId } from './invalid-json-stringify';
 import noFixture, { ruleId as noFixtureRuleId } from './fixture/no-fixture';
 import noPromiseInstanceMethod, { ruleId as noPromiseInstanceMethodRuleId } from './no-promise-instance-method';
@@ -36,7 +36,7 @@ export default {
     [noPromiseInstanceMethodRuleId]: noPromiseInstanceMethod,
     [noFixtureRuleId]: noFixture,
     [fetchHeaderGetterRuleId]: fetchHeaderGetter,
-    [concurrentPromisesRuleId]: concurrentPromises,
+    [fetchThenRuleId]: fetchThen,
   },
   configs: {
     all: {
@@ -54,7 +54,7 @@ export default {
         [`@checkdigit/${noPromiseInstanceMethodRuleId}`]: 'error',
         [`@checkdigit/${noFixtureRuleId}`]: 'error',
         [`@checkdigit/${fetchHeaderGetterRuleId}`]: 'error',
-        [`@checkdigit/${concurrentPromisesRuleId}`]: 'error',
+        [`@checkdigit/${fetchThenRuleId}`]: 'error',
       },
     },
     recommended: {