@chatpanel/bridge 0.11.0 → 0.11.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@chatpanel/bridge",
-  "version": "0.11.0",
+  "version": "0.11.2",
   "type": "module",
   "description": "Local bridge that exposes the AI coding agents installed on your machine \u2014 Claude Code (CLI), Codex (CLI), and Antigravity CLI (formerly Gemini CLI, which remains available for business/enterprise) \u2014 to the ChatPanel Chrome extension over a localhost SSE endpoint. Bring your own agent.",
   "keywords": [

package/src/channels/service.js

@@ -68,12 +68,15 @@ export function createChannelService({
   logger = console,
   fetchImpl = undefined,         // injected in tests
   now = () => Date.now(),
+  // The adapter is injectable for the same reason fetchImpl is: the thing worth asserting
+  // about the loop is WHAT it is handed, and a real Telegram long-poll cannot be asked.
+  startAdapter = startTelegram,
 } = {}) {
   const tokenFile = path.join(home, 'telegram-token');
   const configFile = path.join(dataDir, 'config.json');
   const pairingFile = path.join(dataDir, 'pairing.json');
 
-  let pairing = createPairingStore();
+  let pairing = null; // created by load(), then kept — see the note there
   let settings = { ...DEFAULT_SETTINGS };
   let appender = null;
   let bot = null;              // { id, username, name } once verified
@@ -83,7 +86,7 @@ export function createChannelService({
   let attempt = 0;
   let stopped = true;          // deliberate stop — suppresses the restart
 
-  const savePairing = () => writeJson(pairingFile, pairing.toJSON());
+  const savePairing = () => writeJson(pairingFile, pairing ? pairing.toJSON() : {});
   const saveSettings = () => writeJson(configFile, settings);
 
   async function readToken() {
@@ -100,7 +103,14 @@ export function createChannelService({
 
   async function load() {
     await mkdir(dataDir, { recursive: true });
-    pairing = createPairingStore(await readJson(pairingFile, {}), { now });
+    // Built ONCE and never replaced. spawnLoop() hands this exact object to the adapter, which
+    // holds it for the life of a polling loop — so rebuilding it here (as every service call
+    // used to) broke pairing in both directions at once: `pair()` minted the code into a fresh
+    // store the adapter could not see, so every redeem answered "unknown or expired code" no
+    // matter how many codes you generated; and `savePairing()` serialises whichever store this
+    // variable currently points at, so a redeem that DID land would have been persisted from
+    // the wrong object. Two aliases of one thing is the bug — there is only ever one store.
+    if (!pairing) pairing = createPairingStore(await readJson(pairingFile, {}), { now });
     settings = { ...DEFAULT_SETTINGS, ...(await readJson(configFile, {})) };
     if (!appender) appender = await createEventLog({ file: path.join(dataDir, 'events.jsonl'), host: 'channel' });
   }
@@ -110,7 +120,7 @@ export function createChannelService({
   function spawnLoop(botToken) {
     controller = new AbortController();
     running = true;
-    const done = startTelegram({
+    const done = startAdapter({
       botToken,
       baseUrl: bridge.baseUrl,
       token: bridge.token,

package/src/server.js

@@ -67,7 +67,7 @@ import {
 // Hardcoded (not read from package.json) so it survives Bun's single-file
 // --compile, where package.json isn't on a readable FS. CI fails the publish if
 // this drifts from package.json, so the two can't silently diverge.
-const VERSION = '0.11.0';
+const VERSION = '0.11.2';
 const HOST = process.env.CHATPANEL_BRIDGE_HOST || '127.0.0.1';
 const PORT = Number(process.env.CHATPANEL_BRIDGE_PORT) || 4319;
 
@@ -337,8 +337,19 @@ const PRIVILEGED_POST = new Set([
   '/channels/settings',
   '/channels/disconnect',
 ]);
-// /channels lists which phones may drive this machine. That is not a public reading.
-const PRIVILEGED_GET = new Set(['/debug', '/channels']);
+// /channels is NOT here, for the same reason /skills is not, and it was a regression to add
+// it: a privileged GET is unreachable from the extension. The panel holds `<all_urls>`, so
+// its fetches bypass CORS altogether — no preflight fires — and the Fetch spec attaches
+// `Origin` only to requests whose method is not GET or HEAD. That is the whole asymmetry:
+// every privileged POST here works, and a privileged GET can only ever answer the settings
+// page with "forbidden: this endpoint requires the ChatPanel extension or a valid bridge
+// token", which is what shipped in 0.11.0.
+//
+// Nothing is opened up by removing it. `originAllowed` still refuses any web page (it is the
+// check doing the work), so the only caller admitted is a local no-Origin process — which can
+// already read ~/.chatpanel/channels/ off the disk. /debug stays privileged: it exposes
+// configuration a local process cannot otherwise see.
+const PRIVILEGED_GET = new Set(['/debug']);
 
 // /skills* is NOT privileged, and that is a considered position rather than a
 // convenience. `privileged` adds exactly one thing over the origin allowlist: it requires