@chaosity/location-client 0.4.0 → 0.4.2

package/dist/adapters/GeoPlaces.js

@@ -2,6 +2,47 @@ import { GeocodeCommand, GetPlaceAdditionalFeature, GetPlaceCommand, ReverseGeoc
 import { geocodeResponseToFeatureCollection, getPlaceResponseToFeatureCollection, reverseGeocodeResponseToFeatureCollection, } from '@aws/amazon-location-utilities-datatypes';
 import debug from 'debug';
 const log = debug('location-client:geocoder');
+/**
+ * Give the control the fields it renders, not just the ones GeoJSON needs.
+ *
+ * `@maplibre/maplibre-gl-geocoder` is a Carmen-shaped consumer: its result list
+ * calls `item.place_name.split(',')`, the input takes `result.place_name` on
+ * select, and fly-to reads `center` / `bbox`. The AWS converters produce plain
+ * GeoJSON — `properties` and `geometry` only — so a forward geocode used to
+ * hand the control features with no `place_name`. The list renderer threw, the
+ * control caught it and emitted `error`, and with no listener that surfaced as
+ * `Unhandled error. (undefined)` in the console: the Enter key silently did
+ * nothing. Suggestions were unaffected because that path renders `text`.
+ *
+ * The `as MaplibreGeocoderFeatureResults` cast this replaces is what hid it —
+ * `place_name` and `text` are required on the type.
+ */
+function toCarmenFeatures(features) {
+    return features.map((feature) => {
+        const p = (feature.properties ?? {});
+        const title = typeof p.Title === 'string' ? p.Title : '';
+        const label = typeof p['Address.Label'] === 'string' ? p['Address.Label'] : '';
+        // `flattenProperties` flattens nested OBJECTS (Address.Label) but leaves an
+        // array of numbers intact, so MapView is still [minx, miny, maxx, maxy].
+        const view = p.MapView;
+        const bbox = Array.isArray(view) &&
+            view.length === 4 &&
+            view.every((v) => typeof v === 'number')
+            ? view
+            : undefined;
+        const center = feature.geometry?.type === 'Point'
+            ? feature.geometry.coordinates
+            : undefined;
+        return {
+            ...feature,
+            text: title || label,
+            place_name: label || title,
+            place_type: typeof p.PlaceType === 'string' ? [p.PlaceType] : [],
+            ...(bbox ? { bbox } : {}),
+            ...(center ? { center } : {}),
+        };
+    });
+}
 export class GeoPlaces {
     constructor(client, map, options = {}) {
         this.client = client;
@@ -53,10 +94,14 @@ export class GeoPlaces {
             };
         }
         const response = (await this.client.send(new GeocodeCommand(commandInput)));
-        const result = geocodeResponseToFeatureCollection(response, {
+        const converted = geocodeResponseToFeatureCollection(response, {
             flattenProperties: true,
         });
-        log('forwardGeocode returned %d results', result.features?.length ?? 0);
+        const result = {
+            type: 'FeatureCollection',
+            features: toCarmenFeatures(converted.features),
+        };
+        log('forwardGeocode returned %d results', result.features.length);
         return result;
     }
     async reverseGeocode(config) {
@@ -70,10 +115,14 @@ export class GeoPlaces {
             Language: this.normalizeLanguage(config.language),
         };
         const response = (await this.client.send(new ReverseGeocodeCommand(commandInput)));
-        const result = reverseGeocodeResponseToFeatureCollection(response, {
+        const converted = reverseGeocodeResponseToFeatureCollection(response, {
             flattenProperties: true,
         });
-        log('reverseGeocode returned %d results', result.features?.length ?? 0);
+        const result = {
+            type: 'FeatureCollection',
+            features: toCarmenFeatures(converted.features),
+        };
+        log('reverseGeocode returned %d results', result.features.length);
         return result;
     }
     async getSuggestions(config) {

package/dist/maps/mapStyle.js

@@ -1,3 +1,4 @@
+import { parseErrorResponse } from '../transport/errors';
 /**
  * Build a map style descriptor URL for the Location Service API.
  *
@@ -61,7 +62,19 @@ export async function fetchMapStyle(apiUrl, mapStyle, getToken, options = {}) {
         },
     });
     if (!response.ok) {
-        throw new Error(`Failed to fetch map style: ${response.status} ${response.statusText}`);
+        // Read the body. The API sends `{message, code, requestId}` and the message
+        // is the whole point of it — for a style request it is Amazon's own
+        // sentence, forwarded verbatim by location-service-api#89:
+        //
+        //   400 "Traffic is not supported for style."
+        //   400 "light is not a supported color scheme for style Standard."
+        //
+        // This used to throw `Failed to fetch map style: 400`, discarding all of it
+        // two lines before anyone could read it — the same defect #89 fixed in the
+        // API, one layer up. Reuses parseErrorResponse so a style failure arrives as
+        // the same LocationServiceException as every other call in this package,
+        // with `code`, `statusCode` and `requestId` intact.
+        throw parseErrorResponse(response.status, response.statusText, await response.text(), response.headers);
     }
     const style = (await response.json());
     if (language) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@chaosity/location-client",
-  "version": "0.4.0",
+  "version": "0.4.2",
   "description": "Client library for Chaosity Location Service with AWS Location Service compatibility",
   "type": "module",
   "main": "dist/index.js",