@channel47/google-ads-mcp 1.0.2 → 1.0.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@channel47/google-ads-mcp",
-  "version": "1.0.2",
+  "version": "1.0.4",
   "description": "Google Ads MCP Server - Query and mutate Google Ads data using GAQL",
   "main": "server/index.js",
   "bin": {

package/server/tools/mutate.js

@@ -60,10 +60,14 @@ export async function mutate(params) {
     if (partial_failure && error.errors && Array.isArray(error.errors)) {
       for (const err of error.errors) {
         const opIndex = err.location?.field_path_elements?.[0]?.index ?? -1;
+        // Extract full field path for debugging (e.g., "operations.create.campaign_bidding_strategy")
+        const fieldPath = err.location?.field_path_elements?.map(e => e.field_name).join('.') || null;
         partialFailureErrors.push({
           message: err.message || JSON.stringify(err.error_code),
           error_code: err.error_code,
-          operation_index: opIndex
+          operation_index: opIndex,
+          field_path: fieldPath,
+          trigger: err.trigger?.string_value || null
         });
       }
 
@@ -91,10 +95,13 @@ export async function mutate(params) {
       || [];
 
     for (const error of errorDetails) {
+      const fieldPath = error.location?.field_path_elements?.map(e => e.field_name).join('.') || null;
       partialFailureErrors.push({
         message: error.message || error.error_message || JSON.stringify(error),
         error_code: error.error_code || error.code,
-        operation_index: error.location?.field_path_elements?.[0]?.index ?? -1
+        operation_index: error.location?.field_path_elements?.[0]?.index ?? -1,
+        field_path: fieldPath,
+        trigger: error.trigger?.string_value || null
       });
     }
   }

package/server/utils/operation-transform.js

@@ -3,6 +3,15 @@
  * Converts standard Google Ads API format to Opteo library format
  */
 
+/**
+ * Entities that legitimately use resource_name in CREATE operations.
+ * These use temporary resource IDs (-1, -2, etc.) for atomic multi-resource creation.
+ * See: https://developers.google.com/google-ads/api/docs/mutating/overview
+ */
+const ENTITIES_REQUIRING_RESOURCE_NAME_IN_CREATE = new Set([
+  'campaign_budget'  // Used for temp IDs when creating budget + campaign atomically
+]);
+
 /**
  * Resource name URL path segments to entity type mapping
  * Based on Google Ads API resource name patterns
@@ -156,12 +165,13 @@ function transformToOpteoFormat(operation, index) {
 
   if (opType === 'remove') {
     // Remove operations have resource_name as string value
+    // The Opteo library expects resource to be the string directly for remove ops
     const resourceName = operation.remove;
     if (typeof resourceName !== 'string') {
       throw new Error(`Operation ${index}: 'remove' value must be a resource_name string`);
     }
     entity = inferEntityFromResourceName(resourceName);
-    resource = { resource_name: resourceName };
+    resource = resourceName;  // String, not object - Opteo expects { remove: "resource_name" }
   } else {
     // Create/Update operations have resource as object
     resource = operation[opType];
@@ -193,6 +203,16 @@ function transformToOpteoFormat(operation, index) {
     );
   }
 
+  // Strip resource_name from CREATE operations (API generates it automatically)
+  // Exception: entities that use temp IDs for atomic multi-resource creation
+  // See: https://developers.google.com/google-ads/api/docs/campaigns/create-campaigns
+  if (opType === 'create' && resource.resource_name) {
+    if (!ENTITIES_REQUIRING_RESOURCE_NAME_IN_CREATE.has(entity)) {
+      const { resource_name, ...resourceWithoutName } = resource;
+      resource = resourceWithoutName;
+    }
+  }
+
   return {
     entity,
     operation: opType,
@@ -214,8 +234,16 @@ export function normalizeOperations(operations) {
     const op = operations[i];
 
     if (isOpteoFormat(op)) {
-      // Already in Opteo format - pass through
-      normalizedOps.push(op);
+      // Already in Opteo format - pass through, but normalize remove operations
+      // For remove ops, ensure resource is the string, not an object
+      if (op.operation === 'remove' && op.resource && typeof op.resource === 'object') {
+        normalizedOps.push({
+          ...op,
+          resource: op.resource.resource_name || op.resource
+        });
+      } else {
+        normalizedOps.push(op);
+      }
     } else {
       // Transform from standard format
       const transformed = transformToOpteoFormat(op, i);