@cesium/engine 18.3.1-ion.0 → 19.0.0

package/Source/Scene/Cesium3DTileStyle.js

@@ -1,3 +1,4 @@
+import addAllToArray from "../Core/addAllToArray.js";
 import clone from "../Core/clone.js";
 import Frozen from "../Core/Frozen.js";
 import defined from "../Core/defined.js";
@@ -1452,15 +1453,15 @@ Cesium3DTileStyle.prototype.getVariables = function () {
   let variables = [];
 
   if (defined(this.color) && defined(this.color.getVariables)) {
-    variables.push.apply(variables, this.color.getVariables());
+    addAllToArray(variables, this.color.getVariables());
   }
 
   if (defined(this.show) && defined(this.show.getVariables)) {
-    variables.push.apply(variables, this.show.getVariables());
+    addAllToArray(variables, this.show.getVariables());
   }
 
   if (defined(this.pointSize) && defined(this.pointSize.getVariables)) {
-    variables.push.apply(variables, this.pointSize.getVariables());
+    addAllToArray(variables, this.pointSize.getVariables());
   }
 
   // Remove duplicates

package/Source/Scene/Cesium3DTileset.js

@@ -119,7 +119,7 @@ import ImageryLayerCollection from "./ImageryLayerCollection.js";
  * @property {string|number} [instanceFeatureIdLabel="instanceFeatureId_0"] Label of the instance feature ID set used for picking and styling. If instanceFeatureIdLabel is set to an integer N, it is converted to the string "instanceFeatureId_N" automatically. If both per-primitive and per-instance feature IDs are present, the instance feature IDs take priority.
  * @property {boolean} [showCreditsOnScreen=false] Whether to display the credits of this tileset on screen.
  * @property {SplitDirection} [splitDirection=SplitDirection.NONE] The {@link SplitDirection} split to apply to this tileset.
- * @property {boolean} [enableCollision=false] When <code>true</code>, enables collisions for camera or CPU picking. While this is <code>true</code> the camera will be prevented from going below the tileset surface if {@link ScreenSpaceCameraController#enableCollisionDetection} is true.
+ * @property {boolean} [enableCollision=false] When <code>true</code>, enables collisions for camera or CPU picking. While this is <code>true</code> the camera will be prevented from going below the tileset surface if {@link ScreenSpaceCameraController#enableCollisionDetection} is true. This also affects the behavior of {@link HeightReference.CLAMP_TO_GROUND} when clamping to 3D Tiles surfaces. If <code>enableCollision</code> is <code>false</code>, entities may not be correctly clamped to the tileset geometry.
  * @property {boolean} [projectTo2D=false] Whether to accurately project the tileset to 2D. If this is true, the tileset will be projected accurately to 2D, but it will use more memory to do so. If this is false, the tileset will use less memory and will still render in 2D / CV mode, but its projected positions may be inaccurate. This cannot be set after the tileset has been created.
  * @property {boolean} [enablePick=false] Whether to allow collision and CPU picking with <code>pick</code> when using WebGL 1. If using WebGL 2 or above, this option will be ignored. If using WebGL 1 and this is true, the <code>pick</code> operation will work correctly, but it will use more memory to do so. If running with WebGL 1 and this is false, the model will use less memory, but <code>pick</code> will always return <code>undefined</code>. This cannot be set after the tileset has loaded.
  * @property {boolean} [asynchronouslyLoadImagery=false] Whether loading imagery that is draped over the tileset should be done asynchronously. If this is <code>true</code>, then tile content will be displayed with its original texture until the imagery texture is loaded. If this is <code>false</code>, then the tile content will not be displayed until the imagery is ready.

package/Source/Scene/ConditionsExpression.js

@@ -1,3 +1,4 @@
+import addAllToArray from "../Core/addAllToArray.js";
 import clone from "../Core/clone.js";
 import defined from "../Core/defined.js";
 import Expression from "./Expression.js";
@@ -203,8 +204,8 @@ ConditionsExpression.prototype.getVariables = function () {
   const length = conditions.length;
   for (let i = 0; i < length; ++i) {
     const statement = conditions[i];
-    variables.push.apply(variables, statement.condition.getVariables());
-    variables.push.apply(variables, statement.expression.getVariables());
+    addAllToArray(variables, statement.condition.getVariables());
+    addAllToArray(variables, statement.expression.getVariables());
   }
 
   // Remove duplicates

package/Source/Scene/GaussianSplatPrimitive.js

@@ -720,7 +720,7 @@ GaussianSplatPrimitive.prototype.update = function (frameState) {
     this._rootTransform = tileset.root.computedTransform;
   }
 
-  if (this._drawCommand) {
+  if (this._drawCommand && tileset.show) {
     frameState.commandList.push(this._drawCommand);
   }
 

package/Source/Scene/GltfLoader.js

@@ -32,6 +32,7 @@ import VertexAttributeSemantic from "./VertexAttributeSemantic.js";
 import GltfGpmLoader from "./Model/Extensions/Gpm/GltfGpmLoader.js";
 import GltfMeshPrimitiveGpmLoader from "./Model/Extensions/Gpm/GltfMeshPrimitiveGpmLoader.js";
 import oneTimeWarning from "../Core/oneTimeWarning.js";
+import addAllToArray from "../Core/addAllToArray.js";
 
 const {
   Attribute,
@@ -2827,12 +2828,12 @@ function parse(loader, frameState) {
 
   // Gather promises and handle any errors
   const readyPromises = [];
-  readyPromises.push.apply(readyPromises, loader._loaderPromises);
+  addAllToArray(readyPromises, loader._loaderPromises);
 
   // When incrementallyLoadTextures is true, the errors are caught and thrown individually
   // since it doesn't affect the overall loader state
   if (!loader._incrementallyLoadTextures) {
-    readyPromises.push.apply(readyPromises, loader._texturesPromises);
+    addAllToArray(readyPromises, loader._texturesPromises);
   }
 
   return Promise.all(readyPromises);

package/Source/Scene/GltfPipeline/ForEach.js

@@ -80,7 +80,7 @@ ForEach.accessorWithSemantic = function (gltf, semantic, handler) {
               return value;
             }
           }
-        }
+        },
       );
 
       if (defined(valueForEach)) {
@@ -102,7 +102,7 @@ ForEach.accessorWithSemantic = function (gltf, semantic, handler) {
                 return value;
               }
             }
-          }
+          },
         );
       });
     });
@@ -124,7 +124,7 @@ ForEach.accessorContainingVertexAttributeData = function (gltf, handler) {
               return value;
             }
           }
-        }
+        },
       );
 
       if (defined(valueForEach)) {
@@ -143,7 +143,7 @@ ForEach.accessorContainingVertexAttributeData = function (gltf, handler) {
                 return value;
               }
             }
-          }
+          },
         );
       });
     });
@@ -322,7 +322,7 @@ ForEach.program = function (gltf, handler) {
   if (usesExtension(gltf, "KHR_techniques_webgl")) {
     return ForEach.object(
       gltf.extensions.KHR_techniques_webgl.programs,
-      handler
+      handler,
     );
   }
 
@@ -341,7 +341,7 @@ ForEach.shader = function (gltf, handler) {
   if (usesExtension(gltf, "KHR_techniques_webgl")) {
     return ForEach.object(
       gltf.extensions.KHR_techniques_webgl.shaders,
-      handler
+      handler,
     );
   }
 
@@ -410,7 +410,7 @@ ForEach.technique = function (gltf, handler) {
   if (usesExtension(gltf, "KHR_techniques_webgl")) {
     return ForEach.object(
       gltf.extensions.KHR_techniques_webgl.techniques,
-      handler
+      handler,
     );
   }
 

package/Source/Scene/GltfPipeline/addDefaults.js

@@ -1,7 +1,6 @@
 import addToArray from "./addToArray.js";
 import ForEach from "./ForEach.js";
 import getAccessorByteStride from "./getAccessorByteStride.js";
-import Frozen from "../../Core/Frozen.js";
 import defined from "../../Core/defined.js";
 import WebGLConstants from "../../Core/WebGLConstants.js";
 
@@ -62,7 +61,7 @@ function addDefaults(gltf) {
   });
 
   ForEach.material(gltf, function (material) {
-    const extensions = material.extensions ?? Frozen.EMPTY_OBJECT;
+    const extensions = material.extensions ?? {};
     const materialsCommon = extensions.KHR_materials_common;
     if (defined(materialsCommon)) {
       const technique = materialsCommon.technique;

package/Source/Scene/GltfPipeline/addToArray.js

@@ -1,3 +1,5 @@
+
+
 /**
  * Adds an element to an array and returns the element's index.
  *

package/Source/Scene/GltfPipeline/findAccessorMinMax.js

@@ -52,7 +52,7 @@ function findAccessorMinMax(gltf, accessor) {
       byteOffset,
       numberOfComponents,
       componentTypeByteLength,
-      components
+      components,
     );
     for (let j = 0; j < numberOfComponents; j++) {
       const value = components[j];

package/Source/Scene/GltfPipeline/getComponentReader.js

@@ -16,11 +16,11 @@ function getComponentReader(componentType) {
         byteOffset,
         numberOfComponents,
         componentTypeByteLength,
-        result
+        result,
       ) {
         for (let i = 0; i < numberOfComponents; ++i) {
           result[i] = dataView.getInt8(
-            byteOffset + i * componentTypeByteLength
+            byteOffset + i * componentTypeByteLength,
           );
         }
       };
@@ -30,11 +30,11 @@ function getComponentReader(componentType) {
         byteOffset,
         numberOfComponents,
         componentTypeByteLength,
-        result
+        result,
       ) {
         for (let i = 0; i < numberOfComponents; ++i) {
           result[i] = dataView.getUint8(
-            byteOffset + i * componentTypeByteLength
+            byteOffset + i * componentTypeByteLength,
           );
         }
       };
@@ -44,12 +44,12 @@ function getComponentReader(componentType) {
         byteOffset,
         numberOfComponents,
         componentTypeByteLength,
-        result
+        result,
       ) {
         for (let i = 0; i < numberOfComponents; ++i) {
           result[i] = dataView.getInt16(
             byteOffset + i * componentTypeByteLength,
-            true
+            true,
           );
         }
       };
@@ -59,12 +59,12 @@ function getComponentReader(componentType) {
         byteOffset,
         numberOfComponents,
         componentTypeByteLength,
-        result
+        result,
       ) {
         for (let i = 0; i < numberOfComponents; ++i) {
           result[i] = dataView.getUint16(
             byteOffset + i * componentTypeByteLength,
-            true
+            true,
           );
         }
       };
@@ -74,12 +74,12 @@ function getComponentReader(componentType) {
         byteOffset,
         numberOfComponents,
         componentTypeByteLength,
-        result
+        result,
       ) {
         for (let i = 0; i < numberOfComponents; ++i) {
           result[i] = dataView.getInt32(
             byteOffset + i * componentTypeByteLength,
-            true
+            true,
           );
         }
       };
@@ -89,12 +89,12 @@ function getComponentReader(componentType) {
         byteOffset,
         numberOfComponents,
         componentTypeByteLength,
-        result
+        result,
       ) {
         for (let i = 0; i < numberOfComponents; ++i) {
           result[i] = dataView.getUint32(
             byteOffset + i * componentTypeByteLength,
-            true
+            true,
           );
         }
       };
@@ -104,12 +104,12 @@ function getComponentReader(componentType) {
         byteOffset,
         numberOfComponents,
         componentTypeByteLength,
-        result
+        result,
       ) {
         for (let i = 0; i < numberOfComponents; ++i) {
           result[i] = dataView.getFloat32(
             byteOffset + i * componentTypeByteLength,
-            true
+            true,
           );
         }
       };
@@ -119,12 +119,12 @@ function getComponentReader(componentType) {
         byteOffset,
         numberOfComponents,
         componentTypeByteLength,
-        result
+        result,
       ) {
         for (let i = 0; i < numberOfComponents; ++i) {
           result[i] = dataView.getFloat64(
             byteOffset + i * componentTypeByteLength,
-            true
+            true,
           );
         }
       };

package/Source/Scene/GltfPipeline/moveTechniqueRenderStates.js

@@ -87,7 +87,7 @@ function moveTechniqueRenderStates(gltf) {
               blendFunctions.blendEquationSeparate ?? defaultBlendEquation,
             blendFactors: getSupportedBlendFactors(
               blendFunctions.blendFuncSeparate,
-              defaultBlendFactors
+              defaultBlendFactors,
             ),
           };
         }

package/Source/Scene/GltfPipeline/moveTechniquesToExtension.js

@@ -44,7 +44,7 @@ function moveTechniquesToExtension(gltf) {
           technique.attributes[attributeName] = {
             semantic: parameterLegacy.semantic,
           };
-        }
+        },
       );
 
       ForEach.techniqueUniform(
@@ -64,7 +64,7 @@ function moveTechniquesToExtension(gltf) {
             mappedUniforms[techniqueId] = {};
           }
           mappedUniforms[techniqueId][parameterName] = uniformName;
-        }
+        },
       );
 
       if (!defined(seenPrograms[techniqueLegacy.program])) {
@@ -92,7 +92,7 @@ function moveTechniquesToExtension(gltf) {
       // Store the index of the new technique to reference instead.
       updatedTechniqueIndices[techniqueId] = addToArray(
         extension.techniques,
-        technique
+        technique,
       );
     });
 

package/Source/Scene/GltfPipeline/parseGlb.js

@@ -43,7 +43,7 @@ function readHeader(glb, byteOffset, count) {
   for (let i = 0; i < count; ++i) {
     header[i] = dataView.getUint32(
       glb.byteOffset + byteOffset + i * sizeOfUint32,
-      true
+      true,
     );
   }
   return header;

package/Source/Scene/GltfPipeline/readAccessorPacked.js

@@ -16,7 +16,7 @@ import defined from "../../Core/defined.js";
 function readAccessorPacked(gltf, accessor) {
   const byteStride = getAccessorByteStride(gltf, accessor);
   const componentTypeByteLength = ComponentDatatype.getSizeInBytes(
-    accessor.componentType
+    accessor.componentType,
   );
   const numberOfComponents = numberOfComponentsForType(accessor.type);
   const count = accessor.count;
@@ -41,7 +41,7 @@ function readAccessorPacked(gltf, accessor) {
       byteOffset,
       numberOfComponents,
       componentTypeByteLength,
-      components
+      components,
     );
     for (let j = 0; j < numberOfComponents; ++j) {
       values[i * numberOfComponents + j] = components[j];

package/Source/Scene/GltfPipeline/removeUnusedElements.js

@@ -87,7 +87,7 @@ Remove.accessor = function (gltf, accessorId) {
           if (attributeAccessorId > accessorId) {
             primitive.attributes[semantic]--;
           }
-        }
+        },
       );
 
       // Update accessor ids for the targets.
@@ -98,7 +98,7 @@ Remove.accessor = function (gltf, accessorId) {
             if (attributeAccessorId > accessorId) {
               target[semantic]--;
             }
-          }
+          },
         );
       });
       const indices = primitive.indices;
@@ -548,7 +548,7 @@ getListOfElementsIdsInUse.accessor = function (gltf) {
             const attributeAccessorId =
               node.extensions.EXT_mesh_gpu_instancing.attributes[key];
             usedAccessorIds[attributeAccessorId] = true;
-          }
+          },
         );
       }
     });
@@ -587,9 +587,8 @@ getListOfElementsIdsInUse.buffer = function (gltf) {
       defined(bufferView.extensions) &&
       defined(bufferView.extensions.EXT_meshopt_compression)
     ) {
-      usedBufferIds[
-        bufferView.extensions.EXT_meshopt_compression.buffer
-      ] = true;
+      usedBufferIds[bufferView.extensions.EXT_meshopt_compression.buffer] =
+        true;
     }
   });
 

package/Source/Scene/GltfPipeline/updateAccessorComponentTypes.js

@@ -42,7 +42,7 @@ function updateAccessorComponentTypes(gltf) {
 function convertType(gltf, accessor, updatedComponentType) {
   const typedArray = ComponentDatatype.createTypedArray(
     updatedComponentType,
-    readAccessorPacked(gltf, accessor)
+    readAccessorPacked(gltf, accessor),
   );
   const newBuffer = new Uint8Array(typedArray.buffer);
   accessor.bufferView = addBuffer(gltf, newBuffer);

package/Source/Scene/GltfPipeline/updateVersion.js

@@ -13,7 +13,6 @@ import Cartesian3 from "../../Core/Cartesian3.js";
 import Cartesian4 from "../../Core/Cartesian4.js";
 import clone from "../../Core/clone.js";
 import ComponentDatatype from "../../Core/ComponentDatatype.js";
-import Frozen from "../../Core/Frozen.js";
 import defined from "../../Core/defined.js";
 import Matrix4 from "../../Core/Matrix4.js";
 import Quaternion from "../../Core/Quaternion.js";
@@ -40,11 +39,13 @@ const updateFunctions = {
  * @private
  */
 function updateVersion(gltf, options) {
-  options = options ?? Frozen.EMPTY_OBJECT;
+  options = options ?? {};
   const targetVersion = options.targetVersion;
   let version = gltf.version;
 
-  gltf.asset = gltf.asset ?? { version: "1.0" };
+  gltf.asset = gltf.asset ?? {
+    version: "1.0",
+  };
 
   gltf.asset.version = gltf.asset.version ?? "1.0";
   version = (version ?? gltf.asset.version).toString();
@@ -176,7 +177,7 @@ function updateAnimations(gltf) {
               componentType,
               source.buffer,
               byteOffset,
-              length
+              length,
             );
 
             for (let j = 0; j < count; j++) {
@@ -416,7 +417,7 @@ function objectsToArrays(gltf) {
         primitive,
         function (accessorId, semantic) {
           primitive.attributes[semantic] = globalMapping.accessors[accessorId];
-        }
+        },
       );
       if (defined(primitive.material)) {
         primitive.material = globalMapping.materials[primitive.material];
@@ -636,7 +637,7 @@ function requireAttributeSetIndex(gltf) {
           } else if (semantic === "COLOR") {
             primitive.attributes.COLOR_0 = accessorId;
           }
-        }
+        },
       );
       delete primitive.attributes.TEXCOORD;
       delete primitive.attributes.COLOR;
@@ -695,7 +696,7 @@ function underscoreApplicationSpecificSemantics(gltf) {
               mappedSemantics[semantic] = newSemantic;
             }
           }
-        }
+        },
       );
       for (const semantic in mappedSemantics) {
         if (Object.prototype.hasOwnProperty.call(mappedSemantics, semantic)) {
@@ -756,7 +757,7 @@ function requireByteLength(gltf) {
         accessor.byteOffset + accessor.count * accessorByteStride;
       bufferView.byteLength = Math.max(
         bufferView.byteLength ?? 0,
-        accessorByteEnd
+        accessorByteEnd,
       );
     }
   });
@@ -861,7 +862,7 @@ function isNodeEmpty(node) {
       Cartesian3.fromArray(node.scale).equals(new Cartesian3(1.0, 1.0, 1.0))) &&
     (!defined(node.rotation) ||
       Cartesian4.fromArray(node.rotation).equals(
-        new Cartesian4(0.0, 0.0, 0.0, 1.0)
+        new Cartesian4(0.0, 0.0, 0.0, 1.0),
       )) &&
     (!defined(node.matrix) ||
       Matrix4.fromColumnMajorArray(node.matrix).equals(Matrix4.IDENTITY)) &&
@@ -1028,7 +1029,7 @@ function srgbToLinear(srgb) {
       linear[i] = Math.pow(
         // eslint-disable-next-line no-loss-of-precision
         (c + 0.055) * 0.94786729857819905213270142180095,
-        2.4
+        2.4,
       );
     }
   }
@@ -1037,7 +1038,7 @@ function srgbToLinear(srgb) {
 }
 
 function convertTechniquesToPbr(gltf, options) {
-  options = options ?? Frozen.EMPTY_OBJECT;
+  options = options ?? {};
   const baseColorTextureNames =
     options.baseColorTextureNames ?? defaultBaseColorTextureNames;
   const baseColorFactorNames =
@@ -1083,8 +1084,7 @@ function assignAsEmissive(material, emissive) {
 function convertMaterialsCommonToPbr(gltf) {
   // Future work: convert KHR_materials_common lights to KHR_lights_punctual
   ForEach.material(gltf, function (material) {
-    const materialsCommon = (material.extensions ?? Frozen.EMPTY_OBJECT)
-      .KHR_materials_common;
+    const materialsCommon = (material.extensions ?? {}).KHR_materials_common;
     if (!defined(materialsCommon)) {
       // Nothing to do
       return;

package/Source/Scene/GltfSpzLoader.js

@@ -194,7 +194,9 @@ GltfSpzLoader.prototype.process = function (frameState) {
     return false;
   }
 
-  const decodePromise = loadSpz(this._bufferViewTypedArray);
+  const decodePromise = loadSpz(this._bufferViewTypedArray, {
+    unpackOptions: { coordinateSystem: "UNSPECIFIED" },
+  });
 
   if (!defined(decodePromise)) {
     return false;

package/Source/Scene/HeightReference.js

@@ -12,7 +12,7 @@ const HeightReference = {
   NONE: 0,
 
   /**
-   * The position is clamped to the terrain and 3D Tiles.
+   * The position is clamped to the terrain and 3D Tiles. When clamping to 3D Tilesets such as photorealistic 3D Tiles, ensure the tileset has {@link Cesium3DTileset#enableCollision} set to <code>true</code>. Otherwise, the entity may not be correctly clamped to the tileset surface.
    * @type {number}
    * @constant
    */