@cesium/engine 12.0.0 → 13.0.0

package/Source/Scene/PostProcessStageLibrary.js

@@ -476,27 +476,19 @@ PostProcessStageLibrary.createBloomStage = function () {
  * surface receives light and regardless of the light's position.
  * </p>
  * <p>
- * The uniforms have the following properties: <code>intensity</code>, <code>bias</code>, <code>lengthCap</code>,
- * <code>stepSize</code>, <code>frustumLength</code>, <code>randomTexture</code>, <code>ambientOcclusionOnly</code>,
- * <code>delta</code>, <code>sigma</code>, and <code>blurStepSize</code>.
- * </p>
+ * The uniforms have the following properties:
  * <ul>
  * <li><code>intensity</code> is a scalar value used to lighten or darken the shadows exponentially. Higher values make the shadows darker. The default value is <code>3.0</code>.</li>
  * <li><code>bias</code> is a scalar value representing an angle in radians. If the dot product between the normal of the sample and the vector to the camera is less than this value,
  * sampling stops in the current direction. This is used to remove shadows from near planar edges. The default value is <code>0.1</code>.</li>
  * <li><code>lengthCap</code> is a scalar value representing a length in meters. If the distance from the current sample to first sample is greater than this value,
  * sampling stops in the current direction. The default value is <code>0.26</code>.</li>
- * <li><code>stepSize</code> is a scalar value indicating the distance to the next texel sample in the current direction. The default value is <code>1.95</code>.</li>
- * <li><code>frustumLength</code> is a scalar value in meters. If the current fragment has a distance from the camera greater than this value, ambient occlusion is not computed for the fragment.
- * The default value is <code>1000.0</code>.</li>
+ * <li><code>directionCount</code> is the number of directions along which the ray marching will search for occluders. The default value is <code>8</code>.</li>
+ * <li><code>stepCount</code> is the number of steps the ray marching will take along each direction. The default value is <code>32</code>.</li>
  * <li><code>randomTexture</code> is a texture where the red channel is a random value in [0.0, 1.0]. The default value is <code>undefined</code>. This texture needs to be set.</li>
  * <li><code>ambientOcclusionOnly</code> is a boolean value. When <code>true</code>, only the shadows generated are written to the output. When <code>false</code>, the input texture is modulated
  * with the ambient occlusion. This is a useful debug option for seeing the effects of changing the uniform values. The default value is <code>false</code>.</li>
  * </ul>
- * <p>
- * <code>delta</code>, <code>sigma</code>, and <code>blurStepSize</code> are the same properties as {@link PostProcessStageLibrary#createBlurStage}.
- * The blur is applied to the shadows generated from the image to make them smoother.
- * </p>
  * @return {PostProcessStageComposite} A post-process stage that applies an ambient occlusion effect.
  *
  * @private
@@ -509,24 +501,18 @@ PostProcessStageLibrary.createAmbientOcclusionStage = function () {
       intensity: 3.0,
       bias: 0.1,
       lengthCap: 0.26,
-      stepSize: 1.95,
-      frustumLength: 1000.0,
+      directionCount: 8,
+      stepCount: 32,
       randomTexture: undefined,
     },
   });
-  const blur = createBlur("czm_ambient_occlusion_blur");
-  blur.uniforms.stepSize = 0.86;
-  const generateAndBlur = new PostProcessStageComposite({
-    name: "czm_ambient_occlusion_generate_blur",
-    stages: [generate, blur],
-  });
 
   const ambientOcclusionModulate = new PostProcessStage({
     name: "czm_ambient_occlusion_composite",
     fragmentShader: AmbientOcclusionModulate,
     uniforms: {
       ambientOcclusionOnly: false,
-      ambientOcclusionTexture: generateAndBlur.name,
+      ambientOcclusionTexture: generate.name,
     },
   });
 
@@ -556,20 +542,20 @@ PostProcessStageLibrary.createAmbientOcclusionStage = function () {
         generate.uniforms.lengthCap = value;
       },
     },
-    stepSize: {
+    directionCount: {
       get: function () {
-        return generate.uniforms.stepSize;
+        return generate.uniforms.directionCount;
       },
       set: function (value) {
-        generate.uniforms.stepSize = value;
+        generate.uniforms.directionCount = value;
       },
     },
-    frustumLength: {
+    stepCount: {
       get: function () {
-        return generate.uniforms.frustumLength;
+        return generate.uniforms.stepCount;
       },
       set: function (value) {
-        generate.uniforms.frustumLength = value;
+        generate.uniforms.stepCount = value;
       },
     },
     randomTexture: {
@@ -580,30 +566,6 @@ PostProcessStageLibrary.createAmbientOcclusionStage = function () {
         generate.uniforms.randomTexture = value;
       },
     },
-    delta: {
-      get: function () {
-        return blur.uniforms.delta;
-      },
-      set: function (value) {
-        blur.uniforms.delta = value;
-      },
-    },
-    sigma: {
-      get: function () {
-        return blur.uniforms.sigma;
-      },
-      set: function (value) {
-        blur.uniforms.sigma = value;
-      },
-    },
-    blurStepSize: {
-      get: function () {
-        return blur.uniforms.stepSize;
-      },
-      set: function (value) {
-        blur.uniforms.stepSize = value;
-      },
-    },
     ambientOcclusionOnly: {
       get: function () {
         return ambientOcclusionModulate.uniforms.ambientOcclusionOnly;
@@ -616,7 +578,7 @@ PostProcessStageLibrary.createAmbientOcclusionStage = function () {
 
   return new PostProcessStageComposite({
     name: "czm_ambient_occlusion",
-    stages: [generateAndBlur, ambientOcclusionModulate],
+    stages: [generate, ambientOcclusionModulate],
     inputPreviousStageTexture: false,
     uniforms: uniforms,
   });

package/Source/Scene/PropertyAttributeProperty.js

@@ -80,7 +80,7 @@ Object.defineProperties(PropertyAttributeProperty.prototype, {
    * True if offset/scale should be applied. If both offset/scale were
    * undefined, they default to identity so this property is set false
    *
-   * @memberof MetadataClassProperty.prototype
+   * @memberof PropertyAttributeProperty.prototype
    * @type {boolean}
    * @readonly
    * @private
@@ -94,7 +94,13 @@ Object.defineProperties(PropertyAttributeProperty.prototype, {
   /**
    * The offset to be added to property values as part of the value transform.
    *
-   * @memberof MetadataClassProperty.prototype
+   * This is always defined, even when `hasValueTransform` is `false`. If
+   * the property JSON itself did not define it, then it will inherit the
+   * value from the `MetadataClassProperty`. There, it also is always
+   * defined, and initialized to the default value if it was not contained
+   * in the class property JSON.
+   *
+   * @memberof PropertyAttributeProperty.prototype
    * @type {number|Cartesian2|Cartesian3|Cartesian4|Matrix2|Matrix3|Matrix4}
    * @readonly
    * @private
@@ -108,7 +114,13 @@ Object.defineProperties(PropertyAttributeProperty.prototype, {
   /**
    * The scale to be multiplied to property values as part of the value transform.
    *
-   * @memberof MetadataClassProperty.prototype
+   * This is always defined, even when `hasValueTransform` is `false`. If
+   * the property JSON itself did not define it, then it will inherit the
+   * value from the `MetadataClassProperty`. There, it also is always
+   * defined, and initialized to the default value if it was not contained
+   * in the class property JSON.
+   *
+   * @memberof PropertyAttributeProperty.prototype
    * @type {number|Cartesian2|Cartesian3|Cartesian4|Matrix2|Matrix3|Matrix4}
    * @readonly
    * @private

package/Source/Scene/PropertyTextureProperty.js

@@ -111,6 +111,12 @@ Object.defineProperties(PropertyTextureProperty.prototype, {
   /**
    * The offset to be added to property values as part of the value transform.
    *
+   * This is always defined, even when `hasValueTransform` is `false`. If
+   * the property JSON itself did not define it, then it will inherit the
+   * value from the `MetadataClassProperty`. There, it also is always
+   * defined, and initialized to the default value if it was not contained
+   * in the class property JSON.
+   *
    * @memberof PropertyTextureProperty.prototype
    * @type {number|Cartesian2|Cartesian3|Cartesian4|Matrix2|Matrix3|Matrix4}
    * @readonly
@@ -125,6 +131,12 @@ Object.defineProperties(PropertyTextureProperty.prototype, {
   /**
    * The scale to be multiplied to property values as part of the value transform.
    *
+   * This is always defined, even when `hasValueTransform` is `false`. If
+   * the property JSON itself did not define it, then it will inherit the
+   * value from the `MetadataClassProperty`. There, it also is always
+   * defined, and initialized to the default value if it was not contained
+   * in the class property JSON.
+   *
    * @memberof PropertyTextureProperty.prototype
    * @type {number|Cartesian2|Cartesian3|Cartesian4|Matrix2|Matrix3|Matrix4}
    * @readonly

package/Source/Scene/Scene.js

@@ -79,6 +79,7 @@ import VoxelCell from "./VoxelCell.js";
 import VoxelPrimitive from "./VoxelPrimitive.js";
 import getMetadataClassProperty from "./getMetadataClassProperty.js";
 import PickedMetadataInfo from "./PickedMetadataInfo.js";
+import getMetadataProperty from "./getMetadataProperty.js";
 
 const requestRenderAfterFrame = function (scene) {
   return function () {
@@ -4402,7 +4403,8 @@ Scene.prototype.pickVoxel = function (windowPosition, width, height) {
  * values from
  * @param {string} propertyName The name of the metadata property to pick
  * values from
- * @returns The metadata value
+ * @returns {MetadataValue|undefined} The metadata value, or `undefined` when
+ * no matching metadata was found at the given position
  *
  * @experimental This feature is not final and is subject to change without Cesium's standard deprecation policy.
  */
@@ -4426,7 +4428,11 @@ Scene.prototype.pickMetadata = function (
   // Check if the picked object is a model that has structural
   // metadata, with a schema that contains the specified
   // property.
-  const schema = pickedObject.detail?.model?.structuralMetadata?.schema;
+  const structuralMetadata = pickedObject.detail?.model?.structuralMetadata;
+  if (!defined(structuralMetadata)) {
+    return undefined;
+  }
+  const schema = structuralMetadata.schema;
   const classProperty = getMetadataClassProperty(
     schema,
     schemaId,
@@ -4436,12 +4442,21 @@ Scene.prototype.pickMetadata = function (
   if (!defined(classProperty)) {
     return undefined;
   }
+  const metadataProperty = getMetadataProperty(
+    structuralMetadata,
+    className,
+    propertyName,
+  );
+  if (!defined(metadataProperty)) {
+    return undefined;
+  }
 
   const pickedMetadataInfo = new PickedMetadataInfo(
     schemaId,
     className,
     propertyName,
     classProperty,
+    metadataProperty,
   );
 
   const pickedMetadataValues = this._picking.pickMetadata(

package/Source/Scene/SkyBox.js

@@ -81,6 +81,8 @@ function SkyBox(options) {
 
   this._attributeLocations = undefined;
   this._useHdr = undefined;
+  this._hasError = false;
+  this._error = undefined;
 }
 
 /**
@@ -111,6 +113,15 @@ SkyBox.prototype.update = function (frameState, useHdr) {
     return undefined;
   }
 
+  // Throw any errors that had previously occurred asynchronously so they aren't
+  // ignored when running.  See https://github.com/CesiumGS/cesium/pull/12307
+  if (this._hasError) {
+    const error = this._error;
+    this._hasError = false;
+    this._error = undefined;
+    throw error;
+  }
+
   if (this._sources !== this.sources) {
     this._sources = this.sources;
     const sources = this.sources;
@@ -141,10 +152,18 @@ SkyBox.prototype.update = function (frameState, useHdr) {
 
     if (typeof sources.positiveX === "string") {
       // Given urls for cube-map images.  Load them.
-      loadCubeMap(context, this._sources).then(function (cubeMap) {
-        that._cubeMap = that._cubeMap && that._cubeMap.destroy();
-        that._cubeMap = cubeMap;
-      });
+      loadCubeMap(context, this._sources)
+        .then(function (cubeMap) {
+          that._cubeMap = that._cubeMap && that._cubeMap.destroy();
+          that._cubeMap = cubeMap;
+        })
+        .catch((error) => {
+          // Defer throwing the error until the next call to update to prevent
+          // test from failing in `afterAll` if this is rejected after the test
+          // using the Skybox ends.  See https://github.com/CesiumGS/cesium/pull/12307
+          this._hasError = true;
+          this._error = error;
+        });
     } else {
       this._cubeMap = this._cubeMap && this._cubeMap.destroy();
       this._cubeMap = new CubeMap({

package/Source/Scene/UrlTemplateImageryProvider.js

@@ -159,13 +159,13 @@ const pickFeaturesTags = combine(tags, {
  * });
  * // Access a Web Map Service (WMS) server.
  * const wms = new Cesium.UrlTemplateImageryProvider({
- *    url : 'https://programs.communications.gov.au/geoserver/ows?tiled=true&' +
- *          'transparent=true&format=image%2Fpng&exceptions=application%2Fvnd.ogc.se_xml&' +
- *          'styles=&service=WMS&version=1.1.1&request=GetMap&' +
- *          'layers=public%3AMyBroadband_Availability&srs=EPSG%3A3857&' +
+ *    url : 'https://services.ga.gov.au/gis/services/NM_Hydrology_and_Marine_Points/MapServer/WMSServer?' +
+ *          'tiled=true&transparent=true&format=image%2Fpng&exceptions=application%2Fvnd.ogc.se_xml&' +
+ *          'styles=&service=WMS&version=1.3.0&request=GetMap&' +
+ *          'layers=Bores&crs=EPSG%3A3857&' +
  *          'bbox={westProjected}%2C{southProjected}%2C{eastProjected}%2C{northProjected}&' +
  *          'width=256&height=256',
- *    rectangle : Cesium.Rectangle.fromDegrees(96.799393, -43.598214999057824, 153.63925700000001, -9.2159219997013)
+ *    rectangle : Cesium.Rectangle.fromDegrees(95.0, -55.0, 170.0, -1.0)  // From GetCapabilities EX_GeographicBoundingBox
  * });
  * // Using custom tags in your template url.
  * const custom = new Cesium.UrlTemplateImageryProvider({

package/Source/Scene/createGooglePhotorealistic3DTileset.js

@@ -4,23 +4,37 @@ import defined from "../Core/defined.js";
 import IonResource from "../Core/IonResource.js";
 import GoogleMaps from "../Core/GoogleMaps.js";
 import Resource from "../Core/Resource.js";
+import oneTimeWarning from "../Core/oneTimeWarning.js";
+import deprecationWarning from "../Core/deprecationWarning.js";
 
 /**
- * Creates a {@link Cesium3DTileset} instance for the Google Photorealistic 3D Tiles tileset.
+ * Creates a {@link Cesium3DTileset} instance for the Google Photorealistic 3D
+ * Tiles tileset.
+ *
+ * Google Photorealistic 3D Tiles can only be used with the Google geocoder.  To
+ * confirm that you are aware of this restriction pass
+ * `usingOnlyWithGoogleGeocoder: true` to the apiOptions.  Otherwise a one time
+ * warning will be displayed when this function is called.
  *
  * @function
  *
- * @param {string} [key=GoogleMaps.defaultApiKey] Your API key to access Google Photorealistic 3D Tiles. See {@link https://developers.google.com/maps/documentation/javascript/get-api-key} for instructions on how to create your own key.
- * @param {Cesium3DTileset.ConstructorOptions} [options] An object describing initialization options.
+ * @param {object} [apiOptions]
+ * @param {string} [apiOptions.key=GoogleMaps.defaultApiKey] Your API key to access Google Photorealistic 3D Tiles. See {@link https://developers.google.com/maps/documentation/javascript/get-api-key} for instructions on how to create your own key.
+ * @param {true} [apiOptions.onlyUsingWithGoogleGeocoder] Confirmation that this tileset will only be used with the Google geocoder.
+ * @param {Cesium3DTileset.ConstructorOptions} [tilesetOptions] An object describing initialization options.
  * @returns {Promise<Cesium3DTileset>}
  *
  * @see GoogleMaps
  *
  * @example
- * const viewer = new Cesium.Viewer("cesiumContainer");
+ * const viewer = new Cesium.Viewer("cesiumContainer", {
+ *   geocoder: Cesium.IonGeocodeProviderType.GOOGLE
+ * });
  *
  * try {
- *   const tileset = await Cesium.createGooglePhotorealistic3DTileset();
+ *   const tileset = await Cesium.createGooglePhotorealistic3DTileset({
+ *      onlyUsingWithGoogleGeocoder: true,
+ *   });
  *   viewer.scene.primitives.add(tileset));
  * } catch (error) {
  *   console.log(`Error creating tileset: ${error}`);
@@ -30,27 +44,52 @@ import Resource from "../Core/Resource.js";
  * // Use your own Google Maps API key
  * Cesium.GoogleMaps.defaultApiKey = "your-api-key";
  *
- * const viewer = new Cesium.Viewer("cesiumContainer");
+ * const viewer = new Cesium.Viewer("cesiumContainer". {
+ *   geocoder: Cesium.IonGeocodeProviderType.GOOGLE
+ * });
  *
  * try {
- *   const tileset = await Cesium.createGooglePhotorealistic3DTileset();
+ *   const tileset = await Cesium.createGooglePhotorealistic3DTileset({
+ *      onlyUsingWithGoogleGeocoder: true,
+ *   });
  *   viewer.scene.primitives.add(tileset));
  * } catch (error) {
  *   console.log(`Error creating tileset: ${error}`);
  * }
  */
-async function createGooglePhotorealistic3DTileset(key, options) {
-  options = defaultValue(options, {});
-  options.cacheBytes = defaultValue(options.cacheBytes, 1536 * 1024 * 1024);
-  options.maximumCacheOverflowBytes = defaultValue(
-    options.maximumCacheOverflowBytes,
+async function createGooglePhotorealistic3DTileset(apiOptions, tilesetOptions) {
+  tilesetOptions = defaultValue(tilesetOptions, {});
+  tilesetOptions.cacheBytes = defaultValue(
+    tilesetOptions.cacheBytes,
+    1536 * 1024 * 1024,
+  );
+  tilesetOptions.maximumCacheOverflowBytes = defaultValue(
+    tilesetOptions.maximumCacheOverflowBytes,
     1024 * 1024 * 1024,
   );
-  options.enableCollision = defaultValue(options.enableCollision, true);
+  tilesetOptions.enableCollision = defaultValue(
+    tilesetOptions.enableCollision,
+    true,
+  );
 
-  key = defaultValue(key, GoogleMaps.defaultApiKey);
+  apiOptions = defaultValue(apiOptions, defaultValue.EMPTY_OBJECT);
+  if (typeof apiOptions === "string") {
+    deprecationWarning(
+      "createGooglePhotorealistic3DTileset(key)",
+      "createGooglePhotorealistic3DTileset(key) has been deprecated.   It is replaced by createGooglePhotorealistic3DTileset({key}).  It will be removed in Cesium 1.126.",
+    );
+    apiOptions = { key: apiOptions };
+  }
+  if (!apiOptions.onlyUsingWithGoogleGeocoder) {
+    oneTimeWarning(
+      "google-tiles-with-google-geocoder",
+      "Only the Google geocoder can be used with Google Photorealistic 3D Tiles.  Set the `geocode` property of Viewer constructor options.  You can set additionalOptions.onlyUsingWithGoogleGeocoder to hide this warning once you have configured the geocoder.",
+    );
+  }
+
+  const key = defaultValue(apiOptions.key, GoogleMaps.defaultApiKey);
   if (!defined(key)) {
-    return requestCachedIonTileset(options);
+    return requestCachedIonTileset(tilesetOptions);
   }
 
   let credits;
@@ -67,7 +106,7 @@ async function createGooglePhotorealistic3DTileset(key, options) {
     credits: credits,
   });
 
-  return Cesium3DTileset.fromUrl(resource, options);
+  return Cesium3DTileset.fromUrl(resource, tilesetOptions);
 }
 
 const metadataCache = {};

package/Source/Scene/getMetadataProperty.js

@@ -0,0 +1,48 @@
+import defined from "../Core/defined.js";
+
+/**
+ * Return the `PropertyTextureProperty` from the given `StructuralMetadata`
+ * that matches the given description.
+ *
+ * If the given structural metadata is `undefined`, then `undefined` is returned.
+ *
+ * Otherwise, this method will check all the property textures in the given
+ * structural metadata.
+ *
+ * If it finds a property texture that has a class with an `_id` that matches
+ * the given name, and that contains a property for the given property name, then
+ * this property is returned.
+ *
+ * Otherwise, `undefined` is returned
+ *
+ * @param {StructuralMetadata} structuralMetadata The structural metadata
+ * @param {string} className The name of the metadata class
+ * @param {string} propertyName The name of the metadata property
+ * @returns {PropertyTextureProperty|undefined}
+ * @private
+ */
+function getMetadataProperty(structuralMetadata, className, propertyName) {
+  if (!defined(structuralMetadata)) {
+    return undefined;
+  }
+  const propertyTextures = structuralMetadata.propertyTextures;
+  for (const propertyTexture of propertyTextures) {
+    const metadataClass = propertyTexture.class;
+    if (metadataClass.id === className) {
+      const properties = propertyTexture.properties;
+      const property = properties[propertyName];
+      if (defined(property)) {
+        return property;
+      }
+    }
+  }
+  // Note: This could check for property attributes in a similar
+  // way. But since picking arbitrary property attributes via the
+  // frame buffer is not supported yet, returning "undefined" here
+  // causes the picking to bail out early and safely when no
+  // property texture was found.
+  // See https://github.com/CesiumGS/cesium/issues/12225
+  return undefined;
+}
+
+export default getMetadataProperty;

package/Source/Shaders/Builtin/Functions/reverseLogDepth.glsl

@@ -4,7 +4,7 @@ float czm_reverseLogDepth(float logZ)
     float near = czm_currentFrustum.x;
     float far = czm_currentFrustum.y;
     float log2Depth = logZ * czm_log2FarDepthFromNearPlusOne;
-    float depthFromNear = pow(2.0, log2Depth) - 1.0;
+    float depthFromNear = exp2(log2Depth) - 1.0;
     return far * (1.0 - near / (depthFromNear + near)) / (far - near);
 #endif
     return logZ;

package/Source/Shaders/Builtin/Functions/reverseLogDepth.js

@@ -5,7 +5,7 @@ export default "float czm_reverseLogDepth(float logZ)\n\
     float near = czm_currentFrustum.x;\n\
     float far = czm_currentFrustum.y;\n\
     float log2Depth = logZ * czm_log2FarDepthFromNearPlusOne;\n\
-    float depthFromNear = pow(2.0, log2Depth) - 1.0;\n\
+    float depthFromNear = exp2(log2Depth) - 1.0;\n\
     return far * (1.0 - near / (depthFromNear + near)) / (far - near);\n\
 #endif\n\
     return logZ;\n\

package/Source/Shaders/ConvolveSpecularMapFS.glsl

@@ -62,7 +62,7 @@ void main() {
 
             float NdotL = max(dot(V, L), 0.0);
             if (NdotL > 0.0) {
-                color += vec4(texture(u_radianceTexture, L).rgb, 1.0) * NdotL;
+                color += vec4(czm_textureCube(u_radianceTexture, L).rgb, 1.0) * NdotL;
                 weight += NdotL;
             }
         }

package/Source/Shaders/ConvolveSpecularMapFS.js

@@ -63,7 +63,7 @@ void main() {\n\
 \n\
             float NdotL = max(dot(V, L), 0.0);\n\
             if (NdotL > 0.0) {\n\
-                color += vec4(texture(u_radianceTexture, L).rgb, 1.0) * NdotL;\n\
+                color += vec4(czm_textureCube(u_radianceTexture, L).rgb, 1.0) * NdotL;\n\
                 weight += NdotL;\n\
             }\n\
         }\n\

package/Source/Shaders/Model/ModelFS.glsl

@@ -28,6 +28,13 @@ SelectedFeature selectedFeature;
 
 void main()
 {
+    #ifdef HAS_POINT_CLOUD_SHOW_STYLE
+        if (v_pointCloudShow == 0.0)
+        {
+            discard;
+        }
+    #endif
+
     #ifdef HAS_MODEL_SPLITTER
     modelSplitterStage();
     #endif

package/Source/Shaders/Model/ModelFS.js

@@ -29,6 +29,13 @@ SelectedFeature selectedFeature;\n\
 \n\
 void main()\n\
 {\n\
+    #ifdef HAS_POINT_CLOUD_SHOW_STYLE\n\
+        if (v_pointCloudShow == 0.0)\n\
+        {\n\
+            discard;\n\
+        }\n\
+    #endif\n\
+\n\
     #ifdef HAS_MODEL_SPLITTER\n\
     modelSplitterStage();\n\
     #endif\n\

package/Source/Shaders/Model/ModelVS.glsl

@@ -145,5 +145,13 @@ void main()
         gl_PointSize *= show;
     #endif
 
-    gl_Position = show * positionClip;
+    // Important NOT to compute gl_Position = show * positionClip or we hit:
+    // https://github.com/CesiumGS/cesium/issues/11270
+    //
+    // We will discard points with v_pointCloudShow == 0 in the fragment shader.
+    gl_Position = positionClip;
+
+    #ifdef HAS_POINT_CLOUD_SHOW_STYLE
+    v_pointCloudShow = show;
+    #endif
 }

package/Source/Shaders/Model/ModelVS.js

@@ -146,6 +146,14 @@ void main()\n\
         gl_PointSize *= show;\n\
     #endif\n\
 \n\
-    gl_Position = show * positionClip;\n\
+    // Important NOT to compute gl_Position = show * positionClip or we hit:\n\
+    // https://github.com/CesiumGS/cesium/issues/11270\n\
+    //\n\
+    // We will discard points with v_pointCloudShow == 0 in the fragment shader.\n\
+    gl_Position = positionClip;\n\
+\n\
+    #ifdef HAS_POINT_CLOUD_SHOW_STYLE\n\
+    v_pointCloudShow = show;\n\
+    #endif\n\
 }\n\
 ";