@certik/skynet 0.10.55 → 0.10.56

package/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 0.10.56
+
+- Fixed: should await on app deploy check
+
 ## 0.10.55
 
 - Fixed: local nomad deployment error for multiple line string secret

package/app.js

@@ -29,22 +29,26 @@ function isDeleteCommand(command) {
 }
 
 async function checkDeployEnv(env) {
-  // check sensitive env
-  const missingEnvs = [];
-
-  for (let key of Object.keys(env)) {
-    if (env[key] === SENSITIVE_VALUE) {
-      const res = await fetch(`${SKYNET_API_PREFIX}/secrets/verify?name=${key}`);
-
-      if (res.ok) {
-        const hasEnv = await res.json();
-
-        if (!hasEnv) {
-          missingEnvs.push(key);
+  const envStatus = await Promise.all(
+    Object.keys(env).map(async (key) => {
+      if (env[key] === SENSITIVE_VALUE) {
+        // check sensitive env
+        const res = await fetch(`${SKYNET_API_PREFIX}/secrets/verify?name=${key}`);
+
+        if (res.ok) {
+          const hasEnv = await res.json();
+
+          if (!hasEnv) {
+            return { name: key, ok: false };
+          }
         }
       }
-    }
-  }
+
+      return { name: key, ok: true };
+    })
+  );
+
+  const missingEnvs = envStatus.filter((s) => !s.ok).map((s) => s.name);
 
   if (missingEnvs.length > 0) {
     console.log(`Missing the following sensitive environment on nomad server:${EOL}- ${missingEnvs.join(EOL + "- ")}`);
@@ -94,7 +98,7 @@ function createApp({ parameterErrors, env, check, onRun, onDeploy, onCheck }) {
       }
 
       if (process.argv.includes("--production")) {
-        checkDeployEnv(env)
+        await checkDeployEnv(env)
           .then(() => onDeploy())
           .catch(console.error);
       } else {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@certik/skynet",
-  "version": "0.10.55",
+  "version": "0.10.56",
   "description": "Skynet Shared JS library",
   "main": "index.js",
   "author": "CertiK Engineering",