@certik/serverless-api 1.0.7 → 1.0.8

package/CHANGELOG.md

@@ -1,3 +1,7 @@
+# 1.0.8
+
+- fixed CORS
+
 # 1.0.7
 
 - fixed a typo in pack

package/lib/app.js

@@ -2,7 +2,6 @@ import * as pulumi from "@pulumi/pulumi";
 import * as aws from "@pulumi/aws";
 import * as apigateway from "@pulumi/aws-apigateway";
 import { readFile } from "node:fs/promises";
-import { corsPreflight } from "./cors.js";
 import { isReservedEnvName } from "./env.js";
 import { packAndZip } from "./pack.js";
 
@@ -41,11 +40,6 @@ export async function createPulumiAPIApp({
   const wildcardCertificateName = getWildcardCertificateName(domainName);
   const lambdaRoleName = config.get("lambdaRole");
 
-  // any route that has corsOrigin will have a preflight request
-  if (routes.some((r) => r.corsOrigin)) {
-    routes.push(corsPreflight());
-  }
-
   const role = aws.iam.getRole({ name: lambdaRoleName });
 
   const sourceBucket = aws.s3.getBucket({ bucket: sourceBucketName });

package/lib/cors.js

@@ -1,7 +1,7 @@
-export function corsPreflight() {
+export function corsPreflight(name, path) {
   return {
-    name: "cors-preflight",
-    path: "/{proxy+}",
+    name,
+    path,
     method: "OPTIONS",
     timeout: 10,
     memorySize: 128,

package/lib/routes.js

@@ -1,5 +1,6 @@
 import pathModule from "node:path";
 import { readdir } from "node:fs/promises";
+import { corsPreflight } from "./cors.js";
 import { DEFAULT_TIMEOUT, MAX_TIMEOUT, DEFAULT_MEMORY_SIZE } from "./const.js";
 
 export async function getRoutes(routeDirectory) {
@@ -13,7 +14,7 @@ export async function getRoutes(routeDirectory) {
       const methods = route.methods || ["GET"];
       const environmentVariables = route.environmentVariables || [];
 
-      return methods.map((method) => ({
+      const methodRoutes = methods.map((method) => ({
         name: `${routeName}-${method}`,
         path: `/${routeName}`,
         method,
@@ -23,6 +24,14 @@ export async function getRoutes(routeDirectory) {
         memorySize: route.memorySize || DEFAULT_MEMORY_SIZE,
         environmentVariables,
       }));
+
+      if (route.corsOrigin) {
+        methodRoutes.push(
+          corsPreflight(`${routeName}-OPTIONS`, `/${routeName}`),
+        );
+      }
+
+      return methodRoutes;
     }),
   );
 

package/package.json

@@ -4,7 +4,7 @@
   "author": "CertiK Engineering",
   "type": "module",
   "main": "index.js",
-  "version": "1.0.7",
+  "version": "1.0.8",
   "scripts": {
     "start": "doppler run -- nodemon start-dev.js",
     "lint": "eslint lib test routes *.js",