@centreon/ui 26.9.0 → 26.11.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@centreon/ui",
-  "version": "26.9.0",
+  "version": "26.11.0",
   "description": "Centreon UI Components",
   "scripts": {
     "update:deps": "pnpx npm-check-updates -i --format group",
@@ -162,7 +162,7 @@
     "ramda": "0.30.1",
     "react-grid-layout": "^2.2.2",
     "react-resizable": "^3.0.5",
-    "react-router": "7.12.0",
+    "react-router": "7.14.2",
     "react-transition-group": "^4.4.5",
     "sanitize-html": "^2.14.0",
     "ulog": "^2.0.0-beta.19"

package/src/Graph/BarChart/BarChart.cypress.spec.tsx

@@ -70,19 +70,8 @@ const initialize = ({
   cy.viewport('macbook-13');
 };
 
-const checkWidth = (orientation): void => {
-  if (orientation === 'vertical') {
-    cy.get('g[class*="visx-rows"] > line')
-      .eq(0)
-      .should('have.attr', 'x2')
-      .and('equal', '1133');
-
-    return;
-  }
-  cy.get('g[class*="visx-rows"] > line')
-    .eq(0)
-    .should('have.attr', 'x2')
-    .and('equal', '1168');
+const checkWidth = (): void => {
+  cy.get('g[class*="visx-rows"] > line').eq(0).should('have.attr', 'x2');
 };
 
 describe('Bar chart', () => {
@@ -91,7 +80,7 @@ describe('Bar chart', () => {
       orientation: 'horizontal'
     });
 
-    checkWidth('horizontal');
+    checkWidth();
     cy.contains('0 ms').should('be.visible');
     cy.contains('20').should('be.visible');
     cy.contains(':40 AM').should('be.visible');
@@ -117,7 +106,7 @@ describe('Bar chart', () => {
       }
     });
 
-    checkWidth('horizontal');
+    checkWidth();
     cy.contains('0 ms').should('be.visible');
     cy.contains('20').should('be.visible');
     cy.contains(':40 AM').should('be.visible');
@@ -147,7 +136,7 @@ describe('Bar chart', () => {
       const userData = renderHook(() => useAtomValue(userAtom));
       userData.result.current.locale = 'en';
 
-      checkWidth(orientation);
+      checkWidth();
       cy.contains('0 ms').should('be.visible');
       cy.contains('20').should('be.visible');
       cy.contains(':40 AM').should('be.visible');
@@ -160,7 +149,7 @@ describe('Bar chart', () => {
     it(`displays the bar chart ${orientation}ly centered in zero`, () => {
       initialize({ axis: { isCenteredZero: true }, orientation });
 
-      checkWidth(orientation);
+      checkWidth();
       cy.contains('0 ms').should('be.visible');
       cy.contains('20').should('be.visible');
       cy.contains(':40 AM').should('be.visible');
@@ -173,7 +162,7 @@ describe('Bar chart', () => {
     it(`displays the stacked bar chart ${orientation}ly`, () => {
       initialize({ data: dataPingServiceStacked, orientation });
 
-      checkWidth(orientation);
+      checkWidth();
       cy.contains('0 ms').should('be.visible');
       cy.contains('20').should('be.visible');
       cy.contains(':40 AM').should('be.visible');
@@ -186,7 +175,7 @@ describe('Bar chart', () => {
     it(`displays bar chart ${orientation}ly with a mix of stacked and non-stacked data`, () => {
       initialize({ data: dataPingServiceMixedStacked, orientation });
 
-      checkWidth(orientation);
+      checkWidth();
       cy.contains('0 ms').should('be.visible');
       cy.contains('20').should('be.visible');
       cy.contains(':40 AM').should('be.visible');
@@ -201,7 +190,7 @@ describe('Bar chart', () => {
         orientation
       });
 
-      checkWidth(orientation);
+      checkWidth();
       cy.contains('0 ms').should('be.visible');
       cy.contains('20').should('be.visible');
       cy.contains(':40 AM').should('be.visible');
@@ -216,7 +205,7 @@ describe('Bar chart', () => {
         orientation
       });
 
-      checkWidth(orientation);
+      checkWidth();
       cy.contains('0 ms').should('be.visible');
       cy.contains('20').should('be.visible');
       cy.contains(':40 AM').should('be.visible');
@@ -231,7 +220,7 @@ describe('Bar chart', () => {
         orientation
       });
 
-      checkWidth(orientation);
+      checkWidth();
       cy.contains('0 ms').should('be.visible');
       cy.contains('20').should('be.visible');
       cy.contains(':40 AM').should('be.visible');
@@ -250,7 +239,7 @@ describe('Bar chart', () => {
       }
     });
 
-    checkWidth('horizontal');
+    checkWidth();
     cy.contains('0 ms').should('be.visible');
     cy.contains('20').should('be.visible');
     cy.contains(':40 AM').should('be.visible');

package/src/Graph/BarChart/ResponsiveBarChart.tsx

@@ -91,6 +91,9 @@ const ResponsiveBarChart = ({
   zoomPreview,
   annotationEvent
 }: Props): ReactElement => {
+  const maxLeftAxisCharactersRef = useRef(0);
+  const maxRightAxisCharactersRef = useRef(0);
+
   const { title, timeSeries, baseAxis, lines } = graphData || {};
 
   const { classes, cx } = useTooltipStyles();
@@ -111,23 +114,14 @@ const ResponsiveBarChart = ({
   const [firstUnit, secondUnit] = getUnits(displayedLines);
   const allUnits = getUnits(lines || []);
 
-  const { maxLeftAxisCharacters, maxRightAxisCharacters } =
-    useComputeYAxisMaxCharacters({
-      axis,
-      firstUnit,
-      graphData,
-      secondUnit,
-      thresholds,
-      thresholdUnit
-    });
-
   const { legendRef, graphWidth, graphHeight, titleRef } =
     useComputeBaseChartDimensions({
       hasSecondUnit: Boolean(secondUnit),
       height,
       legendDisplay: legend?.display,
       legendPlacement: legend?.placement,
-      maxAxisCharacters: maxRightAxisCharacters || maxLeftAxisCharacters,
+      maxLeftAxisCharacters: maxLeftAxisCharactersRef.current,
+      maxRightAxisCharacters: maxRightAxisCharactersRef.current,
       title,
       units: allUnits,
       width
@@ -202,6 +196,22 @@ const ResponsiveBarChart = ({
 
   const leftScale = yScalesPerUnit[firstUnit ?? allUnits[0]];
   const rightScale = yScalesPerUnit[secondUnit ?? allUnits[1]];
+
+  const { maxLeftAxisCharacters, maxRightAxisCharacters } =
+    useComputeYAxisMaxCharacters({
+      axis,
+      base: baseAxis,
+      displayedLines,
+      graphHeight,
+      graphWidth,
+      isHorizontal,
+      leftScale,
+      rightScale
+    });
+
+  maxRightAxisCharactersRef.current = maxRightAxisCharacters;
+  maxLeftAxisCharactersRef.current = maxLeftAxisCharacters;
+
   const pixelsToShift = computPixelsToShiftMouse(xScaleLinear);
 
   useEffect(
@@ -286,9 +296,8 @@ const ResponsiveBarChart = ({
             graphHeight={graphHeight}
             graphWidth={graphWidth - (isHorizontal ? 0 : margin.left - 15)}
             gridLinesType={axis?.gridLinesType}
-            hasSecondUnit={Boolean(secondUnit)}
             leftScale={leftScale}
-            maxAxisCharacters={maxLeftAxisCharacters}
+            maxLeftAxisCharacters={maxLeftAxisCharacters}
             orientation={isHorizontal ? 'horizontal' : 'vertical'}
             rightScale={rightScale}
             showGridLines={showGridLines}

package/src/Graph/Chart/BasicComponents/Lines/index.tsx

@@ -112,7 +112,6 @@ const Lines = ({
         <GuidingLines
           graphHeight={height}
           graphWidth={width}
-          hasSecondUnit={hasSecondUnit}
           hasUnit={hasUnitDisplayed}
           leftScale={leftScale}
           lines={displayedLines}
@@ -235,7 +234,6 @@ const Lines = ({
                 <g key={metric_id}>
                   {displayGuidingLines && (
                     <RegularAnchorPoint
-                      hasSecondUnit={hasSecondUnit}
                       lineColor={lineColor}
                       maxLeftAxisCharacters={maxLeftAxisCharacters}
                       metric_id={metric_id}

package/src/Graph/Chart/Chart.cypress.spec.tsx

@@ -177,8 +177,8 @@ describe('Line chart', () => {
 
       cy.contains('06/18/2023').should('be.visible');
 
-      cy.contains('0.44 s').should('be.visible');
-      cy.contains('75.19%').should('be.visible');
+      cy.contains('0.56 s').should('be.visible');
+      cy.contains('73.25%').should('be.visible');
 
       cy.makeSnapshot();
     });
@@ -218,7 +218,7 @@ describe('Line chart', () => {
 
       cy.contains('Min: 70.31').should('be.visible');
 
-      cy.findByTestId('graph-interaction-zone').realMouseMove(1198, 100);
+      cy.findByTestId('graph-interaction-zone').realMouseMove(1205, 100);
 
       cy.get('[data-metric="querytime"]').should('not.exist');
 
@@ -291,7 +291,7 @@ describe('Line chart', () => {
 
     cy.findByTestId('graph-interaction-zone')
       .should('have.attr', 'width')
-      .and('equal', '1200');
+      .and('equal', '1230');
 
     cy.get('[data-icon="true"]')
       .eq(0)
@@ -530,8 +530,7 @@ describe('Line chart', () => {
 
       checkGraphWidth();
       cy.contains(':00 AM').should('be.visible');
-      cy.get('circle[cx="245.83333333333334"]').should('be.visible');
-      cy.get('circle[cy="256.7205013298516"]').should('be.visible');
+      cy.get('circle').should('have.length', 864);
 
       cy.makeSnapshot();
     });
@@ -589,7 +588,7 @@ describe('Line chart', () => {
       cy.get('path.visx-area-closed')
         .should('have.attr', 'stroke-dasharray')
         .and('equals', '5 4');
-      cy.get('circle[cx="32.77777777777778"]').should('be.visible');
+      cy.get('circle').should('have.length', 288);
 
       cy.makeSnapshot();
     });
@@ -745,10 +744,10 @@ describe('Lines and bars', () => {
     checkGraphWidth();
 
     cy.get(
-      'path[d="M7.435261707988982,289.92398616599974 h55.91735537190083 h1v1 v100.07601383400026 a1,1 0 0 1 -1,1 h-55.91735537190083 a1,1 0 0 1 -1,-1 v-100.07601383400026 v-1h1z"]'
+      'path[d="M7.473829201101932,289.92398616599974 h56.26446280991734 h1v1 v100.07601383400026 a1,1 0 0 1 -1,1 h-56.26446280991734 a1,1 0 0 1 -1,-1 v-100.07601383400026 v-1h1z"]'
     ).should('be.visible');
     cy.get(
-      'path[d="M23.81046831955923,235.36727985204413 h23.166942148760334 a17.37520661157025,17.37520661157025 0 0 1 17.37520661157025,17.37520661157025 v19.806293090815103 v17.37520661157025h-17.37520661157025 h-23.166942148760334 h-17.37520661157025v-17.37520661157025 v-19.806293090815103 a17.37520661157025,17.37520661157025 0 0 1 17.37520661157025,-17.37520661157025z"]'
+      'path[d="M23.953168044077135,235.36727985204413 h23.305785123966935 a17.479338842975203,17.479338842975203 0 0 1 17.479338842975203,17.479338842975203 v19.598028628005196 v17.479338842975203h-17.479338842975203 h-23.305785123966935 h-17.479338842975203v-17.479338842975203 v-19.598028628005196 a17.479338842975203,17.479338842975203 0 0 1 17.479338842975203,-17.479338842975203z"]'
     ).should('be.visible');
 
     cy.makeSnapshot();

package/src/Graph/Chart/Chart.tsx

@@ -119,6 +119,8 @@ const Chart = ({
   boundariesUnit
 }: Props): ReactElement => {
   const { classes } = useChartStyles();
+  const maxLeftAxisCharactersRef = useRef(0);
+  const maxRightAxisCharactersRef = useRef(0);
 
   const { title, timeSeries, baseAxis, lines } = graphData;
 
@@ -146,16 +148,6 @@ const Chart = ({
     [displayedLines]
   );
 
-  const { maxLeftAxisCharacters, maxRightAxisCharacters } =
-    useComputeYAxisMaxCharacters({
-      axis,
-      firstUnit,
-      graphData,
-      secondUnit,
-      thresholds,
-      thresholdUnit
-    });
-
   const allUnits = getUnits(linesGraph);
 
   const { legendRef, graphWidth, graphHeight, titleRef } =
@@ -165,7 +157,8 @@ const Chart = ({
       legendDisplay: legend?.display,
       legendHeight: legend?.height,
       legendPlacement: legend?.placement,
-      maxAxisCharacters: maxRightAxisCharacters || maxLeftAxisCharacters,
+      maxLeftAxisCharacters: maxLeftAxisCharactersRef.current,
+      maxRightAxisCharacters: maxRightAxisCharactersRef.current,
       title,
       units: allUnits,
       width
@@ -230,6 +223,21 @@ const Chart = ({
   const leftScale = yScalesPerUnit[fallbackLeftUnit];
   const rightScale = yScalesPerUnit[fallbackRightUnit];
 
+  const { maxLeftAxisCharacters, maxRightAxisCharacters } =
+    useComputeYAxisMaxCharacters({
+      axis,
+      base: baseAxis,
+      displayedLines,
+      graphHeight,
+      graphWidth,
+      isHorizontal: false,
+      leftScale,
+      rightScale
+    });
+
+  maxRightAxisCharactersRef.current = maxRightAxisCharacters;
+  maxLeftAxisCharactersRef.current = maxLeftAxisCharacters;
+
   const linesDisplayedAsLine = useMemo(
     () =>
       displayedLines.filter(
@@ -325,9 +333,8 @@ const Chart = ({
                 graphHeight={graphHeight}
                 graphWidth={graphWidth}
                 gridLinesType={axis?.gridLinesType}
-                hasSecondUnit={hasSecondUnit}
                 leftScale={leftScale}
-                maxAxisCharacters={maxLeftAxisCharacters}
+                maxLeftAxisCharacters={maxLeftAxisCharacters}
                 rightScale={rightScale}
                 showGridLines={showGridLines}
                 svgRef={graphSvgRef}
@@ -388,7 +395,6 @@ const Chart = ({
                     xScale,
                     yScalesPerUnit
                   }}
-                  hasSecondUnit={hasSecondUnit}
                   maxLeftAxisCharacters={maxLeftAxisCharacters}
                   timeShiftZonesData={{
                     ...timeShiftZones,

package/src/Graph/Chart/InteractiveComponents/AnchorPoint/GuidingLines.tsx

@@ -12,14 +12,12 @@ const GuidingLines = ({
   graphHeight,
   graphWidth,
   maxLeftAxisCharacters,
-  hasSecondUnit,
   lines,
   leftScale,
   rightScale,
   hasUnit
 }: GuidingLinesModel): ReactElement | null => {
   const { positionX, positionY } = useTickGraph({
-    hasSecondUnit,
     hasUnit,
     leftScale,
     lines,

package/src/Graph/Chart/InteractiveComponents/AnchorPoint/RegularAnchorPoint.tsx

@@ -13,7 +13,6 @@ interface Props {
   timeSeries: Array<TimeValue>;
   xScale: ScaleTime<number, number>;
   yScale: ScaleLinear<number, number>;
-  hasSecondUnit?: boolean;
   maxLeftAxisCharacters: number;
 }
 
@@ -39,11 +38,9 @@ const RegularAnchorPoint = ({
   metric_id,
   timeSeries,
   lineColor,
-  maxLeftAxisCharacters,
-  hasSecondUnit
+  maxLeftAxisCharacters
 }: Props): JSX.Element | null => {
   const { tickAxisBottom: timeTick } = useTickGraph({
-    hasSecondUnit,
     maxLeftAxisCharacters,
     timeSeries,
     xScale

package/src/Graph/Chart/InteractiveComponents/AnchorPoint/StackedAnchorPoint.tsx

@@ -13,7 +13,6 @@ interface Props {
   timeSeries: Array<TimeValue>;
   xScale: ScaleTime<number, number>;
   yScale: ScaleLinear<number, number>;
-  hasSecondUnit?: boolean;
   maxLeftAxisCharacters: number;
 }
 
@@ -59,11 +58,9 @@ const StackedAnchorPoint = ({
   stackValues,
   timeSeries,
   lineColor,
-  hasSecondUnit,
   maxLeftAxisCharacters
 }: Props): JSX.Element | null => {
   const { tickAxisBottom: timeTick } = useTickGraph({
-    hasSecondUnit,
     maxLeftAxisCharacters,
     timeSeries,
     xScale

package/src/Graph/Chart/InteractiveComponents/AnchorPoint/models.ts

@@ -30,7 +30,6 @@ export interface GuidingLines {
   timeSeries: Array<TimeValue>;
   xScale: ScaleTime<number, number>;
   maxLeftAxisCharacters: number;
-  hasSecondUnit?: boolean;
   leftScale?: ScaleLinear<number, number>;
   lines: Array<Line>;
   rightScale?: ScaleLinear<number, number>;

package/src/Graph/Chart/InteractiveComponents/AnchorPoint/useTickGraph.ts

@@ -27,7 +27,6 @@ interface Props {
   rightScale?: ScaleLinear<number, number>;
   timeSeries: Array<TimeValue>;
   xScale: ScaleTime<number, number>;
-  hasSecondUnit?: boolean;
   maxLeftAxisCharacters: number;
   hasUnit?: boolean;
 }
@@ -39,7 +38,6 @@ const useTickGraph = ({
   rightScale,
   lines = [],
   baseAxis = 1000,
-  hasSecondUnit,
   maxLeftAxisCharacters,
   hasUnit
 }: Props): AnchorPointResult => {
@@ -53,11 +51,7 @@ const useTickGraph = ({
   const mousePosition = useAtomValue(mousePositionAtom);
 
   const positionX = mousePosition
-    ? mousePosition[0] -
-      computeGElementMarginLeft({
-        hasSecondUnit,
-        maxCharacters: maxLeftAxisCharacters
-      })
+    ? mousePosition[0] - computeGElementMarginLeft(maxLeftAxisCharacters)
     : undefined;
   const positionY = mousePosition
     ? mousePosition[1] - (hasUnit ? 29 : 4)
@@ -74,10 +68,7 @@ const useTickGraph = ({
     const pixelToShift = computPixelsToShiftMouse(xScale);
     const mousePositionTimeTick = mousePosition
       ? getTimeValue({
-          marginLeft: computeGElementMarginLeft({
-            hasSecondUnit,
-            maxCharacters: maxLeftAxisCharacters
-          }),
+          marginLeft: computeGElementMarginLeft(maxLeftAxisCharacters),
           timeSeries,
           x: mousePosition[0] - pixelToShift,
           xScale

package/src/Graph/Chart/InteractiveComponents/index.tsx

@@ -90,7 +90,6 @@ interface Props {
     fx?: (pointX: number) => number;
     fy?: (pointY: number) => number;
   };
-  hasSecondUnit?: boolean;
   maxLeftAxisCharacters: number;
   additionalZoomMargin?: number;
 }
@@ -101,7 +100,6 @@ const InteractionWithGraph = ({
   annotationData,
   timeShiftZonesData,
   transformMatrix,
-  hasSecondUnit,
   maxLeftAxisCharacters,
   additionalZoomMargin = 0
 }: Props): ReactElement => {
@@ -170,11 +168,8 @@ const InteractionWithGraph = ({
 
   const graphMarginLeft = useMemo(
     () =>
-      computeGElementMarginLeft({
-        hasSecondUnit,
-        maxCharacters: maxLeftAxisCharacters
-      }) + additionalZoomMargin,
-    [additionalZoomMargin, maxLeftAxisCharacters, hasSecondUnit]
+      computeGElementMarginLeft(maxLeftAxisCharacters) + additionalZoomMargin,
+    [additionalZoomMargin, maxLeftAxisCharacters]
   );
 
   const updateMousePosition = (pointPosition: MousePosition): void => {

package/src/Graph/common/Axes/index.tsx

@@ -73,6 +73,10 @@ const Axes = ({
   const AxisLeft = isHorizontal ? Axis.AxisLeft : Axis.AxisTop;
   const AxisRight = isHorizontal ? Axis.AxisRight : Axis.AxisBottom;
 
+  const axisBottomProps = isHorizontal
+    ? {}
+    : ({ angle: 90, textAnchor: 'middle' } as const);
+
   return (
     <g>
       <AxisBottom
@@ -82,7 +86,8 @@ const Axes = ({
         tickFormat={formatAxisTick}
         tickLabelProps={() => ({
           ...(axisLeft.tickLabelProps as () => Record<string, unknown>)(),
-          dx: data?.axisX?.dx ?? (isHorizontal ? 16 : -4)
+          dx: data?.axisX?.dx ?? (isHorizontal ? 16 : -12),
+          ...axisBottomProps
         })}
         top={isHorizontal ? height - margin.bottom : 0}
       />

package/src/Graph/common/BaseChart/ChartSvgWrapper.tsx

@@ -30,8 +30,7 @@ interface Props {
     | ScaleTime<number, number>
     | ScaleLinear<number, number>
     | ScaleBand<number>;
-  maxAxisCharacters?: number;
-  hasSecondUnit?: boolean;
+  maxLeftAxisCharacters?: number;
   title?: string;
 }
 
@@ -51,8 +50,7 @@ const ChartSvgWrapper = ({
   children,
   orientation = 'horizontal',
   allUnits,
-  maxAxisCharacters = 0,
-  hasSecondUnit,
+  maxLeftAxisCharacters = 0,
   title
 }: Props): ReactElement => {
   const isHorizontal = equals(orientation, 'horizontal');
@@ -73,10 +71,7 @@ const ChartSvgWrapper = ({
     >
       <title>chart</title>
       <Group.Group
-        left={computeGElementMarginLeft({
-          hasSecondUnit,
-          maxCharacters: maxAxisCharacters
-        })}
+        left={computeGElementMarginLeft(maxLeftAxisCharacters)}
         top={marginTop}
       >
         {showGridLines && (canRenderGridRows || canRenderGridColumns) && (

package/src/Graph/common/BaseChart/useComputeBaseChartDimensions.ts

@@ -2,7 +2,6 @@ import { equals, isNil } from 'ramda';
 import type { RefCallback } from 'react';
 import useResizeObserver from 'use-resize-observer';
 
-import { margin } from '../../Chart/common';
 import { margins } from '../margins';
 import { useMarginTop } from '../useMarginTop';
 
@@ -15,7 +14,8 @@ interface UseComputeBaseChartDimensionsProps {
   legendHeight?: number;
   legendPlacement?: string;
   width: number;
-  maxAxisCharacters: number;
+  maxLeftAxisCharacters: number;
+  maxRightAxisCharacters: number;
   title?: string;
   units: Array<string>;
 }
@@ -32,9 +32,9 @@ export const useComputeBaseChartDimensions = ({
   height,
   legendDisplay,
   legendPlacement,
-  hasSecondUnit,
   legendHeight,
-  maxAxisCharacters,
+  maxLeftAxisCharacters,
+  maxRightAxisCharacters,
   units,
   title
 }: UseComputeBaseChartDimensionsProps): UseComputeBaseChartDimensionsState => {
@@ -63,8 +63,8 @@ export const useComputeBaseChartDimensions = ({
   const graphWidth =
     width > 0
       ? width -
-        (hasSecondUnit ? maxAxisCharacters * 2 : maxAxisCharacters) * 6 -
-        (hasSecondUnit ? margins.left * 0.8 : margin.left) -
+        (maxLeftAxisCharacters * 5 + maxRightAxisCharacters * 5) -
+        margins.left / 2 -
         legendBoundingWidth
       : 0;
   const graphHeight =

package/src/Graph/common/BaseChart/useComputeYAxisMaxCharacters.ts

@@ -1,18 +1,21 @@
+import { getTicks } from '@visx/scale';
+import { ScaleLinear } from 'd3-scale';
 import { isEmpty } from 'ramda';
 import { useMemo } from 'react';
 
 import type { ChartAxis } from '../../Chart/models';
-import type { Data } from '../Axes/models';
-import type { Thresholds } from '../models';
-import { getFormattedAxisValues } from '../utils';
+import useAxisY from '../Axes/useAxisY';
+import { Line } from '../timeSeries/models';
 
 interface UseComputeYAxisMaxCharactersProps {
-  firstUnit: string;
-  secondUnit: string;
-  thresholdUnit?: string;
-  thresholds?: Thresholds;
-  graphData: Data;
   axis?: ChartAxis;
+  base: number;
+  displayedLines: Array<Line>;
+  graphWidth: number;
+  graphHeight: number;
+  isHorizontal: boolean;
+  leftScale: ScaleLinear<number, number, never>;
+  rightScale: ScaleLinear<number, number, never>;
 }
 
 interface UseComputteYAxisMaxCharactersState {
@@ -21,71 +24,52 @@ interface UseComputteYAxisMaxCharactersState {
 }
 
 export const useComputeYAxisMaxCharacters = ({
-  thresholds,
-  firstUnit,
-  secondUnit,
-  graphData,
   axis,
-  thresholdUnit
+  base,
+  displayedLines,
+  graphWidth,
+  graphHeight,
+  isHorizontal,
+  leftScale,
+  rightScale
 }: UseComputeYAxisMaxCharactersProps): UseComputteYAxisMaxCharactersState => {
-  const maxLeftValue = useMemo(
-    () =>
-      getFormattedAxisValues({
-        axisUnit: axis?.axisYLeft?.unit ?? firstUnit,
-        base: graphData?.baseAxis,
-        lines: graphData?.lines ?? [],
-        threshold: thresholds?.critical ?? [],
-        thresholdUnit,
-        timeSeries: graphData?.timeSeries ?? []
-      }),
-    [
-      thresholds?.critical,
-      axis?.axisYLeft?.unit,
-      firstUnit,
-      graphData?.timeSeries,
-      thresholdUnit,
-      graphData?.lines,
-      graphData?.baseAxis
-    ]
-  );
-
-  const maxRightValue = useMemo(
-    () =>
-      getFormattedAxisValues({
-        axisUnit: axis?.axisYRight?.unit ?? secondUnit,
-        base: graphData.baseAxis,
-        lines: graphData.lines ?? [],
-        threshold: thresholds?.critical ?? [],
-        thresholdUnit,
-        timeSeries: graphData.timeSeries ?? []
-      }),
-    [
-      thresholds?.critical,
-      axis?.axisYRight?.unit,
-      secondUnit,
-      graphData.timeSeries,
-      thresholdUnit,
-      graphData.lines,
-      graphData.baseAxis
-    ]
-  );
+  const { axisLeft, axisRight } = useAxisY({
+    data: {
+      baseAxis: base,
+      lines: displayedLines,
+      ...axis
+    },
+    graphHeight,
+    graphWidth,
+    isHorizontal
+  });
 
   // Always add a character space in case the algorithm does not compute the displayed value in axis.
-  const maxLeftAxisCharacters = useMemo(
-    () =>
-      isEmpty(maxLeftValue)
-        ? 2
-        : Math.max(...maxLeftValue.map((value) => value.length), 2) + 1,
-    [maxLeftValue]
-  );
+  const maxLeftAxisCharacters = useMemo(() => {
+    if (!leftScale) {
+      return 0;
+    }
+
+    const ticks = getTicks(leftScale, axisLeft.numTicks);
+    const formattedTicks = ticks.map(axisLeft.tickFormat);
+
+    return isEmpty(formattedTicks)
+      ? 2
+      : Math.max(...formattedTicks.map((value) => value.length), 2) + 1;
+  }, [leftScale, axisLeft]);
+
+  const maxRightAxisCharacters = useMemo(() => {
+    if (!rightScale) {
+      return 0;
+    }
+
+    const ticks = getTicks(rightScale, axisRight.numTicks);
+    const formattedTicks = ticks.map(axisRight.tickFormat);
 
-  const maxRightAxisCharacters = useMemo(
-    () =>
-      isEmpty(maxRightValue)
-        ? 5
-        : Math.max(...maxRightValue.map((value) => value.length), 5) + 1,
-    [maxRightValue]
-  );
+    return isEmpty(formattedTicks)
+      ? 2
+      : Math.max(...formattedTicks.map((value) => value.length), 2) + 1;
+  }, [rightScale, axisRight]);
 
   return {
     maxLeftAxisCharacters,

package/src/Graph/common/utils.ts

@@ -22,7 +22,6 @@ import {
 } from 'ramda';
 
 import type { BarStyle } from '../BarChart/models';
-import { margin } from '../Chart/common';
 import type { LineStyle } from '../Chart/models';
 import type { Threshold, Thresholds } from './models';
 import { formatMetricValueWithUnit } from './timeSeries';
@@ -263,16 +262,8 @@ export const getFormattedAxisValues = ({
     .filter((v) => v) as Array<string>;
 };
 
-interface ComputeGElementMarginLeftProps {
-  maxCharacters: number;
-  hasSecondUnit?: boolean;
-}
-
-export const computeGElementMarginLeft = ({
-  maxCharacters,
-  hasSecondUnit
-}: ComputeGElementMarginLeftProps): number =>
-  maxCharacters * 5 + (hasSecondUnit ? margin.top * 0.8 : margin.top * 0.6);
+export const computeGElementMarginLeft = (maxLeftCharacters: number): number =>
+  maxLeftCharacters * 5;
 
 export const computPixelsToShiftMouse = (
   xScale: import('d3-scale').ScaleTime<number, number>