@centreon/ui 26.12.5 → 26.12.7

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@centreon/ui",
-  "version": "26.12.5",
+  "version": "26.12.7",
   "description": "Centreon UI Components",
   "scripts": {
     "update:deps": "pnpx npm-check-updates -i --format group",

package/src/Form/Form.stories.tsx

@@ -110,3 +110,42 @@ export const exclusiveCheckboxGroup = (): JSX.Element => (
     validationSchema={object()}
   />
 );
+
+export const segmentedButtons = (): JSX.Element => (
+  <Form
+    initialValues={{
+      activeChecks: 'use_default',
+      updateMode: 'incremental'
+    }}
+    inputs={[
+      {
+        fieldName: 'activeChecks',
+        group: '',
+        label: 'Active checks enabled',
+        segmentedButtons: {
+          options: [
+            { label: 'Yes', value: 'true' },
+            { label: 'No', value: 'false' },
+            { label: 'Default', value: 'use_default' }
+          ]
+        },
+        type: InputType.SegmentedButtons
+      },
+      {
+        fieldName: 'updateMode',
+        group: '',
+        label: 'Update mode (long labels)',
+        segmentedButtons: {
+          options: [
+            { label: 'Incremental', value: 'incremental' },
+            { label: 'Replacement', value: 'replacement' },
+            { label: 'Inherit from the host template', value: 'inherit' }
+          ]
+        },
+        type: InputType.SegmentedButtons
+      }
+    ]}
+    submit={submit}
+    validationSchema={object()}
+  />
+);

package/src/Form/Inputs/PasswordInput.browser.test.tsx

@@ -0,0 +1,80 @@
+import { rs } from '@rstest/core';
+import { render } from '@test-setup/render';
+import { screen } from '@testing-library/react';
+import userEvent from '@testing-library/user-event';
+import { object } from 'yup';
+
+import { Form } from '../Form';
+import { InputType } from './models';
+
+const initialize = (): void => {
+  render(
+    <Form
+      initialValues={{ community: '', note: '' }}
+      inputs={[
+        {
+          dataTestId: 'note',
+          fieldName: 'note',
+          group: '',
+          label: 'Note',
+          type: InputType.Text
+        },
+        {
+          dataTestId: 'community',
+          fieldName: 'community',
+          group: '',
+          label: 'SNMP community',
+          type: InputType.Password
+        }
+      ]}
+      submit={rs.fn()}
+      validationSchema={object()}
+    />
+  );
+};
+
+const getInput = async (testId: string): Promise<HTMLInputElement> =>
+  (await screen.findAllByTestId(testId)).find(
+    (element) => element.tagName === 'INPUT'
+  ) as HTMLInputElement;
+
+describe('Password input', () => {
+  beforeEach(() => {
+    expect.hasAssertions();
+  });
+
+  it('asks the browser and the password managers not to fill it', async () => {
+    initialize();
+
+    const password = await getInput('community');
+
+    expect(password).toHaveAttribute('type', 'password');
+    expect(password).toHaveAttribute('autocomplete', 'new-password');
+    expect(password).toHaveAttribute('data-1p-ignore', 'true');
+    expect(password).toHaveAttribute('data-bwignore', 'true');
+    expect(password).toHaveAttribute('data-lpignore', 'true');
+  });
+
+  it('keeps those hints while the password is shown', async () => {
+    initialize();
+
+    await userEvent.click(
+      await screen.findByRole('button', { name: /password|show|visib/i })
+    );
+
+    const password = await getInput('community');
+
+    expect(password).toHaveAttribute('type', 'text');
+    expect(password).toHaveAttribute('autocomplete', 'new-password');
+    expect(password).toHaveAttribute('data-1p-ignore', 'true');
+  });
+
+  it('leaves the other text inputs as they were', async () => {
+    initialize();
+
+    const note = await getInput('note');
+
+    expect(note).toHaveAttribute('autocomplete', 'off');
+    expect(note).not.toHaveAttribute('data-1p-ignore');
+  });
+});

package/src/Form/Inputs/SegmentedButtons.browser.test.tsx

@@ -27,38 +27,44 @@ const ValueDisplay = (): JSX.Element => {
 };
 
 interface InitializeProps {
+  columnWidth?: number;
   disabled?: boolean;
   enabled?: string;
+  segmentedOptions?: Array<{ label: string; value: string }>;
 }
 
 const initialize = ({
   enabled = 'use_default',
-  disabled = false
+  disabled = false,
+  columnWidth = 800,
+  segmentedOptions = options
 }: InitializeProps = {}): void => {
   render(
-    <Form
-      initialValues={{ enabled }}
-      inputs={[
-        {
-          dataTestId: 'enabled',
-          fieldName: 'enabled',
-          getDisabled: () => disabled,
-          group: '',
-          label: 'Notification Enabled',
-          segmentedButtons: { options },
-          type: InputType.SegmentedButtons
-        },
-        {
-          custom: { Component: ValueDisplay },
-          fieldName: 'value',
-          group: '',
-          label: 'value',
-          type: InputType.Custom
-        }
-      ]}
-      submit={rs.fn()}
-      validationSchema={object()}
-    />
+    <div style={{ width: columnWidth }}>
+      <Form
+        initialValues={{ enabled }}
+        inputs={[
+          {
+            dataTestId: 'enabled',
+            fieldName: 'enabled',
+            getDisabled: () => disabled,
+            group: '',
+            label: 'Notification Enabled',
+            segmentedButtons: { options: segmentedOptions },
+            type: InputType.SegmentedButtons
+          },
+          {
+            custom: { Component: ValueDisplay },
+            fieldName: 'value',
+            group: '',
+            label: 'value',
+            type: InputType.Custom
+          }
+        ]}
+        submit={rs.fn()}
+        validationSchema={object()}
+      />
+    </div>
   );
 };
 
@@ -73,7 +79,11 @@ describe('Segmented buttons', () => {
   it('displays every option and marks the current one', async () => {
     initialize();
 
-    expect(await screen.findByText('Notification Enabled')).toBeVisible();
+    const label = await screen.findByText('Notification Enabled');
+
+    expect(label).toBeVisible();
+    // Bold, as the design shows the label above the buttons.
+    expect(getComputedStyle(label).fontWeight).toBe('700');
     expect(await button('Yes')).toHaveAttribute('aria-pressed', 'false');
     expect(await button('No')).toHaveAttribute('aria-pressed', 'false');
     expect(await button('Default')).toHaveAttribute('aria-pressed', 'true');
@@ -104,6 +114,80 @@ describe('Segmented buttons', () => {
     expect(await button('No')).toHaveAttribute('aria-pressed', 'true');
   });
 
+  it('sizes each segment to its label, at least 104px, whatever the column', async () => {
+    initialize({
+      columnWidth: 800,
+      segmentedOptions: [
+        { label: 'Yes', value: 'true' },
+        { label: 'No', value: 'false' },
+        { label: 'Inherit from template', value: 'use_default' }
+      ]
+    });
+
+    const group = await screen.findByTestId('enabled');
+    const [yes, no, inherit] = (
+      await Promise.all(['Yes', 'No', 'Inherit from template'].map(button))
+    ).map((element) => element.getBoundingClientRect().width);
+
+    // As in the design: Yes and No keep 104px, the longer label grows alone
+    // (the group overlaps the borders of its buttons, a pixel at most).
+    expect(yes).toBeGreaterThanOrEqual(104);
+    expect(Math.abs(yes - no)).toBeLessThanOrEqual(1);
+    expect(yes).toBeLessThan(110);
+    expect(inherit).toBeGreaterThan(yes + 20);
+    expect(group.getBoundingClientRect().width).toBeLessThan(500);
+    expect(group.getBoundingClientRect().left).toBe(
+      (await screen.findByText('Notification Enabled')).getBoundingClientRect()
+        .left
+    );
+  });
+
+  it('keeps three segments of 104px when the labels are short', async () => {
+    initialize({ columnWidth: 800 });
+
+    const widths = (
+      await Promise.all(['Yes', 'No', 'Default'].map(button))
+    ).map((element) => element.getBoundingClientRect().width);
+
+    expect(Math.min(...widths)).toBeGreaterThanOrEqual(104);
+    expect(Math.max(...widths) - Math.min(...widths)).toBeLessThanOrEqual(1);
+  });
+
+  it('cuts a label wider than the room left with an ellipsis', async () => {
+    const longLabel =
+      'Vorlage erben und alle Werte der Vorlage ohne Ausnahme übernehmen';
+
+    initialize({
+      columnWidth: 420,
+      segmentedOptions: [
+        { label: 'Yes', value: 'true' },
+        { label: 'No', value: 'false' },
+        { label: longLabel, value: 'use_default' }
+      ]
+    });
+
+    const long = await button(longLabel);
+    const text = long.firstElementChild as HTMLElement;
+
+    expect(text.scrollWidth).toBeGreaterThan(text.clientWidth);
+    expect(getComputedStyle(text).textOverflow).toBe('ellipsis');
+    expect(long).toHaveAttribute('title', longLabel);
+    expect(long.getBoundingClientRect().height).toBe(28);
+    expect(
+      (await screen.findByTestId('enabled')).getBoundingClientRect().right
+    ).toBeLessThanOrEqual(420 + 1);
+  });
+
+  it('stays inside a column narrower than its segments', async () => {
+    initialize({ columnWidth: 200 });
+
+    const group = await screen.findByTestId('enabled');
+    const wrapper = group.parentElement as HTMLElement;
+
+    expect(wrapper.getBoundingClientRect().width).toBeLessThanOrEqual(200);
+    expect(wrapper.scrollWidth).toBeGreaterThan(wrapper.clientWidth);
+  });
+
   it('does not change when disabled', async () => {
     initialize({ disabled: true });
 

package/src/Form/Inputs/SegmentedButtons.tsx

@@ -32,36 +32,43 @@ const SegmentedButtons = ({
   return useMemoComponent({
     Component: (
       <FormGroup>
-        <FormLabel>{t(label)}</FormLabel>
-        <ButtonGroup
-          aria-label={t(label)}
-          // As wide as its column, up to what three labels need.
-          className="max-w-[412px]"
-          color="primary"
-          data-testid={dataTestId}
-          disabled={disabled}
-          fullWidth
-          size="small"
-        >
-          {segmentedButtons?.options.map(
-            ({ label: optionLabel, value: optionValue }) => {
-              const isSelected = equals(value, optionValue);
+        <FormLabel className="font-bold">{t(label)}</FormLabel>
+        {/* In a column narrower than the three minimum widths, the group scrolls
+            inside it rather than overflowing into what is next to it. */}
+        <div className="max-w-full self-start overflow-x-auto">
+          <ButtonGroup
+            aria-label={t(label)}
+            className="max-w-full"
+            color="primary"
+            data-testid={dataTestId}
+            disabled={disabled}
+            size="small"
+          >
+            {segmentedButtons?.options.map(
+              ({ label: optionLabel, value: optionValue }) => {
+                const isSelected = equals(value, optionValue);
 
-              return (
-                <Button
-                  aria-pressed={isSelected}
-                  className="h-7 px-3 py-0 font-medium text-sm leading-[21px] normal-case"
-                  data-testid={`${dataTestId}-${optionValue}`}
-                  key={optionValue}
-                  onClick={select(optionValue)}
-                  variant={isSelected ? 'contained' : 'outlined'}
-                >
-                  {t(optionLabel)}
-                </Button>
-              );
-            }
-          )}
-        </ButtonGroup>
+                // As in the design: every segment is 26 spacing units (104px)
+                // wide at least, and grows with its own label. A label wider
+                // than the room left is cut with an ellipsis, its full text
+                // in the tooltip.
+                return (
+                  <Button
+                    aria-pressed={isSelected}
+                    className="h-7 min-w-26 px-3 py-0 font-medium text-sm leading-[21px] normal-case"
+                    data-testid={`${dataTestId}-${optionValue}`}
+                    key={optionValue}
+                    onClick={select(optionValue)}
+                    title={t(optionLabel)}
+                    variant={isSelected ? 'contained' : 'outlined'}
+                  >
+                    <span className="min-w-0 truncate">{t(optionLabel)}</span>
+                  </Button>
+                );
+              }
+            )}
+          </ButtonGroup>
+        </div>
       </FormGroup>
     ),
     memoProps: [value, disabled, segmentedButtons, additionalMemoProps]

package/src/Form/Inputs/Text.tsx

@@ -17,6 +17,17 @@ import { TextField, useMemoComponent } from '../..';
 import { type InputPropsWithoutGroup, InputType } from './models';
 import PasswordEndAdornment from './PasswordEndAdornment';
 
+// Keeps password managers from taking the text field before a password field
+// for a user name and filling it in, and from filling the password itself:
+// `new-password` for the browsers, the opt-out attributes for the extensions
+// (1Password, Bitwarden, LastPass).
+const passwordManagerOptOut = {
+  autoComplete: 'new-password',
+  'data-1p-ignore': true,
+  'data-bwignore': true,
+  'data-lpignore': true
+};
+
 const Text = ({
   dataTestId,
   label,
@@ -140,7 +151,8 @@ const Text = ({
             htmlInput: {
               'aria-label': label,
               'data-testid': dataTestId || label,
-              min: text?.min
+              min: text?.min,
+              ...(equals(type, InputType.Password) && passwordManagerOptOut)
             }
           }
         }}