@centreon/ui 24.4.72 → 24.4.73

package/.storybook/main.js

@@ -0,0 +1,82 @@
+const { equals } = require("ramda");
+
+const excludeNodeModulesExceptCentreonUi =
+  /node_modules(\\|\/)(?!(centreon-frontend(\\|\/)packages(\\|\/)(ui-context|centreon-ui)))/;
+  
+module.exports = {
+  core: {
+    builder: 'webpack5',
+  },
+  features: {
+    previewMdx2: true,
+  },
+  stories: ['../src/*.stories.mdx', '../src/**/*.stories.@(jsx|tsx)'],
+  typescript: {
+    reactDocgen: 'react-docgen-typescript'
+  },
+  addons: [
+    'storybook-addon-mock/register',
+    'storybook-dark-mode',
+    '@storybook/addon-controls', 
+    {
+      name: '@storybook/addon-docs',
+      options: {
+        configureJSX: true,
+      },
+    },
+  ],
+  webpackFinal: (config) => {
+    delete config.resolve.alias['emotion-theming'];
+    delete config.resolve.alias['@emotion/styled'];
+    delete config.resolve.alias['@emotion/core'];
+
+    const configWithoutEmotionAliases = {
+      ...config,
+      resolve: {
+        ...config.resolve,
+        extensions: ['.js', '.ts', '.tsx'],
+      },
+      module: {
+        ...config.module,
+        rules: [
+          {
+            test: /\.tsx?$/,
+            exclude: /node_modules(\\|\/)(?!(@centreon))/,
+            use: {
+              loader: 'swc-loader',
+              options: {
+                jsc: {
+                  transform: {
+                    react: {
+                      runtime: 'automatic',
+                    },
+                  },
+                  parser: {
+                    syntax: 'typescript',
+                  },
+                },
+                parseMap: true,
+              },
+            }
+          },
+          {
+            exclude: excludeNodeModulesExceptCentreonUi,
+            test: /\.(bmp|png|jpg|jpeg|gif|svg)$/,
+            use: [
+              {
+                loader: 'url-loader',
+                options: {
+                  limit: 10000,
+                  name: '[name].[hash:8].[ext]',
+                },
+              },
+            ],
+          },
+          ...(config.module.rules.filter(({ type }) => !equals(type, 'asset/resource'))),
+        ],
+      },
+    }
+
+    return configWithoutEmotionAliases;
+  }
+};

package/.storybook/preview.tsx

@@ -0,0 +1,21 @@
+import { addDecorator } from '@storybook/react';
+
+import { useDarkMode } from 'storybook-dark-mode';
+
+import { ThemeMode } from '@centreon/ui-context';
+
+import StoryBookThemeProvider from '../src/StoryBookThemeProvider';
+import QueryProvider from '../src/api/QueryProvider';
+import { ReactQueryDevtools } from '@tanstack/react-query-devtools';
+
+
+const withThemeProvider = (story): JSX.Element => (
+  <StoryBookThemeProvider themeMode={useDarkMode() ? ThemeMode.dark :  ThemeMode.light}>
+    <QueryProvider>
+      {story()}
+      <ReactQueryDevtools />
+    </QueryProvider>
+  </StoryBookThemeProvider>
+);
+
+addDecorator(withThemeProvider);

package/README.md

@@ -20,57 +20,27 @@ To start Storybook server, run:
 
 `pnpm storybook`
 
+# Tests
 
-# Add stories
+We have two kind of tests:
+ - Unit tests provided by Jest
+ - End to End tests provided by Storyshot using Jest. Storyshot is an addon of Storybook that compares graphically our stories.
 
-- Create a file named `index.stories.tsx` along side your component
-      
-- Add a title, the component and argTypes
-  
-  ```typescript
-  export default {
-    title: 'MyComponent',
-    Component: MyComponent,
-    argTypes: {
-      propA: { control: 'text' },
-      propB: { control: 'number' },
-    },
-  };
-  ```
+To run Unit tests:
 
-- Create a playground for your component
+`pnpm test`
 
-  ```typescript
-    const Template: ComponentStory<typeof MyComponent> = (args) => (
-      <MyComponent {...args} />
-    );
+or
 
-    export const Playground = Template.bind({});
-  ```
+`pnpm t`
 
-- Then add your story
+To run End to End tests:
+  - Build Storybook : `pnpm build:storybook`
+  - Run all Storyshot tests : `pnpm test:storyshot`
 
-  ```typescript
-    export const basic = Template.bind({});
-    basic.args = { propA: 'test', propB: 0 };
-  ```
-
-# Tests architecture
-
-There are two kinds of tests in Centreon UI.
-- Jest + RTL and Cypress: Component testing. We want to migrate from Jest to Cypress
-- Chromatic: Chromatic is a tool that snapshots our stories and better handle snapshots changes using a review process
-
-
-### Run Jest tests
-
-```bash
-pnpm t
-```
-
-### Run Cypress tests
+You can also test one or more Components using the following syntax:
 
 ```bash
-pnpm cypress:ui # Opens the Cypress controlled browser to debug tests
-pnpm cypress:cli # Runs tests in the terminal
+pnpm test:storyshot -- --story "Title" # Run Storyshot tests about Title component
+pnpm test:storyshot -- --story "Breadcrumb|Title" # Run Storyshot tests about Title and Breadcrumb components
 ```

package/jest.config.js

@@ -0,0 +1,20 @@
+const baseConfig = require('../js-config/jest');
+
+module.exports = {
+  ...baseConfig,
+  moduleNameMapper: {
+    '\\.(s?css|png|svg)$': 'identity-obj-proxy',
+    '^react($|/.+)': '<rootDir>/../../node_modules/react$1'
+  },
+  reporters: ['default', ['jest-junit', { outputName: 'junit.xml' }]],
+  roots: ['<rootDir>/src/'],
+  setupFilesAfterEnv: [
+    '<rootDir>/setupTests.js',
+    '@testing-library/jest-dom/extend-expect'
+  ],
+  testResultsProcessor: 'jest-junit',
+  transform: {
+    ...baseConfig.transform,
+    '^.+\\.mdx?$': '@storybook/addon-docs/jest-transform-mdx'
+  }
+};

package/package.json

@@ -1,21 +1,16 @@
 {
   "name": "@centreon/ui",
-  "version": "24.4.72",
+  "version": "24.4.73",
   "description": "Centreon UI Components",
+  "main": "src/index.ts",
   "scripts": {
-    "update:deps": "pnpx npm-check-updates -i --format group",
     "eslint": "eslint ./src --ext .js,.jsx,.ts,.tsx --max-warnings 0",
     "eslint:fix": "pnpm eslint --fix",
-    "storybook": "storybook dev -p 9001 -c .storybook",
-    "build:storybook": "storybook build -c .storybook -o .out",
-    "test": "jest",
-    "test:storybook:local": "test-storybook --url http://127.0.0.1:9001",
-    "test:ci": "jest --silent --reporter=jest-junit",
-    "cypress:ui": "cypress open --component --browser=chrome",
-    "cypress:cli:updateSnapshot": "pnpm cypress:cli --env updateSnapshots=true",
-    "cypress:run:coverage": "cypress run --component --browser=chrome --env codeCoverageTasksRegistered=true",
-    "cypress:cli": "cypress run --component --browser=chrome",
-    "tokens:transform": "TS_NODE_PROJECT=tsconfig.node.json ts-node style-dictionary.transform.ts"
+    "storybook": "start-storybook -p 9001 -c .storybook",
+    "build:storybook": "build-storybook -c .storybook -o .out",
+    "test": "node testRunner.js",
+    "test:storyshot": "pnpm test storyshots.test.js",
+    "test:ci": "node testRunner.js --silent --reporter=jest-junit"
   },
   "sideEffects": false,
   "repository": {
@@ -26,140 +21,65 @@
     "centreon",
     "react"
   ],
-  "author": {
-    "name": "centreon@centreon.com"
-  },
-  "baseCodeCoveragePercentage": 60,
+  "author": "centreon@centreon.com",
   "license": "GPL-2.0",
   "bugs": {
     "url": "https://github.com/centreon/centreon/issues"
   },
   "homepage": "https://github.com/centreon/centreon#readme",
-  "main": "src/index.ts",
-  "exports": {
-    ".": "./src/index.ts",
-    "./components": "./src/components/index.ts",
-    "./fonts/*": "./public/fonts/*",
-    "./test/testRenderer": "./test/testRenderer.tsx"
-  },
-  "files": [
-    "package.json",
-    "src/*",
-    "public/*",
-    "test/*"
-  ],
   "devDependencies": {
-    "@cypress/react": "^8.0.0",
-    "@cypress/webpack-dev-server": "^3.7.4",
-    "@faker-js/faker": "^8.4.1",
-    "@mdx-js/react": "^3.0.1",
-    "@simonsmith/cypress-image-snapshot": "^9.0.1",
-    "@storybook/addon-a11y": "^7.0.9",
-    "@storybook/addon-docs": "^7.0.9",
-    "@storybook/addon-essentials": "^7.0.9",
-    "@storybook/addon-interactions": "^7.0.9",
-    "@storybook/addon-styling": "^1.0.6",
-    "@storybook/blocks": "^7.0.26",
-    "@storybook/builder-vite": "^7.0.9",
-    "@storybook/jest": "^0.1.0",
-    "@storybook/manager-api": "^7.0.9",
-    "@storybook/mdx2-csf": "^1.1.0",
-    "@storybook/preview-api": "^7.0.9",
-    "@storybook/react": "^7.0.9",
-    "@storybook/react-vite": "^7.0.9",
-    "@storybook/test-runner": "^0.16.0",
-    "@storybook/testing-library": "^0.1.0",
-    "@storybook/theming": "^7.0.9",
-    "@testing-library/cypress": "^8.0.7",
-    "@testing-library/jest-dom": "^5.16.5",
-    "@testing-library/react": "^13.4.0",
-    "@testing-library/react-hooks": "^8.0.1",
-    "@types/jest": "^29.5.12",
-    "@types/mocha": "^10.0.6",
-    "@types/ramda": "^0.29.9",
-    "@types/react": "^18.2.65",
-    "@types/testing-library__jest-dom": "^6.0.0",
-    "@vitejs/plugin-react": "^4.2.1",
-    "@vitejs/plugin-react-swc": "^3.6.0",
-    "axios-mock-adapter": "^1.22.0",
-    "cypress": "^13.7.1",
+    "@mdx-js/react": "^2.1.4",
+    "@storybook/addon-docs": "^6.5.16",
+    "@storybook/addon-essentials": "^6.5.11",
+    "@storybook/addon-storyshots": "^6.5.11",
+    "@storybook/addon-storyshots-puppeteer": "^6.5.11",
+    "@storybook/builder-webpack5": "^6.5.11",
+    "@storybook/manager-webpack5": "^6.5.11",
+    "@storybook/mdx2-csf": "^0.0.3",
+    "@storybook/react": "^6.5.11",
+    "@types/jest": "^27.5.0",
+    "@types/ramda": "^0.28.12",
+    "axios-mock-adapter": "^1.20.0",
+    "babel-plugin-require-context-hook": "^1.0.0",
+    "clean-webpack-plugin": "^4.0.0",
     "identity-obj-proxy": "^3.0.0",
-    "jest-transform-stub": "^2.0.0",
-    "mochawesome": "^7.1.3",
-    "msw": "1.3.2",
-    "msw-storybook-addon": "^1.10.0",
     "puppeteer": "^13.7.0",
-    "react": "^18.2.0",
-    "react-dom": "^18.2.0",
-    "react-test-renderer": "^18.2.0",
-    "remark-gfm": "^3.0.1",
-    "speed-measure-vite-plugin": "^0.1.2",
-    "storybook": "^7.6.8",
-    "storybook-addon-mock": "^4.3.0",
-    "storybook-dark-mode": "^3.0.3",
-    "style-dictionary": "^3.9.2",
-    "ts-node": "^10.9.2",
-    "use-resize-observer": "^9.1.0",
-    "vite": "^4.3.5",
-    "vite-plugin-istanbul": "^5.0.0",
-    "vite-plugin-svgr": "^3.2.0",
-    "vite-plugin-turbosnap": "^1.0.3"
+    "react-test-renderer": "^18.1.0",
+    "storybook-addon-mock": "^2.4.1",
+    "storybook-dark-mode": "^1.1.0"
   },
   "dependencies": {
-    "@lexical/html": "^0.12.6",
-    "@lexical/link": "^0.12.6",
-    "@lexical/list": "^0.12.6",
-    "@lexical/react": "^0.12.6",
-    "@lexical/rich-text": "^0.12.6",
-    "@lexical/selection": "^0.12.6",
-    "@lexical/utils": "^0.12.6",
-    "@react-spring/web": "^9.7.3",
-    "@visx/clip-path": "^3.3.0",
-    "@visx/curve": "^2.1.0",
-    "@visx/event": "^3.3.0",
-    "@visx/group": "^3.3.0",
-    "@visx/hierarchy": "^3.3.0",
-    "@visx/legend": "^3.5.0",
-    "@visx/pattern": "^3.3.0",
-    "@visx/point": "^3.3.0",
-    "@visx/scale": "^3.5.0",
-    "@visx/shape": "^2.18.0",
-    "@visx/text": "^3.3.0",
-    "@visx/threshold": "^2.12.2",
-    "@visx/visx": "2.16.0",
-    "@visx/zoom": "^3.3.0",
+    "@lexical/link": "0.8.0",
+    "@lexical/react": "0.8.0",
+    "@lexical/selection": "0.8.0",
+    "@lexical/utils": "0.8.0",
     "anylogger": "^1.0.11",
-    "d3-array": "3.2.4",
-    "humanize-duration": "^3.31.0",
-    "lexical": "^0.12.6",
-    "notistack": "^3.0.1",
-    "numeral": "^2.0.6",
-    "ramda": "0.29.1",
-    "react-grid-layout": "^1.4.4",
-    "react-html-parser": "^2.0.2",
-    "react-resizable": "^3.0.5",
+    "humanize-duration": "^3.27.3",
+    "lexical": "0.8.0",
+    "notistack": "^2.0.8",
     "react-transition-group": "^4.4.5",
-    "sanitize-html": "^2.12.1",
     "ulog": "^2.0.0-beta.19"
   },
   "peerDependencies": {
     "@centreon/ui-context": "file:../ui-context",
     "@dnd-kit/core": "6.x",
     "@dnd-kit/sortable": "6.x",
-    "@dnd-kit/utilities": "3.x",
+    "@dnd-kit/utilities": "6.x",
     "@mui/icons-material": "5.x",
+    "@mui/lab": "5.x",
     "@mui/material": "5.x",
     "@mui/styles": "5.x",
-    "@tanstack/react-query": "5.x",
+    "@tanstack/react-query": "4.x",
     "axios": ">= 1.6.4",
     "dayjs": "1.x",
     "formik": "2.x",
     "jotai": "2.x",
     "numeral": "2.x",
     "ramda": "0.x",
+    "react": "18.x",
+    "react-dom": "18.x",
     "react-i18next": "12.x",
     "react-router-dom": "6.x",
-    "react-scale-text": "1.x",
     "resize-observer-polyfill": "1.x",
     "ts.data.json": "2.x",
     "tss-react": "4.x"
@@ -167,8 +87,5 @@
   "jest-junit": {
     "suiteName": "jest tests",
     "output": "./junit.xml"
-  },
-  "msw": {
-    "workerDirectory": "public"
   }
 }

package/{test/setupTests.js → setupTests.js}

@@ -1,6 +1,6 @@
 /* eslint-disable no-underscore-dangle */
 /* eslint-disable no-undef */
-
+// import '@testing-library/jest-dom/extend-expect';
 import i18n from 'i18next';
 import { initReactI18next } from 'react-i18next';
 import fetchMock from 'jest-fetch-mock';

package/src/ActionsList/index.stories.tsx

@@ -24,68 +24,6 @@ const actions = [
   }
 ];
 
-const actionsWithVariants = [
-  {
-    label: 'No variant',
-    onClick: (): void => undefined
-  },
-  {
-    label: 'Primary',
-    onClick: (): void => undefined,
-    variant: 'primary'
-  },
-  {
-    label: 'Secondary',
-    onClick: (): void => undefined,
-    variant: 'secondary'
-  },
-  {
-    label: 'Success',
-    onClick: (): void => undefined,
-    variant: 'success'
-  },
-  {
-    label: 'Warning',
-    onClick: (): void => undefined,
-    variant: 'warning'
-  },
-  {
-    label: 'Error',
-    onClick: (): void => undefined,
-    variant: 'error'
-  },
-  {
-    label: 'Info',
-    onClick: (): void => undefined,
-    variant: 'info'
-  },
-  {
-    label: 'Pending',
-    onClick: (): void => undefined,
-    variant: 'pending'
-  }
-];
-
-const actionsWithSecondaryLabel = [
-  {
-    Icon: EditIcon,
-    label: 'Edit',
-    onClick: (): void => undefined
-  },
-  {
-    Icon: CopyIcon,
-    label: 'Duplicate',
-    onClick: (): void => undefined,
-    secondaryLabel:
-      'This is a secondary label that the purpose is to give a small description about an action'
-  },
-  {
-    Icon: DeleteIcon,
-    label: 'Delete',
-    onClick: (): void => undefined
-  }
-];
-
 export default {
   argTypes: {},
   component: ActionsList,
@@ -101,15 +39,3 @@ export const Playground = Template.bind({});
 Playground.args = {
   actions
 };
-
-export const Variants = Template.bind({});
-
-Variants.args = {
-  actions: actionsWithVariants
-};
-
-export const SecondaryLabel = Template.bind({});
-
-SecondaryLabel.args = {
-  actions: actionsWithSecondaryLabel
-};

package/src/ActionsList/index.tsx

@@ -1,83 +1,46 @@
-/* eslint-disable react/no-array-index-key */
+import * as React from 'react';
+
+import { makeStyles } from 'tss-react/mui';
 import { useTranslation } from 'react-i18next';
-import { equals } from 'ramda';
 
 import {
+  SvgIconProps,
   MenuList,
   MenuItem,
   ListItemText,
-  ListItemIcon,
-  Divider,
-  SvgIconTypeMap
+  ListItemIcon
 } from '@mui/material';
-import { OverridableComponent } from '@mui/material/OverridableComponent';
-
-import { sanitizedHTML } from '..';
-
-import { useStyles } from './ActionsList.styles';
-import { ActionVariants } from './models';
 
 interface ActionsType {
-  Icon?: OverridableComponent<SvgIconTypeMap<object, 'svg'>> & {
-    muiName: string;
-  };
+  Icon: (props: SvgIconProps) => JSX.Element;
   label: string;
-  onClick?: (e?) => void;
-  secondaryLabel?: string;
-  variant?: ActionVariants;
-}
-
-export enum ActionsListActionDivider {
-  divider = 'divider'
+  onClick?: () => void;
 }
-export type ActionsListActions = Array<ActionsType | ActionsListActionDivider>;
 
 interface Props {
-  actions: ActionsListActions;
+  actions: Array<ActionsType>;
   className?: string;
-  listItemClassName?: string;
 }
 
-const ActionsList = ({
-  className,
-  listItemClassName,
-  actions
-}: Props): JSX.Element => {
+const useStyles = makeStyles()({
+  list: {
+    maxWidth: '100%'
+  }
+});
+
+const ActionsList = ({ className, actions }: Props): JSX.Element => {
   const { cx, classes } = useStyles();
   const { t } = useTranslation();
 
   return (
     <MenuList className={cx(classes.list, className)}>
-      {actions?.map((action, idx) => {
-        if (equals(action, ActionsListActionDivider.divider)) {
-          return <Divider key={`divider_${idx}`} />;
-        }
-
-        const { label, Icon, onClick, variant, secondaryLabel } =
-          action as ActionsType;
-
+      {actions?.map(({ Icon, label, onClick }) => {
         return (
-          <MenuItem
-            aria-label={label}
-            className={classes.item}
-            data-variant={variant}
-            id={label}
-            key={label}
-            onClick={onClick}
-          >
-            {Icon && (
-              <ListItemIcon>
-                <Icon fontSize="small" />
-              </ListItemIcon>
-            )}
-            <ListItemText
-              className={listItemClassName}
-              primary={t(label)}
-              secondary={
-                secondaryLabel &&
-                sanitizedHTML({ initialContent: t(secondaryLabel) })
-              }
-            />
+          <MenuItem aria-label={label} key={label} onClick={onClick}>
+            <ListItemIcon>
+              <Icon fontSize="small" />
+            </ListItemIcon>
+            <ListItemText>{t(label)}</ListItemText>
           </MenuItem>
         );
       })}

package/src/Button/Icon/index.stories.tsx

@@ -4,7 +4,7 @@ import { makeStyles } from 'tss-react/mui';
 import AccessibilityIcon from '@mui/icons-material/Accessibility';
 import { Theme } from '@mui/material';
 
-import { IconButton } from '.';
+import IconButton from '.';
 
 const useStyles = makeStyles()((theme: Theme) => ({
   root: {

package/src/Button/Icon/index.tsx

@@ -6,14 +6,11 @@ import {
   Tooltip
 } from '@mui/material';
 
-import { getNormalizedId } from '../../utils';
+import getNormalizedId from '../../utils/getNormalizedId';
 
 const useStyles = makeStyles()((theme) => ({
   button: {
     padding: theme.spacing(0.25)
-  },
-  tooltip: {
-    background: theme.palette.background.tooltip
   }
 }));
 
@@ -21,8 +18,7 @@ type Props = {
   ariaLabel?: string;
   className?: string;
   onClick: (event) => void;
-  title?: string | JSX.Element;
-  tooltipClassName?: string;
+  title?: string;
   tooltipPlacement?:
     | 'bottom'
     | 'left'
@@ -38,22 +34,17 @@ type Props = {
     | 'top-start';
 } & IconButtonProps;
 
-export const IconButton = ({
+const IconButton = ({
   title = '',
   ariaLabel,
   className,
   tooltipPlacement,
-  tooltipClassName,
   ...props
 }: Props): JSX.Element => {
   const { classes, cx } = useStyles();
 
   return (
-    <Tooltip
-      classes={{ tooltip: cx(classes.tooltip, tooltipClassName) }}
-      placement={tooltipPlacement}
-      title={title}
-    >
+    <Tooltip placement={tooltipPlacement} title={title}>
       <span aria-label={undefined}>
         <MuiIconButton
           aria-label={ariaLabel}